From nobody Sun Feb 8 21:11:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ADDEC6FD20 for ; Fri, 24 Mar 2023 03:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230476AbjCXDPW (ORCPT ); Thu, 23 Mar 2023 23:15:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbjCXDPS (ORCPT ); Thu, 23 Mar 2023 23:15:18 -0400 Received: from hust.edu.cn (unknown [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BE57AF3B; Thu, 23 Mar 2023 20:15:17 -0700 (PDT) Received: from pride-PowerEdge-R740.. ([172.16.0.254]) (user=u201912584@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 32O3E84U023389-32O3E84V023389 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 24 Mar 2023 11:14:14 +0800 From: SongJingyi To: Yangbo Lu , Richard Cochran , "David S. Miller" , Claudiu Manoil Cc: hust-os-kernel-patches@googlegroups.com, SongJingyi , Dan Carpenter , Dongliang Mu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ptp_qoriq: fix memory leak in probe() Date: Fri, 24 Mar 2023 11:14:06 +0800 Message-Id: <20230324031406.1895159-1-u201912584@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: u201912584@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch complains that: drivers/ptp/ptp_qoriq.c ptp_qoriq_probe() warn: 'base' from ioremap() not released. Fix this by revising the parameter from 'ptp_qoriq->base' to 'base'. This is only a bug if ptp_qoriq_init() returns on the first -ENODEV error path. For other error paths ptp_qoriq->base and base are the same. And this change makes the code more readable. Fixes: 7f4399ba405b ("ptp_qoriq: fix NULL access if ptp dt node missing") Signed-off-by: SongJingyi Reviewed-by: Dan Carpenter Reviewed-by: Dongliang Mu --- drivers/ptp/ptp_qoriq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ptp/ptp_qoriq.c b/drivers/ptp/ptp_qoriq.c index 61530167efe4..350154e4c2b5 100644 --- a/drivers/ptp/ptp_qoriq.c +++ b/drivers/ptp/ptp_qoriq.c @@ -637,7 +637,7 @@ static int ptp_qoriq_probe(struct platform_device *dev) return 0; =20 no_clock: - iounmap(ptp_qoriq->base); + iounmap(base); no_ioremap: release_resource(ptp_qoriq->rsrc); no_resource: --=20 2.34.1