From nobody Mon Feb 9 00:25:35 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D774C6FD1D for ; Mon, 20 Mar 2023 18:51:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231311AbjCTSvb (ORCPT ); Mon, 20 Mar 2023 14:51:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34192 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjCTSuk (ORCPT ); Mon, 20 Mar 2023 14:50:40 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B76B2A6C9 for ; Mon, 20 Mar 2023 11:43:56 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id f6-20020a17090ac28600b0023b9bf9eb63so13430595pjt.5 for ; Mon, 20 Mar 2023 11:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679337835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W3N8NUnKA3HwSL7nYHdw0w+EtU7IHilem2dLWFayh5k=; b=jnQOizljVF+zmRvkZ4il44P9m7IzRy6YHlVV6WGhqJ+A9RiRbAMwSQqCFzQc+FQyyg fTxc2cPNv7UnYmEs0qsVj6OMrLGu+ZztPZ82H7V17uxhLpYcUNB+HnCoygUCeLKCWMzj C8khiI9tsZ6Z/+GSwdO1m7PC8fILoCXKFwHxpDK3AcPDlL5Ra+LIscfSdP2FnWdGy0+g S4Vr8q0YicNWd5+71v4TFVu4AowEE+cqe61zgIUWjrifyV9VLakQ6r7VHNf0aJ0CYHIX jhJqWNPQ7zd0o7RHiN2/Vzp1zMrsI5h31vMca/xZb/Fdz0wfqKYYgO8XZqF9kPTmemAK b/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679337835; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W3N8NUnKA3HwSL7nYHdw0w+EtU7IHilem2dLWFayh5k=; b=w1SWIy55pEObWjX86VBMwy8/s0aFrLdafsbRl1F32JoUw45giul21Q+m2VzjY8ItWu tWzz7mk4DpOg9CtwHFqVZwgwJk4gexIZpEPQfUABJCBSHs5Uuq2hpjgA1d8aGbcwpwzU rrI1rRWhwm6on0GjD/ZpcHmFdTF+M1iplGHr2p6kgKJMXtgxeLk4eKWfO1FuezT49lWD +RK5CVptlkFkmJtZiJ+rnbhgDiorA78j6QA7vY6NyxVZJOQfL1g38e9IxVQ+IiThG7Mu DA+bWJ8gT22yR4ePoiASbXu89mA7MGUrNUCO9JHDPlb6I0gEOPMwBgt40FisDGjSkFUq Kokg== X-Gm-Message-State: AO0yUKWn1jHUZ0OFE/8T7DYk8wNkmLvPXv8t9Q66R5teYL40I4brx8Dp 5cSjM8rfhvEqgpChzkutVdM= X-Google-Smtp-Source: AK7set8b5ij+pVnZupkFfVqQH+2xx9aXqJtC5qJqofBfJSQ/hJREcOlXUXQufIKPkWRlV8v9keGkwQ== X-Received: by 2002:a05:6a20:3f28:b0:da:144:92bf with SMTP id az40-20020a056a203f2800b000da014492bfmr2211159pzb.14.1679337835037; Mon, 20 Mar 2023 11:43:55 -0700 (PDT) Received: from f37.eng.vmware.com ([66.170.99.1]) by smtp.googlemail.com with ESMTPSA id bn10-20020a056a00324a00b005a84ef49c63sm6671755pfb.214.2023.03.20.11.43.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Mar 2023 11:43:54 -0700 (PDT) From: Shreenidhi Shedi X-Google-Original-From: Shreenidhi Shedi To: gregkh@linuxfoundation.org, dhowells@redhat.com, dwmw2@infradead.org Cc: yesshedi@gmail.com, linux-kernel@vger.kernel.org, sshedi@vmware.com Subject: [PATCH v5 4/7] sign-file: add support to sign modules in bulk Date: Tue, 21 Mar 2023 00:13:42 +0530 Message-Id: <20230320184345.80166-5-sshedi@vmware.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230320184345.80166-1-sshedi@vmware.com> References: <20230320184345.80166-1-sshedi@vmware.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Shreenidhi Shedi In the existing system, we need to invoke sign-file binary for every module we want to sign. This patch adds support to give modules list in bulk and it will sign them all one by one. Signed-off-by: Shreenidhi Shedi --- scripts/sign-file.c | 41 +++++++++++++++++++++++++++-------------- 1 file changed, 27 insertions(+), 14 deletions(-) diff --git a/scripts/sign-file.c b/scripts/sign-file.c index 64d5e00f08e2..0a275256ca16 100644 --- a/scripts/sign-file.c +++ b/scripts/sign-file.c @@ -224,6 +224,7 @@ struct cmd_opts { bool replace_orig; bool raw_sig; bool sign_only; + bool bulk_sign; #ifndef USE_PKCS7 unsigned int use_keyid; #endif @@ -252,10 +253,10 @@ static void parse_args(int argc, char **argv, struct = cmd_opts *opts) =20 do { #ifndef USE_PKCS7 - opt =3D getopt_long_only(argc, argv, "hpds:i:a:x:t:r:", + opt =3D getopt_long_only(argc, argv, "hpdbs:i:a:x:t:r:", cmd_options, &opt_index); #else - opt =3D getopt_long_only(argc, argv, "hpdks:i:a:x:t:r:", + opt =3D getopt_long_only(argc, argv, "hpdkbs:i:a:x:t:r:", cmd_options, &opt_index); #endif switch (opt) { @@ -303,6 +304,10 @@ static void parse_args(int argc, char **argv, struct c= md_opts *opts) opts->replace_orig =3D true; break; =20 + case 'b': + opts->bulk_sign =3D true; + break; + case -1: break; =20 @@ -460,26 +465,34 @@ static int sign_single_file(struct cmd_opts *opts) =20 int main(int argc, char **argv) { + int i; struct cmd_opts opts =3D {}; =20 parse_args(argc, argv, &opts); argc -=3D optind; argv +=3D optind; =20 - if (!argv[0] || argc !=3D 1) - format(); - - if (opts.dest_name && strcmp(argv[0], opts.dest_name)) { - opts.replace_orig =3D false; - } else { - ERR(asprintf(&opts.dest_name, "%s.~signed~", opts.module_name) < 0, - "asprintf"); - opts.replace_orig =3D true; - } - OpenSSL_add_all_algorithms(); ERR_load_crypto_strings(); ERR_clear_error(); =20 - return sign_single_file(&opts); + for (i =3D 0; i < argc; ++i) { + opts.module_name =3D argv[i]; + + if (!opts.bulk_sign && opts.dest_name && strcmp(argv[i], opts.dest_name)= ) { + opts.replace_orig =3D false; + } else { + ERR(asprintf(&opts.dest_name, "%s.~signed~", opts.module_name) < 0, + "asprintf"); + if (!opts.replace_orig) + opts.replace_orig =3D true; + } + + if (sign_single_file(&opts)) { + fprintf(stderr, "Failed to sign: %s module\n", opts.module_name); + return -1; + } + } + + return 0; } --=20 2.39.2