From nobody Mon Feb 9 01:30:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1ED6C7618A for ; Sun, 19 Mar 2023 20:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230110AbjCSUtv (ORCPT ); Sun, 19 Mar 2023 16:49:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbjCSUtr (ORCPT ); Sun, 19 Mar 2023 16:49:47 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ED3310418 for ; Sun, 19 Mar 2023 13:49:46 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id z21so39551660edb.4 for ; Sun, 19 Mar 2023 13:49:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679258985; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L5CLt5l4TCz1CmnxOdt+WgUKYgrA3LVqAot+WuRXqlA=; b=HTciBLqcsxjQsKrrZaKrQBKJb05epJEzu/YvZe7+r1jdosOareVKQQRXiSteVVTGVL 5ttb0pAiDAH/EjxTKEgTdoIADo5HUncf+YAIy5+L6xfw6Pf42lQZHYRqBUYXigVyD38p qfFtGR2NrCH+U7UJMlKUFlnVZmCoc4IPkWIoChJHwrwBQaIHVoTTejZevp4hQQN2/pfb f/wRDsetcWyFgfTTseaG4G2794tTGmLl953N+ey0uqCjuKwR7Ci13ywEKOr0yBUepLHq dmflQ2e5vcDebYxsDBUveVkl5DjN87Td5RjuCRU+ek9H1gLvG/ekC24mnMHOW6PcdX38 22GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679258985; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L5CLt5l4TCz1CmnxOdt+WgUKYgrA3LVqAot+WuRXqlA=; b=toOmhiZOLtG0eLVOlFI76WS6ZnqS6Ji+ThlA9CHqFJrfAyQnrBkR0uzHnKHWeDcTmK 1xRmKmnqe7LbbPnUL8HKYico7+skz6abNwuz2GUd2NcVbsl8zpphajatgRjklwaTQ3Np u8djERLfxLOmzV1hU0PKCK22YKBuJWVo+9uPwsp2hxQkUvoskMrw93rY3i+qhw70cLwD DS97ZG9U2PR1IfPYAButfCV9JBRTEvuRWaUaalY6oJ3j8ef36RZfeAH/j/AXOMWtXzBR RA8zrvIN5dxJneN+zomjf1oxnZhi+CrfctHmccAwnls034GfeKGiefSBvfQ/qFelgI6i VerA== X-Gm-Message-State: AO0yUKU3n6/cGPisbPX0ICZuhd4JQusjenCInB+otJnnXzOMs4VynLKh 6r2crPdmab6/OSuZ2O6Atbo= X-Google-Smtp-Source: AK7set+hOHTt0i9nlpUrmYUdJsFFLqBmF7VGZ3UHdlitwTFKimwuNTjzvOGv6RkYHNWLm3T5+3EzFg== X-Received: by 2002:a05:6402:4ca:b0:4ad:738b:6706 with SMTP id n10-20020a05640204ca00b004ad738b6706mr10982836edw.2.1679258984926; Sun, 19 Mar 2023 13:49:44 -0700 (PDT) Received: from alaa-emad.. ([41.42.177.251]) by smtp.gmail.com with ESMTPSA id v6-20020a50d086000000b004fb00831851sm3882901edd.66.2023.03.19.13.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Mar 2023 13:49:44 -0700 (PDT) From: Menna Mahmoud To: gregkh@linuxfoundation.org Cc: outreachy@lists.linux.dev, johan@kernel.org, elder@kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, eng.mennamahmoud.mm@gmail.com, Julia Lawall Subject: [PATCH v2] staging: greybus: use inline function for macros Date: Sun, 19 Mar 2023 22:49:35 +0200 Message-Id: <20230319204935.259217-1-eng.mennamahmoud.mm@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Convert `to_gbphy_dev` and `to_gbphy_driver` macros into a static inline function. it is not great to have macro that use `container_of` macro, because from looking at the definition one cannot tell what type it applies to. One can get the same benefit from an efficiency point of view by making an inline function. Suggested-by: Julia Lawall Signed-off-by: Menna Mahmoud --- changes in v2: remove newlines added in previous patch. --- drivers/staging/greybus/gbphy.h | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbph= y.h index 1de510499480..03a977056637 100644 --- a/drivers/staging/greybus/gbphy.h +++ b/drivers/staging/greybus/gbphy.h @@ -15,8 +15,10 @@ struct gbphy_device { struct list_head list; struct device dev; }; - -#define to_gbphy_dev(d) container_of(d, struct gbphy_device, dev) +static inline struct gbphy_device *to_gbphy_dev(const struct device *d) +{ + return container_of(d, struct gbphy_device, dev); +} =20 static inline void *gb_gbphy_get_data(struct gbphy_device *gdev) { @@ -44,8 +46,10 @@ struct gbphy_driver { =20 struct device_driver driver; }; - -#define to_gbphy_driver(d) container_of(d, struct gbphy_driver, driver) +static inline struct gbphy_driver *to_gbphy_driver(struct device_driver *d) +{ + return container_of(d, struct gbphy_driver, driver); +} =20 int gb_gbphy_register_driver(struct gbphy_driver *driver, struct module *owner, const char *mod_name); --=20 2.34.1