From nobody Fri Apr 26 21:37:33 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4727FC74A5B for ; Sat, 18 Mar 2023 03:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229731AbjCRDbp (ORCPT ); Fri, 17 Mar 2023 23:31:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjCRDbm (ORCPT ); Fri, 17 Mar 2023 23:31:42 -0400 Received: from mail.nfschina.com (unknown [42.101.60.237]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E243E1E3 for ; Fri, 17 Mar 2023 20:31:40 -0700 (PDT) Received: from localhost (unknown [127.0.0.1]) by mail.nfschina.com (Postfix) with ESMTP id DE4961A00AE2; Sat, 18 Mar 2023 11:31:40 +0800 (CST) X-Virus-Scanned: amavisd-new at nfschina.com Received: from mail.nfschina.com ([127.0.0.1]) by localhost (localhost.localdomain [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I47z3DFNmwEc; Sat, 18 Mar 2023 11:31:40 +0800 (CST) Received: from localhost.localdomain (unknown [219.141.250.2]) (Authenticated sender: kunyu@nfschina.com) by mail.nfschina.com (Postfix) with ESMTPA id A5BDC1A0091E; Sat, 18 Mar 2023 11:31:39 +0800 (CST) From: Li kunyu To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org, Li kunyu Subject: [PATCH] sched: core: Optimize the structure of 'tg_cfs_schedulable_down' function Date: Mon, 20 Mar 2023 04:02:55 +0800 Message-Id: <20230319200255.3640-1-kunyu@nfschina.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Optimize if branches and define in the branch statement block=E3=80=80parent_quota variable. Signed-off-by: Li kunyu --- kernel/sched/core.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 488655f2319f..7e8535d2e36d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -10915,15 +10915,12 @@ static int tg_cfs_schedulable_down(struct task_gr= oup *tg, void *data) { struct cfs_schedulable_data *d =3D data; struct cfs_bandwidth *cfs_b =3D &tg->cfs_bandwidth; - s64 quota =3D 0, parent_quota =3D -1; + s64 quota =3D RUNTIME_INF; =20 - if (!tg->parent) { - quota =3D RUNTIME_INF; - } else { + if (tg->parent) { struct cfs_bandwidth *parent_b =3D &tg->parent->cfs_bandwidth; - + s64 parent_quota =3D parent_b->hierarchical_quota; quota =3D normalize_cfs_quota(tg, d); - parent_quota =3D parent_b->hierarchical_quota; =20 /* * Ensure max(child_quota) <=3D parent_quota. On cgroup2, --=20 2.18.2