From nobody Thu Apr 25 05:15:04 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2809C74A5B for ; Sat, 18 Mar 2023 14:39:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbjCROjm (ORCPT ); Sat, 18 Mar 2023 10:39:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbjCROjk (ORCPT ); Sat, 18 Mar 2023 10:39:40 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6C7410DE; Sat, 18 Mar 2023 07:39:36 -0700 (PDT) Received: from laboratory-MS-7D42.. ([10.12.190.56]) (user=jingfelix@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 32IEcxOK023737-32IEcxOL023737 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 18 Mar 2023 22:39:04 +0800 From: Tianyi Jing To: Jean Delvare , Guenter Roeck Cc: Tianyi Jing , Dongliang Mu , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drivers: hwmon: fix ioremap and memremap leak Date: Sat, 18 Mar 2023 22:38:51 +0800 Message-Id: <20230318143851.2191625-1-jingfelix@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FEAS-AUTH-USER: jingfelix@hust.edu.cn Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Smatch reports: drivers/hwmon/xgene-hwmon.c:757 xgene_hwmon_probe() warn: 'ctx->pcc_comm_addr' from ioremap() not released on line: 757. This is because in drivers/hwmon/xgene-hwmon.c:701 xgene_hwmon_probe(), ioremap and memremap is not released, which may cause a leak. To fix this, ioremap and memremap is modified to devm_ioremap and devm_memremap. Signed-off-by: Tianyi Jing Reviewed-by: Dongliang Mu --- v1 -> v2: use devm_ioremap and devm_memremap instead. drivers/hwmon/xgene-hwmon.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c index 5cde837bfd09..a25fae9b19b7 100644 --- a/drivers/hwmon/xgene-hwmon.c +++ b/drivers/hwmon/xgene-hwmon.c @@ -698,11 +698,13 @@ static int xgene_hwmon_probe(struct platform_device *= pdev) ctx->comm_base_addr =3D pcc_chan->shmem_base_addr; if (ctx->comm_base_addr) { if (version =3D=3D XGENE_HWMON_V2) - ctx->pcc_comm_addr =3D (void __force *)ioremap( + ctx->pcc_comm_addr =3D (void __force *)devm_ioremap( + &pdev->dev, ctx->comm_base_addr, pcc_chan->shmem_size); else - ctx->pcc_comm_addr =3D memremap( + ctx->pcc_comm_addr =3D devm_memremap( + &pdev->dev, ctx->comm_base_addr, pcc_chan->shmem_size, MEMREMAP_WB); --=20 2.34.1