[PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions

Tom Rix posted 1 patch 4 days, 9 hours ago
sound/drivers/portman2x4.c | 10 ----------
1 file changed, 10 deletions(-)
[PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions
Posted by Tom Rix 4 days, 9 hours ago
clang with W=1 reports
sound/drivers/portman2x4.c:185:18: error: unused function
  'portman_read_command' [-Werror,-Wunused-function]
static inline u8 portman_read_command(struct portman *pm)
                 ^
sound/drivers/portman2x4.c:195:18: error: unused function
  'portman_read_data' [-Werror,-Wunused-function]
static inline u8 portman_read_data(struct portman *pm)
                 ^
These static functions are not used, so remove them.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 sound/drivers/portman2x4.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/sound/drivers/portman2x4.c b/sound/drivers/portman2x4.c
index 52a656735365..4cdf56a0eb65 100644
--- a/sound/drivers/portman2x4.c
+++ b/sound/drivers/portman2x4.c
@@ -182,21 +182,11 @@ static inline void portman_write_command(struct portman *pm, u8 value)
 	parport_write_control(pm->pardev->port, value);
 }
 
-static inline u8 portman_read_command(struct portman *pm)
-{
-	return parport_read_control(pm->pardev->port);
-}
-
 static inline u8 portman_read_status(struct portman *pm)
 {
 	return parport_read_status(pm->pardev->port);
 }
 
-static inline u8 portman_read_data(struct portman *pm)
-{
-	return parport_read_data(pm->pardev->port);
-}
-
 static inline void portman_write_data(struct portman *pm, u8 value)
 {
 	parport_write_data(pm->pardev->port, value);
-- 
2.27.0
Re: [PATCH] ALSA: portman2x4: remove unused portman_read_command,data functions
Posted by Takashi Iwai 3 days, 14 hours ago
On Sat, 18 Mar 2023 14:52:29 +0100,
Tom Rix wrote:
> 
> clang with W=1 reports
> sound/drivers/portman2x4.c:185:18: error: unused function
>   'portman_read_command' [-Werror,-Wunused-function]
> static inline u8 portman_read_command(struct portman *pm)
>                  ^
> sound/drivers/portman2x4.c:195:18: error: unused function
>   'portman_read_data' [-Werror,-Wunused-function]
> static inline u8 portman_read_data(struct portman *pm)
>                  ^
> These static functions are not used, so remove them.
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Applied now, thanks.


Takashi