From nobody Tue Feb 10 21:38:33 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FF46C74A5B for ; Fri, 17 Mar 2023 14:18:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229814AbjCQOSh (ORCPT ); Fri, 17 Mar 2023 10:18:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbjCQOSe (ORCPT ); Fri, 17 Mar 2023 10:18:34 -0400 Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D71359C2 for ; Fri, 17 Mar 2023 07:18:05 -0700 (PDT) Received: by mail-il1-x134.google.com with SMTP id 4so2811868ilz.6 for ; Fri, 17 Mar 2023 07:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679062679; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=bLuzKAEkaqcIq6AVNq4PWYMR9r7yckQDIYx3W14fFbQ=; b=fLsYWDjuE07eQ6G7uOVyBOIkC4PhM2uiPK5xhuv90Xm/LclY/Ra0qzFnB8lU6UJS7P OXqIu97p4TXATvyYYNKHslRWDEScL1KR088FLjH2yVx3qaGpBKQN1rmU8tasyAMQRV8w OjpbjB+OctmWGzKRNWuPHTe/GhvMyVhQcDlILgN3ry4q4j6GMkK+2iQy7t9jjAsXhcwK /4sQD+m50YS9i/w6B//y5hNhOjObq93mxgT45VM2fGmbs/bCkATU9d2fokGy9zcYJNmX C5R62cV6FxRSnItqIPEepLiTCtmjD4slIQZBNXzqdLlPNzqCKPu7ZkCTItQP/g4+x6jx W7AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679062679; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bLuzKAEkaqcIq6AVNq4PWYMR9r7yckQDIYx3W14fFbQ=; b=vhMj8iRafhV95U0AUhnFHh2hgnnaHBm6xHcik2E+PGsd3/4OwP+F065SCQwcxcaGpe qQbOPTxcvEhymYMnXqq8EIw0urp5w+/m4dFLb1xwnJCJi4OmRy2IKMB0M67g/aFbszh0 e9sFctZhgowhuYVNxI/NDJzinZ+UB6y9iuAsyNS8h2i1RiyRsNSW3cEfoJpicfDJ+Ywl 1F2gPIT7pDGOaWcI934q21x7H+5u9YAXRFIIAVxUZKfqvBtqhCoD9CO61WvwCdeju6cJ HAi6ikD/6Vu8vWsGLxW3gtBRZPXDz0guAtDiTBE+xETbw17cuo1W3qVYuxYH45xfdLlp loxw== X-Gm-Message-State: AO0yUKXFjzAuRkcGhq+NY/pjdYIGdnOjBJ1UAGXBX2tG76fdnZsp9+5A ShzbVi3leLb7EY6mVj6dxa2CLvshWYleabo+ X-Google-Smtp-Source: AK7set+OyC/Lyv3VlxfdCZWj7X/hYLmc594LVPMonaUxAi00/vpMqSiwJu5BZFZkgYI4SpckqUM1NA== X-Received: by 2002:a92:ddca:0:b0:323:162a:80d4 with SMTP id d10-20020a92ddca000000b00323162a80d4mr5978ilr.4.1679062678808; Fri, 17 Mar 2023 07:17:58 -0700 (PDT) Received: from pikachu-Z97-D3H ([76.76.64.93]) by smtp.gmail.com with ESMTPSA id s20-20020a92c5d4000000b00315d1153ffcsm618638ilt.65.2023.03.17.07.17.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Mar 2023 07:17:58 -0700 (PDT) Date: Fri, 17 Mar 2023 08:17:56 -0600 From: Mark Thomas Heim To: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH] staging: greybus: extract a fxn to improve clarity Message-ID: <20230317141756.GA43753@pikachu-Z97-D3H> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The gb_audio_gb_get_topology function at the top of the file needs to be split per a TODO comment above the function. It is necessary to refactor the code to pull out a method that has fewer parameters to improve readability. A prototype for the new function is now in the relevant header, and the simpler function calls replace the old ones. Signed-off-by: Mark Thomas Heim --- drivers/staging/greybus/audio_codec.h | 2 ++ drivers/staging/greybus/audio_gb.c | 21 +++++++++++---------- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybu= s/audio_codec.h index ce15e800e607..a2e8361952b8 100644 --- a/drivers/staging/greybus/audio_codec.h +++ b/drivers/staging/greybus/audio_codec.h @@ -177,6 +177,8 @@ int gbaudio_register_module(struct gbaudio_module_info = *module); void gbaudio_unregister_module(struct gbaudio_module_info *module); =20 /* protocol related */ +int fetch_gb_audio_data(struct gb_connection *connection, int type, + void *response, int response_size); int gb_audio_gb_get_topology(struct gb_connection *connection, struct gb_audio_topology **topology); int gb_audio_gb_get_control(struct gb_connection *connection, diff --git a/drivers/staging/greybus/audio_gb.c b/drivers/staging/greybus/a= udio_gb.c index 9d8994fdb41a..3c924d13f0e7 100644 --- a/drivers/staging/greybus/audio_gb.c +++ b/drivers/staging/greybus/audio_gb.c @@ -8,7 +8,13 @@ #include #include "audio_codec.h" =20 -/* TODO: Split into separate calls */ +int fetch_gb_audio_data(struct gb_connection *connection, + int type, void *response, int response_size) +{ + return gb_operation_sync(connection, type, NULL, 0, + response, response_size); +} + int gb_audio_gb_get_topology(struct gb_connection *connection, struct gb_audio_topology **topology) { @@ -17,28 +23,23 @@ int gb_audio_gb_get_topology(struct gb_connection *conn= ection, u16 size; int ret; =20 - ret =3D gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, - NULL, 0, &size_resp, sizeof(size_resp)); + ret =3D fetch_gb_audio_data(connection, GB_AUDIO_TYPE_GET_TOPOLOGY_SIZE, + &size_resp, sizeof(size_resp)); if (ret) return ret; - size =3D le16_to_cpu(size_resp.size); if (size < sizeof(*topo)) return -ENODATA; - topo =3D kzalloc(size, GFP_KERNEL); if (!topo) return -ENOMEM; - - ret =3D gb_operation_sync(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, NULL, 0, - topo, size); + ret =3D fetch_gb_audio_data(connection, GB_AUDIO_TYPE_GET_TOPOLOGY, + topo, size); if (ret) { kfree(topo); return ret; } - *topology =3D topo; - return 0; } EXPORT_SYMBOL_GPL(gb_audio_gb_get_topology); --=20 2.25.1