From nobody Wed Feb 11 09:01:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34451C7618A for ; Thu, 16 Mar 2023 10:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230422AbjCPKaK (ORCPT ); Thu, 16 Mar 2023 06:30:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231310AbjCPK37 (ORCPT ); Thu, 16 Mar 2023 06:29:59 -0400 X-Greylist: delayed 52879 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 16 Mar 2023 03:29:49 PDT Received: from forwardcorp1b.mail.yandex.net (forwardcorp1b.mail.yandex.net [IPv6:2a02:6b8:c02:900:1:45:d181:df01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CE911CBF9; Thu, 16 Mar 2023 03:29:48 -0700 (PDT) Received: from mail-nwsmtp-smtp-corp-main-44.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-44.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:5398:0:640:443b:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTP id 70F355FC9C; Thu, 16 Mar 2023 13:29:46 +0300 (MSK) Received: from d-tatianin-nix.yandex-team.ru (unknown [2a02:6b8:b081:b53b::1:d]) by mail-nwsmtp-smtp-corp-main-44.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id OTh0TA0hxGk0-rpgz28XH; Thu, 16 Mar 2023 13:29:45 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1678962585; bh=YSsSTmCAl0Avq9yZ876wK9u88LT7FmPh5ldlvefTzBc=; h=Message-Id:Date:Cc:Subject:To:From; b=SitDX3BapP0GEm3WMcsc5ae2KZijq5YVjSHC3jr7IiJvDD8AIs97Gq65BFB/UYgLf fQpciIUezgZAd0f6fmUF9m/CHYkN3arRUDmGRXlWOOivMXCK7w0Ty0tLi+kR3yBTC8 RxiFlYchyYAVsF/NeqhVt/A0oOhOpX3alWd1Dngw= Authentication-Results: mail-nwsmtp-smtp-corp-main-44.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Daniil Tatianin To: Ariel Elior Cc: Daniil Tatianin , Manish Chopra , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yuval Mintz , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] qed/qed_sriov: guard against NULL derefs from qed_iov_get_vf_info Date: Thu, 16 Mar 2023 13:29:21 +0300 Message-Id: <20230316102921.609266-1-d-tatianin@yandex-team.ru> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" We have to make sure that the info returned by the helper is valid before using it. Found by Linux Verification Center (linuxtesting.org) with the SVACE static analysis tool. Fixes: f990c82c385b ("qed*: Add support for ndo_set_vf_trust") Fixes: 733def6a04bf ("qed*: IOV link control") Signed-off-by: Daniil Tatianin Reviewed-by: Michal Swiatkowski --- Changes since v1: - Add a vf check to qed_iov_handle_trust_change as well --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_sriov.c b/drivers/net/ethe= rnet/qlogic/qed/qed_sriov.c index 2bf18748581d..fa167b1aa019 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_sriov.c +++ b/drivers/net/ethernet/qlogic/qed/qed_sriov.c @@ -4404,6 +4404,9 @@ qed_iov_configure_min_tx_rate(struct qed_dev *cdev, i= nt vfid, u32 rate) } =20 vf =3D qed_iov_get_vf_info(QED_LEADING_HWFN(cdev), (u16)vfid, true); + if (!vf) + return -EINVAL; + vport_id =3D vf->vport_id; =20 return qed_configure_vport_wfq(cdev, vport_id, rate); @@ -5152,7 +5155,7 @@ static void qed_iov_handle_trust_change(struct qed_hw= fn *hwfn) =20 /* Validate that the VF has a configured vport */ vf =3D qed_iov_get_vf_info(hwfn, i, true); - if (!vf->vport_instance) + if (!vf || !vf->vport_instance) continue; =20 memset(¶ms, 0, sizeof(params)); --=20 2.25.1