From nobody Wed Feb 11 10:19:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D2FEC6FD1D for ; Wed, 15 Mar 2023 19:11:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232766AbjCOTLh (ORCPT ); Wed, 15 Mar 2023 15:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232524AbjCOTLd (ORCPT ); Wed, 15 Mar 2023 15:11:33 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC28C574FF for ; Wed, 15 Mar 2023 12:11:32 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id o3-20020a634e43000000b0050726979a86so4727347pgl.4 for ; Wed, 15 Mar 2023 12:11:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678907492; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=MPGBQpB/QOW3rOyiIDpJ1ssFrkSwrzaQZYPEXWdODjE=; b=DmIV0/goxFG7244B78LovLy06QrlSgu8/f40cOxIKKIBWcFXMdLj2/R/SlxpjVI4Xs FyUfyY6rHLpQIRLKr5KEahhvus39lwLLwwb1AQLRk8kAWyYQvyWEI54fGCL0uZ0DnT5p 1ohtmXtfIfH+AiU7mEHey888ZlDpXgbLWl0bfugYDjapKaQ2Rvv7ZdqM/hiYsJTp137H xD1vW+VMReaaLTBGQXU2bY9+JSK17d/EKiYyKK9udwboPopfApz3zvvdmC4KSdaOyM0T 47Dg2Eri745skE5XoFMII7S7y7R5XBt80sAHmZFd5xoRoRq/FwdnQcqQESDxIsSUmSut 3MhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678907492; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MPGBQpB/QOW3rOyiIDpJ1ssFrkSwrzaQZYPEXWdODjE=; b=NK+kbb6tSFwp5Fmes0/P2T2bxljb+Pt0R/TGQ1DryxC5tvuPrgHWKXSep6Ua4rmDRb aHYSW2/XE3njTAvDJK0RKNMsX9SsD8pWVat2PAJHRXLMZ+oLeEDc9/RZikS5sTl5pEjY eJadOY6ZHQaJQ6JjgZ1fs4vmbqREWIQGQkNBEhh50aW1vEGgrFfwoyttb3XbuC30bpty XlAhHmRnmfrDD0a9rXqQ4d69gU6jxeXwSzuA8WEZXVD+34JfiJM37zDtdHP9CPzgcMkA jrsU+d3J88ovP7bS/lUryQx/9mcmW2YjREy7L4hgq5SbbjlqjCPu35gcZLZdd34WbJYa 1IlA== X-Gm-Message-State: AO0yUKXxxctqkgWnaY5F/sHEyNxn7eBaUtdLgK74MKqMX+ONqr7uVOzD l0aIoB4VtKIRlhtzPCgp0EAUu3xQZ58= X-Google-Smtp-Source: AK7set920HmFpb4MlEzZ8bRlGcqLIXXvrzrExQHAfTr81kPsDnjFnKwpGVaRsLPcCVKmLXRheMOgnHuI+sY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:452:b0:19e:f660:81ee with SMTP id iw18-20020a170903045200b0019ef66081eemr303110plb.2.1678907492254; Wed, 15 Mar 2023 12:11:32 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 15 Mar 2023 12:11:27 -0700 In-Reply-To: <20230315191128.1407655-1-seanjc@google.com> Mime-Version: 1.0 References: <20230315191128.1407655-1-seanjc@google.com> X-Mailer: git-send-email 2.40.0.rc2.332.ga46443480c-goog Message-ID: <20230315191128.1407655-2-seanjc@google.com> Subject: [PATCH 1/2] KVM: VMX: Drop unprotected-by-braces variable declaration in case-statement From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Emanuele Giuseppe Esposito Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the intermediate "guest_flush_l1d" boolean to fix a build error on clang due to the variable being declared inside a case-statement without curly braces to create a proper code block. Fixes: c7ed946b95cb ("kvm: vmx: Add IA32_FLUSH_CMD guest support") Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202303151912.oZ6SGd90-lkp@intel= .com Cc: Emanuele Giuseppe Esposito Signed-off-by: Sean Christopherson Reviewed-by: Emanuele Giuseppe Esposito --- arch/x86/kvm/vmx/vmx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index c63f6c786eb1..d7bf14abdba1 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -2325,10 +2325,8 @@ static int vmx_set_msr(struct kvm_vcpu *vcpu, struct= msr_data *msr_info) X86_FEATURE_IBPB); break; case MSR_IA32_FLUSH_CMD: - bool guest_flush_l1d =3D guest_cpuid_has(vcpu, - X86_FEATURE_FLUSH_L1D); ret =3D vmx_set_msr_ia32_cmd(vcpu, msr_info, - guest_flush_l1d, + guest_cpuid_has(vcpu, X86_FEATURE_FLUSH_L1D), L1D_FLUSH, X86_FEATURE_FLUSH_L1D); break; --=20 2.40.0.rc2.332.ga46443480c-goog From nobody Wed Feb 11 10:19:23 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FBEDC61DA4 for ; Wed, 15 Mar 2023 19:11:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232786AbjCOTLl (ORCPT ); Wed, 15 Mar 2023 15:11:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232746AbjCOTLf (ORCPT ); Wed, 15 Mar 2023 15:11:35 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6EF4838A5 for ; Wed, 15 Mar 2023 12:11:34 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 206-20020a2504d7000000b00b3511d10748so15090514ybe.20 for ; Wed, 15 Mar 2023 12:11:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678907494; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=NrTG/RNvnmx6+qCUMITlqkHzZaqBZaogZoP5BHuvk2o=; b=Ln4oqm3uMTtO1Ycn3E5ZXBvER2L0XR0Mog6BKVGC+G7ETMrCmliz22b5QbVcYzWucf 157OT8hIWXk1CwHAkYlJAm0E7I7okipnOsdZei5Syhx8/i6x9JyYUbUB6ZBHhdWxk2zb AZolc+nyJTHsoX6yGj5fQbX8hxqpvG79kHIQ6uai6mN+ClyxejQR/Qvhmk60e5N0TDL5 xMKRyAgS7Ob9o9EC+3QSPWFqmxyXssn5LMyqBBtg9qHG+A+Z3IC3RuajXDco0U1MUkjA LywmmAgrnbZdxT8Vcv4PeWh7NifgbSFSw9vo4rxDo2p7Hb/YEtj5Y6kz+t6gqGIUgIyt RkCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678907494; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrTG/RNvnmx6+qCUMITlqkHzZaqBZaogZoP5BHuvk2o=; b=iexT2Q3aSOBp0ckZN5qBEYaCLR0VMtwn4Afm1LqyrA4/ZpzT3XDK62XT22K5MsXdUL fUWT9H0SkHtotfmlH8MMRgpMWSLclTGIzsAzkIMao0FW5lLhevVyTOB3pbFkmLEiTrOR Bti7OMm9FxTfDCV5FnDOSQ50MfRvl+JG/1A3bS4lGe0dnJGjDYfh4tBpIUwWL563ETZ1 m3rUZdzBQ/GE33w2Br+zPIqBd/hq8SZTFWNzi7iePfXdnLkGch3T3XQiK9qO2umdNdSa r5jQflQv6gn7PjFeGuPCyDjY3btmpRbyiUD8pXj3rBoZo+8M4NOsuOd5feZb4RMv4qCs xy1Q== X-Gm-Message-State: AO0yUKVd+AbuQ2gsaPYZcbkmy4ztqUN0Bht6lli+Rpcj9dguFKG50OQn e4Sb3hHbzeYTr39X5RT1LV/3UewNOEU= X-Google-Smtp-Source: AK7set9L9eMBtTsJBCZzCkxPA4so99AyclhxgsIBkWeEvMjkC8pq4EmQ+TV0Wv8rl6Tt4hvQEQIdBmYJ+QU= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:8c84:0:b0:b23:4649:7ef3 with SMTP id m4-20020a258c84000000b00b2346497ef3mr13951296ybl.4.1678907494054; Wed, 15 Mar 2023 12:11:34 -0700 (PDT) Reply-To: Sean Christopherson Date: Wed, 15 Mar 2023 12:11:28 -0700 In-Reply-To: <20230315191128.1407655-1-seanjc@google.com> Mime-Version: 1.0 References: <20230315191128.1407655-1-seanjc@google.com> X-Mailer: git-send-email 2.40.0.rc2.332.ga46443480c-goog Message-ID: <20230315191128.1407655-3-seanjc@google.com> Subject: [PATCH 2/2] KVM: SVM: Drop unprotected-by-braces variable declaration in case-statement From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Emanuele Giuseppe Esposito Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the intermediate "guest_flush_l1d" boolean to fix a build error on clang due to the variable being declared inside a case-statement without curly braces to create a proper code block. Fixes: cfc1f129df06 ("kvm: svm: Add IA32_FLUSH_CMD guest support") Cc: Emanuele Giuseppe Esposito Signed-off-by: Sean Christopherson Reviewed-by: Emanuele Giuseppe Esposito --- arch/x86/kvm/svm/svm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c index 2780254d4362..70183d2271b5 100644 --- a/arch/x86/kvm/svm/svm.c +++ b/arch/x86/kvm/svm/svm.c @@ -2970,9 +2970,8 @@ static int svm_set_msr(struct kvm_vcpu *vcpu, struct = msr_data *msr) PRED_CMD_IBPB, X86_FEATURE_IBPB); break; case MSR_IA32_FLUSH_CMD: - bool guest_flush_l1d =3D guest_cpuid_has(vcpu, - X86_FEATURE_FLUSH_L1D); - r =3D svm_set_msr_ia32_cmd(vcpu, msr, guest_flush_l1d, + r =3D svm_set_msr_ia32_cmd(vcpu, msr, + guest_cpuid_has(vcpu, X86_FEATURE_FLUSH_L1D), L1D_FLUSH, X86_FEATURE_FLUSH_L1D); break; case MSR_AMD64_VIRT_SPEC_CTRL: --=20 2.40.0.rc2.332.ga46443480c-goog