From nobody Wed Sep 10 05:38:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AFD0C61DA4 for ; Sun, 12 Mar 2023 02:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229956AbjCLCQv (ORCPT ); Sat, 11 Mar 2023 21:16:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbjCLCQr (ORCPT ); Sat, 11 Mar 2023 21:16:47 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 977EA4DBD8 for ; Sat, 11 Mar 2023 18:16:26 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id w200-20020a25c7d1000000b00b3215dc7b87so4947187ybe.4 for ; Sat, 11 Mar 2023 18:16:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1678587386; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=uXcDY77l4F8nFJ6IeFtiGZvS8C7nKH2bFLw1W06sHco=; b=hc9HjUv1Duu5eqI32NQsQb957q2Yi5F1MnFUk2WDfyyY6pd6G5MaWOks9wkXQE52+d ywMj3Due6PlliYPGeFp+m5sFAcj8GnV3ZjPcj6blk886sRPPiswr1v0g9y+Wdq3HUFrf WiSRViNbjvcEEdQt+CovLEdwambpkl7F0ohKh1F7veAzmJdtRsBTmlBlqpbjV9MFyG// cYrNO5mWKilWMY8VUnBkLEeUiZf7Y+gPoBPDJooS4TQkAYPj75g4FPN+WQ92ow+DxLDY J+EuT7YN7tFi8EEifKOG4iy48gFtfW8EAZan1zyvrpA4/GPICjjavLeIJOVLna6rZuda rg8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678587386; h=cc:to:from:subject:references:mime-version:message-id:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uXcDY77l4F8nFJ6IeFtiGZvS8C7nKH2bFLw1W06sHco=; b=OK0rqu0823405NdTf9Hv8gV0We8hdnURjzmMB7uHj3m6ymHYKe+E4wXy7uAQ1pV5Ls 0ctvaujxl4aKM5HbpYJlb5tQxUiCD6R3TiP1QTjl4dxFwP2AaEGTjEZjodWLyplh04Lt vIUJsWbk5aE7hv5V0CJlkxac5Wv3frXIzV526IAWwJhNpLuO6KdcqaF9YaxDqSiWpgzn 3U/AAG6e0X3GSZUaJWwsmkFKyDHxTfIfwgLvdTEvCwfY/W4UdBtPPkwoDGjArKmojO8r JKXHuDrCYfw1rwvk1u25902oWfwHaCIt7LKwoIDDcEgduCb8LY9ETHiaClhx+CL4Gj4/ 1cwg== X-Gm-Message-State: AO0yUKXSZpehVOwB918blv+onNFUz2P3GA3w1TobpPYkxzfZAWxIjitr vYtGql0mGTGjQyOAFLrOqbBhNG1C/rTk X-Google-Smtp-Source: AK7set/x/A1I/b0OOUdLh84YVDmwWWkJLj2dgDbD/RHYWhQkb17EHDezeQNnJi1zEVZexigTUEwJYmvjF8xp X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:b42b:2e07:afb:877e]) (user=irogers job=sendgmr) by 2002:a05:6902:188:b0:a99:de9d:d504 with SMTP id t8-20020a056902018800b00a99de9dd504mr18477824ybh.12.1678587385808; Sat, 11 Mar 2023 18:16:25 -0800 (PST) Date: Sat, 11 Mar 2023 18:15:36 -0800 In-Reply-To: <20230312021543.3060328-1-irogers@google.com> Message-Id: <20230312021543.3060328-5-irogers@google.com> Mime-Version: 1.0 References: <20230312021543.3060328-1-irogers@google.com> X-Mailer: git-send-email 2.40.0.rc1.284.g88254d51c5-goog Subject: [PATCH v5 04/11] perf stat: Modify the group test From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Mark Rutland , Adrian Hunter , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Kan Liang , Zhengjun Xing , Ravi Bangoria , "Steinar H. Gunderson" , Kim Phillips , Florian Fischer , James Clark , Suzuki Poulouse , Sean Christopherson , Leo Yan , John Garry , Kajol Jain , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Currently nr_members is 0 for an event with no group, however, they are always a leader of their own group. A later change will make that count 1 because the event is its own leader. Make the find_stat logic consistent with this, an improvement suggested by Namhyung Kim. Suggested-by: Namhyung Kim Signed-off-by: Ian Rogers --- tools/perf/util/stat-shadow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c index ef85f1ae1ab2..eeccab6751d7 100644 --- a/tools/perf/util/stat-shadow.c +++ b/tools/perf/util/stat-shadow.c @@ -163,7 +163,7 @@ static double find_stat(const struct evsel *evsel, int = aggr_idx, enum stat_type continue; =20 /* Ignore evsels that are part of different groups. */ - if (evsel->core.leader->nr_members && + if (evsel->core.leader->nr_members > 1 && evsel->core.leader !=3D cur->core.leader) continue; /* Ignore evsels with mismatched modifiers. */ --=20 2.40.0.rc1.284.g88254d51c5-goog