From nobody Sat Apr 11 20:29:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C03EC6FD19 for ; Fri, 10 Mar 2023 08:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231205AbjCJIfV (ORCPT ); Fri, 10 Mar 2023 03:35:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230444AbjCJIfJ (ORCPT ); Fri, 10 Mar 2023 03:35:09 -0500 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 744EC57D27 for ; Fri, 10 Mar 2023 00:35:07 -0800 (PST) Received: by mail-ed1-x529.google.com with SMTP id x3so17303464edb.10 for ; Fri, 10 Mar 2023 00:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678437306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qq0v9YVI3wtTDDjRzU92twoQtmr2PxAaTyrW0UMmWQw=; b=DPozms87b/PKkkvHKub1WKUztXE4+jPb5NnQzzW1kMEuhkF8hKSWBzkPblC7l61XQh EZ1IRrjDeI6vRq9phb5K1GGpS+AbLi8zw0oHClXEhj+1S/M50sK6Zh87BFVW8E/x1k86 GPNd3m060qI+rO6sDrrMjMqBIjYU5L0drL2gxFllMpKGHFfM6Ib4pIGPrHMslE4+1xS7 IPPJxK0q+RZLSIQg8FCsIpBBqs8h+Gwp/umX+b9Mhp0jaWndX2nPWxVv7fpU6/ZKK7xn EzRJ/uL5ZIzsIfu46DzMC6ihuntdr1MWemfP1ze9dgz+6G5NssJ18c5vqAveeFWzRxqS HsZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437306; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qq0v9YVI3wtTDDjRzU92twoQtmr2PxAaTyrW0UMmWQw=; b=z/7cIWcy4nLDGP5x26av/tWp02wg/wL8hejf2fqjgYqTEp/yNPkKPFePeHowv4fWzi 3REZ9oiIirRK4oIgPBxkcnEx76m8OHnfE6PAD7jMcd8oHQLOCJfA8bfUfEfO3/9iHqFv AYX2EN2OiRaNFJuk6R7I9LLiL6909FpaGbN1bgaO9g7+4H3mnFRioe547MNf6molQ5qc JHSb0qIKkwC4N/D8DU0gNKiCs21EO4jyznIPNqjU4yg9U1mvDr++dILf4b08rlTPXqdd YUjqNG8KV136hlb1X7roL6LKP7jFWdIHkF+nwuJVDdY6meAOwTkIbbVgadc4Jcnu5IkY x3xA== X-Gm-Message-State: AO0yUKWHF64w4MYAV7VD9Mec8y/BHKY7qdb+nya22LmyNs294miaH50d cAMPDNkrimHyRBi0bBzBsrE= X-Google-Smtp-Source: AK7set9zvfifLV+DAdB0O75/g20ZDKcfqNMOyFRopgBKGXG/WmOUXZN7jRDevDU5HDD2DOXlzO0/3g== X-Received: by 2002:a17:906:6d85:b0:8c3:3439:24d9 with SMTP id h5-20020a1709066d8500b008c3343924d9mr19667016ejt.24.1678437306035; Fri, 10 Mar 2023 00:35:06 -0800 (PST) Received: from localhost.localdomain (ip5f5abbd3.dynamic.kabel-deutschland.de. [95.90.187.211]) by smtp.gmail.com with ESMTPSA id h10-20020a17090619ca00b008ce5b426d77sm697888ejd.13.2023.03.10.00.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:35:05 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 1/5] staging: rtl8723bs: MapCharToHexDigit() is not used Date: Fri, 10 Mar 2023 09:34:45 +0100 Message-Id: <20230310083449.23775-2-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310083449.23775-1-straube.linux@gmail.com> References: <20230310083449.23775-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function MapCharToHexDigit() is not used anywhere, remove it. Signed-off-by: Michael Straube Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_com.c | 16 ---------------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 2 files changed, 18 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index e42556d03bce..b74817fc4316 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -859,22 +859,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num) return true; } =20 -/* */ -/* Description: */ -/* Translate a character to hex digit. */ -/* */ -u32 MapCharToHexDigit(char chTmp) -{ - if (chTmp >=3D '0' && chTmp <=3D '9') - return chTmp - '0'; - else if (chTmp >=3D 'a' && chTmp <=3D 'f') - return 10 + (chTmp - 'a'); - else if (chTmp >=3D 'A' && chTmp <=3D 'F') - return 10 + (chTmp - 'A'); - else - return 0; -} - bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8 *pInt) { u16 i =3D 0; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 6356b8c2ef81..8a7d31d1eaca 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -147,8 +147,6 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_v= ariable variable, =20 bool eqNByte(u8 *str1, u8 *str2, u32 num); =20 -u32 MapCharToHexDigit(char chTmp); - bool ParseQualifiedString(char *In, u32 *Start, char *Out, char LeftQualif= ier, char RightQualifier); =20 --=20 2.39.2 From nobody Sat Apr 11 20:29:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A50FEC6FD19 for ; Fri, 10 Mar 2023 08:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbjCJIf3 (ORCPT ); Fri, 10 Mar 2023 03:35:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbjCJIfM (ORCPT ); Fri, 10 Mar 2023 03:35:12 -0500 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A0E75D746 for ; Fri, 10 Mar 2023 00:35:09 -0800 (PST) Received: by mail-ed1-x530.google.com with SMTP id u9so17429673edd.2 for ; Fri, 10 Mar 2023 00:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678437308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gReelpVe4zvSWiZRdb8tfO79qo06lsPORLYzKHhKDKI=; b=SWku8Pd8dDAyAUoUWp4nVPyVnmqu8m9KfnggqUW6hqjOiOCxQGQmhrjYXw/XTV5q6D NJUXM9/K6dyg3UTvC+ZwmN+X5axinHki4oXxkcUtDTYfFO2NlDbzTgCKZzzSC2gW8GiZ Z03AgvUWM6axMuK6GFIRshNHF2bKNtJQJQJYxVkp39Rm+MKkUluYXjfjkjwo1dOKVxHb d6EjEiVwg0J01uiAs9VIsITZCCiLvo/e++CIrqX2XzLrrNg6Y/WM7KVAYJ9k7KxEGQVZ ywzDlwkF6hFvWI9Sd1EzfekYpi06EiIKtKGysvRyRuzyXzb3LTgCvJXBo1PMq7OSbOId kHHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gReelpVe4zvSWiZRdb8tfO79qo06lsPORLYzKHhKDKI=; b=z0sY5n4v+NGx95Ajbvo75vRllQ9DylXX8N37SvFFnVr8RIQNgy/IuPSh7gzfgKW02p AWcXpFRTjh6OCDmdSnCKQ5pslgbQNnTzVyC0EpFXC/yOjN3Zowm1m8d3QxGbIuCqFHbG n9wBTyf1TzhUD8rZhQhcDriOj+i266sHdf8aSjX3GDt9MHSnF0BlWukKgtN6ix9PwmHt Db6VP3VhMaN/xfWzmNkmtSEuV0Y6Mwo2uOdvD1XtlT7HjnFxao0Av6uIYowxs2zkB6xp jmOzjuCjg8d7DISDVeW0klUKsf64QL1ThGMAtvJK16hgKOaRaES0vH1C1Drnxd2qBHsG HD5A== X-Gm-Message-State: AO0yUKVvZHVNZfH4MVw6fRNFq/ceHR1NMPEzFWtzNnWG0cTU/TGg5nRs tXNyhF4xifFJif7dV9h3XQU= X-Google-Smtp-Source: AK7set9/L1r/raS/hQPUMv+1ex7lPMAWTlgp4gB5S+woMqEvmkEeH771z0d1gMu8z/MXFLlSmUU3EQ== X-Received: by 2002:a17:907:d14:b0:8f6:711b:8d67 with SMTP id gn20-20020a1709070d1400b008f6711b8d67mr34277473ejc.26.1678437308048; Fri, 10 Mar 2023 00:35:08 -0800 (PST) Received: from localhost.localdomain (ip5f5abbd3.dynamic.kabel-deutschland.de. [95.90.187.211]) by smtp.gmail.com with ESMTPSA id h10-20020a17090619ca00b008ce5b426d77sm697888ejd.13.2023.03.10.00.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:35:07 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 2/5] staging: rtl8723bs: ParseQualifiedString() is not used Date: Fri, 10 Mar 2023 09:34:46 +0100 Message-Id: <20230310083449.23775-3-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310083449.23775-1-straube.linux@gmail.com> References: <20230310083449.23775-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function ParseQualifiedString() is not used anywhere, remove it. Signed-off-by: Michael Straube Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_com.c | 24 --------------------- drivers/staging/rtl8723bs/include/hal_com.h | 3 --- 2 files changed, 27 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index b74817fc4316..ff0e41bf72b0 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -877,30 +877,6 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8= *pInt) return true; } =20 -/* <20121004, Kordan> For example, - * ParseQualifiedString(inString, 0, outString, '[', ']') gets "Kordan" f= rom - * a string "Hello [Kordan]". - * If RightQualifier does not exist, it will hang in the while loop - */ -bool ParseQualifiedString( - char *In, u32 *Start, char *Out, char LeftQualifier, char RightQualifier -) -{ - u32 i =3D 0, j =3D 0; - char c =3D In[(*Start)++]; - - if (c !=3D LeftQualifier) - return false; - - i =3D (*Start); - while ((c =3D In[(*Start)++]) !=3D RightQualifier) - ; /* find ']' */ - j =3D (*Start) - 2; - strncpy((char *)Out, (const char *)(In+i), j-i+1); - - return true; -} - bool isAllSpaceOrTab(u8 *data, u8 size) { u8 cnt =3D 0, NumOfSpaceAndTab =3D 0; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 8a7d31d1eaca..31fdb5c45de3 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -147,9 +147,6 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_v= ariable variable, =20 bool eqNByte(u8 *str1, u8 *str2, u32 num); =20 -bool ParseQualifiedString(char *In, u32 *Start, char *Out, char LeftQualif= ier, - char RightQualifier); - bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); =20 bool isAllSpaceOrTab(u8 *data, u8 size); --=20 2.39.2 From nobody Sat Apr 11 20:29:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08096C6FD1C for ; Fri, 10 Mar 2023 08:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229637AbjCJIff (ORCPT ); Fri, 10 Mar 2023 03:35:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbjCJIfM (ORCPT ); Fri, 10 Mar 2023 03:35:12 -0500 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA8A16153C for ; Fri, 10 Mar 2023 00:35:09 -0800 (PST) Received: by mail-ed1-x532.google.com with SMTP id da10so17429209edb.3 for ; Fri, 10 Mar 2023 00:35:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678437308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s4eERmpGRWxN7WGTZJirAqZLtcWVZejiRDlj9T4wObg=; b=QEHT/Kmafou4c+fPJ4W3mksw8ajqdo2XLzLsHGizvtqOzI7nCHZoz67aRqVygsWNYI vYYEJVdHtWJ1ByZTTanLjVOpcB4EeOamopmdXVZzv4SrO/Nlgr6bIN6/EtCuiop81i1+ qbQPTif6bWMIjblA5muXgURhXELE2Ost6+EW/qo+b21PoubO9ZVRj9NnZg5BfYr/R6L7 9//z+geQJ6je0xWKAAvis5k/814C4zAeonRRvnkO6XbvwFWSvgwC0cuTio/4Eb8F6V+J 69/G56a6W86SdCANiBZ4DXUuH1IvLz8bI837HzWqvNxi0cF/PvApv3mg6MV1AYZB19VG Da+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s4eERmpGRWxN7WGTZJirAqZLtcWVZejiRDlj9T4wObg=; b=W65Q7oEmN7bEbJVpZud7sSSG5VBZnY3UXL0pZ1GGw5Nq7qSocRQVpuf99Rgz51FKKh EzWfjprnPtvQfkQgEpsUPLwI6MaWsx2y5FiO21wF/PdDOwQpZVg2VpNbyClSE4GZHVO8 ed3toFUrppB8a70q929m/lhKRYTkVlXB3XlTHiA/y0XHPIDk2iUVXrto1cVk6V0356Fh aIrsuyz+wFOnLLdCsv0Lu1SqKh1ZdI6tqz+VYz86RXrZetfUAA6LxYUmeAHKEwlsnsHr RnlXSfRM3VFACwgN5QnJxtLjirVjt+1BE3LVuwoY0OrbYtFimPEpyRTpWjPjplR54PYE GDbg== X-Gm-Message-State: AO0yUKUddXTMjNp4p6afXf1rgsHIhKi/K85YAIvy1sL+JEn/4YQmGe1C a/QDkDnwiU9ENsskHWQ8pQ7YGgRpPWE= X-Google-Smtp-Source: AK7set/gGW4PyYu6LY3aIJ3Hp9Re7e7hvAsjhgO+H1xmMX+PpYMlrAWORpE4aOBw42Vsz+6YXngpSg== X-Received: by 2002:a17:906:d9c2:b0:8b1:7b22:90b6 with SMTP id qk2-20020a170906d9c200b008b17b2290b6mr23302762ejb.37.1678437308487; Fri, 10 Mar 2023 00:35:08 -0800 (PST) Received: from localhost.localdomain (ip5f5abbd3.dynamic.kabel-deutschland.de. [95.90.187.211]) by smtp.gmail.com with ESMTPSA id h10-20020a17090619ca00b008ce5b426d77sm697888ejd.13.2023.03.10.00.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:35:08 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 3/5] staging: rtl8723bs: isAllSpaceOrTab() is not used Date: Fri, 10 Mar 2023 09:34:47 +0100 Message-Id: <20230310083449.23775-4-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310083449.23775-1-straube.linux@gmail.com> References: <20230310083449.23775-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function isAllSpaceOrTab() is not used anywhere, remove it. Signed-off-by: Michael Straube Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_com.c | 15 --------------- drivers/staging/rtl8723bs/include/hal_com.h | 2 -- 2 files changed, 17 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index ff0e41bf72b0..da68557c5b20 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -877,21 +877,6 @@ bool GetU1ByteIntegerFromStringInDecimal(char *Str, u8= *pInt) return true; } =20 -bool isAllSpaceOrTab(u8 *data, u8 size) -{ - u8 cnt =3D 0, NumOfSpaceAndTab =3D 0; - - while (size > cnt) { - if (data[cnt] =3D=3D ' ' || data[cnt] =3D=3D '\t' || data[cnt] =3D=3D '\= 0') - ++NumOfSpaceAndTab; - - ++cnt; - } - - return size =3D=3D NumOfSpaceAndTab; -} - - void rtw_hal_check_rxfifo_full(struct adapter *adapter) { struct dvobj_priv *psdpriv =3D adapter->dvobj; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 31fdb5c45de3..839d93d8a1df 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -149,8 +149,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num); =20 bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); =20 -bool isAllSpaceOrTab(u8 *data, u8 size); - void linked_info_dump(struct adapter *padapter, u8 benable); #ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA void rtw_get_raw_rssi_info(void *sel, struct adapter *padapter); --=20 2.39.2 From nobody Sat Apr 11 20:29:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D663C64EC4 for ; Fri, 10 Mar 2023 08:35:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231253AbjCJIfh (ORCPT ); Fri, 10 Mar 2023 03:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230331AbjCJIfN (ORCPT ); Fri, 10 Mar 2023 03:35:13 -0500 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A9F662D88 for ; Fri, 10 Mar 2023 00:35:10 -0800 (PST) Received: by mail-ed1-x52f.google.com with SMTP id ec29so17358921edb.6 for ; Fri, 10 Mar 2023 00:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678437309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oFs/e/K/gilrBIUS/3vF7+owOyPjJYDXNevbCxgiE/4=; b=RBkobFKJ41nf/fAPlQny3VRJNwdx8fMPH4lp5Z454gp+GwXUmlPcJuYgMoYmBq2a5N U37LQ2hsJ8LRI/fJFR/ctcpJIIeIJg6LzQTB7lMCzM/wUDtN1E/6TmFG+4FlPJ16w+Ir Z+KTbWNcggIOfMBWwUKuNgMC6ZInlEyST4ZsCMeaU68ZTSlVg97/Wzz/jJf+tkDknIBb +wVAWiEQUyP+spNrrcXCmczq06tzSyhWG0wKAnNtmGFZno/hgtDP4DYnTAvdtCyZoKzc qrEZRS/CxTmg0EAre8rcOxwkojquYa1OQvyxyy2skXFPoS1lZGeubw2/kYqyBlpOy6tA 8zlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oFs/e/K/gilrBIUS/3vF7+owOyPjJYDXNevbCxgiE/4=; b=7x9vZEJJ9sRD6NSaMJegSgjvnjTMupwQ6cZvV7+HwQFCIKnDGp0A/2NDRPUuDSocO9 CjQhfrZLSK29PiDUD/yqLbruGNWotJ4volM2zrUKu/cIU7mXXOixi/ckfiXCtsiirPJP brgM9/lek0HD4wQps6fDI7vFURVYNm2kTumTELpzgAVJklaevhLC5hA+951T+wnCs2Er 9yD8bRwW/YggQ1ByhEFrdEbWdN/4l7jHxSOY17oGUN+v/at005+/eqDEovW9YVMp3J9F Jz+ZFBHFL9Isxr1O4CHAw+xx/MY3rGkWLmu6Ge6wbKVtZEBe1sx4p9/tTBRsLZE685fq LcUQ== X-Gm-Message-State: AO0yUKXgLQqzb9l3UCTOfBBdrZp/dC8Zmdk9+HTxjHp1HvPFC9AzYYu6 BWCB6rZCRuJIAwHZLL5f1cw= X-Google-Smtp-Source: AK7set+1UXSQl+SRqmOeFWItIcmJaep95cXb1ps44FVISlcj/OWnPtRPQ4M8UE5ZmeungxVUnuDKmQ== X-Received: by 2002:a17:906:fcb2:b0:8aa:c105:f0bf with SMTP id qw18-20020a170906fcb200b008aac105f0bfmr28935468ejb.17.1678437308902; Fri, 10 Mar 2023 00:35:08 -0800 (PST) Received: from localhost.localdomain (ip5f5abbd3.dynamic.kabel-deutschland.de. [95.90.187.211]) by smtp.gmail.com with ESMTPSA id h10-20020a17090619ca00b008ce5b426d77sm697888ejd.13.2023.03.10.00.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:35:08 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 4/5] staging: rtl8723bs: linked_info_dump() is not used Date: Fri, 10 Mar 2023 09:34:48 +0100 Message-Id: <20230310083449.23775-5-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310083449.23775-1-straube.linux@gmail.com> References: <20230310083449.23775-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function linked_info_dump() is not used anywhere, remove it. Signed-off-by: Michael Straube Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_com.c | 21 --------------------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 2 files changed, 22 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index da68557c5b20..792636fe3270 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -897,27 +897,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter) } } =20 -void linked_info_dump(struct adapter *padapter, u8 benable) -{ - struct pwrctrl_priv *pwrctrlpriv =3D adapter_to_pwrctl(padapter); - - if (padapter->bLinkInfoDump =3D=3D benable) - return; - - if (benable) { - pwrctrlpriv->org_power_mgnt =3D pwrctrlpriv->power_mgnt;/* keep org valu= e */ - rtw_pm_set_lps(padapter, PS_MODE_ACTIVE); - - pwrctrlpriv->ips_org_mode =3D pwrctrlpriv->ips_mode;/* keep org value */ - rtw_pm_set_ips(padapter, IPS_NONE); - } else { - rtw_pm_set_ips(padapter, pwrctrlpriv->ips_org_mode); - - rtw_pm_set_lps(padapter, pwrctrlpriv->ips_org_mode); - } - padapter->bLinkInfoDump =3D benable; -} - #ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA void rtw_get_raw_rssi_info(void *sel, struct adapter *padapter) { diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index 839d93d8a1df..c1aa7f0a35f9 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -149,7 +149,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num); =20 bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); =20 -void linked_info_dump(struct adapter *padapter, u8 benable); #ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA void rtw_get_raw_rssi_info(void *sel, struct adapter *padapter); void rtw_store_phy_info(struct adapter *padapter, union recv_frame *prfram= e); --=20 2.39.2 From nobody Sat Apr 11 20:29:12 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C4CC6FD1C for ; Fri, 10 Mar 2023 08:35:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231261AbjCJIfl (ORCPT ); Fri, 10 Mar 2023 03:35:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230050AbjCJIfN (ORCPT ); Fri, 10 Mar 2023 03:35:13 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF8A962DB3 for ; Fri, 10 Mar 2023 00:35:10 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id i34so17339096eda.7 for ; Fri, 10 Mar 2023 00:35:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678437309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=msAKBo8aTzc9Ggd6g1HwoQudAOedzcnckHsa9qcUuhU=; b=PzmwXRfMGrJIqx4xxVlb9XULjKpymRYv/u7KKo5I3aB4ihccXSnVkurxp8VjDYqVnC JfKZgG+LjfQY86kxUQyadFXLr3qUrkX9/DwITbpftNDZyfrGt5UKQ4cSP5CVdAvP8/8U cyRB2N8XU6M3CBY/HLOxaeSA/bSDQ1ix+BHV1SXvvSGAs0K0X6/3cP8HTwwnv6dqr28n fcygIkgSKCU9Xthq6eON9P3rgwVWtddSpzJ7/gVd7RMPESnjaEUEJB7zbJFwPff7MuzC G9ky1RkvmKhgyrJM63ww/3nMqJJ2j5jIyKe9+UNCjqg/oGeKteOrSFWvD0l1YE5czzDd t1pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678437309; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=msAKBo8aTzc9Ggd6g1HwoQudAOedzcnckHsa9qcUuhU=; b=y21iEt8rLSkBAKSvo19YMnHDTg6CDIuy6HpLyxpAEY0z+alwo6+ZiEhjRYMb3KCE8k ddbDpYS2/Lsv10NpWHkGbMgtHivbPOxv+/IqgyUiCZ80Cu+/vILFWXLywat/Y/Eu8db/ Rp0TzzBDZ8TmcQ5BRDzVU5wbMNmK0PZIoFuoAIBXq+YjL2tmCeOIz20OehegvSOblxLf XFfCghNjpBtQ88hZDRtQMZT7A5Tf/qf8Rm/0KLIkLDzeZG5ScqP8z5GlT28SldhMUu9u TgYH4bTWCkMOxxZeJwwF3ePySjAfuH6x4HuX3KM+81ySFW3wUIQZK9594ihRmsHjHcf7 zw7Q== X-Gm-Message-State: AO0yUKVkZCQ0xSgBz+WVPnQT13f9Ah3ISSlPGDET1M/Pji8b5ZgHXEKk cFotNkGr9ISU6dbkhV9BBivW1L9O518= X-Google-Smtp-Source: AK7set8PRabUyEPOVX0EH2+KGtKBA2MWD26erh7YDXt7xGRcF62/POeOCoHiLP/ZLnf4MU+I4ApfcQ== X-Received: by 2002:a17:907:8746:b0:8b1:7fe9:162e with SMTP id qo6-20020a170907874600b008b17fe9162emr27434749ejc.47.1678437309325; Fri, 10 Mar 2023 00:35:09 -0800 (PST) Received: from localhost.localdomain (ip5f5abbd3.dynamic.kabel-deutschland.de. [95.90.187.211]) by smtp.gmail.com with ESMTPSA id h10-20020a17090619ca00b008ce5b426d77sm697888ejd.13.2023.03.10.00.35.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 00:35:09 -0800 (PST) From: Michael Straube To: gregkh@linuxfoundation.org Cc: hdegoede@redhat.com, Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube Subject: [PATCH 5/5] staging: rtl8723bs: rtw_get_raw_rssi_info() is not used Date: Fri, 10 Mar 2023 09:34:49 +0100 Message-Id: <20230310083449.23775-6-straube.linux@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230310083449.23775-1-straube.linux@gmail.com> References: <20230310083449.23775-1-straube.linux@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The function rtw_get_raw_rssi_info() is not used anywhere, remove it. Signed-off-by: Michael Straube Reviewed-by: Hans de Goede --- drivers/staging/rtl8723bs/hal/hal_com.c | 32 --------------------- drivers/staging/rtl8723bs/include/hal_com.h | 1 - 2 files changed, 33 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8= 723bs/hal/hal_com.c index 792636fe3270..852232102433 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -898,38 +898,6 @@ void rtw_hal_check_rxfifo_full(struct adapter *adapter) } =20 #ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA -void rtw_get_raw_rssi_info(void *sel, struct adapter *padapter) -{ - u8 isCCKrate, rf_path; - struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); - struct rx_raw_rssi *psample_pkt_rssi =3D &padapter->recvpriv.raw_rssi_inf= o; - - netdev_dbg(padapter->pnetdev, - "RxRate =3D %s, PWDBALL =3D %d(%%), rx_pwr_all =3D %d(dBm)\n", - HDATA_RATE(psample_pkt_rssi->data_rate), - psample_pkt_rssi->pwdball, psample_pkt_rssi->pwr_all); - - isCCKrate =3D psample_pkt_rssi->data_rate <=3D DESC_RATE11M; - - if (isCCKrate) - psample_pkt_rssi->mimo_signal_strength[0] =3D psample_pkt_rssi->pwdball; - - for (rf_path =3D 0; rf_path < pHalData->NumTotalRFPath; rf_path++) { - netdev_dbg(padapter->pnetdev, - "RF_PATH_%d =3D>signal_strength:%d(%%), signal_quality:%d(%%)\n", - rf_path, - psample_pkt_rssi->mimo_signal_strength[rf_path], - psample_pkt_rssi->mimo_signal_quality[rf_path]); - - if (!isCCKrate) { - netdev_dbg(padapter->pnetdev, - "\trx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n", - psample_pkt_rssi->ofdm_pwr[rf_path], - psample_pkt_rssi->ofdm_snr[rf_path]); - } - } -} - void rtw_dump_raw_rssi_info(struct adapter *padapter) { u8 isCCKrate, rf_path; diff --git a/drivers/staging/rtl8723bs/include/hal_com.h b/drivers/staging/= rtl8723bs/include/hal_com.h index c1aa7f0a35f9..17d5cfb66a36 100644 --- a/drivers/staging/rtl8723bs/include/hal_com.h +++ b/drivers/staging/rtl8723bs/include/hal_com.h @@ -150,7 +150,6 @@ bool eqNByte(u8 *str1, u8 *str2, u32 num); bool GetU1ByteIntegerFromStringInDecimal(char *str, u8 *in); =20 #ifdef DBG_RX_SIGNAL_DISPLAY_RAW_DATA -void rtw_get_raw_rssi_info(void *sel, struct adapter *padapter); void rtw_store_phy_info(struct adapter *padapter, union recv_frame *prfram= e); void rtw_dump_raw_rssi_info(struct adapter *padapter); #endif --=20 2.39.2