From nobody Wed Sep 10 07:42:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B554DC6FD1C for ; Thu, 9 Mar 2023 10:12:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230208AbjCIKM3 (ORCPT ); Thu, 9 Mar 2023 05:12:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbjCIKMX (ORCPT ); Thu, 9 Mar 2023 05:12:23 -0500 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2047.outbound.protection.outlook.com [40.107.243.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14D26E4DBE; Thu, 9 Mar 2023 02:12:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDqwFY7L1ovbQzee9cE5SoMddGDFJdJDMkF5sdJqWwFICxUGy8w5rYrThtWL213I6OosnPLxdNYx5TNvgNOdEybuU3oLuIT1icV+TP08OOj+m0ac0mk/7PURp7HzXuwzNB2BHgMLD2VZ7z1lh15zdgTeRQ0lcDe30y/1uOZqxPQJh93tqnzskhV9ZeYp8q439r5eDe7/FxRItES/CG5vzGRZfsTDRjGq69+1sfmbJEUgVFLAIi0uaLweZpF1tIJdi6xD3e154xVioSvUp1zkRyzXCnbSMkmvf5jKW+VcB5IPicCPoz4GuSGYncCnY1naURIF569FzParWfZkV5bpUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NXugKCKESUudTWx1tbmZHaLHdUPVJN7tl1Sbgv0cXo0=; b=MohGFtqS/NCPYllQN6jtelJmSpFvhX8R0Bz/z8i+0d+Xjls1wmGA80wjDee9KBs9UGBFjBlRXyDwhShGugxs+JsgO3VUVOsLHk5dtk23KPNGIynJ9PpbSGjnakF4TBFhjxc7d7aCZJt92qVG5korgIlTgl1Jda95mI2Brsd7dfpMtTSQy65wfV/2nUxE0Ph8rRZh9PuMAEKAk8ltpIcoxgZAXO94Z3xCuu0+KhS8VSGaRA/CEf2dZHcTaFJvLozCnL7T/b+jySDHugA1ScjhDDgsYbNDR7DgjO9gHWk9oTMWc2wuHPzO9FkYir4ac0kfkeryh6vbDU9WDcxQq/y0/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NXugKCKESUudTWx1tbmZHaLHdUPVJN7tl1Sbgv0cXo0=; b=g6kPbJttiWqpV+Hb1OuDLk2yeeATQ5mu2QSTClNArHKDtHCPJaJQkq9L/5WXmvZcgvOgUsKNNfxlrBTW/2xFZex4fbeBGCLvLRhd7M6ZkzN9rRzWuOIRyV/286qCRchVWjwNWU/i3pGtzYnc1yzx+YpdT9F5k7kwPKR4nFrfGzw= Received: from DS7PR05CA0063.namprd05.prod.outlook.com (2603:10b6:8:57::19) by BN9PR12MB5100.namprd12.prod.outlook.com (2603:10b6:408:119::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Thu, 9 Mar 2023 10:12:19 +0000 Received: from DM6NAM11FT109.eop-nam11.prod.protection.outlook.com (2603:10b6:8:57:cafe::c6) by DS7PR05CA0063.outlook.office365.com (2603:10b6:8:57::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19 via Frontend Transport; Thu, 9 Mar 2023 10:12:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT109.mail.protection.outlook.com (10.13.173.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.18 via Frontend Transport; Thu, 9 Mar 2023 10:12:19 +0000 Received: from BLR-5CG113396H.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Mar 2023 04:12:13 -0600 From: Ravi Bangoria To: CC: , , , , , , , , , , , , , Subject: [PATCH v2 1/3] perf/ibs: Introduce ibs_core_pmu_event() Date: Thu, 9 Mar 2023 15:41:09 +0530 Message-ID: <20230309101111.444-2-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230309101111.444-1-ravi.bangoria@amd.com> References: <20230309101111.444-1-ravi.bangoria@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT109:EE_|BN9PR12MB5100:EE_ X-MS-Office365-Filtering-Correlation-Id: e5b5d358-ab1e-40dc-9394-08db2086c44a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qvX16gSzZ/b6zQESUryK7dMv7MYvKb7TTdiYsF+Se5UoSpi1wcHqjXUMuMayBnWan0HnnlSQ/GoxgILYrwX5TrLgsKNfiadLNROX1ufNDd+9KZ8zdeq8n0UAKAo+nv0W9ill/DE0JQsdA9ICkPDL2nRLPTV+X964+7iAM6OSS0p9BrdLdMC7TQzzd+Ps83xnb4UrRTDPsszMMdj+WP39G7eMAhYj1w7BdGmHxc04Tc8GtsifSysmjDa/z9/iwM5vNWZil1igKUR0TTxKkL0iS0hxY8cx6C1I9x3cxp3dq0g9JlivIWEwxrKmWdGye1tv7LYGOW+FUR1/pOCGy/RpW01e2eyWgEMo8ynICTh7Dd6v3cvL0WiXuuyPGLWRaOC64rfsw41L1O6A5Ynzmg93FF2h6Y5H0V/JruoFuq78bsWIG+QP9rM7evTbO/jFSZ1aLEc3ZiuZ1TcI2uvC2rq7lzCk2CfeixDVRY1m9Qm4/l/B5n/YM163qMRUQ8R0IDA5LyVX69U0JIpYRkxtlxqnP4wgAC/SKAhJVAHZDErjcCMqj1OX/QEiPsoCLLxoWn7pIlusmcn36sxijk5pjCorEYDOd03r3NgDBJu8Zs4G2htkAoV7qwO8zAOxGI5Y8Sh7MghUzLLJ6k/vENHkCdzq4RTLznbesNDV5LGtsgbH5WIoO/Ai6H3H+3P077dUeAQMOROzf2g3sXqUMthUFxgPitZ6iM4ypJvFmWxci53eURE= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(376002)(346002)(39860400002)(136003)(451199018)(46966006)(40470700004)(36840700001)(8936002)(36756003)(26005)(7416002)(5660300002)(1076003)(8676002)(82740400003)(36860700001)(6666004)(81166007)(47076005)(82310400005)(83380400001)(426003)(336012)(16526019)(186003)(2616005)(40480700001)(54906003)(86362001)(316002)(41300700001)(70206006)(4326008)(40460700003)(6916009)(70586007)(356005)(7696005)(478600001)(2906002)(44832011)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 10:12:19.3204 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5b5d358-ab1e-40dc-9394-08db2086c44a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT109.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5100 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Split core pmu event comparing code from perf_ibs_precise_event() into a separate function ibs_core_pmu_event(). Signed-off-by: Ravi Bangoria --- arch/x86/events/amd/ibs.c | 52 +++++++++++++++++-------------- arch/x86/include/asm/perf_event.h | 2 ++ 2 files changed, 31 insertions(+), 23 deletions(-) diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c index 64582954b5f6..67eb5b7564e8 100644 --- a/arch/x86/events/amd/ibs.c +++ b/arch/x86/events/amd/ibs.c @@ -218,29 +218,7 @@ static int perf_ibs_precise_event(struct perf_event *e= vent, u64 *config) return -EOPNOTSUPP; } =20 - switch (event->attr.type) { - case PERF_TYPE_HARDWARE: - switch (event->attr.config) { - case PERF_COUNT_HW_CPU_CYCLES: - *config =3D 0; - return 0; - } - break; - case PERF_TYPE_RAW: - switch (event->attr.config) { - case 0x0076: - *config =3D 0; - return 0; - case 0x00C1: - *config =3D IBS_OP_CNT_CTL; - return 0; - } - break; - default: - return -ENOENT; - } - - return -EOPNOTSUPP; + return ibs_core_pmu_event(event, config); } =20 static int perf_ibs_init(struct perf_event *event) @@ -1296,6 +1274,34 @@ u32 get_ibs_caps(void) =20 EXPORT_SYMBOL(get_ibs_caps); =20 +/* Convert core pmu event into IBS event */ +int ibs_core_pmu_event(struct perf_event *event, u64 *config) +{ + switch (event->attr.type) { + case PERF_TYPE_HARDWARE: + switch (event->attr.config) { + case PERF_COUNT_HW_CPU_CYCLES: + *config =3D 0; + return 0; + } + break; + case PERF_TYPE_RAW: + switch (event->attr.config) { + case 0x0076: + *config =3D 0; + return 0; + case 0x00C1: + *config =3D IBS_OP_CNT_CTL; + return 0; + } + break; + default: + return -ENOENT; + } + + return -EOPNOTSUPP; +} + static inline int get_eilvt(int offset) { return !setup_APIC_eilvt(offset, 0, APIC_EILVT_MSG_NMI, 1); diff --git a/arch/x86/include/asm/perf_event.h b/arch/x86/include/asm/perf_= event.h index 8fc15ed5e60b..1ad9d504ae71 100644 --- a/arch/x86/include/asm/perf_event.h +++ b/arch/x86/include/asm/perf_event.h @@ -475,8 +475,10 @@ struct pebs_xmm { =20 #ifdef CONFIG_X86_LOCAL_APIC extern u32 get_ibs_caps(void); +extern int ibs_core_pmu_event(struct perf_event *event, u64 *config); #else static inline u32 get_ibs_caps(void) { return 0; } +static inline int ibs_core_pmu_event(struct perf_event *event, u64 *config= ) { return -ENOENT; } #endif =20 #ifdef CONFIG_PERF_EVENTS --=20 2.39.2 From nobody Wed Sep 10 07:42:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EECDC61DA4 for ; Thu, 9 Mar 2023 10:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230453AbjCIKMo (ORCPT ); Thu, 9 Mar 2023 05:12:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230062AbjCIKMi (ORCPT ); Thu, 9 Mar 2023 05:12:38 -0500 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2080.outbound.protection.outlook.com [40.107.244.80]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B678FE63CE; Thu, 9 Mar 2023 02:12:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hecRw/DP21YIvdI9nhFD0pVSIGfM21k6Lf3PrXYvpaXk0XWWmaM+ZumUYx7Iuym24/+bLoQN9rme0NdAHrrXjhv0aew5GDUKtYddLRRMEv8QPHxLrEk4g6Ai5Jc2RZG1mDrWUkn60xcnr+8e57OBTt1nENVR38EY97pFxvP00jfLV9TmpV/q2WTdoKnjtGAv5J62+wtQiVOvCyquYtJ6M0UYHrvsF0SfaUBrYdZh73dCexBQeGmM9BSkfJB9MjwbqNWt4rL/4gw8cubCW0g2C7OcpAnJq9ayoQB1nm9E36Ipv4FNbwc8qIkK7Dz21IDOXq1cqj7YeWHjx+uKWVjlgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mXFNOHaSqp2WhZvg3ozwniSBg72BBUMaMUTA+Aikp5Y=; b=NmBIGWRZ+2Sz6yu6Mv+fHILggoiFswVGB7MqDWWkU+skargp0E2KIaLyqGWDKEJPttNsDENvFNvUO/tnsSXyWUUxwAYySwybfjqZhr4XUYHnrSCNz78ErxCftZLjAyJhhJ7cbjIcRDV7bVKzShROAq3wG5s40DW4NpQaPTWlpVtj+ojt6g2eKWwuksR2WLqdDAGYl+g1GMykc6444BrzNFZE2xcfvkLYiMpYiyOg5l0v62qmfLhiva6XTSY6kRJLhV9vr+29oz0Y7iwM+XMUXOdjWULnQkFeUHUc8I7pVzTW0TBP/E7nF0VUfqQFFQX/UpE28gYLo3ti5SukHdtDSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mXFNOHaSqp2WhZvg3ozwniSBg72BBUMaMUTA+Aikp5Y=; b=ZN4q0ayE8uUBoxpsH57+VAcXcChbY9zomjsTcEnPVEPlsubTbrAw7xHOz4dkzLebrmNFweW/TFe5/y2v4N59CzRx+OjT3ml6NfyP0xxe9K/6M8xQ7RG4fsJ6oRzM8zL4//Q99zCIQzlunUFe9z25O2iGTQG2wgo8DXlnoiCEoWM= Received: from DM6PR06CA0101.namprd06.prod.outlook.com (2603:10b6:5:336::34) by MN0PR12MB6200.namprd12.prod.outlook.com (2603:10b6:208:3c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29; Thu, 9 Mar 2023 10:12:26 +0000 Received: from DM6NAM11FT029.eop-nam11.prod.protection.outlook.com (2603:10b6:5:336:cafe::fe) by DM6PR06CA0101.outlook.office365.com (2603:10b6:5:336::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.29 via Frontend Transport; Thu, 9 Mar 2023 10:12:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT029.mail.protection.outlook.com (10.13.173.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.18 via Frontend Transport; Thu, 9 Mar 2023 10:12:25 +0000 Received: from BLR-5CG113396H.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Mar 2023 04:12:19 -0600 From: Ravi Bangoria To: CC: , , , , , , , , , , , , , Subject: [PATCH v2 2/3] perf/ibs: Fix interface via core pmu events Date: Thu, 9 Mar 2023 15:41:10 +0530 Message-ID: <20230309101111.444-3-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230309101111.444-1-ravi.bangoria@amd.com> References: <20230309101111.444-1-ravi.bangoria@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT029:EE_|MN0PR12MB6200:EE_ X-MS-Office365-Filtering-Correlation-Id: 021cb43f-fd76-43cf-4f73-08db2086c81d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4r6qcVczdc8RfER9wfmBd0/UNaNQg7FXBPSpT8WiVr4gtzkLfqME0FLXE4dsNWi9EOMaZodotrHsWC82Ff/fbVTA5iJMEObHAS//lsxTIZcc7bJq/PieI+GByHXTZvNQFkk7BzNGXT6dN9tmpmd5wFjfNef/vHPAyTqz5CHceCeAw5mUOkA1qmfhBPQZZ03K4U0wDVAO2W8Xic+Q+XKaSRBOK78HSuu3OPJE7B7fwhT18kLXR4BJIz1zIyj1jTWzkzDe8b8mUz9ba/E+BvIS7+/m80+Wi90S9cNzFEVV/Kst5C53sjkbBfU0a+wrIDPEI0r5MQLcYm60i9I+QR4iYOGRgzbnNw86hguNMC4gn1J4XKH9yYdOz61XzOhoF5VB6poBEXfEw0ryEqFTFtwmuJvS1xhB7BDd8k4nCf8xfEK0ubaZSy4/YU9PGxLMRDjS65xMJLXZsPg4egGnT2ShKka+tVbHKOua2//s/241QrBzA9uE2rISZxz/VvwwWQC+JZvkNjsd81Hav8JrSMhBJpmQ4daq6zwcM7hkAiyNH6CJSL/3U6yfUvQvxl1b4t4dtjfxGbQf6Fu/VeSi0Ikw4LsVgw9pJE2IwsgrlvsaHYEprsBTdVbNiOKfsgogBm2npT2i7JsAe7tXmU4PWV8F3KqGJTb8nbDGOgLSoHyobqLyTl3svXGbPSWKBDq740xcrx+STNnkOiMPXQ8Cu7ensYBhemK3HB128io2NoK/5SQ= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(396003)(346002)(39860400002)(136003)(376002)(451199018)(40470700004)(46966006)(36840700001)(8676002)(4326008)(70586007)(70206006)(6916009)(83380400001)(2616005)(16526019)(186003)(82310400005)(47076005)(40480700001)(336012)(81166007)(356005)(36756003)(36860700001)(82740400003)(54906003)(478600001)(40460700003)(6666004)(7696005)(86362001)(316002)(426003)(1076003)(26005)(2906002)(8936002)(5660300002)(7416002)(44832011)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 10:12:25.7346 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 021cb43f-fd76-43cf-4f73-08db2086c81d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT029.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6200 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Although, IBS pmu can be invoked via it's own interface, indirect IBS invocation via core pmu event is also supported with fixed set of events: cpu-cycles:p, r076:p (same as cpu-cycles:p) and r0C1:p (micro-ops) for user convenience. This indirect IBS invocation is broken since commit 66d258c5b048 ("perf/core: Optimize perf_init_event()"), which added RAW pmu under pmu_idr list and thus if event_init() fails with RAW pmu, it started returning error instead of trying other pmus. Fix it by trying to open event on all pmus if event_init() on user requested pmu returns -ESRCH. Without patch: $ sudo ./perf record -C 0 -e r076:p -- sleep 1 Error: The r076:p event is not supported. With patch: $ sudo ./perf record -C 0 -e r076:p -- sleep 1 [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.341 MB perf.data (37 samples) ] Note that there is no notion of forward pmu mapping. i.e. kernel doesn't know which specific pmu(or a set of pmus) the event should be forwarded to. As of now, only AMD core pmu forwards a set of events to IBS pmu when precise_ip attribute is set and thus trying with all pmus works. But if more pmus starts returning -ESRCH, some sort of forward pmu mapping needs to be introduced through which the event can directly get forwarded to only mapped pmus. Otherwise, trying all pmus can inadvertently open event on wrong pmu. Fixes: 66d258c5b048 ("perf/core: Optimize perf_init_event()") Reported-by: Stephane Eranian Signed-off-by: Ravi Bangoria --- arch/x86/events/amd/core.c | 11 ++++++++--- kernel/events/core.c | 10 +++++++++- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c index 8c45b198b62f..81d67b899371 100644 --- a/arch/x86/events/amd/core.c +++ b/arch/x86/events/amd/core.c @@ -371,10 +371,15 @@ static inline int amd_has_nb(struct cpu_hw_events *cp= uc) static int amd_pmu_hw_config(struct perf_event *event) { int ret; + u64 dummy; =20 - /* pass precise event sampling to ibs: */ - if (event->attr.precise_ip && get_ibs_caps()) - return -ENOENT; + if (event->attr.precise_ip) { + /* pass precise event sampling to ibs by returning -ESRCH */ + if (get_ibs_caps() && !ibs_core_pmu_event(event, &dummy)) + return -ESRCH; + else + return -ENOENT; + } =20 if (has_branch_stack(event) && !x86_pmu.lbr_nr) return -EOPNOTSUPP; diff --git a/kernel/events/core.c b/kernel/events/core.c index f79fd8b87f75..e990c71ba34a 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -11639,18 +11639,26 @@ static struct pmu *perf_init_event(struct perf_ev= ent *event) goto again; } =20 + /* + * pmu->event_init() should return -ESRCH only when it + * wants to forward the event to other pmu. + */ + if (ret =3D=3D -ESRCH) + goto try_all; + if (ret) pmu =3D ERR_PTR(ret); =20 goto unlock; } =20 +try_all: list_for_each_entry_rcu(pmu, &pmus, entry, lockdep_is_held(&pmus_srcu)) { ret =3D perf_try_init_event(pmu, event); if (!ret) goto unlock; =20 - if (ret !=3D -ENOENT) { + if (ret !=3D -ENOENT && ret !=3D -ESRCH) { pmu =3D ERR_PTR(ret); goto unlock; } --=20 2.39.2 From nobody Wed Sep 10 07:42:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76980C64EC4 for ; Thu, 9 Mar 2023 10:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230032AbjCIKNA (ORCPT ); Thu, 9 Mar 2023 05:13:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230432AbjCIKMn (ORCPT ); Thu, 9 Mar 2023 05:12:43 -0500 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2060.outbound.protection.outlook.com [40.107.92.60]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A326E6809; Thu, 9 Mar 2023 02:12:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KMXVcQLKRlczZ0AN0aAw9sFaI6jFu4mlIzW7fRXXos7oBui3THhI7VVpiQt3DNyBELvcKe/vkDWpXxyieTAT7vHqFyDtvFvNJVrXvw85y+K6KbGB6BxDRSvtK6GcE26oWuL9yqSZtQajgVXArzqWohbhgCh/th8RGiFJyqhzWBlG749FofLSsKJo5IGD5xqdAOKsho8kNFho8xZIo7n+6s4cho4yZ5tFZWqwyOyo1Q5B/CPTsnJ/iQFhglwudoWdjlAvA9HoDgFAjmRwyLX/WKogRRe5KxjeFTLE1rQe8qR+PodtT5Jvg0mHA0ngOjaKtZU4QS3trdyfON/bX2Jbtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7YFGamy51KwjAnD1EwQNXRknuXM19EugsdsE//yNK7E=; b=S5cLOOJXZm1rt/V4YGaFnWOinWMfviNYajdlE7VmV90OzFY8L8VvFQz2HGwbbgrskLrMoWSHMAEBPMr5+tyI19e5MebmN6oSJYj2+liQyX7472atwU6ga3LAcoexA8VYS2cjs6bzPF/FZEbQMN4Brd8sRmFcrFzDzAnd53pBJkB1+7Guk6xCsHAJ68oIF3hM2WFQHOuZn5ZbCXHWSFg0NfGbuWf+ov4LI/OxUyZB4UFizarvOCr2gBLR6yRWr874yrrdAaTuBXIWw6JN+cnZ2OcqKN/TXouMDyKKOkfX7473DzR/B2Ndz0s71FfUhqE7gWYjS75hiNP/usxAXGfdAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=infradead.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7YFGamy51KwjAnD1EwQNXRknuXM19EugsdsE//yNK7E=; b=GkluZA77yQl3uU0pzATrnlScvBpofDDchx9ux06oOadAI8IcM++mSBQLiVe31lOI6Eal3FhbJ6DztFE9C3Tey1h6asvWq1K7Xe+bg1Em+WXJgNegDEFmZ97OaPsjy8TD3I2sV5tv6TRGm6M/L8VOXOxMjWuqzR55xICr+qbSZBM= Received: from DS7PR03CA0170.namprd03.prod.outlook.com (2603:10b6:5:3b2::25) by SJ1PR12MB6027.namprd12.prod.outlook.com (2603:10b6:a03:48a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.17; Thu, 9 Mar 2023 10:12:32 +0000 Received: from DM6NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::13) by DS7PR03CA0170.outlook.office365.com (2603:10b6:5:3b2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19 via Frontend Transport; Thu, 9 Mar 2023 10:12:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT034.mail.protection.outlook.com (10.13.173.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6178.19 via Frontend Transport; Thu, 9 Mar 2023 10:12:32 +0000 Received: from BLR-5CG113396H.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 9 Mar 2023 04:12:25 -0600 From: Ravi Bangoria To: CC: , , , , , , , , , , , , , Subject: [PATCH v2 3/3] perf test: Add selftest to test IBS invocation via core pmu events Date: Thu, 9 Mar 2023 15:41:11 +0530 Message-ID: <20230309101111.444-4-ravi.bangoria@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230309101111.444-1-ravi.bangoria@amd.com> References: <20230309101111.444-1-ravi.bangoria@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT034:EE_|SJ1PR12MB6027:EE_ X-MS-Office365-Filtering-Correlation-Id: 9853715b-d2c4-483b-4323-08db2086cbff X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CP6MpImZle+NiLDqfPc56DvreMjx57jK25NYEoB/IgwwU7IrABRdvXlFoU7iu9J2FfgMZVoxgXPVRfxsSm8zDCttWYgQnpW9YEebKL4qJOJ2J8w2kbzzsbqkjuLoS0g01Oalla1P3ZGSpmUZvIeF5WJYx8RN/fFSDstjs5iE8MH5hMcZE20GSXUF4mWzE4XCPj0Fy3zj5thGB+D90uzxu88IYB4skECwzzH7PU7EozwCUOdRu9gxIZPIXyrTBPxj+VqWCVu28C9K8qBTfbBisR0X6CsKKIf0oAVU3FzJMWcOJhYAAt/I3ATVAZqXfeFoTARo37+wzEPHfhQCwWh0Et4ooirdYwd0UXbtk426b+FmOHSmgjBIi9rDIK/b9mOUBNSat5Fxye0qhQWznbTe1qpqQKmpVOh5Fqs8UiOvPZ/KhK1vHaNp+dkAfjvuwuByMs9vCyAkGqvQ14lW+OYOi94uVSYkBfVMn5+PZyp0XmKj5NlKDtfGGixVnpeplcS3rb9p2hm0M2aNjIUshkgiDbYGgy+C8kjtcoypJey9sJ6ska/yb9CvA/BqlP73r3kAdw1EKqoXsn4/p2dhH2inQtFQzeFfOnUgcc/Zc0kGUEU69r/V4opCBITE63nUUJcXq+rgkLq67NMH4txmbBdFDbQFibP0UrL8L5ehR0jevLlGThsqJkZGa3BzxJxQ+WM/95vs3ZGsuR4+mk4qY0g6p6DqioUJv+2j/pJcklpJDh4= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230025)(4636009)(376002)(136003)(396003)(39860400002)(346002)(451199018)(46966006)(40470700004)(36840700001)(36756003)(40460700003)(356005)(54906003)(7696005)(7416002)(5660300002)(316002)(8936002)(70586007)(2906002)(8676002)(70206006)(4326008)(6916009)(6666004)(41300700001)(44832011)(186003)(36860700001)(86362001)(81166007)(478600001)(40480700001)(26005)(82740400003)(2616005)(16526019)(1076003)(83380400001)(82310400005)(336012)(47076005)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2023 10:12:32.2486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9853715b-d2c4-483b-4323-08db2086cbff X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6027 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IBS pmu can be invoked via fixed set of core pmu events. Add a simple event open test for all these events. Without kernel fix: $ sudo ./perf test -vv 76 76: IBS via core pmu : --- start --- test child forked, pid 6553 Using CPUID AuthenticAMD-25-1-1 type: 0x0, config: 0x0, fd: 3 - Pass type: 0x0, config: 0x1, fd: -1 - Pass type: 0x4, config: 0x76, fd: -1 - Fail type: 0x4, config: 0xc1, fd: -1 - Fail type: 0x4, config: 0x12, fd: -1 - Pass test child finished with -1 ---- end ---- IBS via core pmu: FAILED! With kernel fix: $ sudo ./perf test -vv 76 76: IBS via core pmu : --- start --- test child forked, pid 7526 Using CPUID AuthenticAMD-25-1-1 type: 0x0, config: 0x0, fd: 3 - Pass type: 0x0, config: 0x1, fd: -1 - Pass type: 0x4, config: 0x76, fd: 3 - Pass type: 0x4, config: 0xc1, fd: 3 - Pass type: 0x4, config: 0x12, fd: -1 - Pass test child finished with 0 ---- end ---- IBS via core pmu: Ok Signed-off-by: Ravi Bangoria --- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 1 + tools/perf/tests/ibs-via-core-pmu.c | 70 +++++++++++++++++++++++++++++ tools/perf/tests/tests.h | 1 + 4 files changed, 73 insertions(+) create mode 100644 tools/perf/tests/ibs-via-core-pmu.c diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build index fb9ac5dc4079..1a232cf13c33 100644 --- a/tools/perf/tests/Build +++ b/tools/perf/tests/Build @@ -69,6 +69,7 @@ perf-y +=3D dlfilter-test.o perf-y +=3D sigtrap.o perf-y +=3D event_groups.o perf-y +=3D symbols.o +perf-y +=3D ibs-via-core-pmu.o =20 $(OUTPUT)tests/llvm-src-base.c: tests/bpf-script-example.c tests/Build $(call rule_mkdir) diff --git a/tools/perf/tests/builtin-test.c b/tools/perf/tests/builtin-tes= t.c index 35cc3807cc9e..aed887234500 100644 --- a/tools/perf/tests/builtin-test.c +++ b/tools/perf/tests/builtin-test.c @@ -119,6 +119,7 @@ static struct test_suite *generic_tests[] =3D { &suite__sigtrap, &suite__event_groups, &suite__symbols, + &suite__ibs_via_core_pmu, NULL, }; =20 diff --git a/tools/perf/tests/ibs-via-core-pmu.c b/tools/perf/tests/ibs-via= -core-pmu.c new file mode 100644 index 000000000000..6ac539509791 --- /dev/null +++ b/tools/perf/tests/ibs-via-core-pmu.c @@ -0,0 +1,70 @@ +// SPDX-License-Identifier: GPL-2.0 +#include "linux/perf_event.h" +#include "tests.h" +#include "pmu.h" +#include "pmus.h" +#include "../perf-sys.h" +#include "debug.h" + +#define NR_SUB_TESTS 5 + +static struct sub_tests { + int type; + unsigned long config; + bool valid; +} sub_tests[NR_SUB_TESTS] =3D { + { PERF_TYPE_HARDWARE, PERF_COUNT_HW_CPU_CYCLES, true }, + { PERF_TYPE_HARDWARE, PERF_COUNT_HW_INSTRUCTIONS, false }, + { PERF_TYPE_RAW, 0x076, true }, + { PERF_TYPE_RAW, 0x0C1, true }, + { PERF_TYPE_RAW, 0x012, false }, +}; + +static int event_open(int type, unsigned long config) +{ + struct perf_event_attr attr; + + memset(&attr, 0, sizeof(struct perf_event_attr)); + attr.type =3D type; + attr.size =3D sizeof(struct perf_event_attr); + attr.config =3D config; + attr.disabled =3D 1; + attr.precise_ip =3D 1; + attr.sample_type =3D PERF_SAMPLE_IP | PERF_SAMPLE_TID; + attr.sample_period =3D 100000; + + return sys_perf_event_open(&attr, -1, 0, -1, 0); +} + +static int test__ibs_via_core_pmu(struct test_suite *text __maybe_unused, + int subtest __maybe_unused) +{ + struct perf_pmu *ibs_pmu; + int ret =3D TEST_OK; + int fd, i; + + if (list_empty(&pmus)) + perf_pmu__scan(NULL); + + ibs_pmu =3D perf_pmu__find("ibs_op"); + if (!ibs_pmu) + return TEST_SKIP; + + for (i =3D 0; i < NR_SUB_TESTS; i++) { + fd =3D event_open(sub_tests[i].type, sub_tests[i].config); + pr_debug("type: 0x%x, config: 0x%lx, fd: %d - ", sub_tests[i].type, + sub_tests[i].config, fd); + if ((sub_tests[i].valid && fd =3D=3D -1) || + (!sub_tests[i].valid && fd > 0)) { + pr_debug("Fail\n"); + ret =3D TEST_FAIL; + } else { + pr_debug("Pass\n"); + close(fd); + } + } + + return ret; +} + +DEFINE_SUITE("IBS via core pmu", ibs_via_core_pmu); diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h index 9a0f3904e53d..36339fdf9c36 100644 --- a/tools/perf/tests/tests.h +++ b/tools/perf/tests/tests.h @@ -149,6 +149,7 @@ DECLARE_SUITE(dlfilter); DECLARE_SUITE(sigtrap); DECLARE_SUITE(event_groups); DECLARE_SUITE(symbols); +DECLARE_SUITE(ibs_via_core_pmu); =20 /* * PowerPC and S390 do not support creation of instruction breakpoints usi= ng the --=20 2.39.2