From nobody Wed Sep 10 05:18:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E729FC678D5 for ; Wed, 8 Mar 2023 17:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229747AbjCHRfm (ORCPT ); Wed, 8 Mar 2023 12:35:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbjCHRfk (ORCPT ); Wed, 8 Mar 2023 12:35:40 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.215]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 45EB1C083C for ; Wed, 8 Mar 2023 09:35:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=eRJDP 6Vc/O5/BFT6QkUGAFvagsrz1RUcQ8m4GSGcwQk=; b=P5+8O4pcjaMSwWpLWwf5s XIdfhUahbwYqB9yeVw1rQo82QfZS1BFndK4SzOZYbmrKGLF8ZxwtELHqnK27lXBL jONOpczcOW5YU4K1BAwIQVxXKf2lyKQ+l4Crhrl5eAzUxfzg0QIg/UIEcbdY392x D+ZEgMrIAKmaF9pau0sqp0= Received: from leanderwang-LC2.localdomain (unknown [111.206.145.21]) by zwqz-smtp-mta-g0-0 (Coremail) with SMTP id _____wD3SnQqxwhkOjFfCg--.59019S2; Thu, 09 Mar 2023 01:34:35 +0800 (CST) From: Zheng Wang To: dri-devel@lists.freedesktop.org Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, jonas@kwiboo.se, airlied@gmail.com, daniel@ffwll.ch, linux-kernel@vger.kernel.org, hackerzheng666@gmail.com, 1395428693sheep@gmail.com, alex000young@gmail.com, Zheng Wang Subject: [PATCH] drm/bridge: adv7511: fix race condition bug in adv7511_remove due to unfinished work Date: Thu, 9 Mar 2023 01:34:33 +0800 Message-Id: <20230308173433.2788833-1-zyytlz.wz@163.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3SnQqxwhkOjFfCg--.59019S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtr18Xr4rGw4ktrW3Ww1UGFg_yoWDZFbEkF y3Z34xWr15A3Wv9w17AFW2vry2k3WUCrZI93WfKa9xJr13Zr1rW347ZrWDXF18uF4YyFyD JrnrZw4rJa42yjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKPfHUUUUUU== X-Originating-IP: [111.206.145.21] X-CM-SenderInfo: h2113zf2oz6qqrwthudrp/1tbiGg0sU1aEEgVt2wAAsb Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In adv7511_probe, adv7511->hpd_work is bound with adv7511_hpd_work. If we call adv7511_remove with a unfinished work. There may be a=20 race condition where bridge->hpd_mutex was destroyed by=20 drm_bridge_remove and used in adv7511_hpd_work in drm_bridge_hpd_notify. Fix it by canceling the work before cleanup in adv7511_remove. Signed-off-by: Zheng Wang --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm= /bridge/adv7511/adv7511_drv.c index ddceafa7b637..9bf72dd6c1d3 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1349,6 +1349,7 @@ static void adv7511_remove(struct i2c_client *i2c) { struct adv7511 *adv7511 =3D i2c_get_clientdata(i2c); =20 + cancel_work_sync(&adv7511->hpd_work); adv7511_uninit_regulators(adv7511); =20 drm_bridge_remove(&adv7511->bridge); --=20 2.25.1