From nobody Wed Sep 10 05:57:20 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70AFEC678D5 for ; Tue, 7 Mar 2023 22:47:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbjCGWrq (ORCPT ); Tue, 7 Mar 2023 17:47:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229953AbjCGWrI (ORCPT ); Tue, 7 Mar 2023 17:47:08 -0500 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 68CEF93C8; Tue, 7 Mar 2023 14:47:01 -0800 (PST) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id 2240E7A0708; Tue, 7 Mar 2023 23:46:49 +0100 (CET) From: Ondrej Zary To: Damien Le Moal , Sudip Mukherjee Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/32] pata_parport-bpck6: use parport access functions instead of port I/O Date: Tue, 7 Mar 2023 23:46:07 +0100 Message-Id: <20230307224627.28011-13-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230307224627.28011-1-linux@zary.sk> References: <20230307224627.28011-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use parport access functions instead of inb/outb/inw/outw/inl/outl. Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/bpck6.c | 1 - drivers/ata/pata_parport/ppc6lnx.c | 212 +++++++++-------------------- 2 files changed, 68 insertions(+), 145 deletions(-) diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bp= ck6.c index dc0f71cc305e..39ac6e1a0aee 100644 --- a/drivers/ata/pata_parport/bpck6.c +++ b/drivers/ata/pata_parport/bpck6.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include "pata_parport.h" #include "ppc6lnx.c" diff --git a/drivers/ata/pata_parport/ppc6lnx.c b/drivers/ata/pata_parport/= ppc6lnx.c index 09480a7fcaee..89c40d6ab036 100644 --- a/drivers/ata/pata_parport/ppc6lnx.c +++ b/drivers/ata/pata_parport/ppc6lnx.c @@ -17,7 +17,6 @@ =20 =20 #define port_int 16 -#define port_dir 0x20 =20 #define ECR_EPP 0x80 #define ECR_BI 0x20 @@ -106,65 +105,60 @@ static int ppc6_select(struct pi_adapter *pi) { u8 i, j, k; =20 - i =3D inb(pi->port + 1); + pi->saved_r0 =3D parport_read_data(pi->pardev->port); =20 - if (i & 1) - outb(i, pi->port + 1); - - pi->saved_r0 =3D inb(pi->port); - - pi->saved_r2 =3D inb(pi->port + 2) & 0x5F; // readback ctrl + pi->saved_r2 =3D parport_read_control(pi->pardev->port) & 0x5F; // readba= ck ctrl =20 CUR_CTRL =3D pi->saved_r2; =20 CUR_CTRL |=3D PARPORT_CONTROL_SELECT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 if (pi->saved_r0 =3D=3D 'b') - outb('x', pi->port); + parport_write_data(pi->pardev->port, 'x'); =20 - outb('b', pi->port); - outb('p', pi->port); - outb(pi->unit, pi->port); - outb(~pi->unit, pi->port); + parport_write_data(pi->pardev->port, 'b'); + parport_write_data(pi->pardev->port, 'p'); + parport_write_data(pi->pardev->port, pi->unit); + parport_write_data(pi->pardev->port, ~pi->unit); =20 CUR_CTRL &=3D ~PARPORT_CONTROL_SELECT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 CUR_CTRL =3D (CUR_CTRL & port_int) | PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 i =3D mode_map[pi->mode] & 0x0C; =20 if (i =3D=3D 0) i =3D (mode_map[pi->mode] & 2) | 1; =20 - outb(i, pi->port); + parport_write_data(pi->pardev->port, i); =20 CUR_CTRL |=3D PARPORT_CONTROL_SELECT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 // DELAY =20 CUR_CTRL |=3D PARPORT_CONTROL_AUTOFD; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 j =3D ((i & 0x08) << 4) | ((i & 0x07) << 3); =20 - k =3D inb(pi->port + 1) & 0xB8; + k =3D parport_read_status(pi->pardev->port) & 0xB8; =20 if (j =3D=3D k) { CUR_CTRL &=3D ~PARPORT_CONTROL_AUTOFD; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 - k =3D (inb(pi->port + 1) & 0xB8) ^ 0xB8; + k =3D (parport_read_status(pi->pardev->port) & 0xB8) ^ 0xB8; =20 if (j =3D=3D k) { @@ -173,15 +167,15 @@ static int ppc6_select(struct pi_adapter *pi) else // PPC/ECP CUR_CTRL &=3D ~PARPORT_CONTROL_SELECT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 return(1); } } =20 - outb(pi->saved_r2, pi->port + 2); + parport_write_control(pi->pardev->port, pi->saved_r2); =20 - outb(pi->saved_r0, pi->port); + parport_write_data(pi->pardev->port, pi->saved_r0); =20 return(0); // FAIL } @@ -195,13 +189,13 @@ static void ppc6_deselect(struct pi_adapter *pi) else // PPC/ECP CUR_CTRL |=3D PARPORT_CONTROL_SELECT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 - outb(pi->saved_r0, pi->port); + parport_write_data(pi->pardev->port, pi->saved_r0); =20 - outb((pi->saved_r2 | PARPORT_CONTROL_SELECT), pi->port + 2); + parport_write_control(pi->pardev->port, (pi->saved_r2 | PARPORT_CONTROL_S= ELECT)); =20 - outb(pi->saved_r2, pi->port + 2); + parport_write_control(pi->pardev->port, pi->saved_r2); } =20 //************************************************************************= *** @@ -215,11 +209,11 @@ static void ppc6_send_cmd(struct pi_adapter *pi, u8 c= md) case PPCMODE_BI_SW : case PPCMODE_BI_FW : { - outb(cmd, pi->port); + parport_write_data(pi->pardev->port, cmd); =20 CUR_CTRL ^=3D PARPORT_CONTROL_AUTOFD; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 break; } @@ -228,7 +222,7 @@ static void ppc6_send_cmd(struct pi_adapter *pi, u8 cmd) case PPCMODE_EPP_WORD : case PPCMODE_EPP_DWORD : { - outb(cmd, pi->port + 3); + pi->pardev->port->ops->epp_write_addr(pi->pardev->port, &cmd, 1, 0); =20 break; } @@ -246,11 +240,11 @@ static void ppc6_wr_data_byte(struct pi_adapter *pi, = u8 data) case PPCMODE_BI_SW : case PPCMODE_BI_FW : { - outb(data, pi->port); + parport_write_data(pi->pardev->port, data); =20 CUR_CTRL ^=3D PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 break; } @@ -259,7 +253,7 @@ static void ppc6_wr_data_byte(struct pi_adapter *pi, u8= data) case PPCMODE_EPP_WORD : case PPCMODE_EPP_DWORD : { - outb(data, pi->port + 4); + pi->pardev->port->ops->epp_write_data(pi->pardev->port, &data, 1, 0); =20 break; } @@ -279,21 +273,21 @@ static u8 ppc6_rd_data_byte(struct pi_adapter *pi) { CUR_CTRL =3D (CUR_CTRL & ~PARPORT_CONTROL_STROBE) ^ PARPORT_CONTROL_INI= T; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 // DELAY =20 - data =3D inb(pi->port + 1); + data =3D parport_read_status(pi->pardev->port); =20 data =3D ((data & 0x80) >> 1) | ((data & 0x38) >> 3); =20 CUR_CTRL |=3D PARPORT_CONTROL_STROBE; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 // DELAY =20 - data |=3D inb(pi->port + 1) & 0xB8; + data |=3D parport_read_status(pi->pardev->port) & 0xB8; =20 break; } @@ -301,23 +295,19 @@ static u8 ppc6_rd_data_byte(struct pi_adapter *pi) case PPCMODE_BI_SW : case PPCMODE_BI_FW : { - CUR_CTRL |=3D port_dir; - - outb(CUR_CTRL, pi->port + 2); + parport_data_reverse(pi->pardev->port); =20 CUR_CTRL =3D (CUR_CTRL | PARPORT_CONTROL_STROBE) ^ PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 - data =3D inb(pi->port); + data =3D parport_read_data(pi->pardev->port); =20 CUR_CTRL &=3D ~PARPORT_CONTROL_STROBE; =20 - outb(CUR_CTRL, pi->port + 2); - - CUR_CTRL &=3D ~port_dir; + parport_write_control(pi->pardev->port, CUR_CTRL); =20 - outb(CUR_CTRL, pi->port + 2); + parport_data_forward(pi->pardev->port); =20 break; } @@ -326,11 +316,7 @@ static u8 ppc6_rd_data_byte(struct pi_adapter *pi) case PPCMODE_EPP_WORD : case PPCMODE_EPP_DWORD : { - outb((CUR_CTRL | port_dir), pi->port + 2); - - data =3D inb(pi->port + 4); - - outb(CUR_CTRL, pi->port + 2); + pi->pardev->port->ops->epp_read_data(pi->pardev->port, &data, 1, 0); =20 break; } @@ -373,21 +359,21 @@ static void ppc6_rd_data_blk(struct pi_adapter *pi, u= 8 *data, long count) CUR_CTRL =3D (CUR_CTRL & ~PARPORT_CONTROL_STROBE) ^ PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 // DELAY =20 - d =3D inb(pi->port + 1); + d =3D parport_read_status(pi->pardev->port); =20 d =3D ((d & 0x80) >> 1) | ((d & 0x38) >> 3); =20 CUR_CTRL |=3D PARPORT_CONTROL_STROBE; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 // DELAY =20 - d |=3D inb(pi->port + 1) & 0xB8; + d |=3D parport_read_status(pi->pardev->port) & 0xB8; =20 *data++ =3D d; count--; @@ -399,9 +385,7 @@ static void ppc6_rd_data_blk(struct pi_adapter *pi, u8 = *data, long count) case PPCMODE_BI_SW : case PPCMODE_BI_FW : { - CUR_CTRL |=3D port_dir; - - outb(CUR_CTRL, pi->port + 2); + parport_data_reverse(pi->pardev->port); =20 CUR_CTRL |=3D PARPORT_CONTROL_STROBE; =20 @@ -409,84 +393,47 @@ static void ppc6_rd_data_blk(struct pi_adapter *pi, u= 8 *data, long count) { CUR_CTRL ^=3D PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 - *data++ =3D inb(pi->port); + *data++ =3D parport_read_data(pi->pardev->port); count--; } =20 CUR_CTRL &=3D ~PARPORT_CONTROL_STROBE; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 - CUR_CTRL &=3D ~port_dir; - - outb(CUR_CTRL, pi->port + 2); + parport_data_forward(pi->pardev->port); =20 break; } =20 case PPCMODE_EPP_BYTE : { - outb((CUR_CTRL | port_dir), pi->port + 2); - // DELAY =20 - while(count) - { - *data++ =3D inb(pi->port + 4); - count--; - } - - outb(CUR_CTRL, pi->port + 2); + pi->pardev->port->ops->epp_read_data(pi->pardev->port, + data, count, PARPORT_EPP_FAST_8); =20 break; } =20 case PPCMODE_EPP_WORD : { - outb((CUR_CTRL | port_dir), pi->port + 2); - // DELAY =20 - while(count > 1) - { - *((u16 *)data) =3D inw(pi->port + 4); - data +=3D 2; - count -=3D 2; - } - - while(count) - { - *data++ =3D inb(pi->port + 4); - count--; - } - - outb(CUR_CTRL, pi->port + 2); + pi->pardev->port->ops->epp_read_data(pi->pardev->port, + data, count, PARPORT_EPP_FAST_16); =20 break; } =20 case PPCMODE_EPP_DWORD : { - outb((CUR_CTRL | port_dir), pi->port + 2); - // DELAY =20 - while(count > 3) - { - *((u32 *)data) =3D inl(pi->port + 4); - data +=3D 4; - count -=3D 4; - } - - while(count) - { - *data++ =3D inb(pi->port + 4); - count--; - } - - outb(CUR_CTRL, pi->port + 2); + pi->pardev->port->ops->epp_read_data(pi->pardev->port, + data, count, PARPORT_EPP_FAST_32); =20 break; } @@ -503,7 +450,7 @@ static void ppc6_wait_for_fifo(struct pi_adapter *pi) if (PPC_FLAGS & fifo_wait) { for(i=3D0; i<20; i++) - inb(pi->port + 1); + parport_read_status(pi->pardev->port); } } =20 @@ -518,11 +465,11 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u= 8 *data, long count) { while(count--) { - outb(*data++, pi->port); + parport_write_data(pi->pardev->port, *data++); =20 CUR_CTRL ^=3D PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); } =20 break; @@ -537,11 +484,11 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u= 8 *data, long count) =20 CUR_CTRL |=3D PARPORT_CONTROL_STROBE; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 last =3D *data; =20 - outb(last, pi->port); + parport_write_data(pi->pardev->port, last); =20 while(count) { @@ -552,11 +499,11 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u= 8 *data, long count) { CUR_CTRL ^=3D PARPORT_CONTROL_INIT; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); } else { - outb(this, pi->port); + parport_write_data(pi->pardev->port, this); =20 last =3D this; } @@ -564,7 +511,7 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u8 = *data, long count) =20 CUR_CTRL &=3D ~PARPORT_CONTROL_STROBE; =20 - outb(CUR_CTRL, pi->port + 2); + parport_write_control(pi->pardev->port, CUR_CTRL); =20 ppc6_send_cmd(pi, CMD_PREFIX_RESET | PREFIX_FASTWR); =20 @@ -573,11 +520,8 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u8= *data, long count) =20 case PPCMODE_EPP_BYTE : { - while(count) - { - outb(*data++, pi->port + 4); - count--; - } + pi->pardev->port->ops->epp_write_data(pi->pardev->port, + data, count, PARPORT_EPP_FAST_8); =20 ppc6_wait_for_fifo(pi); =20 @@ -586,18 +530,8 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u8= *data, long count) =20 case PPCMODE_EPP_WORD : { - while(count > 1) - { - outw(*((u16 *)data), pi->port + 4); - data +=3D 2; - count -=3D 2; - } - - while(count) - { - outb(*data++, pi->port + 4); - count--; - } + pi->pardev->port->ops->epp_write_data(pi->pardev->port, + data, count, PARPORT_EPP_FAST_16); =20 ppc6_wait_for_fifo(pi); =20 @@ -606,18 +540,8 @@ static void ppc6_wr_data_blk(struct pi_adapter *pi, u8= *data, long count) =20 case PPCMODE_EPP_DWORD : { - while(count > 3) - { - outl(*((u32 *)data), pi->port + 4); - data +=3D 4; - count -=3D 4; - } - - while(count) - { - outb(*data++, pi->port + 4); - count--; - } + pi->pardev->port->ops->epp_write_data(pi->pardev->port, + data, count, PARPORT_EPP_FAST_32); =20 ppc6_wait_for_fifo(pi); =20 --=20 Ondrej Zary