From nobody Mon Dec 15 11:04:17 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBDD0C6FA99 for ; Tue, 7 Mar 2023 20:25:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229764AbjCGUZg (ORCPT ); Tue, 7 Mar 2023 15:25:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230522AbjCGUZP (ORCPT ); Tue, 7 Mar 2023 15:25:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35F76A838D for ; Tue, 7 Mar 2023 12:24:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9F706614DF for ; Tue, 7 Mar 2023 20:24:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7919C433D2; Tue, 7 Mar 2023 20:24:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678220680; bh=sLfm8UYUs/1eOM3F9JNSEG6q6gN2CiEXvnHjj2Ve6DY=; h=From:To:Cc:Subject:Date:From; b=vPT0G5T3LFOYsMnNBuPeZ9PFTR8kRvsC4SOE8sW5j6iza24W3pkD0qI/838BnPilu QLVcuACKPREaFT+kxNkS2VSk6/uFgq4WocAv4WFKV5eIpwulKg9WYHS7/N1Zw5+SVF xFK7DqPsKq9AOozjWi6HPxjFebmY2AcbMSASBZ59njMfcowX9cHtNO9rcROAsVyKIH i1UjdGJjGWRmrDp/Q3W7vmmS6NYnfvHpVp3NtsWUpi1vWIn+gFUFKIOHoZ9aWxWiVJ KoHs2NodOGPT90n584IlhhKMy0lCeIuygXpX1rRjxcJpf39XxUz2QBMMiNInCEWzIu rrHvf/17QRT5Q== From: Bjorn Helgaas To: Arnd Bergmann , Greg Kroah-Hartman Cc: Frank Haverkamp , linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH] misc: genwqe: Drop redundant pci_enable_pcie_error_reporting() Date: Tue, 7 Mar 2023 14:24:35 -0600 Message-Id: <20230307202435.880921-1-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Bjorn Helgaas pci_enable_pcie_error_reporting() enables the device to send ERR_* Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), the PCI core does this for all devices during enumeration, so the driver doesn't need to do it itself. Remove the redundant pci_enable_pcie_error_reporting() call from the driver. Note that this only controls ERR_* Messages from the device. An ERR_* Message may cause the Root Port to generate an interrupt, depending on the AER Root Error Command register managed by the AER service driver. Signed-off-by: Bjorn Helgaas --- drivers/misc/genwqe/card_base.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_bas= e.c index 5b63d179b24e..4829bc2208d6 100644 --- a/drivers/misc/genwqe/card_base.c +++ b/drivers/misc/genwqe/card_base.c @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include @@ -1099,7 +1098,6 @@ static int genwqe_pci_setup(struct genwqe_dev *cd) } =20 pci_set_master(pci_dev); - pci_enable_pcie_error_reporting(pci_dev); =20 /* EEH recovery requires PCIe fundamental reset */ pci_dev->needs_freset =3D 1; --=20 2.25.1