From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65BD8C74A5B for ; Sat, 18 Mar 2023 13:43:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjCRNnB (ORCPT ); Sat, 18 Mar 2023 09:43:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjCRNm6 (ORCPT ); Sat, 18 Mar 2023 09:42:58 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6675427D64 for ; Sat, 18 Mar 2023 06:42:56 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id x36so7789580ljq.7 for ; Sat, 18 Mar 2023 06:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146974; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gR7d4RO2oXpB/c3r0bQ4Ajknjymjb6WOVIZPuCDVi/s=; b=H+KKwkXjEOO0xzTuKFQmmnSBPzTcBRlFbmOuHHf0Uf1URi+8D0dsxGBIdjFfhSufft DrJpuK0pjFw5vgPotYM8FgqBQan/tczhlitMFlsrMRdr6y1YoAiafr7ZNKsSQhjxcP9i QdGlVVNlQVzg2orND8EdgzhC7jo6B2q11qv2GhzXuxoRIPLQsqaKpQR8yYmitCbxFlf6 8ePht5xEcqLrc9tJ/+GOPrYedYc/80thHuI+k1zq2FBRjOTtam2lDB+hz6s/gbG+/4vc nKCUA3ZMHKf8TG1JhXh7229zquYFFboM05CWaQpMqtUQQcK0bYW25K/WR2h7EV2y+JD6 bT+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146974; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gR7d4RO2oXpB/c3r0bQ4Ajknjymjb6WOVIZPuCDVi/s=; b=nFoa0pN6C+eo66Pk9EwmvkbEAqTgu88d59WORgPV4fNp7TXonNfYvb/Wo355aP00IC zuSyon7+2nRBnHpLgzVRCdG6GDUKvBrD5VKjGCr4Zvf3jC0ClOq8wmfq9N7gDlLBSyMv n30u5K/MVNKyaMUs/S+OCnsJNbO+NQqyH0D9AkfxczM7YA5RPifPKPeRY5sIVR+juSuM CJ84g7JKYsjVadWd8GDxrFO241kQvrxfe7I8kWyysaK1PcXHJsq7cUrobU4QFJY7cUv1 oe8k5F+/kTpVUJoFJvD37iNmYXPnFTq3FtLg5d2cB6av4I6+8tcKxxB+E0B6yRyLjjth kY4w== X-Gm-Message-State: AO0yUKUg1Rw6YqFR9Yec8ec8iWu508u+tRocG0eOYGmRSgjdUb4mQDLI uv0aOyQQOnSL1as5t8Cu5gPAfgW7J6222uHoTFc= X-Google-Smtp-Source: AK7set9GN9auH9hYdKHl3gOJyNgaD+0SoeqFRn4nVBRLI6bcjVlPdnl1lVslCbG8ftxVuXbiMtxUiw== X-Received: by 2002:a05:651c:391:b0:298:9db0:a9dd with SMTP id e17-20020a05651c039100b002989db0a9ddmr3848542ljp.50.1679146974706; Sat, 18 Mar 2023 06:42:54 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:42:54 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:47 +0100 Subject: [PATCH v6 1/9] dt-bindings: display/msm: dsi-controller-main: Fix deprecated QCM2290 compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-1-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=1481; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=lSCVKFJ04QtIFibtVglZV7BCCs/8/zx27+lAfw7WMPU=; b=X/s/41QPUlm8nRs2vQaKIl635XNevr5YacB1S+xQkmK9HwhcN8L3ph+JFfv/IpLFvBj0pHm1IC6M af8muWHKDv5rbdPZkHE5JmnQP98Q8umthXsGYo2492dX8ODNKJbj X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The point of the previous cleanup was to disallow "qcom,mdss-dsi-ctrl" alone. This however didn't quite work out and the property became undocumented instead of deprecated. Fix that. Additionally, the "qcom," prefix was missed previously. Fix it. Fixes: 0c0f65c6dd44 ("dt-bindings: msm: dsi-controller-main: Add compatible= strings for every current SoC") Acked-by: Rob Herring Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 7 +++= ---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-m= ain.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-mai= n.yaml index e75a3efe4dac..ecc89011bec4 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -31,10 +31,9 @@ properties: - qcom,sm8450-dsi-ctrl - qcom,sm8550-dsi-ctrl - const: qcom,mdss-dsi-ctrl - - items: - - enum: - - dsi-ctrl-6g-qcm2290 - - const: qcom,mdss-dsi-ctrl + - enum: + - qcom,dsi-ctrl-6g-qcm2290 + - qcom,mdss-dsi-ctrl # This should always come with an SoC-speci= fic compatible deprecated: true =20 reg: --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E099C74A5B for ; Sat, 18 Mar 2023 13:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbjCRNnK (ORCPT ); Sat, 18 Mar 2023 09:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229787AbjCRNnB (ORCPT ); Sat, 18 Mar 2023 09:43:01 -0400 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D80216898 for ; Sat, 18 Mar 2023 06:42:58 -0700 (PDT) Received: by mail-lj1-x22c.google.com with SMTP id z5so7778310ljc.8 for ; Sat, 18 Mar 2023 06:42:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146976; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Ja37xKiglxJ/lPrUpuyUvSbThkrJV11m94PBRXq1WhI=; b=j63kOdN48NM1FMwxcRvOouDRuBkw/SDRBHKcP2kCDXbu3eHffkQvdRMB5TPrDoXTcX mHr1VIHZmvH42mEPA3OI5L0LoLqyrsx3ZyHhwdllm985tYhkwUSHBTBf9xgZP1CnUgTy NxeutMT6w3eoDEOWbp74rUCl1bSWJAZLEfTlaHP138zVMIqyhh25b74XRzQfERfdMGKm a3TqcZoBGwQEkRIFc9bG7NZx76E0ZY/ALPtwDZcBrsPYXH9Vkw3rmxnJurwkukLBHiOE Jd/fkrIYQVRk/5yg2Y4uQZI4ZgtCNDUFmrsTufkgG7z35+BfeMn+K8YNwK8jNjQrHUMN PcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146976; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ja37xKiglxJ/lPrUpuyUvSbThkrJV11m94PBRXq1WhI=; b=SN9EHrbCedXoascpUZRaN4RMLwte0WXLe4vrNy4HGEUu+kB/E3AZIMXiAtVWpgwNMn +TPfzJi6ZWgkJRvGteNNYMf6sAf9bYZo6Ss+hLQO2IBXdg/FcGXhSTul9wcUOWnO0d8i UkoK+uz8kymETcCCp+HB4wEFYBPBanHmB0P9guUxnU5n2utkGQvJhq4sOXUH9HLWU5sO Zu5uCZrfZgZqQVhZDIM2b0jsOLeGjB5ZI/BG/cGZgcpaMcWhUxRbE6Vj82BBAImfJl8/ bCqW9zNqxcgY8WIY+ItehjdsDredkIYc2zzAuEy5n8/FPrDV2Qh8MrlkbrVwl/7bgIkg uOeA== X-Gm-Message-State: AO0yUKXap6CbisJOyDQe1d1t4rFag8agPHqVPUYtHEhC4ISnlWSDSNVL wgSwlU3n9zQwa9oRJ6BVpNyW1g== X-Google-Smtp-Source: AK7set+8apd8tn9mAphOC18izxibwyQooL29lC9fvKqCL5UUy3N4m2lCRBggOum5nEJf5MYRJYnieQ== X-Received: by 2002:a05:651c:b10:b0:295:9659:fba5 with SMTP id b16-20020a05651c0b1000b002959659fba5mr5354998ljr.37.1679146976294; Sat, 18 Mar 2023 06:42:56 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:42:55 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:48 +0100 Subject: [PATCH v6 2/9] drm/msm/dsi: Get rid of msm_dsi_config::num_dsi MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-2-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=5720; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=nAK7VhpEOKQPVDoVxGmSH//l3jkm1AocrDNJW7zWKno=; b=0sipnApXZIY2+VWgYQXjuxdpIip3V7pkk/e9SMtNlW7/sozotVv8DC+ri2fXG6ktgln5mEWPoQx6 cO56WjaJAvSYJhZTn5zVwfoXybtVsC1jvQYz/UY85zPo2/VBzZMG X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In preparation for supporting multiple sets of possible base registers, remove the num_dsi variable. We're comparing the io_start array contents with the reg value from the DTS, so it will either match one of the expected values or don't match against a zero (which we get from partial array initialization). Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 13 ------------- drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 - drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/ds= i_cfg.c index 6d21f0b33411..4515f52b407a 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -22,7 +22,6 @@ static const struct msm_dsi_config apq8064_dsi_cfg =3D { .bus_clk_names =3D dsi_v2_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_v2_bus_clk_names), .io_start =3D { 0x4700000, 0x5800000 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_6g_bus_clk_names[] =3D { @@ -42,7 +41,6 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_cf= g =3D { .bus_clk_names =3D dsi_6g_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_6g_bus_clk_names), .io_start =3D { 0xfd922800, 0xfd922b00 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_8916_bus_clk_names[] =3D { @@ -61,7 +59,6 @@ static const struct msm_dsi_config msm8916_dsi_cfg =3D { .bus_clk_names =3D dsi_8916_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_8916_bus_clk_names), .io_start =3D { 0x1a98000 }, - .num_dsi =3D 1, }; =20 static const char * const dsi_8976_bus_clk_names[] =3D { @@ -80,7 +77,6 @@ static const struct msm_dsi_config msm8976_dsi_cfg =3D { .bus_clk_names =3D dsi_8976_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_8976_bus_clk_names), .io_start =3D { 0x1a94000, 0x1a96000 }, - .num_dsi =3D 2, }; =20 static const struct regulator_bulk_data msm8994_dsi_regulators[] =3D { @@ -99,7 +95,6 @@ static const struct msm_dsi_config msm8994_dsi_cfg =3D { .bus_clk_names =3D dsi_6g_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_6g_bus_clk_names), .io_start =3D { 0xfd998000, 0xfd9a0000 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_8996_bus_clk_names[] =3D { @@ -119,7 +114,6 @@ static const struct msm_dsi_config msm8996_dsi_cfg =3D { .bus_clk_names =3D dsi_8996_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_8996_bus_clk_names), .io_start =3D { 0x994000, 0x996000 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_msm8998_bus_clk_names[] =3D { @@ -138,7 +132,6 @@ static const struct msm_dsi_config msm8998_dsi_cfg =3D { .bus_clk_names =3D dsi_msm8998_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_msm8998_bus_clk_names), .io_start =3D { 0xc994000, 0xc996000 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_sdm660_bus_clk_names[] =3D { @@ -156,7 +149,6 @@ static const struct msm_dsi_config sdm660_dsi_cfg =3D { .bus_clk_names =3D dsi_sdm660_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sdm660_bus_clk_names), .io_start =3D { 0xc994000, 0xc996000 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_sdm845_bus_clk_names[] =3D { @@ -178,7 +170,6 @@ static const struct msm_dsi_config sdm845_dsi_cfg =3D { .bus_clk_names =3D dsi_sdm845_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), .io_start =3D { 0xae94000, 0xae96000 }, - .num_dsi =3D 2, }; =20 static const struct regulator_bulk_data sm8550_dsi_regulators[] =3D { @@ -192,7 +183,6 @@ static const struct msm_dsi_config sm8550_dsi_cfg =3D { .bus_clk_names =3D dsi_sdm845_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), .io_start =3D { 0xae94000, 0xae96000 }, - .num_dsi =3D 2, }; =20 static const struct regulator_bulk_data sc7180_dsi_regulators[] =3D { @@ -206,7 +196,6 @@ static const struct msm_dsi_config sc7180_dsi_cfg =3D { .bus_clk_names =3D dsi_sc7180_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sc7180_bus_clk_names), .io_start =3D { 0xae94000 }, - .num_dsi =3D 1, }; =20 static const char * const dsi_sc7280_bus_clk_names[] =3D { @@ -224,7 +213,6 @@ static const struct msm_dsi_config sc7280_dsi_cfg =3D { .bus_clk_names =3D dsi_sc7280_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sc7280_bus_clk_names), .io_start =3D { 0xae94000, 0xae96000 }, - .num_dsi =3D 2, }; =20 static const char * const dsi_qcm2290_bus_clk_names[] =3D { @@ -242,7 +230,6 @@ static const struct msm_dsi_config qcm2290_dsi_cfg =3D { .bus_clk_names =3D dsi_qcm2290_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_qcm2290_bus_clk_names), .io_start =3D { 0x5e94000 }, - .num_dsi =3D 1, }; =20 static const struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops =3D { diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/ds= i_cfg.h index 44be4a88aa83..6b6b16c5fd25 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h @@ -39,7 +39,6 @@ struct msm_dsi_config { const char * const *bus_clk_names; const int num_bus_clks; const resource_size_t io_start[DSI_MAX]; - const int num_dsi; }; =20 struct msm_dsi_host_cfg_ops { diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/d= si_host.c index 18fa30e1e858..9021f0d65515 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1868,7 +1868,7 @@ static int dsi_host_get_id(struct msm_dsi_host *msm_h= ost) if (!res) return -EINVAL; =20 - for (i =3D 0; i < cfg->num_dsi; i++) { + for (i =3D 0; i < DSI_MAX; i++) { if (cfg->io_start[i] =3D=3D res->start) return i; } --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F70C7618A for ; Sat, 18 Mar 2023 13:43:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbjCRNnP (ORCPT ); Sat, 18 Mar 2023 09:43:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229788AbjCRNnI (ORCPT ); Sat, 18 Mar 2023 09:43:08 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C87332532 for ; Sat, 18 Mar 2023 06:42:59 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id 20so644648lju.0 for ; Sat, 18 Mar 2023 06:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146978; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6mz7dhLEVkKzAk8Lkvywe3WYisGA69PWt7jvCUOITN8=; b=l5RxrNP+TtC35jL5wSHwWEmzYcpTKYJiVNeU7phV2VuXQ+JNCMp9q4UexzZrpDwU5R KnrjB8DZn/kONTNEpVXtXYcwFz3d2zUNaW/F1cq5hnQ4btoQ3FjYLYzF9nqeyFxo6Mx2 pPaLMOroe7P5/SolQ1DbJ24fU1cgAR8nMdI3FgG2fh7th0mxOKOr0Jm2Qmgo6q+S7ZmQ JB8em81q1zC6hvGehieWV5a9f7SGlQWuSg4hhxa2nwjEw+zRbmirvKE0dDaDOYsx3LIw Dj6iwzbceiOypEbHT7yT650y2SVD1MCjPdksuRsOXJX/tXKH8XOvO9d1nJL76CDaHXR3 zqEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146978; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6mz7dhLEVkKzAk8Lkvywe3WYisGA69PWt7jvCUOITN8=; b=gDRUKCddSwhGd8nyWyB86xIZeGCVY+2dd6LupOSxZX6rSJZjy+r0D1VBDjjOAzB8RK SP6gCSSkjq6YgMq2xIJbdqHsrfhtuXNXGGh9cBzLkIkJr+6zLDD5QBzXfQw5Z68DWVDX VdGoAKRMXR6XxMW9yCaRw0a2xkg59RFknNqFPksocubo687Vi4CFZBcxMbg34pgYwBkE ir4tthDWH+FveKENOZG4zeGbiSIcAE8XemU41JUvA7FIGkow6VLENVXlBNi3QsHlpzTj TiyWdd3TNyVg5icodrU7xh/ne4/1/nZq1edcRwp42xawJ+0u6CfkiE8lWvhYJgDi7LrA tsig== X-Gm-Message-State: AO0yUKX0gU5xcW7x3bTeMGY3ZfnYIAiqrp5Q7VJb6teZ9a+oEXTdnpWz IN7scD50k1XgS/LvWWWHDZbI5w== X-Google-Smtp-Source: AK7set+3ky8feSimwcyJYoz0JQtH30GI5/oKt9cI4GAhN/+7l/YvRPkVCQFCVdPKvMYTcjfF1jNvaA== X-Received: by 2002:a2e:9255:0:b0:299:f770:db5e with SMTP id v21-20020a2e9255000000b00299f770db5emr2373447ljg.16.1679146977879; Sat, 18 Mar 2023 06:42:57 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:42:57 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:49 +0100 Subject: [PATCH v6 3/9] drm/msm/dsi: Fix DSI index detection when version clash occurs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-3-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=8216; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=b+otjvnFVNWNHQbPO9HD+5KH7xMK3hiBo7WDBK4sSP4=; b=MfZ/bvuF4tdu+wbKKRHHAtd41nx3udsJRMbHkWH2gfTniRqLXaDQHSqqfteGWRp+h1YUTjF/qq6r JTxxWCUfCNm02easWL3yM/g3WG9mmiNRWC9jK8SbyOk64nVlBdiJ X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, we allow for MAX_DSI entries in io_start to facilitate for MAX_DSI number of DSI hosts at different addresses. The configuration is matched against the DSI CTRL hardware revision read back from the component. We need a way to resolve situations where multiple SoCs with different register maps may use the same version of DSI CTRL. In preparation to do so, make msm_dsi_config a 2d array where each entry represents a set of configurations adequate for a given SoC. This is totally fine to do, as the only differentiating factors between same-version-different-SoCs configurations are the number of DSI hosts (1 or 2, at least as of today) and the set of base registers. The regulator setup is the same, because the DSI hardware is the same, regardless of the SoC it was implemented in. In addition to that, update the matching logic such that it will loop over VARIANTS_MAX variants, making sure they are all taken into account. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 52 ++++++++++++++++++++++++++++------= ---- drivers/gpu/drm/msm/dsi/dsi_cfg.h | 5 +++- drivers/gpu/drm/msm/dsi/dsi_host.c | 10 ++++---- 3 files changed, 48 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/ds= i_cfg.c index 4515f52b407a..6c192963c100 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -21,7 +21,9 @@ static const struct msm_dsi_config apq8064_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(apq8064_dsi_regulators), .bus_clk_names =3D dsi_v2_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_v2_bus_clk_names), - .io_start =3D { 0x4700000, 0x5800000 }, + .io_start =3D { + { 0x4700000, 0x5800000 }, + }, }; =20 static const char * const dsi_6g_bus_clk_names[] =3D { @@ -40,7 +42,9 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_cf= g =3D { .num_regulators =3D ARRAY_SIZE(msm8974_apq8084_regulators), .bus_clk_names =3D dsi_6g_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_6g_bus_clk_names), - .io_start =3D { 0xfd922800, 0xfd922b00 }, + .io_start =3D { + { 0xfd922800, 0xfd922b00 }, + }, }; =20 static const char * const dsi_8916_bus_clk_names[] =3D { @@ -58,7 +62,9 @@ static const struct msm_dsi_config msm8916_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(msm8916_dsi_regulators), .bus_clk_names =3D dsi_8916_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_8916_bus_clk_names), - .io_start =3D { 0x1a98000 }, + .io_start =3D { + { 0x1a98000 }, + }, }; =20 static const char * const dsi_8976_bus_clk_names[] =3D { @@ -76,7 +82,9 @@ static const struct msm_dsi_config msm8976_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(msm8976_dsi_regulators), .bus_clk_names =3D dsi_8976_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_8976_bus_clk_names), - .io_start =3D { 0x1a94000, 0x1a96000 }, + .io_start =3D { + { 0x1a94000, 0x1a96000 }, + }, }; =20 static const struct regulator_bulk_data msm8994_dsi_regulators[] =3D { @@ -94,7 +102,9 @@ static const struct msm_dsi_config msm8994_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(msm8994_dsi_regulators), .bus_clk_names =3D dsi_6g_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_6g_bus_clk_names), - .io_start =3D { 0xfd998000, 0xfd9a0000 }, + .io_start =3D { + { 0xfd998000, 0xfd9a0000 }, + }, }; =20 static const char * const dsi_8996_bus_clk_names[] =3D { @@ -113,7 +123,9 @@ static const struct msm_dsi_config msm8996_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(msm8996_dsi_regulators), .bus_clk_names =3D dsi_8996_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_8996_bus_clk_names), - .io_start =3D { 0x994000, 0x996000 }, + .io_start =3D { + { 0x994000, 0x996000 }, + }, }; =20 static const char * const dsi_msm8998_bus_clk_names[] =3D { @@ -131,7 +143,9 @@ static const struct msm_dsi_config msm8998_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(msm8998_dsi_regulators), .bus_clk_names =3D dsi_msm8998_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_msm8998_bus_clk_names), - .io_start =3D { 0xc994000, 0xc996000 }, + .io_start =3D { + { 0xc994000, 0xc996000 }, + }, }; =20 static const char * const dsi_sdm660_bus_clk_names[] =3D { @@ -148,7 +162,9 @@ static const struct msm_dsi_config sdm660_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(sdm660_dsi_regulators), .bus_clk_names =3D dsi_sdm660_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sdm660_bus_clk_names), - .io_start =3D { 0xc994000, 0xc996000 }, + .io_start =3D { + { 0xc994000, 0xc996000 }, + }, }; =20 static const char * const dsi_sdm845_bus_clk_names[] =3D { @@ -169,7 +185,9 @@ static const struct msm_dsi_config sdm845_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(sdm845_dsi_regulators), .bus_clk_names =3D dsi_sdm845_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), - .io_start =3D { 0xae94000, 0xae96000 }, + .io_start =3D { + { 0xae94000, 0xae96000 }, + }, }; =20 static const struct regulator_bulk_data sm8550_dsi_regulators[] =3D { @@ -182,7 +200,9 @@ static const struct msm_dsi_config sm8550_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(sm8550_dsi_regulators), .bus_clk_names =3D dsi_sdm845_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), - .io_start =3D { 0xae94000, 0xae96000 }, + .io_start =3D { + { 0xae94000, 0xae96000 }, + }, }; =20 static const struct regulator_bulk_data sc7180_dsi_regulators[] =3D { @@ -195,7 +215,9 @@ static const struct msm_dsi_config sc7180_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(sc7180_dsi_regulators), .bus_clk_names =3D dsi_sc7180_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sc7180_bus_clk_names), - .io_start =3D { 0xae94000 }, + .io_start =3D { + { 0xae94000 }, + }, }; =20 static const char * const dsi_sc7280_bus_clk_names[] =3D { @@ -212,7 +234,9 @@ static const struct msm_dsi_config sc7280_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(sc7280_dsi_regulators), .bus_clk_names =3D dsi_sc7280_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_sc7280_bus_clk_names), - .io_start =3D { 0xae94000, 0xae96000 }, + .io_start =3D { + { 0xae94000, 0xae96000 }, + }, }; =20 static const char * const dsi_qcm2290_bus_clk_names[] =3D { @@ -229,7 +253,9 @@ static const struct msm_dsi_config qcm2290_dsi_cfg =3D { .num_regulators =3D ARRAY_SIZE(qcm2290_dsi_cfg_regulators), .bus_clk_names =3D dsi_qcm2290_bus_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_qcm2290_bus_clk_names), - .io_start =3D { 0x5e94000 }, + .io_start =3D { + { 0x5e94000 }, + }, }; =20 static const struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops =3D { diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/ds= i_cfg.h index 6b6b16c5fd25..8772a3631ac1 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h @@ -32,13 +32,16 @@ =20 #define DSI_6G_REG_SHIFT 4 =20 +/* Maximum number of configurations matched against the same hw revision */ +#define VARIANTS_MAX 2 + struct msm_dsi_config { u32 io_offset; const struct regulator_bulk_data *regulator_data; int num_regulators; const char * const *bus_clk_names; const int num_bus_clks; - const resource_size_t io_start[DSI_MAX]; + const resource_size_t io_start[VARIANTS_MAX][DSI_MAX]; }; =20 struct msm_dsi_host_cfg_ops { diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/d= si_host.c index 9021f0d65515..9cfb9e91bfea 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -1862,16 +1862,16 @@ static int dsi_host_get_id(struct msm_dsi_host *msm= _host) struct platform_device *pdev =3D msm_host->pdev; const struct msm_dsi_config *cfg =3D msm_host->cfg_hnd->cfg; struct resource *res; - int i; + int i, j; =20 res =3D platform_get_resource_byname(pdev, IORESOURCE_MEM, "dsi_ctrl"); if (!res) return -EINVAL; =20 - for (i =3D 0; i < DSI_MAX; i++) { - if (cfg->io_start[i] =3D=3D res->start) - return i; - } + for (i =3D 0; i < VARIANTS_MAX; i++) + for (j =3D 0; j < DSI_MAX; j++) + if (cfg->io_start[i][j] =3D=3D res->start) + return j; =20 return -EINVAL; } --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1B7EC76195 for ; Sat, 18 Mar 2023 13:43:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229839AbjCRNnM (ORCPT ); Sat, 18 Mar 2023 09:43:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229798AbjCRNnE (ORCPT ); Sat, 18 Mar 2023 09:43:04 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 552B432CD5 for ; Sat, 18 Mar 2023 06:43:00 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id t14so7791032ljd.5 for ; Sat, 18 Mar 2023 06:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=64Eim4J+wnLNg16H207185gsYiLvTQ9YXeAiDAajBeo=; b=ZmPK7f34jfn/APMqkk2gLGWySTgDjm48S5x6Fwx1Zwi05nRKt3SlJO2IUJNDEz7THd WIHnpkcpQ74MDnGHngpTAYbq/Hhd5BFfMKGWp7TKLIHFy7bZRvkZB8qZMbTBmHnr0EwG kN3puilAjHRR8Bb8Gua92H6kezHcO7qXGscCeZP5OsnIYYtU1PwztkZSL69EWp46uZro 83wBQxrU1qRvCAU9e1/I6x5x2+BtAxriBbQJ+R3Ofa44foGypVUWnIn9FcNXwclp2Ipt mr6t+WNUpqHmzCqAL6hSWoUmobNTQEhedKKdIpLN/zFaEhy8/OSf+kdGovb4wKABxAG+ 36Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146979; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=64Eim4J+wnLNg16H207185gsYiLvTQ9YXeAiDAajBeo=; b=5RHoh/D3pHgpvlvDFbUoQi4CGa5vb9Y+D+o1arUxNdtXiKA2fNgcccIObtr4Kh6h21 ancC7UyH23uGJ+cTYpuReCPkyHcEtPkz0WbUROl9cXmGRqbeZ7ss8LoEMiApOg90rKAb dGb4YRjuyKhYv0M+yXgMXu6ojVuIAA+9a2bKtmfS8qZDGK97FPDnkRyY1w1ySnT69bzD do1eLrEBl45A5pARJxiGbUP26xaZJbZ7fU/vcSNZotY01LJO9vAuWQmPT+vG4nUqOpsL iGeLMAWVQd1SiK0g4CbtOuv6VU1JqRTtUHBZ/ASoYKO9CHBdwKIviMJhSG9edhH7FjvX 6b1A== X-Gm-Message-State: AO0yUKWl21ZssqbqJ1OCaz5efnwj6ST5iFkEk00XbrNI9qRUm4P4xEfZ mlx3QLQKfQH/eP6QISJXP3egxA== X-Google-Smtp-Source: AK7set99/nq5eGpck0CO6kYinimqMHr04J2cnAXvlgoN7GcS4ZNmQeGEA0/CE3To6dzzTiYYhHBDKg== X-Received: by 2002:a2e:be29:0:b0:290:6af8:ec25 with SMTP id z41-20020a2ebe29000000b002906af8ec25mr5831340ljq.52.1679146979675; Sat, 18 Mar 2023 06:42:59 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:42:59 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:50 +0100 Subject: [PATCH v6 4/9] drm/msm/dsi: dsi_cfg: Deduplicate identical structs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-4-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=7014; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=eQGewel5eMIUbnjRWU8o9jYKXbfa44urQPoDhCO0rnI=; b=aIP2Ci+k4bWQEmaszkmmla0vcEoEAg71XC+VZWKNhlyqM9RKec6JOrzeikoDuGx8RBfy+CT/bgY5 4VtK1qW0BucTsvI7eVuEMI9vqDsF32vJ41jz2cAyaFqhOepQXBkq X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some structs were defined multiple times for no apparent reason. Deduplicate them. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 93 +++++++++++++----------------------= ---- 1 file changed, 30 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/ds= i_cfg.c index 6c192963c100..039f503233d7 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -47,41 +47,32 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_= cfg =3D { }, }; =20 -static const char * const dsi_8916_bus_clk_names[] =3D { +static const char * const dsi_v1_3_1_clk_names[] =3D { "mdp_core", "iface", "bus", }; =20 -static const struct regulator_bulk_data msm8916_dsi_regulators[] =3D { +static const struct regulator_bulk_data dsi_v1_3_1_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 100000 }, /* 1.2 V */ { .supply =3D "vddio", .init_load_uA =3D 100000 }, /* 1.8 V */ }; =20 static const struct msm_dsi_config msm8916_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D msm8916_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(msm8916_dsi_regulators), - .bus_clk_names =3D dsi_8916_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_8916_bus_clk_names), + .regulator_data =3D dsi_v1_3_1_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v1_3_1_regulators), + .bus_clk_names =3D dsi_v1_3_1_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v1_3_1_clk_names), .io_start =3D { { 0x1a98000 }, }, }; =20 -static const char * const dsi_8976_bus_clk_names[] =3D { - "mdp_core", "iface", "bus", -}; - -static const struct regulator_bulk_data msm8976_dsi_regulators[] =3D { - { .supply =3D "vdda", .init_load_uA =3D 100000 }, /* 1.2 V */ - { .supply =3D "vddio", .init_load_uA =3D 100000 }, /* 1.8 V */ -}; - static const struct msm_dsi_config msm8976_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D msm8976_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(msm8976_dsi_regulators), - .bus_clk_names =3D dsi_8976_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_8976_bus_clk_names), + .regulator_data =3D dsi_v1_3_1_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v1_3_1_regulators), + .bus_clk_names =3D dsi_v1_3_1_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v1_3_1_clk_names), .io_start =3D { { 0x1a94000, 0x1a96000 }, }, @@ -107,10 +98,6 @@ static const struct msm_dsi_config msm8994_dsi_cfg =3D { }, }; =20 -static const char * const dsi_8996_bus_clk_names[] =3D { - "mdp_core", "iface", "bus", "core_mmss", -}; - static const struct regulator_bulk_data msm8996_dsi_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 18160 }, /* 1.25 V */ { .supply =3D "vcca", .init_load_uA =3D 17000 }, /* 0.925 V */ @@ -121,8 +108,8 @@ static const struct msm_dsi_config msm8996_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, .regulator_data =3D msm8996_dsi_regulators, .num_regulators =3D ARRAY_SIZE(msm8996_dsi_regulators), - .bus_clk_names =3D dsi_8996_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_8996_bus_clk_names), + .bus_clk_names =3D dsi_6g_bus_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_6g_bus_clk_names), .io_start =3D { { 0x994000, 0x996000 }, }, @@ -167,24 +154,20 @@ static const struct msm_dsi_config sdm660_dsi_cfg =3D= { }, }; =20 -static const char * const dsi_sdm845_bus_clk_names[] =3D { +static const char * const dsi_v2_4_clk_names[] =3D { "iface", "bus", }; =20 -static const char * const dsi_sc7180_bus_clk_names[] =3D { - "iface", "bus", -}; - -static const struct regulator_bulk_data sdm845_dsi_regulators[] =3D { +static const struct regulator_bulk_data dsi_v2_4_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 21800 }, /* 1.2 V */ }; =20 static const struct msm_dsi_config sdm845_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D sdm845_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(sdm845_dsi_regulators), - .bus_clk_names =3D dsi_sdm845_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), + .regulator_data =3D dsi_v2_4_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000, 0xae96000 }, }, @@ -198,32 +181,24 @@ static const struct msm_dsi_config sm8550_dsi_cfg =3D= { .io_offset =3D DSI_6G_REG_SHIFT, .regulator_data =3D sm8550_dsi_regulators, .num_regulators =3D ARRAY_SIZE(sm8550_dsi_regulators), - .bus_clk_names =3D dsi_sdm845_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000, 0xae96000 }, }, }; =20 -static const struct regulator_bulk_data sc7180_dsi_regulators[] =3D { - { .supply =3D "vdda", .init_load_uA =3D 21800 }, /* 1.2 V */ -}; - static const struct msm_dsi_config sc7180_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D sc7180_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(sc7180_dsi_regulators), - .bus_clk_names =3D dsi_sc7180_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sc7180_bus_clk_names), + .regulator_data =3D dsi_v2_4_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000 }, }, }; =20 -static const char * const dsi_sc7280_bus_clk_names[] =3D { - "iface", "bus", -}; - static const struct regulator_bulk_data sc7280_dsi_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 8350 }, /* 1.2 V */ }; @@ -232,27 +207,19 @@ static const struct msm_dsi_config sc7280_dsi_cfg =3D= { .io_offset =3D DSI_6G_REG_SHIFT, .regulator_data =3D sc7280_dsi_regulators, .num_regulators =3D ARRAY_SIZE(sc7280_dsi_regulators), - .bus_clk_names =3D dsi_sc7280_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sc7280_bus_clk_names), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000, 0xae96000 }, }, }; =20 -static const char * const dsi_qcm2290_bus_clk_names[] =3D { - "iface", "bus", -}; - -static const struct regulator_bulk_data qcm2290_dsi_cfg_regulators[] =3D { - { .supply =3D "vdda", .init_load_uA =3D 21800 }, /* 1.2 V */ -}; - static const struct msm_dsi_config qcm2290_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D qcm2290_dsi_cfg_regulators, - .num_regulators =3D ARRAY_SIZE(qcm2290_dsi_cfg_regulators), - .bus_clk_names =3D dsi_qcm2290_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_qcm2290_bus_clk_names), + .regulator_data =3D dsi_v2_4_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0x5e94000 }, }, --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4398EC74A5B for ; Sat, 18 Mar 2023 13:43:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbjCRNnV (ORCPT ); Sat, 18 Mar 2023 09:43:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229822AbjCRNnI (ORCPT ); Sat, 18 Mar 2023 09:43:08 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D4BC33CD7 for ; Sat, 18 Mar 2023 06:43:02 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id y15so9744214lfa.7 for ; Sat, 18 Mar 2023 06:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146981; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=FyfU1KJpQXcUs5jhogFBaoFTlgPH63DY/U4xjNHTWjQ=; b=j/SuZWK4hGzsjGSVxR7d8gdxnkenVxTgbXW9BWPte7dDWKjpvkRvb1DaNyfRBX4I0W G1bXkkbuItkcaCtiEuozT4vbyXYez0ODAylavTT9AO89s9TCGUCq52Q7v9U9emZ8ZGO8 0ixeuALLMGp9IEpUREfGs5x88UQYFRFt6y8uYYsGi4TamiEBru8aSD7Fq54IkJ7wHUED Vt8ZH1TuoXEBaYTzzJsmhZBpBAIGNdEuTWEolCyfgUUSBnOpy6duLCJAafqlflsvYlNq KW3PjuXgCOhDRhkydqBFNjrTz/7OxQ/WGNlDaKSGDt7RD0EYbHaMidi6KEKKBkyM3jcv TIow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146981; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FyfU1KJpQXcUs5jhogFBaoFTlgPH63DY/U4xjNHTWjQ=; b=E0XeXPX2/QylKLRdd6i4bG6Le8L9OMICgwdZeIeJeOhj5MWuiRg8MVFlcw3+cbtgp3 fNrdyKkYmnUfBjW9aFI9qFREtPhRK4TsM3HCScEUlOxHa9ToYlTfNShCA/57JAUyy4il Ohhe3gBRfaw3XlWognzyXJfc/TM/khqPolZmvXYxX/vYwcNFcq2X1188qsT7f8af/A3L yx52bse6jS9v8flF91P4sINl7uXvNTqkklxai3fegSkP1mbluNWt6ZX1qHP3ozjf/0D4 MUP2odGdsSGdo47ZoCqbVifxMEVwnJO1FxSGaVRAo3kMYD5R27lq8vPA6pNSfHSuLmS1 Tm/A== X-Gm-Message-State: AO0yUKU1wLE0HDXVKG7L8KviXr3MuWO7H/YJP+VXlSeROqhhKSz1iEY3 hmd4JQhol5M0saFnTHElw8l6LPE14BpvVpVD+m8= X-Google-Smtp-Source: AK7set+15GJfrf0vus0V2GKbcXZvMhIzBE9jo8AJG7qdkvGE/FNMZouJGBc1KhREYTpkILHyGw41Cw== X-Received: by 2002:a05:6512:68:b0:4dd:a0f6:8f3b with SMTP id i8-20020a056512006800b004dda0f68f3bmr4918976lfo.15.1679146981212; Sat, 18 Mar 2023 06:43:01 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:43:00 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:51 +0100 Subject: [PATCH v6 5/9] drm/msm/dsi: dsi_cfg: Merge SC7180 config into SDM845 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-5-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=2206; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=+ePdH/Gl1hrkxIW7hm63Vg7SPtBJUhhLLi5EVaR0ltI=; b=w5Qh/YigwR8zbCdmDXGOkZlPU3gF9O6EA79QXQ5pTEeLd1VBTvHZNJbYrKDsfGCO2AS16d1bFlvD uVp8tqA5CgXbiLvyhr8IITU9ATLjE8GSafvPJ5cCcflMzSIQK9/y X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The configs are identical, other than the number of *maximum* DSI hosts allowed. This isn't an issue, unless somebody deliberately tries to access the inexistent host by adding a dt node for it. Remove the SC7180 struct and point the hw revision match to the SDM845's one. On a note, this could have been done back when 7180 support was introduced. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/ds= i_cfg.c index 039f503233d7..03d98cbcc978 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -169,7 +169,7 @@ static const struct msm_dsi_config sdm845_dsi_cfg =3D { .bus_clk_names =3D dsi_v2_4_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { - { 0xae94000, 0xae96000 }, + { 0xae94000, 0xae96000 }, /* SDM845 / SDM670 / SC7180 */ }, }; =20 @@ -188,17 +188,6 @@ static const struct msm_dsi_config sm8550_dsi_cfg =3D { }, }; =20 -static const struct msm_dsi_config sc7180_dsi_cfg =3D { - .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D dsi_v2_4_regulators, - .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), - .bus_clk_names =3D dsi_v2_4_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), - .io_start =3D { - { 0xae94000 }, - }, -}; - static const struct regulator_bulk_data sc7280_dsi_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 8350 }, /* 1.2 V */ }; @@ -291,7 +280,7 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handler= s[] =3D { {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_0, &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1, - &sc7180_dsi_cfg, &msm_dsi_6g_v2_host_ops}, + &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_5_0, &sc7280_dsi_cfg, &msm_dsi_6g_v2_host_ops}, {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_6_0, --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F1C7C61DA4 for ; Sat, 18 Mar 2023 13:43:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229925AbjCRNnS (ORCPT ); Sat, 18 Mar 2023 09:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229816AbjCRNnI (ORCPT ); Sat, 18 Mar 2023 09:43:08 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A64333CDB for ; Sat, 18 Mar 2023 06:43:03 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id z42so7764944ljq.13 for ; Sat, 18 Mar 2023 06:43:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4ybpWSBp4lClKqhK/g5tZCNekBaDds3KID0LOYjNmjg=; b=wqtSFUFVe/xqQiyDgL02mrMIhKD9j3mvK3IMDaZT8NgtIad7uKJJJkPKJcNePc7zov papqa6Qe/Kmi6OW/nMwuPx31WMjgWPcbtPdd2xZTPLmfhugWHXncyIZK0x0/NkAqS6j2 oPzRd1Iw1WeR5enLKJxhQK5Wuz1M84u1MBjvOMdDGzkzZhoVhcpZd4tMUuebP8/vKgv0 J1m6+r9QY91Yk7GR98stE9vmz2rFIYUZxE7uLrKi+l2e6KA1YcElDyQ06rlfU03dWyQo 58XTu8umRnOxy55H3oVR/GZkPnpqLxkmeAmtrgtVhYYjwleHxusdPqsZT1UhEsq5YCaX 9zsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146982; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4ybpWSBp4lClKqhK/g5tZCNekBaDds3KID0LOYjNmjg=; b=UFiH61XjhXw8CryMbvitSrdM4sEZLP0JyOht78Cl+2/g+SF+kDUXkmTsJuo+eH+o7E mmYbyfanZ/5Ar9TtQp37vfBuRh+zXqCtsrjEuPPh+IQl+YQQmCN17O+tE4zK0BZv3G7P QXVyRmiynkOsV9VI2x5DRBCKEmAZzsr0OZhaXk5loa3WgXrO4zHQAeb0T30Kt+AVnUT3 RfDG4tOkiyIiJHNjU+hYxMnDmUX39yN3g+ND7tea4syRUX9rMXrfqKwquFnRO44JpcQY eQanJesVSw36NvuNHYaIRCeEA3d7xR+tENz0Miq6R6dC8gHAXqDq9v/yIllOCzOXdWCF mSAg== X-Gm-Message-State: AO0yUKVubA46L9AQvwZ9X38o5vnbOGjAdo75gSgLBEG+Sa/1iexsDqWd U5PLTSNuAXWxyMP3GKhjnqrnug== X-Google-Smtp-Source: AK7set+R0j4Ce26Agp+0Sa59LUZQfjfx5Qx7wJBSevbBYxEHXTxN4tujUPTOz/auYp1r/UV/5jkhmw== X-Received: by 2002:a2e:be85:0:b0:298:a7c4:f838 with SMTP id a5-20020a2ebe85000000b00298a7c4f838mr6668341ljr.25.1679146982761; Sat, 18 Mar 2023 06:43:02 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:43:02 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:52 +0100 Subject: [PATCH v6 6/9] drm/msm/dsi: Switch the QCM2290-specific compatible to index autodetection MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-6-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=3233; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=e/ZDvN1pmXEVddNSmMJ2iSlA9sSO8FBakW2FjAcs2pg=; b=V6Mrw47+2xiejKuA4uajLkdylpMy4cmo+WOXWJZ/4BliI+KHPvZtBJ0Vkpgzr6xBJ34wctaW+Dq4 s4DT+DkuBDHmrFTQtyimBbnhBxb+LvZdkB5AmljaE4Xw0F8T0BJ9 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the logic can handle multiple sets of registers, move the QCM2290 to the common logic and mark it deprecated. This allows us to remove a couple of structs, saving some memory. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi.c | 5 +++-- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 20 ++------------------ drivers/gpu/drm/msm/dsi/dsi_cfg.h | 3 --- 3 files changed, 5 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index 31fdee2052be..f761973e4cba 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -4,7 +4,6 @@ */ =20 #include "dsi.h" -#include "dsi_cfg.h" =20 bool msm_dsi_is_cmd_mode(struct msm_dsi *msm_dsi) { @@ -174,7 +173,9 @@ static int dsi_dev_remove(struct platform_device *pdev) =20 static const struct of_device_id dt_match[] =3D { { .compatible =3D "qcom,mdss-dsi-ctrl", .data =3D NULL /* autodetect cfg = */ }, - { .compatible =3D "qcom,dsi-ctrl-6g-qcm2290", .data =3D &qcm2290_dsi_cfg_= handler }, + + /* Deprecated, don't use */ + { .compatible =3D "qcom,dsi-ctrl-6g-qcm2290", .data =3D NULL }, {} }; =20 diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/ds= i_cfg.c index 03d98cbcc978..29ccd755cc2e 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -169,7 +169,8 @@ static const struct msm_dsi_config sdm845_dsi_cfg =3D { .bus_clk_names =3D dsi_v2_4_clk_names, .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { - { 0xae94000, 0xae96000 }, /* SDM845 / SDM670 / SC7180 */ + { 0xae94000, 0xae96000 }, /* SDM845 / SDM670 */ + { 0x5e94000 }, /* QCM2290 / SM6115 / SM6125 / SM6375 */ }, }; =20 @@ -203,17 +204,6 @@ static const struct msm_dsi_config sc7280_dsi_cfg =3D { }, }; =20 -static const struct msm_dsi_config qcm2290_dsi_cfg =3D { - .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D dsi_v2_4_regulators, - .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), - .bus_clk_names =3D dsi_v2_4_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), - .io_start =3D { - { 0x5e94000 }, - }, -}; - static const struct msm_dsi_host_cfg_ops msm_dsi_v2_host_ops =3D { .link_clk_set_rate =3D dsi_link_clk_set_rate_v2, .link_clk_enable =3D dsi_link_clk_enable_v2, @@ -304,9 +294,3 @@ const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 m= ajor, u32 minor) =20 return cfg_hnd; } - -/* Non autodetect configs */ -const struct msm_dsi_cfg_handler qcm2290_dsi_cfg_handler =3D { - .cfg =3D &qcm2290_dsi_cfg, - .ops =3D &msm_dsi_6g_v2_host_ops, -}; diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/ds= i_cfg.h index 8772a3631ac1..91bdaf50bb1a 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h @@ -65,8 +65,5 @@ struct msm_dsi_cfg_handler { =20 const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor); =20 -/* Non autodetect configs */ -extern const struct msm_dsi_cfg_handler qcm2290_dsi_cfg_handler; - #endif /* __MSM_DSI_CFG_H__ */ =20 --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A1B0C74A5B for ; Sat, 18 Mar 2023 13:43:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbjCRNn0 (ORCPT ); Sat, 18 Mar 2023 09:43:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbjCRNnL (ORCPT ); Sat, 18 Mar 2023 09:43:11 -0400 Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72A9732CEC for ; Sat, 18 Mar 2023 06:43:06 -0700 (PDT) Received: by mail-lj1-x234.google.com with SMTP id by8so6586663ljb.12 for ; Sat, 18 Mar 2023 06:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146984; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Vhpul7Rh3cRj+K0GuudZQvoFoP/xfXO3CkdZI/yylms=; b=j426X71mabGLe1BqLKd75IEf3x1OwnMZApw94sSoRjI9PIBDOgl5mmVj97uwADtRIo dPQ35g3OJujaMQjQn7viOa6Q7fmpMnQ/y5NCKb3hLvNau9VWW993qWBwOUW89sRwWHTB RrQQ/mhy3s7dFVDtwZap3HhE8vNBSXT72A3Y83fC026lvBC4bg3+0owmbu3Njq9nWxy7 oa3wwhpAO6vi9u2HQ0NWCRRlydJOKZTTYJ5UyqV5YvtAQIrDrAid7V4U2aonZQlZRE7I qZemPNvc/UJ3Ghjgfsa73cPc1ni3yCKnhp+/HHHAdVb4vHCtrBcIP8or9yXx0OdCkHCJ Idgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146984; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vhpul7Rh3cRj+K0GuudZQvoFoP/xfXO3CkdZI/yylms=; b=cOSmgU9/SDRSaxPd10I2/RTCBwoK8TseeHmzabdXe653YIjxL/cclzfBdjtxi+AP2i OvBmhVTDClvQyo1+hyTWjfLefqkYUmm6m9z9W2OVSqmg1il/Y38CFxzAsnjM5uiuu3wd 3KuvK6fgdA/o6kxK8PgVTWBDca0Z4HLijz6E/Sn3pb9yD8dJELtjXV7PLR0KbkJS7pYh c8Tzd5zOg8f9VtIy0VmO+qoMwCYK4aw6dWtxQlAPoyc4SBVl8wb2Kh/IxjNU/wUkSF2t CLY++UC4Ty+ELj5AxiPbgG63FY4Ow//7BP4U1GkduhBtSThoRyFOihM/f5szi2T7bL3B DWzg== X-Gm-Message-State: AO0yUKXtiDmQx8gK4Jy6NDBrrdkCzYjoDQmqXz9+9CeOf5x47aPbvYfi k1h/x/6LTOq10v6GW0PC/wKKp5gbqeS7Bl9PxDk= X-Google-Smtp-Source: AK7set+IUKK9tzzPVlhNLzpxw7e6QXgi8Si9QxetIZhZPNuGjkdCxGjG1Aq+32VGmSOdt+mXVZYAnw== X-Received: by 2002:a2e:9f44:0:b0:29b:767f:1421 with SMTP id v4-20020a2e9f44000000b0029b767f1421mr686870ljk.45.1679146984292; Sat, 18 Mar 2023 06:43:04 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:43:03 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:53 +0100 Subject: [PATCH v6 7/9] drm/msm/dsi: Remove custom DSI config handling MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-7-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=1730; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=F4fPirOHyMQPj35ost0pdi8esBWoDrjWNUljpExX+4U=; b=JQL4C8eZU9KdW70xgkVjmI9WYhpJRT9iemBV2gYY5kx+UgSGZNBtZXViYaamh9bBOeacUVPvECKx Hx3zj/elBCkSn/QqsBsTWvU8RPfp3CbFyjYsorJTAB5uakOYwph8 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Now that the only user is handled by common code, remove the option to specify custom handlers through match data. This is effectively a revert of commit: 5ae15e76271 ("drm/msm/dsi: Allow to specify dsi config as pdata") Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi.c | 4 ++-- drivers/gpu/drm/msm/dsi/dsi_host.c | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c index f761973e4cba..baab79ab6e74 100644 --- a/drivers/gpu/drm/msm/dsi/dsi.c +++ b/drivers/gpu/drm/msm/dsi/dsi.c @@ -172,10 +172,10 @@ static int dsi_dev_remove(struct platform_device *pde= v) } =20 static const struct of_device_id dt_match[] =3D { - { .compatible =3D "qcom,mdss-dsi-ctrl", .data =3D NULL /* autodetect cfg = */ }, + { .compatible =3D "qcom,mdss-dsi-ctrl" }, =20 /* Deprecated, don't use */ - { .compatible =3D "qcom,dsi-ctrl-6g-qcm2290", .data =3D NULL }, + { .compatible =3D "qcom,dsi-ctrl-6g-qcm2290" }, {} }; =20 diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/d= si_host.c index 9cfb9e91bfea..961689a255c4 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_host.c +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c @@ -214,10 +214,6 @@ static const struct msm_dsi_cfg_handler *dsi_get_confi= g( int ret; u32 major =3D 0, minor =3D 0; =20 - cfg_hnd =3D device_get_match_data(dev); - if (cfg_hnd) - return cfg_hnd; - ahb_clk =3D msm_clk_get(msm_host->pdev, "iface"); if (IS_ERR(ahb_clk)) { pr_err("%s: cannot get interface clock\n", __func__); --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD63C76195 for ; Sat, 18 Mar 2023 13:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbjCRNnk (ORCPT ); Sat, 18 Mar 2023 09:43:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjCRNnS (ORCPT ); Sat, 18 Mar 2023 09:43:18 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FCAE32CCC for ; Sat, 18 Mar 2023 06:43:08 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id f18so9769576lfa.3 for ; Sat, 18 Mar 2023 06:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146986; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U+jIZB+lOj7L713dwYSMYXhpa9ZO/qMAXKk3i/Uz2ak=; b=FzWZrHP16xKM/suGeskGqhufuiGNrR+wjzdZUs2SRtC9Sn2k3/kRWqsRrv32g1VTTB SW1uYciJCL1aDUBl3hdgBl4qPS6woupjb/jjFDDO0ms9t8TOCvmgGxZRG4Lalb2XCVSj toQ9ndNWqqu/PsPDeHEJYod0QjUP2jz2Zhu2x0o42nU9V1cU6j3pL5xMv3Dzub0SHHwe K0brJpS4DaRA8wEO8n57+XamMquBtcDSEaaG9O3SkOIwJo0hXFHDU7VPXxXEA7GDecaI tYIDqgZIBVMwJA8991R3UynxsA62Ge130WDC3S0yv9hwILh7AdbUSxuGAJTCpuJq/Hko BUgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146986; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U+jIZB+lOj7L713dwYSMYXhpa9ZO/qMAXKk3i/Uz2ak=; b=OblqkR5kZCL3iaAUM1EC2eAjNCBd8jLs7h4hk+mo1jrZtySv4ji+jH7UYldVavq+FA UFRuPeWWMv+JF3mX4l3TtYXMTEhEARrbFzFqHBqTmSz9QM03HnQtHvZopifI9rvwrtJD XC038YlUYJ5BWiHPThQH9bYw94NQpkE8lpOY71WlF2CZ7tO3oOFbOWNMxvzcH4IpH+TS NHLhGtcPmgFHSdpo2+xM/FTCKFFHAgfAdDS1/CuvgEmn7CUtgk+gRHPWGyxLtMAokkoy mFBTfnkEtbFJ0cI2dLp5NbFtE5PbvPTlMEYvOUClo4nEmPg+JW129FAtGrm2s2KmN7gV epXA== X-Gm-Message-State: AO0yUKXCgqla1PGukg/1pr2hr2/UdRkCd0C8koGsk65TSuErBt/PPM6z RL5nnd93P/chG/tdwF6ErOJaEg== X-Google-Smtp-Source: AK7set+hYmmfY91OTCZI8XgA/WZ+zAgYTLxr0qhrk1g8dSCRhvdGhXypnycKVt6y+Ok8/jAX6VF0zw== X-Received: by 2002:ac2:5deb:0:b0:4dc:81a3:c095 with SMTP id z11-20020ac25deb000000b004dc81a3c095mr5463529lfq.38.1679146985862; Sat, 18 Mar 2023 06:43:05 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:43:05 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:54 +0100 Subject: [PATCH v6 8/9] dt-bindings: display/msm: dsi-controller-main: Add SM6115 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-8-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=2355; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=TH3q3Ed2aw6dX9xtVNq6VpDwcDDpJoS9emOd9LF1Zus=; b=IEzuk0TI7uwZ53rvy74C1k+EIg8nf+j85wwtz+eHnVKNv9VaL+M4qtd5rZNbcp2H8mBdNFMZytxd 4nwFN9n7A8b1HfuGX6eiPEKz2RT7s9x6z1fwf5FdJ5ss5B6lElud X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add a compatible for the DSI on SM6115. Acked-by: Rob Herring Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 2 ++ .../devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml | 10 ++++++= ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-m= ain.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-mai= n.yaml index ecc89011bec4..c8884a84e73d 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -25,6 +25,7 @@ properties: - qcom,sc7280-dsi-ctrl - qcom,sdm660-dsi-ctrl - qcom,sdm845-dsi-ctrl + - qcom,sm6115-dsi-ctrl - qcom,sm8150-dsi-ctrl - qcom,sm8250-dsi-ctrl - qcom,sm8350-dsi-ctrl @@ -350,6 +351,7 @@ allOf: contains: enum: - qcom,sdm845-dsi-ctrl + - qcom,sm6115-dsi-ctrl then: properties: clocks: diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss= .yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml index 2491cb100b33..b9f83088f370 100644 --- a/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm6115-mdss.yaml @@ -40,7 +40,13 @@ patternProperties: type: object properties: compatible: - const: qcom,dsi-ctrl-6g-qcm2290 + oneOf: + - items: + - const: qcom,sm6115-dsi-ctrl + - const: qcom,mdss-dsi-ctrl + - description: Old binding, please don't use + deprecated: true + const: qcom,dsi-ctrl-6g-qcm2290 =20 "^phy@[0-9a-f]+$": type: object @@ -114,7 +120,7 @@ examples: }; =20 dsi@5e94000 { - compatible =3D "qcom,dsi-ctrl-6g-qcm2290"; + compatible =3D "qcom,sm6115-dsi-ctrl", "qcom,mdss-dsi-ctrl"; reg =3D <0x05e94000 0x400>; reg-names =3D "dsi_ctrl"; =20 --=20 2.39.2 From nobody Fri Apr 26 07:58:01 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A60FDC7618A for ; Sat, 18 Mar 2023 13:43:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229843AbjCRNnb (ORCPT ); Sat, 18 Mar 2023 09:43:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbjCRNnM (ORCPT ); Sat, 18 Mar 2023 09:43:12 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26C832E55 for ; Sat, 18 Mar 2023 06:43:07 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id h9so7815084ljq.2 for ; Sat, 18 Mar 2023 06:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679146987; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CSwnb94Mzw2MbHXtm3N1Had+b6g5bP1qhG7RvTv6VYM=; b=mp00CxlpC+bkTh9hYBnVlOXwYPkqGR9yuB8P+OvNJKo3xvEtWKUwHs4IbXFw2sX6la ToDNU237KBDMj6KmaIqeO9aslzfGjZ3LTNbygp4AfmbnKSJYP/59Li1NnlMKaVDCoN6o yuMqdUS24LTw5dsubgBUbhxgsjGZrBVBOnl+4JrLZevj8jTlfGpLWf68jaxhK9ZFWUpV 45M2iXZ+O7ra0hU/QFhKImpMFaivn7c/Hvn2oIBOTv0aSIszNwPWp4smKIJyL2v4XgEb eSWP3IULXLWZR9w2Rn9g/1ZhGCgkVuwZZMGGvzkrxGKGHiGtho0t6wiTdjt9lJ0zoJM1 QHfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679146987; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CSwnb94Mzw2MbHXtm3N1Had+b6g5bP1qhG7RvTv6VYM=; b=hAPPtPcGZMwyW14EeMEngjFDGH17OoHnqaoDBzVwD5zVLnE+dP47a8guRZREw/pRXn bXWlmzGe4ypeRFRsPDL9W21omf7sKLfIB+pC1JyzAkXTTXcVxNYEp+eLJMlgLYrt4LIW dHnruCnmBi6tiUZfOYyAWEgJygoXeCOijkHGNezK3dMMcN6sETt4bLS5gMHndLhGm1Fk NlfA0QxeT8lTq2pTMiY52zmb9ofssu9Bxl1t7ZLIiCoVofZ0Gl2yEgFz18dsLR161nTa dov77Nu+pIMkjc2xH2tQosXMszxmsu78whgOJNa+ghCs1ez6jhXMIVaf+pE9DTnaxify gyGg== X-Gm-Message-State: AO0yUKXR9zJWBSh1uu0bCIaBynhP/DZ7nlC4ZWhsfyi0/6lPeKcL2ruI YnHwDHXg6rLLip5y4k/EChd+5A== X-Google-Smtp-Source: AK7set/4S1W5CR/JHQZnR+6Nm46fF8jPG9ALj+09ucPpRDC2nMHbjBg9W9/P6bHYNoTP678GQbmbyQ== X-Received: by 2002:a05:651c:1a0a:b0:298:aada:99a4 with SMTP id by10-20020a05651c1a0a00b00298aada99a4mr5427625ljb.15.1679146987411; Sat, 18 Mar 2023 06:43:07 -0700 (PDT) Received: from [192.168.1.101] (abym238.neoplus.adsl.tpnet.pl. [83.9.32.238]) by smtp.gmail.com with ESMTPSA id c2-20020a2e9d82000000b0029a0b50a34asm888367ljj.36.2023.03.18.06.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 06:43:07 -0700 (PDT) From: Konrad Dybcio Date: Sat, 18 Mar 2023 14:42:55 +0100 Subject: [PATCH v6 9/9] arm64: dts: qcom: sm6115: Use the correct DSI compatible MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v6-9-70e13b1214fa@linaro.org> References: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v6-0-70e13b1214fa@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1679146971; l=835; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=TG72yG+FHoBCa8HzTOP2m4Zz/u5EM4iUM34Xg+mUMPo=; b=bzqbSxqJTBt3yGqTr/I3zYIXTWAXpQidX0CBQfgCGzZ+rFCB5HSPDbOq402ijR1rZFTBnYyMjPUz RjARwgnNAENPj7dkUeSVXV4dYPX1hCJeWkZ7aO/8yBaQyyXt59GZ X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use the non-deprecated, SoC-specific DSI compatible. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- arch/arm64/boot/dts/qcom/sm6115.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qco= m/sm6115.dtsi index c56738633431..fcf7497e8a15 100644 --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi @@ -1227,7 +1227,7 @@ opp-384000000 { }; =20 mdss_dsi0: dsi@5e94000 { - compatible =3D "qcom,dsi-ctrl-6g-qcm2290"; + compatible =3D "qcom,sm6115-dsi-ctrl", "qcom,mdss-dsi-ctrl"; reg =3D <0x0 0x05e94000 0x0 0x400>; reg-names =3D "dsi_ctrl"; =20 --=20 2.39.2