From nobody Sun Apr 12 16:03:36 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE002C6FD19 for ; Thu, 16 Mar 2023 08:53:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbjCPIxM (ORCPT ); Thu, 16 Mar 2023 04:53:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbjCPIw0 (ORCPT ); Thu, 16 Mar 2023 04:52:26 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1CA1B6D08 for ; Thu, 16 Mar 2023 01:51:22 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id h3so830731lja.12 for ; Thu, 16 Mar 2023 01:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678956677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=64Eim4J+wnLNg16H207185gsYiLvTQ9YXeAiDAajBeo=; b=eS1hKUn08srQeT2eu2FF7gbbO3jcCdcr/5mVnwzdoySrrWJ1dl6xMJevAayiXBCkVZ 92XfYle1RLyvbKuEUdJrYMQb7sfnuiMXzd3pFFvRV5nHjhIrQX7mn/rp6U0LnFytg4bh IMUdkrXsBEXQpWb1BOw+EKjYJfM2by1512/4vrWDMJKfAaQIsBGV1v9u0nqq8MLR8qve 5Zgn3ofb3jRflny4ysPHeFmyd7NiEF3UA0pOMOzda69FpWju6Xn3WBa6oh5005IKVnHu CcNZ+H/R5wh6KS2G2/Vdtop42sX6xCqXN+TplD/qDulHI/4ufFLC0SBqDxJB7nzciCNl IF9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678956677; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=64Eim4J+wnLNg16H207185gsYiLvTQ9YXeAiDAajBeo=; b=q2MNHyAE1quMBKaI4G2smZP3yYP6bYqVjCBo0vTKm/MwLOopno12977ZupdO3w0NjT pUe99JKAynjFmIZv9yFEADqVTv4mhurdbMGgVm/eSf6DWiAzlrIud8TJfJXoGJvWYo9b eL3R5iPuAeHxXqFYAWrBvm5Vc9l7JUIccpxCioMqOOSkgKBaLL3AF8bXO9GG+KrxTyjx w80UgOjUyZSVZgsCHQ3Y/Jy59/YKWPjJ6v8UBG4KYu0BZc1AZKXiqsMUH6KOUhhnKVTr 1TaJ0gsU7PUplTQECTZ/z2Ncv8Q8ETq+ZIOpaA3DhEtasBDNjPhc+9uwozwrCWtasF0x nwYg== X-Gm-Message-State: AO0yUKXP0G5s18/kIhmBQBJyaVwa8UklwyW9/WU3GOlebYhw/bQffeTT gECUPmpJDExX1O1HMNc27n+A+g== X-Google-Smtp-Source: AK7set/OYhtplnGmvpbqt5vLcWE6LbWCEW/iI9cvyoApEXMhkrGWwANF73fwDZu6ri1Y1aO3zpN4uw== X-Received: by 2002:a2e:9852:0:b0:299:2b6d:6e90 with SMTP id e18-20020a2e9852000000b002992b6d6e90mr781034ljj.34.1678956677021; Thu, 16 Mar 2023 01:51:17 -0700 (PDT) Received: from [192.168.1.101] (abyj16.neoplus.adsl.tpnet.pl. [83.9.29.16]) by smtp.gmail.com with ESMTPSA id o11-20020a2e730b000000b002991baef49bsm251566ljc.12.2023.03.16.01.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Mar 2023 01:51:16 -0700 (PDT) From: Konrad Dybcio Date: Thu, 16 Mar 2023 09:51:10 +0100 Subject: [PATCH v5 04/10] drm/msm/dsi: dsi_cfg: Deduplicate identical structs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230307-topic-dsi_qcm-v5-4-9d4235b77f4f@linaro.org> References: <20230307-topic-dsi_qcm-v5-0-9d4235b77f4f@linaro.org> In-Reply-To: <20230307-topic-dsi_qcm-v5-0-9d4235b77f4f@linaro.org> To: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Krishna Manikandan , Bryan O'Donoghue , Andy Gross , Bjorn Andersson Cc: Rob Herring , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Marijn Suijten , Konrad Dybcio X-Mailer: b4 0.12.1 X-Developer-Signature: v=1; a=ed25519-sha256; t=1678956668; l=7014; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=eQGewel5eMIUbnjRWU8o9jYKXbfa44urQPoDhCO0rnI=; b=SsPYU6abTVgFrbgo+KmZ3KUlWvIvCkRzHRqXpGGxJP3ioxboCZ3VUBwS49B5NBlATDvaco/QY//Y 39+um3miCRM/+8hPOjohWTzZ/8j/icTCsUhI3Vw/TwKKkybQKh08 X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some structs were defined multiple times for no apparent reason. Deduplicate them. Reviewed-by: Dmitry Baryshkov Reviewed-by: Marijn Suijten Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 93 +++++++++++++----------------------= ---- 1 file changed, 30 insertions(+), 63 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/ds= i_cfg.c index 6c192963c100..039f503233d7 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -47,41 +47,32 @@ static const struct msm_dsi_config msm8974_apq8084_dsi_= cfg =3D { }, }; =20 -static const char * const dsi_8916_bus_clk_names[] =3D { +static const char * const dsi_v1_3_1_clk_names[] =3D { "mdp_core", "iface", "bus", }; =20 -static const struct regulator_bulk_data msm8916_dsi_regulators[] =3D { +static const struct regulator_bulk_data dsi_v1_3_1_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 100000 }, /* 1.2 V */ { .supply =3D "vddio", .init_load_uA =3D 100000 }, /* 1.8 V */ }; =20 static const struct msm_dsi_config msm8916_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D msm8916_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(msm8916_dsi_regulators), - .bus_clk_names =3D dsi_8916_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_8916_bus_clk_names), + .regulator_data =3D dsi_v1_3_1_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v1_3_1_regulators), + .bus_clk_names =3D dsi_v1_3_1_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v1_3_1_clk_names), .io_start =3D { { 0x1a98000 }, }, }; =20 -static const char * const dsi_8976_bus_clk_names[] =3D { - "mdp_core", "iface", "bus", -}; - -static const struct regulator_bulk_data msm8976_dsi_regulators[] =3D { - { .supply =3D "vdda", .init_load_uA =3D 100000 }, /* 1.2 V */ - { .supply =3D "vddio", .init_load_uA =3D 100000 }, /* 1.8 V */ -}; - static const struct msm_dsi_config msm8976_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D msm8976_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(msm8976_dsi_regulators), - .bus_clk_names =3D dsi_8976_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_8976_bus_clk_names), + .regulator_data =3D dsi_v1_3_1_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v1_3_1_regulators), + .bus_clk_names =3D dsi_v1_3_1_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v1_3_1_clk_names), .io_start =3D { { 0x1a94000, 0x1a96000 }, }, @@ -107,10 +98,6 @@ static const struct msm_dsi_config msm8994_dsi_cfg =3D { }, }; =20 -static const char * const dsi_8996_bus_clk_names[] =3D { - "mdp_core", "iface", "bus", "core_mmss", -}; - static const struct regulator_bulk_data msm8996_dsi_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 18160 }, /* 1.25 V */ { .supply =3D "vcca", .init_load_uA =3D 17000 }, /* 0.925 V */ @@ -121,8 +108,8 @@ static const struct msm_dsi_config msm8996_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, .regulator_data =3D msm8996_dsi_regulators, .num_regulators =3D ARRAY_SIZE(msm8996_dsi_regulators), - .bus_clk_names =3D dsi_8996_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_8996_bus_clk_names), + .bus_clk_names =3D dsi_6g_bus_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_6g_bus_clk_names), .io_start =3D { { 0x994000, 0x996000 }, }, @@ -167,24 +154,20 @@ static const struct msm_dsi_config sdm660_dsi_cfg =3D= { }, }; =20 -static const char * const dsi_sdm845_bus_clk_names[] =3D { +static const char * const dsi_v2_4_clk_names[] =3D { "iface", "bus", }; =20 -static const char * const dsi_sc7180_bus_clk_names[] =3D { - "iface", "bus", -}; - -static const struct regulator_bulk_data sdm845_dsi_regulators[] =3D { +static const struct regulator_bulk_data dsi_v2_4_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 21800 }, /* 1.2 V */ }; =20 static const struct msm_dsi_config sdm845_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D sdm845_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(sdm845_dsi_regulators), - .bus_clk_names =3D dsi_sdm845_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), + .regulator_data =3D dsi_v2_4_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000, 0xae96000 }, }, @@ -198,32 +181,24 @@ static const struct msm_dsi_config sm8550_dsi_cfg =3D= { .io_offset =3D DSI_6G_REG_SHIFT, .regulator_data =3D sm8550_dsi_regulators, .num_regulators =3D ARRAY_SIZE(sm8550_dsi_regulators), - .bus_clk_names =3D dsi_sdm845_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sdm845_bus_clk_names), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000, 0xae96000 }, }, }; =20 -static const struct regulator_bulk_data sc7180_dsi_regulators[] =3D { - { .supply =3D "vdda", .init_load_uA =3D 21800 }, /* 1.2 V */ -}; - static const struct msm_dsi_config sc7180_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D sc7180_dsi_regulators, - .num_regulators =3D ARRAY_SIZE(sc7180_dsi_regulators), - .bus_clk_names =3D dsi_sc7180_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sc7180_bus_clk_names), + .regulator_data =3D dsi_v2_4_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000 }, }, }; =20 -static const char * const dsi_sc7280_bus_clk_names[] =3D { - "iface", "bus", -}; - static const struct regulator_bulk_data sc7280_dsi_regulators[] =3D { { .supply =3D "vdda", .init_load_uA =3D 8350 }, /* 1.2 V */ }; @@ -232,27 +207,19 @@ static const struct msm_dsi_config sc7280_dsi_cfg =3D= { .io_offset =3D DSI_6G_REG_SHIFT, .regulator_data =3D sc7280_dsi_regulators, .num_regulators =3D ARRAY_SIZE(sc7280_dsi_regulators), - .bus_clk_names =3D dsi_sc7280_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_sc7280_bus_clk_names), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0xae94000, 0xae96000 }, }, }; =20 -static const char * const dsi_qcm2290_bus_clk_names[] =3D { - "iface", "bus", -}; - -static const struct regulator_bulk_data qcm2290_dsi_cfg_regulators[] =3D { - { .supply =3D "vdda", .init_load_uA =3D 21800 }, /* 1.2 V */ -}; - static const struct msm_dsi_config qcm2290_dsi_cfg =3D { .io_offset =3D DSI_6G_REG_SHIFT, - .regulator_data =3D qcm2290_dsi_cfg_regulators, - .num_regulators =3D ARRAY_SIZE(qcm2290_dsi_cfg_regulators), - .bus_clk_names =3D dsi_qcm2290_bus_clk_names, - .num_bus_clks =3D ARRAY_SIZE(dsi_qcm2290_bus_clk_names), + .regulator_data =3D dsi_v2_4_regulators, + .num_regulators =3D ARRAY_SIZE(dsi_v2_4_regulators), + .bus_clk_names =3D dsi_v2_4_clk_names, + .num_bus_clks =3D ARRAY_SIZE(dsi_v2_4_clk_names), .io_start =3D { { 0x5e94000 }, }, --=20 2.39.2