From nobody Thu Nov 14 06:28:59 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA421C61DA4 for ; Mon, 6 Mar 2023 07:35:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229808AbjCFHfI (ORCPT ); Mon, 6 Mar 2023 02:35:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229771AbjCFHfD (ORCPT ); Mon, 6 Mar 2023 02:35:03 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37322EB63 for ; Sun, 5 Mar 2023 23:35:02 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008Ot-6m; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002C0p-Iz; Mon, 06 Mar 2023 08:34:55 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N0-002bap-Ts; Mon, 06 Mar 2023 08:34:54 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Mauro Carvalho Chehab , Stephen Boyd Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 1/3] spmi: hisi-spmi-controller: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:44 +0100 Message-Id: <20230306073446.2194048-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1769; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=x46iUoVgDIkav2eWjEW3fVwWqvRPWVkTe9JpC8hEs6g=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeKumnzDEGS3cNKpPSgFIsbr4ESrKdUuOXs/ wj2cK5zxUaJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXigAKCRDB/BR4rcrs CaeNCACNimmydFtC9/L6aAebZ10gGzFctSiRYpMUXHe6JH2e9I6Ol6C/p0Ijg4HjV1NAYeud/A0 9UQWbay91553sz82s8dXIQaJ5bLBYFgVMThRG6JupwkhpF+b4Tiyt7iSocLK6dMqPKut3Vs+JDt pifCSelGFKjbCAcSPqtLi2uSSuBKwowm+xutjSH6SoGjCQgJfEuPg/3qPoWXRmQUoVfk9j1a1Gh L2em8drjYf1bnOC5zOwlMorTI2sAClCBaz1ToIdH7gvs9vFWyPMg8WxtcoD9PQGKrZ8fAYudzrK Q8tjIgpWXxvGg3rVV+vDQaE7AVmPHDspR7NrCVOvU7b8m8mS X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/spmi/hisi-spmi-controller.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/hisi-spmi-controller.c b/drivers/spmi/hisi-spmi-c= ontroller.c index 5bd23262abd6..9cbd473487cb 100644 --- a/drivers/spmi/hisi-spmi-controller.c +++ b/drivers/spmi/hisi-spmi-controller.c @@ -324,13 +324,12 @@ static int spmi_controller_probe(struct platform_devi= ce *pdev) return ret; } =20 -static int spmi_del_controller(struct platform_device *pdev) +static void spmi_del_controller(struct platform_device *pdev) { struct spmi_controller *ctrl =3D platform_get_drvdata(pdev); =20 spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } =20 static const struct of_device_id spmi_controller_match_table[] =3D { @@ -343,7 +342,7 @@ MODULE_DEVICE_TABLE(of, spmi_controller_match_table); =20 static struct platform_driver spmi_controller_driver =3D { .probe =3D spmi_controller_probe, - .remove =3D spmi_del_controller, + .remove_new =3D spmi_del_controller, .driver =3D { .name =3D "hisi_spmi_controller", .of_match_table =3D spmi_controller_match_table, --=20 2.39.1 From nobody Thu Nov 14 06:28:59 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D13A7C678D4 for ; Mon, 6 Mar 2023 07:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbjCFHfE (ORCPT ); Mon, 6 Mar 2023 02:35:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39024 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjCFHfA (ORCPT ); Mon, 6 Mar 2023 02:35:00 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC1A2E388 for ; Sun, 5 Mar 2023 23:34:59 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008Ou-ND; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002C0t-Sx; Mon, 06 Mar 2023 08:34:55 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002bas-4i; Mon, 06 Mar 2023 08:34:55 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Stephen Boyd , Matthias Brugger Cc: AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/3] spmi: mtk-pmif: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:45 +0100 Message-Id: <20230306073446.2194048-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1827; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5a+AWwYSnblGSgN1CjlLhD5ySXt5UsbCdNXjzOaMDCo=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeNw+Op0YHpL7jeNZglJdgk4+HUUAM9Syky4 ZopRHF9SD6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXjQAKCRDB/BR4rcrs CRFuB/4rWilHuRqmsO6Tvne6ucKbjyP6e/oEpCNTWXJi4wAQWy/PA01KR1+U4isqwbFlNKhj7MA 6ZzMRG7JvPk4LMS2YiKoyNCMTsBpibuaptG5ltsCFYUQ+/3PMyp7E9Kcgpec516fuIzGQFHEfRK D+pFr7HQCuxvrtD/bq/M72MaWx3efZecUWPJPYKYSJnoBAuN5hrdJtme7HPk2F6+jZcTIysvkh1 P7gklleW9mNP1MRoeLgwiR4D246K8biZWLVsck6rihhzWDwyqWHpH6Jvsmk7TNtVcPPM6BBNzKm RQcw6r/w9FU222K3hwnXdWfUtd618Wppjt7aJInqUfWyDP45 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: AngeloGioacchino Del Regno --- drivers/spmi/spmi-mtk-pmif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index ad511f2c3324..fbcb3921e70c 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -503,7 +503,7 @@ static int mtk_spmi_probe(struct platform_device *pdev) return err; } =20 -static int mtk_spmi_remove(struct platform_device *pdev) +static void mtk_spmi_remove(struct platform_device *pdev) { struct spmi_controller *ctrl =3D platform_get_drvdata(pdev); struct pmif *arb =3D spmi_controller_get_drvdata(ctrl); @@ -511,7 +511,6 @@ static int mtk_spmi_remove(struct platform_device *pdev) clk_bulk_disable_unprepare(arb->nclks, arb->clks); spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } =20 static const struct of_device_id mtk_spmi_match_table[] =3D { @@ -533,7 +532,7 @@ static struct platform_driver mtk_spmi_driver =3D { .of_match_table =3D of_match_ptr(mtk_spmi_match_table), }, .probe =3D mtk_spmi_probe, - .remove =3D mtk_spmi_remove, + .remove_new =3D mtk_spmi_remove, }; module_platform_driver(mtk_spmi_driver); =20 --=20 2.39.1 From nobody Thu Nov 14 06:28:59 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4E0C61DA4 for ; Mon, 6 Mar 2023 07:35:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbjCFHfB (ORCPT ); Mon, 6 Mar 2023 02:35:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjCFHe7 (ORCPT ); Mon, 6 Mar 2023 02:34:59 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B0F1DBFA for ; Sun, 5 Mar 2023 23:34:58 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008P1-MR; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N2-002C0w-2o; Mon, 06 Mar 2023 08:34:56 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002bav-Bi; Mon, 06 Mar 2023 08:34:55 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/3] spmi: pmic-arb: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:46 +0100 Message-Id: <20230306073446.2194048-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1945; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=baC8Vc/YYIcpg5sQZ20fOmFcBz45wH3J4Jd35FckU7k=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeRp+KOukWfnCDPaNKuarCheUCsR4j1f92CH 4fGT4kzvDeJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXkQAKCRDB/BR4rcrs CelrB/90x7/EalnevrxJZcp1D/0ZVT9Qwb22O7hv3KGfzxwXX+MNYARa1UkQRRESCFg/oMaykPC goVnkcez3yqNT8HCqOxInLxi5eI+yC1Rku0v4TevyrGeFGmpIiwb72WfL+A1vEiYJsXHbv1zX3g WwL8W7emEcTfMFnp3TJTtqz9I7r+kiEdCvvSV7lPvwODFyMsa1+kW4N9KnCvt358Y5hMOIbIgPM m65LMVO7D98Ws5pBzj7gACTCTuQvSrOIKhoDuMnEjNwGfa8BrmyQ1OAXXeJGbRTTtQj9ipQPaJ7 uN0IqJWcPIrH/8upCp3LZqB5daygZaQb/Fe03pblg6s9WeuZ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/spmi/spmi-pmic-arb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 8b6a42ab816f..42a593418aad 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1674,7 +1674,7 @@ static int spmi_pmic_arb_probe(struct platform_device= *pdev) return err; } =20 -static int spmi_pmic_arb_remove(struct platform_device *pdev) +static void spmi_pmic_arb_remove(struct platform_device *pdev) { struct spmi_controller *ctrl =3D platform_get_drvdata(pdev); struct spmi_pmic_arb *pmic_arb =3D spmi_controller_get_drvdata(ctrl); @@ -1682,7 +1682,6 @@ static int spmi_pmic_arb_remove(struct platform_devic= e *pdev) irq_set_chained_handler_and_data(pmic_arb->irq, NULL, NULL); irq_domain_remove(pmic_arb->domain); spmi_controller_put(ctrl); - return 0; } =20 static const struct of_device_id spmi_pmic_arb_match_table[] =3D { @@ -1693,7 +1692,7 @@ MODULE_DEVICE_TABLE(of, spmi_pmic_arb_match_table); =20 static struct platform_driver spmi_pmic_arb_driver =3D { .probe =3D spmi_pmic_arb_probe, - .remove =3D spmi_pmic_arb_remove, + .remove_new =3D spmi_pmic_arb_remove, .driver =3D { .name =3D "spmi_pmic_arb", .of_match_table =3D spmi_pmic_arb_match_table, --=20 2.39.1