From nobody Sat Apr 11 08:27:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D235C6FA8E for ; Sat, 4 Mar 2023 04:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229758AbjCDETu (ORCPT ); Fri, 3 Mar 2023 23:19:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229565AbjCDETn (ORCPT ); Fri, 3 Mar 2023 23:19:43 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 407E71259B for ; Fri, 3 Mar 2023 20:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677903582; x=1709439582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=xvEmsWuughcRdW3oGFQ5VdryPdej8zL62swUuDZTanw=; b=engCTQj2R9x0Q22X8Vgse2w7zPaAFGK2vfXALHnSLwgLJRutPMfrPfkO MR4UEl0rhBpwuxtj8I19f7oLs6DE1vwcQtS1gUjBEvzhQy91xFAlUBjvu EInGUSW4ZJxF94qUfvtTEgCsVYfFx3DpqV78eJbYMy9Hlq5vcblDgwWwV SGnMeE+thTk1Ny+tBm/dPLA9/wUComKln+i5sy82h70vByMyfzD3FjfCs clNtAkA6pK4Qyq8VkSzI+FKM2raR54wG9OgKrBXxaVIx/nVqJJZ6xNa5V Gl4n9l1z+HabPR2lIgQ8IzA4lJF0g7tdCI0ZYfa8Nb+CSIOMrWVjWCVQW w==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="315618085" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="315618085" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 20:19:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="708062006" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="708062006" Received: from tdx-lm.sh.intel.com ([10.239.53.27]) by orsmga001.jf.intel.com with ESMTP; 03 Mar 2023 20:19:37 -0800 From: Wei Wang To: arnd@arndb.de, akpm@linux-foundation.org, keescook@chromium.org, herbert@gondor.apana.org.au, josh@joshtriplett.org, jani.nikula@intel.com, corbet@lwn.net, jgg@mellanox.com, dmatlack@google.com, mizhang@google.com, pbonzini@redhat.com, seanjc@google.com Cc: linux-kernel@vger.kernel.org, Wei Wang , James.Bottomley@HansenPartnership.com, jarkko@kernel.org Subject: [PATCH v1 1/3] security: keys: don't use data type as variable name Date: Sat, 4 Mar 2023 12:19:30 +0800 Message-Id: <20230304041932.847133-2-wei.w.wang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230304041932.847133-1-wei.w.wang@intel.com> References: <20230304041932.847133-1-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'bool' is a specific name for the data type that is an alias for the C99 _Bool type. It shoudn't be used as variable names as that causes too much confusion either for the reader or the compilier. CC: James.Bottomley@HansenPartnership.com CC: jarkko@kernel.org Fixes: f2219745250f ("security: keys: trusted: use ASN.1 TPM2 key format fo= r the blobs") Signed-off-by: Wei Wang Reviewed-by: Jarkko Sakkinen --- security/keys/trusted-keys/trusted_tpm2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trus= ted-keys/trusted_tpm2.c index 2b2c8eb258d5..390d7314f5a6 100644 --- a/security/keys/trusted-keys/trusted_tpm2.c +++ b/security/keys/trusted-keys/trusted_tpm2.c @@ -54,12 +54,13 @@ static int tpm2_key_encode(struct trusted_key_payload *= payload, asn1_oid_len(tpm2key_oid)); =20 if (options->blobauth_len =3D=3D 0) { - unsigned char bool[3], *w =3D bool; + unsigned char bool_val[3], *w =3D bool_val; /* tag 0 is emptyAuth */ w =3D asn1_encode_boolean(w, w + sizeof(bool), true); if (WARN(IS_ERR(w), "BUG: Boolean failed to encode")) return PTR_ERR(w); - work =3D asn1_encode_tag(work, end_work, 0, bool, w - bool); + work =3D asn1_encode_tag(work, end_work, 0, + bool_val, w - bool_val); } =20 /* --=20 2.27.0 From nobody Sat Apr 11 08:27:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA3B6C6FA99 for ; Sat, 4 Mar 2023 04:19:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbjCDETx (ORCPT ); Fri, 3 Mar 2023 23:19:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbjCDETr (ORCPT ); Fri, 3 Mar 2023 23:19:47 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE50D126EA for ; Fri, 3 Mar 2023 20:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677903585; x=1709439585; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IcgtldqkfkE6eHD67FeLCamBoKCMzTV2qNFng33ppWw=; b=bhgfJNBuZNt8h0hX5EEB9fRvMmF8zlAMFHVZ3YmP7ib4gdq2h4EyD1fY 6QwbcG3D0lAy9M47X41xjZhsrzO4Rp0ROudSMFQfIMcgUXu/JWocqffOg 9weHm+PslQMagB97GeTC2IzT+y9GQVbuDvl6E+DtN9qxgtZ7YOkWx1daW Nhg/Anu0075Oi//tGrQdiI/u5O2TMGRE0uJLFWnTLR9KHUbhq6V37BPJG MRiOEV54rhCYxy0gDOf1R1ntq0Zng0qaZ9jNgV3RPZtT29XmjR7DLOuJv Kl8pPHLXhoY8EwgHygvzqLloMoi0oinUKKf3ZdG1VIzTYeRA6HtbUHeJu A==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="315618100" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="315618100" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 20:19:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="708062010" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="708062010" Received: from tdx-lm.sh.intel.com ([10.239.53.27]) by orsmga001.jf.intel.com with ESMTP; 03 Mar 2023 20:19:42 -0800 From: Wei Wang To: arnd@arndb.de, akpm@linux-foundation.org, keescook@chromium.org, herbert@gondor.apana.org.au, josh@joshtriplett.org, jani.nikula@intel.com, corbet@lwn.net, jgg@mellanox.com, dmatlack@google.com, mizhang@google.com, pbonzini@redhat.com, seanjc@google.com Cc: linux-kernel@vger.kernel.org, Wei Wang Subject: [PATCH v1 2/3] Documentation/CodingStyle: do not use data type names as variable names Date: Sat, 4 Mar 2023 12:19:31 +0800 Message-Id: <20230304041932.847133-3-wei.w.wang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230304041932.847133-1-wei.w.wang@intel.com> References: <20230304041932.847133-1-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Observed some merged code uses "bool" as variable name. This is confusion either for the reader or compilier. Add a rule to have programmers avoid using data types as variable names. Signed-off-by: Wei Wang --- Documentation/process/coding-style.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/process/coding-style.rst b/Documentation/process= /coding-style.rst index 007e49ef6cec..6d7f4069d55d 100644 --- a/Documentation/process/coding-style.rst +++ b/Documentation/process/coding-style.rst @@ -356,6 +356,9 @@ specification that mandates those terms. For new specif= ications translate specification usage of the terminology to the kernel coding standard where possible. =20 +"bool", "int", "long" etc. are specific names for data types, C +programmers should not use them as variable names. + 5) Typedefs ----------- =20 --=20 2.27.0 From nobody Sat Apr 11 08:27:38 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B155C678D5 for ; Sat, 4 Mar 2023 04:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbjCDEUB (ORCPT ); Fri, 3 Mar 2023 23:20:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229756AbjCDETu (ORCPT ); Fri, 3 Mar 2023 23:19:50 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9341A19F35 for ; Fri, 3 Mar 2023 20:19:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677903589; x=1709439589; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pd8dhXsOYVnMcYaWLAlR4eqh0jn5NMv7qu4K0qUhvcU=; b=aOf30N78IrFHtDyfM5pc47f/xxt/8k5+pMAkRzRNTZqPGcIT2VDEAWCM Uapts8h2Y56sxaisn81A383aPNfKLGMSfNnKW/R31iVaE08J9nDPBJVWY 3m5TjOsL83ixUEZEF1zkxR+i0XKanVeNvgTYRdfD3vlT78SNEDfgqPxyF FN+JG1WuFAK7GA7nUDHXzg1Jc2aS+hDOdBrWvW4O+FvUgu/fw7o4PftsN K43r0oAHLD6fsQ3Z0hbFnVRSVFSBHGUOMwUct3EK06SkPY0DR4K6AkBGx k7Mz+L3KTys6BrumqNTKMOaHdT7YJC1tpjxvTwcZmTm1WYBlGufbeToxq A==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="315618117" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="315618117" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 20:19:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="708062015" X-IronPort-AV: E=Sophos;i="5.98,232,1673942400"; d="scan'208";a="708062015" Received: from tdx-lm.sh.intel.com ([10.239.53.27]) by orsmga001.jf.intel.com with ESMTP; 03 Mar 2023 20:19:45 -0800 From: Wei Wang To: arnd@arndb.de, akpm@linux-foundation.org, keescook@chromium.org, herbert@gondor.apana.org.au, josh@joshtriplett.org, jani.nikula@intel.com, corbet@lwn.net, jgg@mellanox.com, dmatlack@google.com, mizhang@google.com, pbonzini@redhat.com, seanjc@google.com Cc: linux-kernel@vger.kernel.org, Wei Wang Subject: [PATCH v1 3/3] bug: use bool for __ret_warn_on in WARN/WARN_ON Date: Sat, 4 Mar 2023 12:19:32 +0800 Message-Id: <20230304041932.847133-4-wei.w.wang@intel.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20230304041932.847133-1-wei.w.wang@intel.com> References: <20230304041932.847133-1-wei.w.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" coding-style.rst documents below: bool function return types and stack variables are always fine to use whenever appropriate. Use of bool is encouraged to improve readability and is often a better option than 'int' for storing boolean values. __ret_warn_on is essentially used as boolean in WARN/WARN_ON, so change its definition from 'int' to 'bool'. Signed-off-by: Wei Wang --- include/asm-generic/bug.h | 12 ++++++------ tools/include/asm/bug.h | 10 +++++----- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h index 4050b191e1a9..3a316be73f0e 100644 --- a/include/asm-generic/bug.h +++ b/include/asm-generic/bug.h @@ -107,7 +107,7 @@ extern __printf(1, 2) void __warn_printk(const char *fm= t, ...); instrumentation_end(); \ } while (0) #define WARN_ON_ONCE(condition) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN_FLAGS(BUGFLAG_ONCE | \ BUGFLAG_TAINT(TAINT_WARN)); \ @@ -119,7 +119,7 @@ extern __printf(1, 2) void __warn_printk(const char *fm= t, ...); =20 #ifndef WARN_ON #define WARN_ON(condition) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN(); \ unlikely(__ret_warn_on); \ @@ -128,7 +128,7 @@ extern __printf(1, 2) void __warn_printk(const char *fm= t, ...); =20 #ifndef WARN #define WARN(condition, format...) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN_printf(TAINT_WARN, format); \ unlikely(__ret_warn_on); \ @@ -136,7 +136,7 @@ extern __printf(1, 2) void __warn_printk(const char *fm= t, ...); #endif =20 #define WARN_TAINT(condition, taint, format...) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN_printf(taint, format); \ unlikely(__ret_warn_on); \ @@ -164,14 +164,14 @@ extern __printf(1, 2) void __warn_printk(const char *= fmt, ...); =20 #ifndef HAVE_ARCH_WARN_ON #define WARN_ON(condition) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ unlikely(__ret_warn_on); \ }) #endif =20 #ifndef WARN #define WARN(condition, format...) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ no_printk(format); \ unlikely(__ret_warn_on); \ }) diff --git a/tools/include/asm/bug.h b/tools/include/asm/bug.h index 550223f0a6e6..c1f72071303b 100644 --- a/tools/include/asm/bug.h +++ b/tools/include/asm/bug.h @@ -8,14 +8,14 @@ #define __WARN_printf(arg...) do { fprintf(stderr, arg); } while (0) =20 #define WARN(condition, format...) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN_printf(format); \ unlikely(__ret_warn_on); \ }) =20 #define WARN_ON(condition) ({ \ - int __ret_warn_on =3D !!(condition); \ + bool __ret_warn_on =3D !!(condition); \ if (unlikely(__ret_warn_on)) \ __WARN_printf("assertion failed at %s:%d\n", \ __FILE__, __LINE__); \ @@ -23,8 +23,8 @@ }) =20 #define WARN_ON_ONCE(condition) ({ \ - static int __warned; \ - int __ret_warn_once =3D !!(condition); \ + static bool __warned; \ + bool __ret_warn_once =3D !!(condition); \ \ if (unlikely(__ret_warn_once && !__warned)) { \ __warned =3D true; \ @@ -35,7 +35,7 @@ =20 #define WARN_ONCE(condition, format...) ({ \ static int __warned; \ - int __ret_warn_once =3D !!(condition); \ + bool __ret_warn_once =3D !!(condition); \ \ if (unlikely(__ret_warn_once)) \ if (WARN(!__warned, format)) \ --=20 2.27.0