From nobody Sat Apr 11 05:39:25 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B16C6C7EE23 for ; Wed, 1 Mar 2023 21:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229494AbjCAVys (ORCPT ); Wed, 1 Mar 2023 16:54:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229445AbjCAVyq (ORCPT ); Wed, 1 Mar 2023 16:54:46 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78E8C18A8B for ; Wed, 1 Mar 2023 13:54:45 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id eg37so59685328edb.12 for ; Wed, 01 Mar 2023 13:54:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677707684; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=b0zJx89rfTELdYNbGB67wBjBgKXyCkkaq+sJ4qdy1og=; b=jswc3DMkk0426qSQmx5Zjjzc994E/G+dahV+f75JwdlXAV98BmkOA8LQ5/AsVGU+Hy 6fEGkqqE83vGKSiMrKxXveIe/u3vEj2xkzlPzVZjBGqmoUGBp/iDOxnZ3+el+Ii0pjmv HTB6ES5nU7yMYH9NFqx+aczOmdp57LNhQHjZ20uhh4l64DQh+kKcsi85kNB6JphOaana SZT0l3hWePyXO1+XykacVV0E4wAY9ju7+G6NnBNVIdNz2jVGJ55YvqXj0y/NL5LYWP1Q 1XzxScP2P7gp3osHOvWp8O7FejLdmKOFodXmaGlUyQgK4zsV4Rnj3/ghl2FN1yTUBBKz a5Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677707684; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=b0zJx89rfTELdYNbGB67wBjBgKXyCkkaq+sJ4qdy1og=; b=GeyKjpLFj6ABPJAzfNQqoDCweAOuDzlSBng0ufQHMhuq48b48XUCknhylI9NN7Xnkf G4GNxwcdTkVRbNRZFwU1b9rKz5s5FTNcIb3NF7qjW0J5ur6q8kYLgKHiM8jQq0ChVjY0 oruzEfr7rGqkMwvV3Y+ThPH4UwG/kvBBfONzuUN7oRvQTXv34FGQvdpsUiQri0SbiPQc 5wj88JDb7wZKb28uAmEhOuhWcLoHy8eyIFRVRoUmPz/X6qb0Q0rizWTpB7ZzRB/3g8Rb 8yBM2UaqskWZSV7On1Pre0u7yXtNPNgp8VbhQftSYilf1HP+0rkPOHD7FUTwjJp1oDBD HJjg== X-Gm-Message-State: AO0yUKUCY+WAvvQN7/qYQnbH043moDa2n5qP1RVOSl7t+nx49aEVEWiz dkhQtnVPGcYy4icjcu44spQ= X-Google-Smtp-Source: AK7set/5eYdTMz7sAdBJfM/DXo+o39OJnj9v29w//m67DhEG7gaIfwDXGNpArRQFaJEcIgOtJJWw4g== X-Received: by 2002:a17:906:3f44:b0:88f:1255:59c with SMTP id f4-20020a1709063f4400b0088f1255059cmr8232235ejj.1.1677707683785; Wed, 01 Mar 2023 13:54:43 -0800 (PST) Received: from matrix-ESPRIMO-P710 (p57935146.dip0.t-ipconnect.de. [87.147.81.70]) by smtp.gmail.com with ESMTPSA id c15-20020a170906340f00b008e7916f0bdesm6282232ejb.138.2023.03.01.13.54.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 13:54:43 -0800 (PST) Date: Wed, 1 Mar 2023 22:54:41 +0100 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8192e: Remove call_usermodehelper starting RadioPower.sh Message-ID: <20230301215441.GA14049@matrix-ESPRIMO-P710> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove call_usermodehelper starting /etc/acpi/events/RadioPower.sh that is not available. This script is not part of the kernel and it is not officially available on the www. The result is that this lines are just dead code. Signed-off-by: Philipp Hortmann --- I found a hint in this blog about the content of the script: https://github.com/Dekadencee/rtl8187-Linux-Driver/blob/master/ReadMe If you know more about the purpose and the need for this script please respond. Tested with rtl8192e Transferred this patch over wlan connection of rtl8192e --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index c04eb15c4044..d8408acfc763 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -1637,10 +1637,6 @@ static void _rtl92e_dm_check_rf_ctrl_gpio(void *data) u8 tmp1byte; enum rt_rf_power_state rf_power_state_to_set; bool bActuallySet =3D false; - char *argv[3]; - static const char RadioPowerPath[] =3D "/etc/acpi/events/RadioPower.sh"; - static char *envp[] =3D {"HOME=3D/", "TERM=3Dlinux", "PATH=3D/usr/bin:/bi= n", - NULL}; =20 bActuallySet =3D false; =20 @@ -1670,14 +1666,6 @@ static void _rtl92e_dm_check_rf_ctrl_gpio(void *data) mdelay(1000); priv->hw_rf_off_action =3D 1; rtl92e_set_rf_state(dev, rf_power_state_to_set, RF_CHANGE_BY_HW); - if (priv->hw_radio_off) - argv[1] =3D "RFOFF"; - else - argv[1] =3D "RFON"; - - argv[0] =3D (char *)RadioPowerPath; - argv[2] =3D NULL; - call_usermodehelper(RadioPowerPath, argv, envp, UMH_WAIT_PROC); } } =20 --=20 2.39.2