From nobody Mon Sep 8 16:15:19 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A34F6C64ED6 for ; Mon, 27 Feb 2023 16:01:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbjB0QBY (ORCPT ); Mon, 27 Feb 2023 11:01:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbjB0QBW (ORCPT ); Mon, 27 Feb 2023 11:01:22 -0500 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF15220571 for ; Mon, 27 Feb 2023 08:01:20 -0800 (PST) Received: by mail-pj1-x102c.google.com with SMTP id c23so6602910pjo.4 for ; Mon, 27 Feb 2023 08:01:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gjTwJPBli3bVW7BSYmp/MLmUOGFtVANWMeLDc2BTS7w=; b=KOw+Ok8UcEGfwBWBgnnHrAWBMI1r7rJJHiaHQDQ43lJyLYMIHvYoTfg0+MQwxJHiDM +VO1VcVrmP+Y2FYaLPfAw0CZhr3H5h0PcJ3nMkrXe/eulXo2oRdEsk/ycpUSRqBqR/UD Ap5dzfWZADqmvPXDK1Uq1ct72gdykfdnZnf+h2PeLibYxsFRqpIkyF4Eu20Ti+sFkByy QkWAk1mDwv4ss204gpkp05SMKpiQfXcUw8hDSmmCOsJP99EdP7d2tV0KN3hrkgnj0Za8 8wiVMSL4G1XDxJVt3QcgR61j4tt4wKdw0QQzW1+vu1MYkYZuc+pZ4zXH5/eDbFdY+CJR yAdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gjTwJPBli3bVW7BSYmp/MLmUOGFtVANWMeLDc2BTS7w=; b=lQwfU9IUx2tvuyEYPM/3QtiU+HMFzKXMwa9rYr9RkSjHFc0n87c3UGi+zZzNW30aiO RtKwMGni9HhUT1Qb3UJ6Fntvyv7EjSRLfg5YowKtzpFmEi7DPukUw0MhHx05HTah/xao lM2CxLOJ4haapD4tyd38ejxEGkhxac2HEX97reHYOvKM3+0HUqxbQ3JUIdK/IJi6TaSB cVHfVJFtA2euVfMuhu1r7ArAwnl0hIOrgMXrVJl4MOasu0pihEnOFAWuMh26LeDZy0nb ggKsI4Eutn/Gm3xh2Ab04S2trMbDu6/2yh8r2eqW2WUdQyC0Dy8z07OibsalGvA2pCeG Vngg== X-Gm-Message-State: AO0yUKVpUX97ilmNFkhMyubXiRwXlwK773ytuj+Ozcioran20+6uXMzT TtMuTa4TizBhP4hRbsthvMk= X-Google-Smtp-Source: AK7set+Yi+CDKBpYhZODZ5eydyky0qyXDuXPMFlX8Bbuh5Z1gJwIFnECChJNzq6H3xSq7+jChoSMeQ== X-Received: by 2002:a17:902:db12:b0:19a:7622:23e5 with SMTP id m18-20020a170902db1200b0019a762223e5mr33386106plx.4.1677513680037; Mon, 27 Feb 2023 08:01:20 -0800 (PST) Received: from localhost ([2a00:79e1:abd:4a00:61b:48ed:72ab:435b]) by smtp.gmail.com with ESMTPSA id w18-20020a1709029a9200b0019af9a6bf8dsm4831526plp.19.2023.02.27.08.01.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 08:01:19 -0800 (PST) From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: Chia-I Wu , Ryan Neph , Dmitry Osipenko , Gerd Hoffmann , Rob Clark , David Airlie , Gurchetan Singh , Daniel Vetter , virtualization@lists.linux-foundation.org (open list:VIRTIO GPU DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] drm/virtio: Add option to disable KMS support Date: Mon, 27 Feb 2023 08:01:13 -0800 Message-Id: <20230227160114.2799001-1-robdclark@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Rob Clark Add a build option to disable modesetting support. This is useful in cases where the guest only needs to use the GPU in a headless mode, or (such as in the CrOS usage) window surfaces are proxied to a host compositor. v2: Use more if (IS_ENABLED(...)) Signed-off-by: Rob Clark --- drivers/gpu/drm/virtio/Kconfig | 11 +++++++++ drivers/gpu/drm/virtio/Makefile | 5 +++- drivers/gpu/drm/virtio/virtgpu_drv.c | 6 ++++- drivers/gpu/drm/virtio/virtgpu_drv.h | 10 ++++++++ drivers/gpu/drm/virtio/virtgpu_kms.c | 35 ++++++++++++++++------------ 5 files changed, 50 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/virtio/Kconfig b/drivers/gpu/drm/virtio/Kconfig index 51ec7c3240c9..ea06ff2aa4b4 100644 --- a/drivers/gpu/drm/virtio/Kconfig +++ b/drivers/gpu/drm/virtio/Kconfig @@ -11,3 +11,14 @@ config DRM_VIRTIO_GPU QEMU based VMMs (like KVM or Xen). =20 If unsure say M. + +config DRM_VIRTIO_GPU_KMS + bool "Virtio GPU driver modesetting support" + depends on DRM_VIRTIO_GPU + default y + help + Enable modesetting support for virtio GPU driver. This can be + disabled in cases where only "headless" usage of the GPU is + required. + + If unsure, say Y. diff --git a/drivers/gpu/drm/virtio/Makefile b/drivers/gpu/drm/virtio/Makef= ile index b99fa4a73b68..24c7ebe87032 100644 --- a/drivers/gpu/drm/virtio/Makefile +++ b/drivers/gpu/drm/virtio/Makefile @@ -4,8 +4,11 @@ # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. =20 virtio-gpu-y :=3D virtgpu_drv.o virtgpu_kms.o virtgpu_gem.o virtgpu_vram.o= \ - virtgpu_display.o virtgpu_vq.o \ + virtgpu_vq.o \ virtgpu_fence.o virtgpu_object.o virtgpu_debugfs.o virtgpu_plane.o \ virtgpu_ioctl.o virtgpu_prime.o virtgpu_trace_points.o =20 +virtio-gpu-$(CONFIG_DRM_VIRTIO_GPU_KMS) +=3D \ + virtgpu_display.o + obj-$(CONFIG_DRM_VIRTIO_GPU) +=3D virtio-gpu.o diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/= virtgpu_drv.c index ae97b98750b6..9cb7d6dd3da6 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.c +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c @@ -172,7 +172,11 @@ MODULE_AUTHOR("Alon Levy"); DEFINE_DRM_GEM_FOPS(virtio_gpu_driver_fops); =20 static const struct drm_driver driver =3D { - .driver_features =3D DRIVER_MODESET | DRIVER_GEM | DRIVER_RENDER | DRIVER= _ATOMIC, + .driver_features =3D +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS) + DRIVER_MODESET | DRIVER_ATOMIC | +#endif + DRIVER_GEM | DRIVER_RENDER, .open =3D virtio_gpu_driver_open, .postclose =3D virtio_gpu_driver_postclose, =20 diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/= virtgpu_drv.h index af6ffb696086..ffe8faf67247 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.h +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h @@ -426,8 +426,18 @@ virtio_gpu_cmd_set_scanout_blob(struct virtio_gpu_devi= ce *vgdev, uint32_t x, uint32_t y); =20 /* virtgpu_display.c */ +#if defined(CONFIG_DRM_VIRTIO_GPU_KMS) int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev); void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev); +#else +static inline int virtio_gpu_modeset_init(struct virtio_gpu_device *vgdev) +{ + return 0; +} +static inline void virtio_gpu_modeset_fini(struct virtio_gpu_device *vgdev) +{ +} +#endif =20 /* virtgpu_plane.c */ uint32_t virtio_gpu_translate_format(uint32_t drm_fourcc); diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/= virtgpu_kms.c index 27b7f14dae89..70d87e653d07 100644 --- a/drivers/gpu/drm/virtio/virtgpu_kms.c +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c @@ -161,7 +161,8 @@ int virtio_gpu_init(struct virtio_device *vdev, struct = drm_device *dev) if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_VIRGL)) vgdev->has_virgl_3d =3D true; #endif - if (virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_EDID)) { + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS) && + virtio_has_feature(vgdev->vdev, VIRTIO_GPU_F_EDID)) { vgdev->has_edid =3D true; } if (virtio_has_feature(vgdev->vdev, VIRTIO_RING_F_INDIRECT_DESC)) { @@ -218,17 +219,19 @@ int virtio_gpu_init(struct virtio_device *vdev, struc= t drm_device *dev) goto err_vbufs; } =20 - /* get display info */ - virtio_cread_le(vgdev->vdev, struct virtio_gpu_config, - num_scanouts, &num_scanouts); - vgdev->num_scanouts =3D min_t(uint32_t, num_scanouts, - VIRTIO_GPU_MAX_SCANOUTS); - if (!vgdev->num_scanouts) { - DRM_ERROR("num_scanouts is zero\n"); - ret =3D -EINVAL; - goto err_scanouts; + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS)) { + /* get display info */ + virtio_cread_le(vgdev->vdev, struct virtio_gpu_config, + num_scanouts, &num_scanouts); + vgdev->num_scanouts =3D min_t(uint32_t, num_scanouts, + VIRTIO_GPU_MAX_SCANOUTS); + if (!vgdev->num_scanouts) { + DRM_ERROR("num_scanouts is zero\n"); + ret =3D -EINVAL; + goto err_scanouts; + } + DRM_INFO("number of scanouts: %d\n", num_scanouts); } - DRM_INFO("number of scanouts: %d\n", num_scanouts); =20 virtio_cread_le(vgdev->vdev, struct virtio_gpu_config, num_capsets, &num_capsets); @@ -246,10 +249,12 @@ int virtio_gpu_init(struct virtio_device *vdev, struc= t drm_device *dev) virtio_gpu_get_capsets(vgdev, num_capsets); if (vgdev->has_edid) virtio_gpu_cmd_get_edids(vgdev); - virtio_gpu_cmd_get_display_info(vgdev); - virtio_gpu_notify(vgdev); - wait_event_timeout(vgdev->resp_wq, !vgdev->display_info_pending, - 5 * HZ); + if (IS_ENABLED(CONFIG_DRM_VIRTIO_GPU_KMS)) { + virtio_gpu_cmd_get_display_info(vgdev); + virtio_gpu_notify(vgdev); + wait_event_timeout(vgdev->resp_wq, !vgdev->display_info_pending, + 5 * HZ); + } return 0; =20 err_scanouts: --=20 2.39.1