From nobody Mon Sep 8 19:06:38 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0442FC6FA8E for ; Sun, 26 Feb 2023 16:53:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229757AbjBZQxr (ORCPT ); Sun, 26 Feb 2023 11:53:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjBZQxp (ORCPT ); Sun, 26 Feb 2023 11:53:45 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91761B772 for ; Sun, 26 Feb 2023 08:53:44 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.169]) by gnuweeb.org (Postfix) with ESMTPSA id 3120C831C8; Sun, 26 Feb 2023 16:53:41 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1677430424; bh=oMEGAK6ZcuquAYnSKZpKSdMu7CUNw9o2Zlj5wN7zR4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CiLRx/f0KGjMkTA+yVX3K4FSI1KGHN0UJ6igB0kzDWV9298ntqmq/XS4zGs0LSJcQ WVx+0+z/uAxIrLRvkDZfPHYFMdogerGEyJf4KcWFxoyTmqiA1tb/LwVItXpJW+Yl6E 6aU4ufRrFLBQLcP95thn1if3wb5m2gkPmpdsAqiD9NwJp+Cnfapq2UOvKQncyjum+Q 8XD5Yo1xR0PXS3XwekP+qoh9gOrwDd/xTPs0tMpHzfX5M1a9WMPT4ND4V7vI+AUjWD e+vZGjk9qHHxkH9+/OIP1Ku3KY1ipAwftKNCBRqM+6+sKs9u8N5dQpZvitNDNj0XF3 AEh80AtFD4zNw== From: Ammar Faizi To: Tejun Heo Cc: Ammar Faizi , Lai Jiangshan , Linux Kernel Mailing List , GNU/Weeb Mailing List Subject: [PATCH v1 1/2] workqueue: Simplify a pr_warn() call in wq_select_unbound_cpu() Date: Sun, 26 Feb 2023 23:53:20 +0700 Message-Id: <20230226165321.24825-2-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230226165321.24825-1-ammarfaizi2@gnuweeb.org> References: <20230226165321.24825-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use pr_warn_once() to achieve the same thing. It's simpler. Signed-off-by: Ammar Faizi Reviewed-by: Lai Jiangshan --- kernel/workqueue.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index b8b541caed4854a4..3f1fabea000f4408 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1392,15 +1392,13 @@ static bool is_chained_work(struct workqueue_struct= *wq) */ static int wq_select_unbound_cpu(int cpu) { - static bool printed_dbg_warning; int new_cpu; =20 if (likely(!wq_debug_force_rr_cpu)) { if (cpumask_test_cpu(cpu, wq_unbound_cpumask)) return cpu; - } else if (!printed_dbg_warning) { - pr_warn("workqueue: round-robin CPU selection forced, expect performance= impact\n"); - printed_dbg_warning =3D true; + } else { + pr_warn_once("workqueue: round-robin CPU selection forced, expect perfor= mance impact\n"); } =20 if (cpumask_empty(wq_unbound_cpumask)) --=20 Ammar Faizi From nobody Mon Sep 8 19:06:38 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8316AC6FA8E for ; Sun, 26 Feb 2023 16:53:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229818AbjBZQxv (ORCPT ); Sun, 26 Feb 2023 11:53:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229758AbjBZQxs (ORCPT ); Sun, 26 Feb 2023 11:53:48 -0500 Received: from gnuweeb.org (gnuweeb.org [51.81.211.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BA6F10262 for ; Sun, 26 Feb 2023 08:53:47 -0800 (PST) Received: from localhost.localdomain (unknown [182.253.183.169]) by gnuweeb.org (Postfix) with ESMTPSA id 017848319A; Sun, 26 Feb 2023 16:53:44 +0000 (UTC) X-GW-Data: lPqxHiMPbJw1wb7CM9QUryAGzr0yq5atzVDdxTR0iA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1677430427; bh=9YPCw915qKVGWwoFZaFeQr5pSs3AYecYx2tLRncmlc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fhKH07kdWHJrGkijHEtkFaa1d6Gm9C3dpfLDkTsezkgkizdWUXfpUTaZlgoOJUIT2 WaiVIOKTKS2nDFaUD21sQs0EogovchIesORpdlVX4R0ryz61CMGzfV9xrdCMpEKxVf xcpsnc+jpjBl8qEowSWjvbToJov+01FV+V0w4+TiWjDmAPsI7SBMiNbUgRe1UxDGiI zVNi0AtRU/LJbQIzffdSDwGydbh+H0xsWE80RdRxE+Fj9KJaW50e9w2J/9hGQfrbLG zGRanEoMZ7eXKIpS/Se45Xa4al+MkRvDnvOdb3CJORQoI/3jn1O9bZh3DixCDGfBJ9 1DuRke5tCCz2A== From: Ammar Faizi To: Tejun Heo Cc: Ammar Faizi , Lai Jiangshan , Linux Kernel Mailing List , GNU/Weeb Mailing List Subject: [PATCH v1 2/2] MAINTAINERS: Add workqueue_internal.h to the WORKQUEUE entry Date: Sun, 26 Feb 2023 23:53:21 +0700 Message-Id: <20230226165321.24825-3-ammarfaizi2@gnuweeb.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230226165321.24825-1-ammarfaizi2@gnuweeb.org> References: <20230226165321.24825-1-ammarfaizi2@gnuweeb.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This file doesn't have a maintainer. It should belong to the WORKQUEUE entry part. Add it to the WORKQUEUE entry. Signed-off-by: Ammar Faizi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb223dcf0f62f19d..ec4e40eb58778cc7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22585,6 +22585,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/gi= t/tj/wq.git F: Documentation/core-api/workqueue.rst F: include/linux/workqueue.h F: kernel/workqueue.c +F: kernel/workqueue_internal.h =20 WWAN DRIVERS M: Loic Poulain --=20 Ammar Faizi