From nobody Wed Dec 17 10:03:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05E94C77B76 for ; Fri, 21 Apr 2023 11:35:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231719AbjDULfz (ORCPT ); Fri, 21 Apr 2023 07:35:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231778AbjDULfo (ORCPT ); Fri, 21 Apr 2023 07:35:44 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E974C66B; Fri, 21 Apr 2023 04:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682076933; x=1713612933; h=from:date:subject:mime-version:content-transfer-encoding: message-id:references:in-reply-to:to:cc; bh=V3l4oFrTXgNaHDsFH5ny9LhlqFRgL1aXxFRyebnTRqc=; b=UUcKzkEPDmaTyMUSw4yf7QxccGqHgXY/cuHxEOIxV2W46seGFR897jNw 8hNoYIrDx8VxbQqR6b0xMzrGNbeN4SOiwAsxsw8C+J5w9GnfDK2LqYfsY 11O+YmweFrq3SlB7TKB62zoBf00gmUqV5DFqGLyZ90ZwSkwCp/42P20YU fXwOt0Jex93bFGnomW5dB+Dr/e4996I5Z0J2YeeumVeOnGfQRd/hzm2AW tEjVgh/p1A5SYlt06V/lMSoCVLar9XevNjQc4035DU81zIpZYOKXGlgUF ritHe5fi4t7NwEpZu99+O9fEqsO3Ea6cPTq1FhgsTdHomi6/IjCQyApQg Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10686"; a="432249899" X-IronPort-AV: E=Sophos;i="5.99,214,1677571200"; d="scan'208";a="432249899" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2023 04:35:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10686"; a="642489666" X-IronPort-AV: E=Sophos;i="5.99,214,1677571200"; d="scan'208";a="642489666" Received: from lab-ah.igk.intel.com ([10.102.138.202]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2023 04:35:28 -0700 From: Andrzej Hajda Date: Fri, 21 Apr 2023 13:35:07 +0200 Subject: [PATCH v7 4/7] lib/ref_tracker: remove warnings in case of allocation failure MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20230224-track_gt-v7-4-11f08358c1ec@intel.com> References: <20230224-track_gt-v7-0-11f08358c1ec@intel.com> In-Reply-To: <20230224-track_gt-v7-0-11f08358c1ec@intel.com> To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Chris Wilson , netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Dmitry Vyukov , "David S. Miller" , Andi Shyti , Andrzej Hajda X-Mailer: b4 0.11.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Library can handle allocation failures. To avoid allocation warnings __GFP_NOWARN has been added everywhere. Moreover GFP_ATOMIC has been replaced with GFP_NOWAIT in case of stack allocation on tracker free call. Signed-off-by: Andrzej Hajda Reviewed-by: Andi Shyti Reviewed-by: Eric Dumazet --- lib/ref_tracker.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ref_tracker.c b/lib/ref_tracker.c index cce4614b07940f..cf5609b1ca7936 100644 --- a/lib/ref_tracker.c +++ b/lib/ref_tracker.c @@ -189,7 +189,7 @@ int ref_tracker_alloc(struct ref_tracker_dir *dir, unsigned long entries[REF_TRACKER_STACK_ENTRIES]; struct ref_tracker *tracker; unsigned int nr_entries; - gfp_t gfp_mask =3D gfp; + gfp_t gfp_mask =3D gfp | __GFP_NOWARN; unsigned long flags; =20 WARN_ON_ONCE(dir->dead); @@ -237,7 +237,8 @@ int ref_tracker_free(struct ref_tracker_dir *dir, return -EEXIST; } nr_entries =3D stack_trace_save(entries, ARRAY_SIZE(entries), 1); - stack_handle =3D stack_depot_save(entries, nr_entries, GFP_ATOMIC); + stack_handle =3D stack_depot_save(entries, nr_entries, + GFP_NOWAIT | __GFP_NOWARN); =20 spin_lock_irqsave(&dir->lock, flags); if (tracker->dead) { --=20 2.34.1