From nobody Wed Sep 10 23:58:53 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304EAC61DA4 for ; Thu, 23 Feb 2023 01:41:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbjBWBl6 (ORCPT ); Wed, 22 Feb 2023 20:41:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbjBWBl4 (ORCPT ); Wed, 22 Feb 2023 20:41:56 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4B473BD87 for ; Wed, 22 Feb 2023 17:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=4Y/vUgi+zlUePCC78E4DGLn2+CH9ssQFh6vEdznAP9w=; b=LZPK0iLJzCjnUGWbq8qCOx/93y LjP0q1Pvaf5mPsdHgFYtqgrVhncPKPbprYF2m04fLaAjC+IJ7MRaedgo/awUyMcHVCQ+kjAtbN8a2 tr3T56MJikybyESRgRxDAOp/W+s+X0o2aRrYwn6f94VmWEQ1DPMGpRslDyQeDA+3dcnouvXOjRrGO Og91Oj5NpfUTq4NGJQCr+2CNllFw9YLWTQyWU644YtdxlhW2LjkCJ9hDURofNTIHwEohG+W6CFWOI EPf1U+ZZAZKMhFzpEQPPYgyaP0IEyFkF6xlpDR9180sPojTZRINoy1XENEgCWTu2RcESrFmo+ZyBV 6ugW3KMg==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pV0cK-00EgHt-Ln; Thu, 23 Feb 2023 01:41:52 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Benjamin Herrenschmidt , Paul Mackerras , Elimar Riesebieter , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH] macintosh: via-pmu-led: ********************************* Date: Wed, 22 Feb 2023 17:41:51 -0800 Message-Id: <20230223014151.19270-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK when ATA is not set/enabled causes a Kconfig warning: WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK Depends on [n]: NEW_LEDS [=3Dy] && LEDS_TRIGGERS [=3Dy] && ATA [=3Dn] Selected by [y]: - ADB_PMU_LED_DISK [=3Dy] && MACINTOSH_DRIVERS [=3Dy] && ADB_PMU_LED [=3D= y] && LEDS_CLASS [=3Dy] Fix this by making ADB_PMU_LED_DISK depend on ATA. Seen on both PPC32 and PPC64. Fixes: 0e865a80c135 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU= _LED_DISK is selected") Signed-off-by: Randy Dunlap Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Elimar Riesebieter Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org --- drivers/macintosh/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/macintosh/Kconfig b/drivers/macintosh/Kconfig --- a/drivers/macintosh/Kconfig +++ b/drivers/macintosh/Kconfig @@ -86,6 +86,7 @@ config ADB_PMU_LED =20 config ADB_PMU_LED_DISK bool "Use front LED as DISK LED by default" + depends on ATA depends on ADB_PMU_LED depends on LEDS_CLASS select LEDS_TRIGGERS