From nobody Tue Sep 9 07:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293C8C636CC for ; Mon, 20 Feb 2023 14:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbjBTOjM (ORCPT ); Mon, 20 Feb 2023 09:39:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232148AbjBTOjI (ORCPT ); Mon, 20 Feb 2023 09:39:08 -0500 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5528FBB81 for ; Mon, 20 Feb 2023 06:39:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=Q9zHG 0kXKM7EYS1+RRwfxxlcds8xLakH1kfaDLZ5UTI=; b=TiCMVWrajKD84+4Lopo11 MBbTKXVBvS9qg9QHqL4kJMOSDp+hy3XsWKL/xY5NTrVH98REuuJwQhwJsisQyDFu vvUwG9h7FW7ol7cec9KFCeiBk55eZp/vgfLbJVvO6OMgvpCivOJj1JYXny5tnkkq HmKZ/eO3d1Ck8eOEPBNGMM= Received: from localhost (unknown [122.206.190.60]) by zwqz-smtp-mta-g0-0 (Coremail) with SMTP id _____wD3SnTKhfNjP8MQAg--.33396S2; Mon, 20 Feb 2023 22:38:02 +0800 (CST) From: Shibo Li To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Shibo Li Subject: [PATCH] staging: rtl8712: Fix Sparse warnings in rtl871x_ioctl_linux.c Date: Mon, 20 Feb 2023 14:37:58 +0000 Message-Id: <20230220143758.4396-1-zzutcyha@163.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3SnTKhfNjP8MQAg--.33396S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7WFWDZFy3Xr43JryDKF1Utrb_yoW8WrW7pr s8Wa4qyr4kWFnIg3ykJFn5ur15WF10grnYk3s7t34agF1rAr1agr4Iva4IqrsxGry3Z3WY yF1UJr4Yq34YkFJanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRnZ2xUUUUU= X-Originating-IP: [122.206.190.60] X-CM-SenderInfo: x22x3ux1kdqiywtou0bp/1tbiZQ8cbF8ZW-54lgAAsX Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This patch fixes the following warning in rtl871x_ioctl_linux.c WARNING: Avoid multiple line dereference - prefer 'pnetwork->network.Infras= tructureMode' + if (pnetwork->network. + InfrastructureMode WARNING: Avoid multiple line dereference - prefer 'padapter->mlmepriv.cur_n= etwork.network' + padapter->mlmepriv. + cur_network.network. WARNING: Avoid multiple line dereference - prefer 'cur_network.network.Infr= astructureMode' + cur_network.network. + InfrastructureMode) Signed-off-by: Shibo Li --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/stagin= g/rtl8712/rtl871x_ioctl_linux.c index 36f6904d25ab..6673befeb2f0 100644 --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c @@ -1268,14 +1268,11 @@ static int r8711_wx_set_essid(struct net_device *de= v, if ((!memcmp(dst_ssid, src_ssid, ndis_ssid.SsidLength)) && (pnetwork->network.Ssid.SsidLength =3D=3D ndis_ssid.SsidLength)) { - if (check_fwstate(pmlmepriv, - WIFI_ADHOC_STATE)) { - if (pnetwork->network. - InfrastructureMode + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { + if (pnetwork->network.configurationInfrastructureMode !=3D - padapter->mlmepriv. - cur_network.network. - InfrastructureMode) + padapter->mlmepriv.assoc_by_rssi. + cur_network.network.InfrastructureMode) continue; } =20 --=20 2.39.2