From nobody Fri Sep 12 02:25:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4EA8C61DA4 for ; Tue, 14 Feb 2023 06:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231671AbjBNGpo (ORCPT ); Tue, 14 Feb 2023 01:45:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbjBNGpj (ORCPT ); Tue, 14 Feb 2023 01:45:39 -0500 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2098.outbound.protection.outlook.com [40.107.223.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 656DBEF87 for ; Mon, 13 Feb 2023 22:45:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QNVmHuiccnC+unjkSce/1jvZxyX5HeSVn2NQr23Tq5MDPeTTDn0zbN2FTPnaN3UqQjbDChC0Z+JZGQCw7O5B5BHNE17pxHm5/fxSzE3XWZbZhgUBEsPKISkQtCMfoW8XZC9k03pXkezdXgnFxGbQBOl9bLSYQGmMN1s8cV4pT0iuwk0XUpFzLYC6Ywfvi39Q6KLvi62MeI3EZWa9xNJOTcQ+5KQHKD64sL7T6vZ0sg05Q5+LG0FMGoECm2qe50zhMwIj8I6g5RyJNY0QJwWays7jlI9UODY1PohiIMEQvbvDnDmPjc1RSbMcIzTz6lPCks2AGOu+D31xciZZllY1yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W6L6CtaOM6lsMUx2LLXya/oWRSGMEm8r5r/tiVclN+0=; b=PeSOQE4U9H7L9M6b5T4SVYGxsTkL1lBz7ov317XtGDQ0eA9AJCwFkLr1RvUg5/PtkGB6hpHzz4LYlaQH/rHUF5Dc73XQgsxHgApWVd+9lC3KT6u3txlp16tytw+8yacWj4nGpS1/bjQo7ZVdLeUFlAZrDBUXVURRGz5ODE1TpB2NTIzFHuiqZlWnyrn4tkBvPsFBbLbEK/wCbdYqMcCobftmLGx4TcQbmM+k+53gxRL/uszpPoWWOffdyZL/c4+bjUJj4WcXtDWnHu49yebqiUQKwOVxV6Gi9tmdsXfIcMjBWic+2WyYkNq2TTZVPr/rBOngMls7Cx7PWSW9K1uUkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W6L6CtaOM6lsMUx2LLXya/oWRSGMEm8r5r/tiVclN+0=; b=krkB+ZSvE/523qTW/KCUF53IH1nNMDedFDQpgmAY1g5HEO0kYDg3jQnm3/0VNGJDMPZCX+651it1Fkn5/Kk6I/vJRUUyX2p6rQ/B7Mt76UM7RMTJAioP9P/anUi/xe5cLWS+j9NJLIDY1jFTf9ojTzCDyk3UFEftBhCgr2vxKR4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SN4PR01MB7455.prod.exchangelabs.com (2603:10b6:806:202::11) by DM6PR01MB3962.prod.exchangelabs.com (2603:10b6:5:84::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.21; Tue, 14 Feb 2023 06:45:34 +0000 Received: from SN4PR01MB7455.prod.exchangelabs.com ([fe80::bf6:8038:9fe8:1588]) by SN4PR01MB7455.prod.exchangelabs.com ([fe80::bf6:8038:9fe8:1588%4]) with mapi id 15.20.6086.023; Tue, 14 Feb 2023 06:45:34 +0000 From: Quan Nguyen To: Arnd Bergmann , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission Cc: Phong Vo , Thang Nguyen , Quan Nguyen Subject: [PATCH 1/2] misc: smpro-errmon: Add DIMM 2x Refresh rate event Date: Tue, 14 Feb 2023 13:45:08 +0700 Message-Id: <20230214064509.3622044-2-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230214064509.3622044-1-quan@os.amperecomputing.com> References: <20230214064509.3622044-1-quan@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0023.apcprd01.prod.exchangelabs.com (2603:1096:4:192::17) To SN4PR01MB7455.prod.exchangelabs.com (2603:10b6:806:202::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN4PR01MB7455:EE_|DM6PR01MB3962:EE_ X-MS-Office365-Filtering-Correlation-Id: a53bc5a0-acca-48a6-ab27-08db0e5712df X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: spi8ogUJzctBKfsSVgPv/m3gOu+XBqsJVfvmnErFDsDCCeZgLjr6dVQk9RAQYuPkxfj7FJVXTnG5AqqLe7Fr2IxmXXXIvlDokjabnXA/FoAOWrm6T1WbpYcO9eooBxkrh3BXTAmURc7Vh2CxvOERX8ZGqzfMw/i/Tejpsb+UaZkTXe3JOrnFvKj2oNFf6yEfOrX/TvGux7iMz0n7eZh4dQnYPgbR3wNgAmn7a974xnHOX8G1RqfKXSF22WhealPesouM7NQ2ilUGohOKwiUpt5s9BLJw5Wy6ZBEBkIxJUMZ9M5b95eaVLUEHQr8bVb8WYcu2TdB7ly6we5xrkowJxn6/YG5OaIvrQ1JOBfVECGkPA62mGcd6DwdqlaTtKS5FSWsf05vLmcPSeIJRhVXDX3+DUkKusUasNYvGGcI1fbXeqpawt2elxbOOjbxH3saYnra9J3aKBOXldBX2I7NfMpf63OnCE7CP+m++iMEYaKT+pa4FnpZD+VGoGoua7vjeNTNI1caJ9TriNF6ggaSnWM+69evKbwAYZWUX3UX6+bF3XxDVjCnhkbYd/uQivor4Fu51r2romcr4aarT6T44IeVMJ/AI/ZSz6zZiVvwpi/hvgGS/x92j3VwrXwBbLqJg+k1zzwYClzHMj2EFCB3dQkv9ulY8XgHnYhQu7RCWU8VxMfTli6wWvASLKHj2os9TPpn1ptukeqgXg6MjkQHCmg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR01MB7455.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(346002)(376002)(136003)(396003)(39850400004)(451199018)(8936002)(5660300002)(316002)(2906002)(110136005)(41300700001)(2616005)(66476007)(66556008)(4326008)(54906003)(66946007)(8676002)(38100700002)(38350700002)(1076003)(6506007)(6512007)(86362001)(6666004)(52116002)(107886003)(186003)(478600001)(6486002)(26005)(83380400001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yrzQ+ihIbteokA8wV7/DYHa0Jz2PfwUWDqrj04RKv1q9gBn6+ARTc5aw4dNw?= =?us-ascii?Q?qe3nTLPbaGYs6WwyHHLve44ZHf34XyCJ8frfOZbGhILuTq6ydtC06oL0R5KG?= =?us-ascii?Q?QOesa3HNUFRCIS2Sb2sBw28ANW4qiLQfDKRNG3fSbsBUpmJ/cgLIsmMqpyd1?= =?us-ascii?Q?d3fU3dNfyjifAZcPAvsKuEhcYW1hSP2YHM5Fx8LTfQwxtfBscPlkbGu5lHCD?= =?us-ascii?Q?Z04LFU1vZI5+9qlqqUwP9plumqLUgjZpcycnfNe9yd6FicpSROXbYPXnv/Wm?= =?us-ascii?Q?Tt/EqLwHAYmtoDneUoEP16RRgY70YO6HogAczv84egZ8HWwmU4YH7AUBqohc?= =?us-ascii?Q?9UT0mBY2JYTj9ZRNWoTOPYzpFgjCIUs1EL9+MIDSQ7JvMysyb3QOyvK4EDYr?= =?us-ascii?Q?ouHiwWWG3G8ijG+9+YO7fBSbN2uh8zX2/b+frTGQ0i6ixxv6Mnz1gO3zpcwR?= =?us-ascii?Q?rnlMHeeydAiGFhdShgzxi1xFJojB1PKY4wbRJThu5nzVGAowvAU9amI+2C1S?= =?us-ascii?Q?W/xf+hnU2bWaPvM85wEwTV+HCwAysKmeznlDc0O/W1wh6M5Ak04Op6vRVlsl?= =?us-ascii?Q?Tx3Df8NBPEb6o+cg6fWO3IMm89LUHA618iwHSb69TxrrFsBjbVZ3bDMUPO8W?= =?us-ascii?Q?BfIWPgFx2x8Ee/kCky35J3zNzSEt93IJlHavVMrS56OlbUfH/OiKQVGWaDqW?= =?us-ascii?Q?Uz/r/uWam+f9Z1yBMvKGYEXOWkT+n8eIHnTnWY/tbC57ws1IocH/wnLtQXAJ?= =?us-ascii?Q?kItaRRUOin2/IsafInzIwMcer9mUSK03MfADGGd0NR9+VXBxptYKI4b9NwSp?= =?us-ascii?Q?z0VXl0rtn6dFddl98bwU5Lw/Hwf4/A5W1Ab21vDw3O3HcdQP6wNRX/6qHTPp?= =?us-ascii?Q?HyoOv/QnWWw4h/wwn2F6ny6+nnwzXYDfI+8mJwqHow+iSoynRp4J+W8LyX3N?= =?us-ascii?Q?q/LGVfr1MJ46lGOiSKavx6LcbTGUtb7/1lm+2F6L+LT/ZmiOHIJiQejNnxdS?= =?us-ascii?Q?8xvp+iJNXRYv3ioQNpwQv4NJSkP/YlmOGIvcJtSSXiS7wF89w+ldUwsMAlRZ?= =?us-ascii?Q?k851lBKmJ78BVpYa+4C1SBx0yap0zFAhCUFMRUvcmOE2EG2GC37oCIxKQczm?= =?us-ascii?Q?PZUlTS4hWUqdMowp6KGbcVf5XDsAy4bKspYpfeRN1/6vjOXVSEsk0dnzt6NS?= =?us-ascii?Q?mlGwVfk2zoJra07ZNKjSTuWBE+5uZfM6oN9+qg4bYwCOvTKh23Yd2RfY/5kN?= =?us-ascii?Q?ks2lNKmR0cHh4UuJIjfB3h20yCw1o5ukhVAU0/xFjWcYoFczujRvveTolDPK?= =?us-ascii?Q?IZhGOPvq/7mQpydFMPhYVOGmVK4tVwvbZeEBbv/f7Kyv+2bOWh3EzL18lHSo?= =?us-ascii?Q?9ILV1GZk3+HOSYgYkYU/ysZGk7qyuhuyxyKckasPdlQC8m4bpQfD7w9Wgagd?= =?us-ascii?Q?FWMEKQL2uCaXdR88kU30iuwcVR6wrdTCx3rLpzA36mMXF25C9wAga9NRjuAN?= =?us-ascii?Q?ccb3r2LbRbBWZkAT5UkInOmOZ5pu0/+I1CQ7Rj4wrXofxUtIbI8a5vOPn6H1?= =?us-ascii?Q?2wLXiH0VwWGrFmVKwg95ZiIDtin2lnaVhpWDQ0rJNLKgESgCX7jJNA7dv7Ae?= =?us-ascii?Q?SjfzhRQ1h63wP0j8ZCBJpxw=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: a53bc5a0-acca-48a6-ab27-08db0e5712df X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 06:45:34.7461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5D1GRCRK1mnGB9J0Gf95QjyPMjcUtYCKDNwtWe/ihv7aNp7i9mgAlSFwKUddQB8UcSIeCJNGB9dvfcAyJQYhH7b/+Hdu0wikqlJTCK8TrTw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB3962 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In high temperature condition, JEDEC spec requires memory controller to double the refresh rate. This commit adds event_dimm_2x_refresh sysfs to report that events for all memory channels. Signed-off-by: Quan Nguyen --- .../ABI/testing/sysfs-bus-platform-devices-ampere-smpro | 5 ++++- drivers/misc/smpro-errmon.c | 5 +++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-sm= pro b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro index ca93c215ef99..d4e3f308c451 100644 --- a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro +++ b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro @@ -258,8 +258,11 @@ Description: +---------------+-------------------------------------------------------= --------+---------------------+ | DIMM HOT | /sys/bus/platform/devices/smpro-errmon.*/event_dimm_ho= t | DIMM Hot | +---------------+-------------------------------------------------------= --------+---------------------+ + | DIMM 2X | /sys/bus/platform/devices/smpro-errmon.*/event_dimm_2x= _refresh| DIMM 2x refresh rate| + | REFRESH RATE | = | event in high temp | + +---------------+-------------------------------------------------------= --------+---------------------+ =20 - For more details, see section `5.7 GPI Status Registers, + For more details, see section `5.7 GPI Status Registers and 5.9 Memory E= rror Register Definitions, Altra Family Soc BMC Interface Specification`. =20 What: /sys/bus/platform/devices/smpro-misc.*/boot_progress diff --git a/drivers/misc/smpro-errmon.c b/drivers/misc/smpro-errmon.c index d1431d419aa4..1635e881aefb 100644 --- a/drivers/misc/smpro-errmon.c +++ b/drivers/misc/smpro-errmon.c @@ -67,6 +67,7 @@ #define VRD_WARN_FAULT_EVENT_DATA 0x78 #define VRD_HOT_EVENT_DATA 0x79 #define DIMM_HOT_EVENT_DATA 0x7A +#define DIMM_2X_REFRESH_EVENT_DATA 0x96 =20 #define MAX_READ_BLOCK_LENGTH 48 =20 @@ -190,6 +191,7 @@ enum EVENT_TYPES { VRD_WARN_FAULT_EVENT, VRD_HOT_EVENT, DIMM_HOT_EVENT, + DIMM_2X_REFRESH_EVENT, NUM_EVENTS_TYPE, }; =20 @@ -198,6 +200,7 @@ static u8 smpro_event_table[NUM_EVENTS_TYPE] =3D { VRD_WARN_FAULT_EVENT_DATA, VRD_HOT_EVENT_DATA, DIMM_HOT_EVENT_DATA, + DIMM_2X_REFRESH_EVENT_DATA, }; =20 static ssize_t smpro_event_data_read(struct device *dev, @@ -463,6 +466,7 @@ static DEVICE_ATTR_RO(warn_pmpro); EVENT_RO(vrd_warn_fault, VRD_WARN_FAULT_EVENT); EVENT_RO(vrd_hot, VRD_HOT_EVENT); EVENT_RO(dimm_hot, DIMM_HOT_EVENT); +EVENT_RO(dimm_2x_refresh, DIMM_2X_REFRESH_EVENT); =20 static struct attribute *smpro_errmon_attrs[] =3D { &dev_attr_overflow_core_ce.attr, @@ -488,6 +492,7 @@ static struct attribute *smpro_errmon_attrs[] =3D { &dev_attr_event_vrd_warn_fault.attr, &dev_attr_event_vrd_hot.attr, &dev_attr_event_dimm_hot.attr, + &dev_attr_event_dimm_2x_refresh.attr, NULL }; =20 --=20 2.35.1 From nobody Fri Sep 12 02:25:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C4BC05027 for ; Tue, 14 Feb 2023 06:45:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231685AbjBNGpt (ORCPT ); Tue, 14 Feb 2023 01:45:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231190AbjBNGpp (ORCPT ); Tue, 14 Feb 2023 01:45:45 -0500 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2100.outbound.protection.outlook.com [40.107.237.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B23F1CAE0 for ; Mon, 13 Feb 2023 22:45:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TicLpZ1Y5XMSmnuLLDHh1oVnQsL8Wol9nJvGtEx/WoIBrk+mItC3xGkDfmUM0xvQ5DGs1vC5CJgadfpDrgwwSJ0quJsdCtN58+vzzkADPq3sF7IBaMBkb7U78VZ+MrlyBFTeRLjjWJl9ryNHLpcM3Ru658eRzb0tQoFmvP6cqr3BRNmFWuYUqnVOv8m3EYtnEylz6HEJ7jaGz4V38mM+Ph6gcO9VDamSpk5BtQGOh91Ab3i8TnnX5Qaj5P3BinEt77ueIDJgenDqFOsq8pdGxfb7MJJlqgKmKAtYak6jY+voxhj40/aVMJVTID/R0Ww0jnhpzyP80ktWt86OfQl94A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AWAUChPo/u4uLIMKqytJT9gJ5W5sswUJY4XizDq0Y3Q=; b=Kmthv1hxloVFY2OowDrYc+sEbCbDqJhmB8sRPf17ucc8LA/Itj6SVl4GgY+pkGhTzpoQwEPY5MWCOnKYy/v9kflkDWNXi9VvxgdBUsR/G+xkr8IjE/Tt6kbOglCYciWLF1fyoXgVbjeD3EcXGEHjeFhOkihWwPrOnvVvBbBl+3FhmO/5NdZ75akxkEIgBzmduMR3xAuVKBZfsrcKBV8DGOcNWKgZvB49/pe3GAcYz2uvU4pQ1uPPMqPwjWa5egtQ88HVIxTRcvpRpEZCQCAbddWUPoSrfVK02Qz3BDliqYEDy08RDnKBJWbGtXKWaACU0aLkll6hRIUm68uaPSFilQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AWAUChPo/u4uLIMKqytJT9gJ5W5sswUJY4XizDq0Y3Q=; b=JxD/d924eLnbj1EjpOIAmvObOCEE1GiKlcUjVXuYlqA+i9XBExIhQgk3RTBo8xA36oadt4J+/o4WwHaDDbRmlok1BMbQeoRZ5S644bLnhCktGDL+d70D0isU+pl9Ks+tLajwKrn7+Wwsc4XA5cDpwTjYH84HOPa9ecWtSGsMbyA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from SN4PR01MB7455.prod.exchangelabs.com (2603:10b6:806:202::11) by DM4PR01MB7738.prod.exchangelabs.com (2603:10b6:8:66::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Tue, 14 Feb 2023 06:45:38 +0000 Received: from SN4PR01MB7455.prod.exchangelabs.com ([fe80::bf6:8038:9fe8:1588]) by SN4PR01MB7455.prod.exchangelabs.com ([fe80::bf6:8038:9fe8:1588%4]) with mapi id 15.20.6086.023; Tue, 14 Feb 2023 06:45:38 +0000 From: Quan Nguyen To: Arnd Bergmann , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Open Source Submission Cc: Phong Vo , Thang Nguyen , Quan Nguyen Subject: [PATCH 2/2] misc: smpro-errmon: Add dimm training failure syndrome Date: Tue, 14 Feb 2023 13:45:09 +0700 Message-Id: <20230214064509.3622044-3-quan@os.amperecomputing.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230214064509.3622044-1-quan@os.amperecomputing.com> References: <20230214064509.3622044-1-quan@os.amperecomputing.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SI2PR01CA0023.apcprd01.prod.exchangelabs.com (2603:1096:4:192::17) To SN4PR01MB7455.prod.exchangelabs.com (2603:10b6:806:202::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN4PR01MB7455:EE_|DM4PR01MB7738:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c2b7dc1-3261-40b9-ebfb-08db0e571508 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G0meULAQiqfM9LcqRl1E3ZCDNGdyomJ5M26be3I1qKyStnebbgPlCrcCRtIBNDv9xNqedaWh7BqH9Jof1f0867l/KPmzB+Au2eZHy1+CTyT65WQC/MATW/0SxaWDRNNFHZzxXx2gL/zU2y8yrbZ8ReP4ISrE/tPmW50Ax7nBKSl8wog+9TcgX4JDuLU58XfLh7n40P0zsbe9LKLYKvQLP0s4h9cxe+2Lfl6Q55a/GIrusPtqM7+Iy8yX8EqhQxme4BHT+IstLVqTMdI5ZFAqUSl91/WebEAiO6xMgQIbKaLQB3cBH3axZJEg5/a/xvfbuqjcotMkd00Rj+3v5qNcGn0x9+H/Gj9VZIc/19AzAZ/J03BzZaS0mS/hMQZIxph2HYLNJN+aNVrQ1RlbjhdLT3eEw9cetOQb7XRG4ghv0V2XBuJsPdSSZQy9ERzqbSzE2AniiL/6aL3MNUuF4MTPCnvmrT9VvQzE+QiEcllNiHXb+lZmnrTOe8OjVF3Y9W0Nzcdgp3cZIP60diXAL2bmqexmNfSUzMe0tkFC5nQdrneDL0l2xAj+NPe8BLdZiiJSPvlCvj9LBLWec7Ow5zDYV9etmRgz0qjMm1yP9gCuq/s4WxTcZnqwNxtYCmEgt7LDFBMUUNs3vxeaCP8/ntQoRMvNNAjGz25r8bg8K8svViTWyB53C5hnXUYpvHZx8fKhExLOLt6qXuNmZCbcVxvUgg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN4PR01MB7455.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(136003)(346002)(396003)(376002)(39850400004)(451199018)(2906002)(8936002)(83380400001)(5660300002)(41300700001)(478600001)(6666004)(107886003)(6486002)(1076003)(26005)(186003)(66946007)(52116002)(6512007)(2616005)(6506007)(38100700002)(38350700002)(86362001)(4326008)(8676002)(66476007)(66556008)(54906003)(110136005)(316002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HpXTjnsuOKLkt93t3uK/hNBD4MPAZvrQDL6PirhdfVZ7Lx0pXsr52eSc5hBw?= =?us-ascii?Q?4VvxBXsXh2D69/G05dS3zyI6h26a+SSwYpZSqhImTDXetEhzhuFNYaZEiDp/?= =?us-ascii?Q?vSGrMNQj1sIxXbBqOKUCjDzld0GFLnIzb68XN1p9xza/J8W0F8U/z3hRDpgg?= =?us-ascii?Q?+DXmeQpqmE4cfZnQBS9bQc22yVO66e2+Lfk/L3Vm6XBa92E2ApafE8QQTLiU?= =?us-ascii?Q?s6XGHMWZ4JhxjQw++/3oW+FRLoYHb2yd95DwyRAVC45fg3tXvb2zfB6ITnub?= =?us-ascii?Q?iCEhcoa/+0i05NUKLldPrFSEVIQ9b/+ao2G6NFRzjDaolgsJemHOXtB78hVN?= =?us-ascii?Q?Ya0Xg6COM3XWIEaqWqFDVbt9fLuU1ymM7DVJvSljtAGm7aaHNvHhBP9XsvG7?= =?us-ascii?Q?sXq0NXPSHt3QKYDDzh3ogLBGalBn42bLiJQ0CvI78GNRZwEu7J6AOgkRpRbq?= =?us-ascii?Q?sNeoDXwO40f4ZAC0AYsYzvuCbxjVkmp1dK6C6MoFGaoWFIGGA/w5uhJu0Xyx?= =?us-ascii?Q?PZzSvD1ODG7Kzv/VyFdQKLqbTZMPY7aVRYVquAHQMbEmOelTIJ7GUEr35D07?= =?us-ascii?Q?tCbao73blJo+UuDQiM/n9cukdqj01E9dLS3UyWz0Rkzj9ruENKSY8pGXyKJx?= =?us-ascii?Q?GJFNuE89amNwALN+VBCAQON3ZbvsJWVyiftxNDbu02IidOMrzLwABM/iFoVE?= =?us-ascii?Q?6B2Lw+34pgVOvXFe2xQLWT00/69s1THvg54oS4tLb8RE4P8u8ry7dvdTw6FD?= =?us-ascii?Q?A8X9aXzNYhgifs9qptB99ZMGEeryhmOzg2nTzZ9cyAgTQUONgims07JEP6ov?= =?us-ascii?Q?dHbEU87p98M4OfQsRiBKdJTjl4KMF4XFZhy5bxWtWoICI5kJxOdZ7JhTZfii?= =?us-ascii?Q?Qtaf214qhAdjM549BNDF4NpBiStT8EopkVfs5a+fHOYN+IcdCNXIKU1tvp4y?= =?us-ascii?Q?+C3OJhXeXD4+nKRwdBkLnblCrYw2HSywHVrwqiw9oFEsyHccapZ8paJj3nKA?= =?us-ascii?Q?j2P5MK0PKz0R4+8tIdJSz8S+6C9vtBKfFmn0YyEBjOn3v11uxpBb972Sdz0l?= =?us-ascii?Q?5F2vJV0FKljnwkE4lZNDdK4CkBtl5W+PByL8xQK+TsG0GdC4mBOPNiRQ8i6h?= =?us-ascii?Q?A0y/B0v/oT6QIV93IHpiOysJExaN9SS+9fWaAR0uFacc10Qanp0Ks1D5806v?= =?us-ascii?Q?U65uvwJL25MV3CcrZutAq8QUU3XlRVGHJIxduedyCQ5Lo6wysThoXmlFoUAO?= =?us-ascii?Q?eqwJPgtIdKjal+OHAq31rSWOze1UcAI7HIeJodg5JMEmG2nGgRBnaTEKqOsC?= =?us-ascii?Q?wKtGOcJCDPoXPGXck7JV9hZoVnFsa6AZH7fw5iX35zHBa1uhua+u0qF0FiQr?= =?us-ascii?Q?d07ACdBrtt20+gMKAQjO6oPAZ6W6jiOBxB6/nSxzTri9/xvFtMQwedUpSM3+?= =?us-ascii?Q?yxkecWPeSoLJWZgqOehbEBuIjl+DO2tR3iAqI0xxIhIb65FMpl92EFVZL2eU?= =?us-ascii?Q?3POHvF4TqfaxbvHCVmqwvKaqIp6tSl+ufIaV2F78imS+R+RQmWds1ufrMhGc?= =?us-ascii?Q?K4E+1q9FowiWNxEPhlsO5jHS69gDIcOh3bKyj7VyJU+GPdZ12yHuziR7es8f?= =?us-ascii?Q?I+kVqj7s2sEAOKc+JbNJu6g=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c2b7dc1-3261-40b9-ebfb-08db0e571508 X-MS-Exchange-CrossTenant-AuthSource: SN4PR01MB7455.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2023 06:45:38.2762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Eo0RfXqXuxXyr34Heigbm8FfdqfX+pcsKnMrKnk+yQlXakxvsDBUX/eUql0omiM8BmQ7438lca3cvOrCKLu1NEEiuljogpCCWPgn1tEo/38= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR01MB7738 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Adds event_dimm[0-15]_syndrome sysfs to report the failure syndrome to BMC when DIMM training failed. Signed-off-by: Quan Nguyen --- .../sysfs-bus-platform-devices-ampere-smpro | 10 +++ drivers/misc/smpro-errmon.c | 77 +++++++++++++++++++ 2 files changed, 87 insertions(+) diff --git a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-sm= pro b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro index d4e3f308c451..c35f1d45e656 100644 --- a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro +++ b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro @@ -265,6 +265,16 @@ Description: For more details, see section `5.7 GPI Status Registers and 5.9 Memory E= rror Register Definitions, Altra Family Soc BMC Interface Specification`. =20 +What: /sys/bus/platform/devices/smpro-errmon.*/event_dimm[0-15]_syndrome +KernelVersion: 6.1 +Contact: Quan Nguyen +Description: + (RO) The sysfs returns the 2-byte DIMM failure syndrome data for slot + 0-15 if it failed to initialized. + + For more details, see section `5.11 Boot Stage Register Definitions, + Altra Family Soc BMC Interface Specification`. + What: /sys/bus/platform/devices/smpro-misc.*/boot_progress KernelVersion: 6.1 Contact: Quan Nguyen diff --git a/drivers/misc/smpro-errmon.c b/drivers/misc/smpro-errmon.c index 1635e881aefb..3e8570cbb740 100644 --- a/drivers/misc/smpro-errmon.c +++ b/drivers/misc/smpro-errmon.c @@ -47,6 +47,12 @@ #define WARN_PMPRO_INFO_LO 0xAC #define WARN_PMPRO_INFO_HI 0xAD =20 +/* Boot Stage Register */ +#define BOOTSTAGE 0xB0 +#define DIMM_SYNDROME_SEL 0xB4 +#define DIMM_SYNDROME_ERR 0xB5 +#define DIMM_SYNDROME_STAGE 4 + /* PCIE Error Registers */ #define PCIE_CE_ERR_CNT 0xC0 #define PCIE_CE_ERR_LEN 0xC1 @@ -468,6 +474,61 @@ EVENT_RO(vrd_hot, VRD_HOT_EVENT); EVENT_RO(dimm_hot, DIMM_HOT_EVENT); EVENT_RO(dimm_2x_refresh, DIMM_2X_REFRESH_EVENT); =20 +static ssize_t smpro_dimm_syndrome_read(struct device *dev, struct device_= attribute *da, + char *buf, int slot) +{ + struct smpro_errmon *errmon =3D dev_get_drvdata(dev); + s32 data; + int ret; + + ret =3D regmap_read(errmon->regmap, BOOTSTAGE, &data); + if (ret) + return ret; + + /* check for valid stage */ + data =3D (data >> 8) & 0xff; + if (data !=3D DIMM_SYNDROME_STAGE) + return ret; + + /* Write the slot ID to retrieve Error Syndrome */ + ret =3D regmap_write(errmon->regmap, DIMM_SYNDROME_SEL, slot); + if (ret) + return ret; + + /* Read the Syndrome error */ + ret =3D regmap_read(errmon->regmap, DIMM_SYNDROME_ERR, &data); + if (ret || !data) + return ret; + + return sysfs_emit(buf, "%04x\n", data); +} + +#define EVENT_DIMM_SYNDROME(_slot) \ + static ssize_t event_dimm##_slot##_syndrome_show(struct device *dev, = \ + struct device_attribute *da, \ + char *buf) \ + { = \ + return smpro_dimm_syndrome_read(dev, da, buf, _slot); \ + } = \ + static DEVICE_ATTR_RO(event_dimm##_slot##_syndrome) + +EVENT_DIMM_SYNDROME(0); +EVENT_DIMM_SYNDROME(1); +EVENT_DIMM_SYNDROME(2); +EVENT_DIMM_SYNDROME(3); +EVENT_DIMM_SYNDROME(4); +EVENT_DIMM_SYNDROME(5); +EVENT_DIMM_SYNDROME(6); +EVENT_DIMM_SYNDROME(7); +EVENT_DIMM_SYNDROME(8); +EVENT_DIMM_SYNDROME(9); +EVENT_DIMM_SYNDROME(10); +EVENT_DIMM_SYNDROME(11); +EVENT_DIMM_SYNDROME(12); +EVENT_DIMM_SYNDROME(13); +EVENT_DIMM_SYNDROME(14); +EVENT_DIMM_SYNDROME(15); + static struct attribute *smpro_errmon_attrs[] =3D { &dev_attr_overflow_core_ce.attr, &dev_attr_overflow_core_ue.attr, @@ -493,6 +554,22 @@ static struct attribute *smpro_errmon_attrs[] =3D { &dev_attr_event_vrd_hot.attr, &dev_attr_event_dimm_hot.attr, &dev_attr_event_dimm_2x_refresh.attr, + &dev_attr_event_dimm0_syndrome.attr, + &dev_attr_event_dimm1_syndrome.attr, + &dev_attr_event_dimm2_syndrome.attr, + &dev_attr_event_dimm3_syndrome.attr, + &dev_attr_event_dimm4_syndrome.attr, + &dev_attr_event_dimm5_syndrome.attr, + &dev_attr_event_dimm6_syndrome.attr, + &dev_attr_event_dimm7_syndrome.attr, + &dev_attr_event_dimm8_syndrome.attr, + &dev_attr_event_dimm9_syndrome.attr, + &dev_attr_event_dimm10_syndrome.attr, + &dev_attr_event_dimm11_syndrome.attr, + &dev_attr_event_dimm12_syndrome.attr, + &dev_attr_event_dimm13_syndrome.attr, + &dev_attr_event_dimm14_syndrome.attr, + &dev_attr_event_dimm15_syndrome.attr, NULL }; =20 --=20 2.35.1