From nobody Fri Sep 12 05:09:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A038C636CC for ; Mon, 13 Feb 2023 15:09:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231481AbjBMPJI (ORCPT ); Mon, 13 Feb 2023 10:09:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229680AbjBMPJG (ORCPT ); Mon, 13 Feb 2023 10:09:06 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFDAC1BD4 for ; Mon, 13 Feb 2023 07:09:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id F11ADCE0E93 for ; Mon, 13 Feb 2023 15:09:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 414AFC433D2; Mon, 13 Feb 2023 15:08:49 +0000 (UTC) Date: Mon, 13 Feb 2023 10:08:36 -0500 From: Steven Rostedt To: Linus Torvalds Cc: LKML , Masami Hiramatsu , Andrew Morton , Yafang Shao Subject: [GIT PULL] tracing: Make trace_define_field_ext() static Message-ID: <20230213100836.33d2b0b0@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Linus, tracing: Make trace_define_field_ext() static Just after the fix to TASK_COMM_LEN not converted to its value in trace_events was pulled, the kernel test robot reported that the helper function trace_define_field_ext() added to that change was only used in the file it was defined in but was not declared static. Make it a local function. Please pull the latest trace-v6.2-rc7-2 tree, which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace.git trace-v6.2-rc7-2 Tag SHA1: 3883ec09ec4e45286f3c09d4a88dbde8b328573c Head SHA1: 70b5339caf847b8b6097b6dfab0c5a99b40713c8 Steven Rostedt (Google) (1): tracing: Make trace_define_field_ext() static ---- kernel/trace/trace_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --------------------------- commit 70b5339caf847b8b6097b6dfab0c5a99b40713c8 Author: Steven Rostedt (Google) Date: Sun Feb 12 20:11:42 2023 -0500 tracing: Make trace_define_field_ext() static =20 trace_define_field_ext() is not used outside of trace_events.c, it shou= ld be static. =20 Link: https://lore.kernel.org/oe-kbuild-all/202302130750.679RaRog-lkp@i= ntel.com/ =20 Fixes: b6c7abd1c28a ("tracing: Fix TASK_COMM_LEN in trace event format = file") Reported-by: Reported-by: kernel test robot Signed-off-by: Steven Rostedt (Google) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 6a4696719297..6a942fa275c7 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -155,7 +155,7 @@ int trace_define_field(struct trace_event_call *call, c= onst char *type, } EXPORT_SYMBOL_GPL(trace_define_field); =20 -int trace_define_field_ext(struct trace_event_call *call, const char *type, +static int trace_define_field_ext(struct trace_event_call *call, const cha= r *type, const char *name, int offset, int size, int is_signed, int filter_type, int len) {