From nobody Thu Nov 14 07:16:49 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F3AC636CC for ; Mon, 13 Feb 2023 04:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229477AbjBMEPv (ORCPT ); Sun, 12 Feb 2023 23:15:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229589AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 182B8E398; Sun, 12 Feb 2023 20:15:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=b2TQAFC9pQ+rFyre5LGzTHnEk3iqoypnovZvNJTJtgQ=; b=tt2oG+eQWgWsZl+xyvKM8MNAxj VxZJMIDE6T3wn23KcFzBD2dZVlX3BTABLB+4WrBlgaRzb3rdD0dpboH8TYGeHiU2lhtkx0SY/WCcj VhcGdaq6k7QC+QmoafepvH76tngi5sLd4M6iRNNfvtbh+M4hWKo2F0oiYBxHhCmZpoP96sDZckkqe 4rCFVUvZxuSw6zPA3AawRwJAmUfXZGtOjvS+FeTbxlsP+G62MvLGcSAOz7CP+XxzONhy4JAMFoBRR jvA6VS63YbZlktpuhP/73IAV4Q+eSz38jmc2cOuzML+Nsu040MaMbXOdEQpag8pVY5K81qU/j/v2E fW58fEIA==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFh-00D56G-7X; Mon, 13 Feb 2023 04:15:41 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , Eddie Huang , Sean Wang , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Marc Zyngier , Philipp Zabel , Peter Rosin Subject: [PATCH 3/3] rtc: mt6397: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:35 -0800 Message-Id: <20230213041535.12083-4-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change the use of "depends on" for IRQ_DOMAIN to "select" for RTC_DRV_MT6397. Fixes: 04d3ba70a3c9 ("rtc: mt6397: add IRQ domain dependency") Signed-off-by: Randy Dunlap Cc: Arnd Bergmann Cc: Eddie Huang Cc: Sean Wang Cc: Matthias Brugger Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: Alessandro Zummo Cc: Alexandre Belloni Cc: linux-rtc@vger.kernel.org Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Reviewed-by: AngeloGioacchino Del Regno --- I have a similar patch (should be a series) for REGMAP. drivers/rtc/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig --- a/drivers/rtc/Kconfig +++ b/drivers/rtc/Kconfig @@ -1814,7 +1814,8 @@ config RTC_DRV_MT2712 =20 config RTC_DRV_MT6397 tristate "MediaTek PMIC based RTC" - depends on MFD_MT6397 || (COMPILE_TEST && IRQ_DOMAIN) + depends on MFD_MT6397 || COMPILE_TEST + select IRQ_DOMAIN help This selects the MediaTek(R) RTC driver. RTC is part of MediaTek MT6397 PMIC. You should enable MT6397 PMIC MFD before select