From nobody Wed Nov 13 06:46:34 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94EC3C636D7 for ; Mon, 13 Feb 2023 04:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229628AbjBMEPy (ORCPT ); Sun, 12 Feb 2023 23:15:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229581AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7C8BE396 for ; Sun, 12 Feb 2023 20:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=7EM0k4yf3TlWpm0n08kPMpGLehSGSAexr0X/ND2utsk=; b=en4qp0vWpgwjNqCR4CxWOb5O7G m5x0DwxA7IbG+ddJ/QOh/85G88XNLlR9Cb/RtIK1YxZuCRRBmnrQtvsGD9vc+fWi7xBC573DGBt6I BiUwLHQ/Dx/Y0wFBwOo+FQH5HD+q51PFy71EgWqddTqm7zHfY8Pk4biBDm4LVuHq+pxZSYE0jUpvB L1Rhfk3Z4v8YQ2q5qH7p/gbRn4ws3BV56G5mGd9eH8phgTi0rioI9hNAnDKvsr7NmgGlQyZ1i2dRf hoPwjpt3KJ+iO+13Ij6VUwtORq4vLxgfLOSAvWs0TXtznk65QDW4Gv7+P0vzURUqELBs7Dnt5VdZd nmqgFyDw==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFg-00D56G-7N; Mon, 13 Feb 2023 04:15:40 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Geert Uytterhoeven , Rob Herring , Marc Zyngier , Arnd Bergmann , Philipp Zabel , Peter Rosin Subject: [PATCH 2/3] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:34 -0800 Message-Id: <20230213041535.12083-3-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change OF_IRQ's use of "depends on" to "select". This patch reduces one Kconfig circular dependency in drivers/mux/Kconfig when MUX_MMIO attempts to select REGMAP, which that driver needs (but does not completely resolve that issue). [1] [1] https://lore.kernel.org/lkml/20230210115625.GA30942@pengutronix.de/ Fixes: 63c60e3a6dc3 ("of: OF_IRQ should depend on IRQ_DOMAIN") Signed-off-by: Randy Dunlap Cc: Geert Uytterhoeven Cc: Rob Herring Cc: Marc Zyngier Cc: Arnd Bergmann Cc: Philipp Zabel Cc: Peter Rosin --- I have a similar patch (should be a series) for REGMAP. drivers/of/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig --- a/drivers/of/Kconfig +++ b/drivers/of/Kconfig @@ -68,7 +68,8 @@ config OF_ADDRESS =20 config OF_IRQ def_bool y - depends on !SPARC && IRQ_DOMAIN + depends on !SPARC + select IRQ_DOMAIN =20 config OF_RESERVED_MEM def_bool OF_EARLY_FLATTREE