From nobody Thu Nov 14 07:10:57 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD721C6379F for ; Mon, 13 Feb 2023 04:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229687AbjBMEPt (ORCPT ); Sun, 12 Feb 2023 23:15:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbjBMEPq (ORCPT ); Sun, 12 Feb 2023 23:15:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEAEBCA2F for ; Sun, 12 Feb 2023 20:15:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=KP+QUTQLUK2eLfgHq5KRvNPggllLGVnWdOEMxnpKkT0=; b=cAOtQYru6OXsUMRBFJy+DckahO 44CgxcULv8NnYNsA+AZAPfSqrt3F2nv7INKfutwhVAJh3363RQIgqeTbtJ5lJhx86bC8s33Uymac3 y40xl8TwQTFjL2GCWnzrHiZgSFTWciXhoMjURFivyjmwTwz3CPzeSH24CKL5ildUox+xl2I6E2fne GIk6FBdMXV/3Qq0Aj/AthbBXZONaIX/IJ+cqxgufAaBhaKfBRW9CaPqImEPttO/6yuCzs+cmrzdre tzxnRP7Ie7QYIyiBPahk0eKz+vWZKjoPax7qRdzszQZxJuLMGc0RcCADt9MqWsXWDOGSBZhfsztUx FrNYgaqA==; Received: from [2601:1c2:980:9ec0::df2f] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRQFf-00D56G-Jq; Mon, 13 Feb 2023 04:15:39 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Arnd Bergmann , MyungJoo Ham , Chanwoo Choi , Donggeun Kim , Marc Zyngier , Philipp Zabel , Peter Rosin , Greg Kroah-Hartman Subject: [PATCH 1/3] extcon: max8997: select IRQ_DOMAIN instead of depending on it Date: Sun, 12 Feb 2023 20:15:33 -0800 Message-Id: <20230213041535.12083-2-rdunlap@infradead.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230213041535.12083-1-rdunlap@infradead.org> References: <20230213041535.12083-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" IRQ_DOMAIN is a hidden (not user visible) symbol. Users cannot set it directly thru "make *config", so drivers should select it instead of depending on it if they need it. Relying on it being set for a dependency is risky. Consistently using "select" or "depends on" can also help reduce Kconfig circular dependency issues. Therefore, change EXTCON_MAX8997's use of "depends on" for IRQ_DOMAIN to "select". Fixes: dca1a71e4108 ("extcon: Add support irq domain for MAX8997 muic") Signed-off-by: Randy Dunlap Cc: Arnd Bergmann Cc: MyungJoo Ham Cc: Chanwoo Choi Cc: Donggeun Kim Cc: Marc Zyngier Cc: Philipp Zabel Cc: Peter Rosin Cc: Greg Kroah-Hartman --- I have a similar patch (should be a series) for REGMAP. drivers/extcon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -- a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig --- a/drivers/extcon/Kconfig +++ b/drivers/extcon/Kconfig @@ -115,7 +115,8 @@ config EXTCON_MAX77843 =20 config EXTCON_MAX8997 tristate "Maxim MAX8997 EXTCON Support" - depends on MFD_MAX8997 && IRQ_DOMAIN + depends on MFD_MAX8997 + select IRQ_DOMAIN help If you say yes here you get support for the MUIC device of Maxim MAX8997 PMIC. The MAX8997 MUIC is a USB port accessory