From nobody Fri Sep 12 10:42:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED727C636CC for ; Sat, 11 Feb 2023 14:43:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229826AbjBKOnY (ORCPT ); Sat, 11 Feb 2023 09:43:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229827AbjBKOm7 (ORCPT ); Sat, 11 Feb 2023 09:42:59 -0500 Received: from hosting.gsystem.sk (hosting.gsystem.sk [212.5.213.30]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 647912A9AF; Sat, 11 Feb 2023 06:42:53 -0800 (PST) Received: from gsql.ggedos.sk (off-20.infotel.telecom.sk [212.5.213.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by hosting.gsystem.sk (Postfix) with ESMTPSA id E4C077A06EC; Sat, 11 Feb 2023 15:42:49 +0100 (CET) From: Ondrej Zary To: Damien Le Moal Cc: Christoph Hellwig , Sergey Shtylyov , Jens Axboe , Tim Waugh , linux-block@vger.kernel.org, linux-parport@lists.infradead.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/12] pata_parport: use dev_* and print_hex_* instead of printk Date: Sat, 11 Feb 2023 15:42:28 +0100 Message-Id: <20230211144232.15138-9-linux@zary.sk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20230211144232.15138-1-linux@zary.sk> References: <20230211144232.15138-1-linux@zary.sk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use dev_info/dev_err/dev_dbg/print_hex_* instead of printk. Remove version print from log_adapter and meaningless VERSION defines. Remove now useless verbose parameter of bpck6 module. Signed-off-by: Ondrej Zary --- drivers/ata/pata_parport/aten.c | 8 ++--- drivers/ata/pata_parport/bpck.c | 31 ++++-------------- drivers/ata/pata_parport/bpck6.c | 56 +++++++------------------------- drivers/ata/pata_parport/comm.c | 8 ++--- drivers/ata/pata_parport/dstr.c | 8 ++--- drivers/ata/pata_parport/epat.c | 15 +++------ drivers/ata/pata_parport/epia.c | 14 +++----- drivers/ata/pata_parport/fit2.c | 6 ++-- drivers/ata/pata_parport/fit3.c | 9 ++--- drivers/ata/pata_parport/friq.c | 14 +++----- drivers/ata/pata_parport/frpw.c | 22 ++++--------- drivers/ata/pata_parport/kbic.c | 8 ++--- drivers/ata/pata_parport/ktti.c | 7 ++-- drivers/ata/pata_parport/on20.c | 8 ++--- drivers/ata/pata_parport/on26.c | 10 ++---- 15 files changed, 57 insertions(+), 167 deletions(-) diff --git a/drivers/ata/pata_parport/aten.c b/drivers/ata/pata_parport/ate= n.c index 3f5c50c2c43a..dbdd89d091df 100644 --- a/drivers/ata/pata_parport/aten.c +++ b/drivers/ata/pata_parport/aten.c @@ -15,8 +15,6 @@ =20 */ =20 -#define ATEN_VERSION "1.01" - #include #include #include @@ -124,10 +122,8 @@ static void aten_log_adapter(struct pi_adapter *pi) =20 { char *mode_string[2] =3D {"4-bit","8-bit"}; =20 - printk("aten %s, ATEN EH-100 at 0x%x, ", ATEN_VERSION, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "ATEN EH-100 at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol aten =3D { diff --git a/drivers/ata/pata_parport/bpck.c b/drivers/ata/pata_parport/bpc= k.c index 89160a94b30e..d5bc419b2ab3 100644 --- a/drivers/ata/pata_parport/bpck.c +++ b/drivers/ata/pata_parport/bpck.c @@ -14,8 +14,6 @@ =20 */ =20 -#define BPCK_VERSION "1.02"=20 - #include #include #include @@ -334,12 +332,9 @@ static int bpck_test_proto(struct pi_adapter *pi, char= *scratch, int verbose) =20 } =20 - if (verbose) { - printk("bpck: 0x%x unit %d mode %d: ", - pi->port, pi->unit, pi->mode); - for (i=3D0;idev, "bpck: 0x%x unit %d mode %d: ", + pi->port, pi->unit, pi->mode); + print_hex_dump_debug("bpck: ", DUMP_PREFIX_NONE, TEST_LEN, 1, buf, TEST_L= EN, false); =20 e =3D 0; for (i=3D0;i '~')) - scratch[i] =3D '.'; - printk("bpck EEPROM: %64.64s\n", scratch); - printk(" %64.64s\n", &scratch[64]); -#endif - - printk("bpck %s, backpack %8.8s unit %d", - BPCK_VERSION, &scratch[110], pi->unit); - printk(" at 0x%x, mode %d (%s), delay %d\n",pi->port, - pi->mode,mode_string[pi->mode],pi->delay); + print_hex_dump_bytes("bpck EEPROM: ", DUMP_PREFIX_NONE, scratch, 128); + dev_info(&pi->dev, "backpack %8.8s unit %d at 0x%x, mode %d (%s), delay %= d\n", + &scratch[110], pi->unit, pi->port, pi->mode, + mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol bpck =3D { diff --git a/drivers/ata/pata_parport/bpck6.c b/drivers/ata/pata_parport/bp= ck6.c index 41395a97d77c..08dbc1bca4b9 100644 --- a/drivers/ata/pata_parport/bpck6.c +++ b/drivers/ata/pata_parport/bpck6.c @@ -19,9 +19,6 @@ Version 2.0.2 - fixed version string usage, and made ppc functions stat= ic=20 */ =20 - -#define BACKPACK_VERSION "2.0.2" - #include #include #include @@ -33,10 +30,6 @@ #include "ppc6lnx.c" #include =20 -/* PARAMETERS */ -static bool verbose; /* set this to 1 to see debugging messages and whatno= t */ -=20 - #define PPCSTRUCT(pi) ((Interface *)(pi->private)) =20 /****************************************************************/ @@ -90,10 +83,7 @@ static void bpck6_read_block(struct pi_adapter *pi, char= *buf, int len) =20 static void bpck6_connect(struct pi_adapter *pi) { - if(verbose) - { - printk(KERN_DEBUG "connect\n"); - } + dev_dbg(&pi->dev, "connect\n"); =20 if(pi->mode >=3D2) { @@ -114,22 +104,16 @@ static void bpck6_connect(struct pi_adapter *pi) =20 static void bpck6_disconnect(struct pi_adapter *pi) { - if(verbose) - { - printk("disconnect\n"); - } + dev_dbg(&pi->dev, "disconnect\n"); ppc6_wr_extout(PPCSTRUCT(pi),0x0); ppc6_close(PPCSTRUCT(pi)); } =20 static int bpck6_test_port(struct pi_adapter *pi) /* check for 8-bit por= t */ { - if(verbose) - { - printk(KERN_DEBUG "PARPORT indicates modes=3D%x for lp=3D0x%lx\n", - ((struct pardevice*)(pi->pardev))->port->modes, - ((struct pardevice *)(pi->pardev))->port->base);=20 - } + dev_dbg(&pi->dev, "PARPORT indicates modes=3D%x for lp=3D0x%lx\n", + ((struct pardevice *)(pi->pardev))->port->modes, + ((struct pardevice *)(pi->pardev))->port->base); =20 /*copy over duplicate stuff.. initialize state info*/ PPCSTRUCT(pi)->ppc_id=3Dpi->unit; @@ -158,10 +142,7 @@ static int bpck6_probe_unit(struct pi_adapter *pi) { int out; =20 - if(verbose) - { - printk(KERN_DEBUG "PROBE UNIT %x on port:%x\n",pi->unit,pi->port); - } + dev_dbg(&pi->dev, "PROBE UNIT %x on port:%x\n", pi->unit, pi->port); =20 /*SET PPC UNIT NUMBER*/ PPCSTRUCT(pi)->ppc_id=3Dpi->unit; @@ -170,27 +151,17 @@ static int bpck6_probe_unit(struct pi_adapter *pi) PPCSTRUCT(pi)->mode=3D1; =09 =20 out=3Dppc6_open(PPCSTRUCT(pi)); - - if(verbose) - { - printk(KERN_DEBUG "ppc_open returned %2x\n",out); - } + dev_dbg(&pi->dev, "ppc_open returned %2x\n", out); =20 if(out) { ppc6_close(PPCSTRUCT(pi)); - if(verbose) - { - printk(KERN_DEBUG "leaving probe\n"); - } + dev_dbg(&pi->dev, "leaving probe\n"); return(1); } else { - if(verbose) - { - printk(KERN_DEBUG "Failed open\n"); - } + dev_dbg(&pi->dev, "Failed open\n"); return(0); } } @@ -200,10 +171,8 @@ static void bpck6_log_adapter(struct pi_adapter *pi) char *mode_string[5]=3D {"4-bit","8-bit","EPP-8","EPP-16","EPP-32"}; =20 - printk("BACKPACK %s, Micro Solutions BACKPACK Drive at 0x%x\n", - BACKPACK_VERSION, pi->port); - printk("Unit: %d Mode:%d (%s) Delay %d\n", - pi->unit,pi->mode,mode_string[pi->mode],pi->delay); + dev_info(&pi->dev, "Micro Solutions BACKPACK Drive unit %d at 0x%x, mode:= %d (%s), delay %d\n", + pi->unit, pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static int bpck6_init_proto(struct pi_adapter *pi) @@ -215,7 +184,7 @@ static int bpck6_init_proto(struct pi_adapter *pi) return 0; } =20 - printk(KERN_ERR "ERROR COULDN'T ALLOCATE MEMORY\n"); + dev_err(&pi->dev, "ERROR COULDN'T ALLOCATE MEMORY\n"); return -1; } =20 @@ -246,5 +215,4 @@ static struct pi_protocol bpck6 =3D { MODULE_LICENSE("GPL"); MODULE_AUTHOR("Micro Solutions Inc."); MODULE_DESCRIPTION("BACKPACK Protocol module, compatible with PARIDE"); -module_param(verbose, bool, 0644); module_pata_parport_driver(bpck6); diff --git a/drivers/ata/pata_parport/comm.c b/drivers/ata/pata_parport/com= m.c index 88476072b708..8f0b55c1493a 100644 --- a/drivers/ata/pata_parport/comm.c +++ b/drivers/ata/pata_parport/comm.c @@ -14,8 +14,6 @@ =20 */ =20 -#define COMM_VERSION "1.01" - #include #include #include @@ -183,10 +181,8 @@ static void comm_log_adapter(struct pi_adapter *pi) =20 { char *mode_string[5] =3D {"4-bit","8-bit","EPP-8","EPP-16","EPP= -32"}; =20 - printk("comm %s, DataStor Commuter at 0x%x, ", COMM_VERSION, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "DataStor Commuter at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol comm =3D { diff --git a/drivers/ata/pata_parport/dstr.c b/drivers/ata/pata_parport/dst= r.c index a8b238828061..c0e44f33ae37 100644 --- a/drivers/ata/pata_parport/dstr.c +++ b/drivers/ata/pata_parport/dstr.c @@ -13,8 +13,6 @@ =20 */ =20 -#define DSTR_VERSION "1.01" - #include #include #include @@ -195,10 +193,8 @@ static void dstr_log_adapter(struct pi_adapter *pi) { char *mode_string[5] =3D {"4-bit","8-bit","EPP-8", "EPP-16","EPP-32"}; =20 - printk("dstr %s, DataStor EP2000 at 0x%x, ", DSTR_VERSION, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "DataStor EP2000 at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol dstr =3D { diff --git a/drivers/ata/pata_parport/epat.c b/drivers/ata/pata_parport/epa= t.c index 54b81f785fce..ceeaf36d912d 100644 --- a/drivers/ata/pata_parport/epat.c +++ b/drivers/ata/pata_parport/epat.c @@ -16,8 +16,6 @@ =20 */ =20 -#define EPAT_VERSION "1.02" - #include #include #include @@ -279,10 +277,8 @@ static int epat_test_proto(struct pi_adapter *pi, char= *scratch, int verbose) } epat_disconnect(pi); =20 - if (verbose) { - printk("epat: port 0x%x, mode %d, ccr %x, test=3D(%d,%d,%d)\n", - pi->port, pi->mode, cc, e[0], e[1], f); - } + dev_dbg(&pi->dev, "epat: port 0x%x, mode %d, ccr %x, test=3D(%d,%d,%d)\n", + pi->port, pi->mode, cc, e[0], e[1], f); =09 return (e[0] && e[1]) || f; } @@ -298,11 +294,8 @@ static void epat_log_adapter(struct pi_adapter *pi) ver =3D RR(0xb); epat_disconnect(pi); =20 - printk("epat %s, Shuttle EPAT chip %x at 0x%x, ", - EPAT_VERSION, ver, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "Shuttle EPAT chip %x at 0x%x, mode %d (%s), delay %d\= n", + ver, pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol epat =3D { diff --git a/drivers/ata/pata_parport/epia.c b/drivers/ata/pata_parport/epi= a.c index ece7862dc058..8bbe3b2c7634 100644 --- a/drivers/ata/pata_parport/epia.c +++ b/drivers/ata/pata_parport/epia.c @@ -17,8 +17,6 @@ =20 */ =20 -#define EPIA_VERSION "1.02" - #include #include #include @@ -262,10 +260,8 @@ static int epia_test_proto(struct pi_adapter *pi, char= *scratch, int verbose) WR(0x84,0); epia_disconnect(pi); =20 - if (verbose) { - printk("epia: port 0x%x, mode %d, test=3D(%d,%d,%d)\n", - pi->port, pi->mode, e[0], e[1], f); - } + dev_dbg(&pi->dev, "epia: port 0x%x, mode %d, test=3D(%d,%d,%d)\n", + pi->port, pi->mode, e[0], e[1], f); =20 return (e[0] && e[1]) || f; =20 @@ -277,10 +273,8 @@ static void epia_log_adapter(struct pi_adapter *pi) { char *mode_string[6] =3D {"4-bit","5/3","8-bit", "EPP-8","EPP-16","EPP-32"}; =20 - printk("epia %s, Shuttle EPIA at 0x%x, ", EPIA_VERSION, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "Shuttle EPIA at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol epia =3D { diff --git a/drivers/ata/pata_parport/fit2.c b/drivers/ata/pata_parport/fit= 2.c index 33cdc9bbfff4..a32250c9d042 100644 --- a/drivers/ata/pata_parport/fit2.c +++ b/drivers/ata/pata_parport/fit2.c @@ -13,8 +13,6 @@ =20 */ =20 -#define FIT2_VERSION "1.0" - #include #include #include @@ -116,8 +114,8 @@ static void fit2_disconnect(struct pi_adapter *pi) static void fit2_log_adapter(struct pi_adapter *pi) =20 { - printk("fit2 %s, FIT 2000 adapter at 0x%x, delay %d\n", - FIT2_VERSION, pi->port, pi->delay); + dev_info(&pi->dev, "FIT 2000 adapter at 0x%x, delay %d\n", + pi->port, pi->delay); =20 } =20 diff --git a/drivers/ata/pata_parport/fit3.c b/drivers/ata/pata_parport/fit= 3.c index d5056b0157ab..cb2771de7c32 100644 --- a/drivers/ata/pata_parport/fit3.c +++ b/drivers/ata/pata_parport/fit3.c @@ -17,8 +17,6 @@ =20 */ =20 -#define FIT3_VERSION "1.0" - #include #include #include @@ -173,11 +171,8 @@ static void fit3_log_adapter(struct pi_adapter *pi) =20 { char *mode_string[3] =3D {"4-bit","8-bit","EPP"}; =20 - printk("fit3 %s, FIT 3000 adapter at 0x%x, " - "mode %d (%s), delay %d\n", - FIT3_VERSION, pi->port, - pi->mode,mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "FIT 3000 adapter at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol fit3 =3D { diff --git a/drivers/ata/pata_parport/friq.c b/drivers/ata/pata_parport/fri= q.c index bf597ee520b7..dae26a97ad4f 100644 --- a/drivers/ata/pata_parport/friq.c +++ b/drivers/ata/pata_parport/friq.c @@ -25,8 +25,6 @@ 1.01 GRG 1998.12.20 Added support for soft power switch */ =20 -#define FRIQ_VERSION "1.01"=20 - #include #include #include @@ -207,10 +205,8 @@ static int friq_test_proto(struct pi_adapter *pi, char= *scratch, int verbose) for (k=3D0;k<128;k++) if (scratch[k] !=3D k) r++; friq_disconnect(pi); =20 - if (verbose) { - printk("friq: port 0x%x, mode %d, test=3D(%d,%d,%d)\n", - pi->port, pi->mode, e[0], e[1], r); - } + dev_dbg(&pi->dev, "friq: port 0x%x, mode %d, test=3D(%d,%d,%d)\n", + pi->port, pi->mode, e[0], e[1], r); =20 return (r || (e[0] && e[1])); } @@ -221,10 +217,8 @@ static void friq_log_adapter(struct pi_adapter *pi) { char *mode_string[6] =3D {"4-bit","8-bit", "EPP-8","EPP-16","EPP-32"}; =20 - printk("friq %s, Freecom IQ ASIC-2 adapter at 0x%x, ", - FRIQ_VERSION,pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); + dev_info(&pi->dev, "Freecom IQ ASIC-2 adapter at 0x%x, mode %d (%s), dela= y %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); =20 pi->private =3D 1; friq_connect(pi); diff --git a/drivers/ata/pata_parport/frpw.c b/drivers/ata/pata_parport/frp= w.c index 9b8db1122154..92b359460e34 100644 --- a/drivers/ata/pata_parport/frpw.c +++ b/drivers/ata/pata_parport/frpw.c @@ -23,8 +23,6 @@ =20 */ =20 -#define FRPW_VERSION "1.03"=20 - #include #include #include @@ -230,14 +228,12 @@ static int frpw_test_proto(struct pi_adapter *pi, cha= r *scratch, int verbose) pi->private =3D frpw_test_pnp(pi) + 2*pi->port; =20 if (((pi->private%2) =3D=3D 0) && (pi->mode > 2)) { - if (verbose)=20 - printk("frpw: Xilinx does not support mode %d\n", pi->mode); + dev_dbg(&pi->dev, "frpw: Xilinx does not support mode %d\n", pi->mode); return 1; } =20 if (((pi->private%2) =3D=3D 1) && (pi->mode =3D=3D 2)) { - if (verbose) - printk("frpw: ASIC does not support mode 2\n"); + dev_dbg(&pi->dev, "frpw: ASIC does not support mode 2\n"); return 1; } =20 @@ -258,10 +254,8 @@ static int frpw_test_proto(struct pi_adapter *pi, char= *scratch, int verbose) for (k=3D0;k<128;k++) if (scratch[k] !=3D k) r++; frpw_disconnect(pi); =20 - if (verbose) { - printk("frpw: port 0x%x, chip %ld, mode %d, test=3D(%d,%d,%d)\n", - pi->port, (pi->private%2), pi->mode, e[0], e[1], r); - } + dev_dbg(&pi->dev, "frpw: port 0x%x, chip %ld, mode %d, test=3D(%d,%d,%d)\= n", + pi->port, (pi->private%2), pi->mode, e[0], e[1], r); =20 return (r || (e[0] && e[1])); } @@ -272,11 +266,9 @@ static void frpw_log_adapter(struct pi_adapter *pi) { char *mode_string[6] =3D {"4-bit","8-bit","EPP", "EPP-8","EPP-16","EPP-32"}; =20 - printk("frpw %s, Freecom (%s) adapter at 0x%x, ", - FRPW_VERSION,((pi->private%2) =3D=3D 0)?"Xilinx":"ASIC",pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "Freecom (%s) adapter at 0x%x, mode %d (%s), delay %d\= n", + ((pi->private % 2) =3D=3D 0) ? "Xilinx":"ASIC", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol frpw =3D { diff --git a/drivers/ata/pata_parport/kbic.c b/drivers/ata/pata_parport/kbi= c.c index db5e2081ed9c..94a3af034cae 100644 --- a/drivers/ata/pata_parport/kbic.c +++ b/drivers/ata/pata_parport/kbic.c @@ -18,8 +18,6 @@ =20 */ =20 -#define KBIC_VERSION "1.01" - #include #include #include @@ -234,10 +232,8 @@ static void kbic_log_adapter(struct pi_adapter *pi, ch= ar *chip) { char *mode_string[6] =3D {"4-bit","5/3","8-bit", "EPP-8","EPP_16","EPP-32"}; =20 - printk("kbic %s, KingByte %s at 0x%x, ", KBIC_VERSION, chip, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "KingByte %s at 0x%x, mode %d (%s), delay %d\n", + chip, pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static void k951_log_adapter(struct pi_adapter *pi) diff --git a/drivers/ata/pata_parport/ktti.c b/drivers/ata/pata_parport/ktt= i.c index 980da296cac4..5fd4d797720c 100644 --- a/drivers/ata/pata_parport/ktti.c +++ b/drivers/ata/pata_parport/ktti.c @@ -9,8 +9,6 @@ =20 */ =20 -#define KTTI_VERSION "1.0" - #include #include #include @@ -93,9 +91,8 @@ static void ktti_disconnect(struct pi_adapter *pi) static void ktti_log_adapter(struct pi_adapter *pi) =20 { - printk("ktti %s, KT adapter at 0x%x, delay %d\n", - KTTI_VERSION, pi->port, pi->delay); - + dev_info(&pi->dev, "KT adapter at 0x%x, delay %d\n", + pi->port, pi->delay); } =20 static struct pi_protocol ktti =3D { diff --git a/drivers/ata/pata_parport/on20.c b/drivers/ata/pata_parport/on2= 0.c index a3b0708aed71..540b6f842484 100644 --- a/drivers/ata/pata_parport/on20.c +++ b/drivers/ata/pata_parport/on20.c @@ -12,8 +12,6 @@ =20 */ =20 -#define ON20_VERSION "1.01" - #include #include #include @@ -115,10 +113,8 @@ static void on20_log_adapter(struct pi_adapter *pi) =20 { char *mode_string[2] =3D {"4-bit","8-bit"}; =20 - printk("on20 %s, OnSpec 90c20 at 0x%x, ", ON20_VERSION, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "OnSpec 90c20 at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol on20 =3D { diff --git a/drivers/ata/pata_parport/on26.c b/drivers/ata/pata_parport/on2= 6.c index 8dc8296d50e6..4ec1091ae6a7 100644 --- a/drivers/ata/pata_parport/on26.c +++ b/drivers/ata/pata_parport/on26.c @@ -16,8 +16,6 @@ =20 */ =20 -#define ON26_VERSION "1.04" - #include #include #include @@ -167,7 +165,7 @@ static int on26_test_port(struct pi_adapter *pi) /* ha= rd reset */ } =20 if (i =3D=3D RESET_WAIT)=20 - printk("on26: Device reset failed (%x,%x)\n",x,y); + dev_err(&pi->dev, "on26: Device reset failed (%x,%x)\n", x, y); =20 w0(4); P1; w0(4); P1; } @@ -280,10 +278,8 @@ static void on26_log_adapter(struct pi_adapter *pi) { char *mode_string[5] =3D {"4-bit","8-bit","EPP-8", "EPP-16","EPP-32"}; =20 - printk("on26 %s, OnSpec 90c26 at 0x%x, ", ON26_VERSION, pi->port); - printk("mode %d (%s), delay %d\n",pi->mode, - mode_string[pi->mode],pi->delay); - + dev_info(&pi->dev, "OnSpec 90c26 at 0x%x, mode %d (%s), delay %d\n", + pi->port, pi->mode, mode_string[pi->mode], pi->delay); } =20 static struct pi_protocol on26 =3D { --=20 Ondrej Zary