From nobody Sat Feb 7 09:47:46 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202F9C636D7 for ; Wed, 8 Feb 2023 11:14:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230255AbjBHLOI (ORCPT ); Wed, 8 Feb 2023 06:14:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230368AbjBHLNy (ORCPT ); Wed, 8 Feb 2023 06:13:54 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 018D1252A4 for ; Wed, 8 Feb 2023 03:13:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A83EAB81C6E for ; Wed, 8 Feb 2023 11:13:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 991A3C433EF; Wed, 8 Feb 2023 11:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675854827; bh=cn5nHUc6lR7TQRKfGigfXa7oBZoUPrcprKiU8P3aMFs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=opPdyg+UFomBXvB6bMf4nHe1J/FNTBYbatakbLOabCVEFxgwDdCfnZCF6+iIwDQfr R/ZFq2Uep5ut7gx5An0AWTOnlWsuhTYUoxCXwiogTMpVfNhrwVuau977PU5pCSfyUR MP+B+MimUnMeDIkRxWd7M8a4BXtY99kaAMJBhyWg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" Subject: [PATCH 10/21] driver core: bus: bus_register/unregister_notifier() cleanups Date: Wed, 8 Feb 2023 12:13:19 +0100 Message-Id: <20230208111330.439504-11-gregkh@linuxfoundation.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230208111330.439504-1-gregkh@linuxfoundation.org> References: <20230208111330.439504-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1893; i=gregkh@linuxfoundation.org; h=from:subject; bh=cn5nHUc6lR7TQRKfGigfXa7oBZoUPrcprKiU8P3aMFs=; b=owGbwMvMwCRo6H6F97bub03G02pJDMmPm68zxU7NDt2zJsnreVJJreQyn0tv8rx+XFVxUa+um/vE e+aujlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZjIuo0M831jXu7/cpk/8iXHjp6/l3 5tPRPz8TbDgrW2N0M2ThO4peaUMD3ywS6vbDHxtQA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Convert the bus_register_notifier() and bus_unregister_notifier() public functions to use bus_to_subsys() and not use the back-pointer to the private structure as well as the bus_notify() function. Cc: "Rafael J. Wysocki" Signed-off-by: Greg Kroah-Hartman --- drivers/base/bus.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c index 90627c68d02b..f23c6f6306e2 100644 --- a/drivers/base/bus.c +++ b/drivers/base/bus.c @@ -936,22 +936,40 @@ EXPORT_SYMBOL_GPL(bus_unregister); =20 int bus_register_notifier(struct bus_type *bus, struct notifier_block *nb) { - return blocking_notifier_chain_register(&bus->p->bus_notifier, nb); + struct subsys_private *sp =3D bus_to_subsys(bus); + int retval; + + if (!sp) + return -EINVAL; + + retval =3D blocking_notifier_chain_register(&sp->bus_notifier, nb); + subsys_put(sp); + return retval; } EXPORT_SYMBOL_GPL(bus_register_notifier); =20 int bus_unregister_notifier(struct bus_type *bus, struct notifier_block *n= b) { - return blocking_notifier_chain_unregister(&bus->p->bus_notifier, nb); + struct subsys_private *sp =3D bus_to_subsys(bus); + int retval; + + if (!sp) + return -EINVAL; + retval =3D blocking_notifier_chain_unregister(&sp->bus_notifier, nb); + subsys_put(sp); + return retval; } EXPORT_SYMBOL_GPL(bus_unregister_notifier); =20 void bus_notify(struct device *dev, enum bus_notifier_event value) { - struct bus_type *bus =3D dev->bus; + struct subsys_private *sp =3D bus_to_subsys(dev->bus); =20 - if (bus) - blocking_notifier_call_chain(&bus->p->bus_notifier, value, dev); + if (!sp) + return; + + blocking_notifier_call_chain(&sp->bus_notifier, value, dev); + subsys_put(sp); } =20 struct kset *bus_get_kset(struct bus_type *bus) --=20 2.39.1