From nobody Sat Sep 13 16:58:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219A3C636D4 for ; Wed, 1 Feb 2023 21:50:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231364AbjBAVux (ORCPT ); Wed, 1 Feb 2023 16:50:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbjBAVuu (ORCPT ); Wed, 1 Feb 2023 16:50:50 -0500 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::221]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D81BA86BF; Wed, 1 Feb 2023 13:50:46 -0800 (PST) Received: (Authenticated sender: didi.debian@cknow.org) by mail.gandi.net (Postfix) with ESMTPSA id 7CDE3240002; Wed, 1 Feb 2023 21:50:42 +0000 (UTC) From: Diederik de Haas To: Carsten Haitzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Diederik de Haas Subject: [PATCH 2/2] perf test: Replace legacy `...` with $(...) Date: Wed, 1 Feb 2023 22:49:45 +0100 Message-Id: <20230201214945.127474-3-didi.debian@cknow.org> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230201214945.127474-1-didi.debian@cknow.org> References: <20230201214945.127474-1-didi.debian@cknow.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" As detailed in https://www.shellcheck.net/wiki/SC2006: The use of `...` is legacy syntax with several issues: 1. It has a series of undefined behaviors related to quoting in POSIX. 2. It imposes a custom escaping mode with surprising results. 3. It's exceptionally hard to nest. $(...) command substitution has none of these problems, and is therefore strongly encouraged. Signed-off-by: Diederik de Haas --- tools/perf/tests/shell/lib/coresight.sh | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tools/perf/tests/shell/lib/coresight.sh b/tools/perf/tests/she= ll/lib/coresight.sh index 7e27e5c5bc9c..6c3d34ec64d8 100644 --- a/tools/perf/tests/shell/lib/coresight.sh +++ b/tools/perf/tests/shell/lib/coresight.sh @@ -58,9 +58,9 @@ perf_dump_aux_verify() { # compiler may produce different code depending on the compiler and # optimization options, so this is rough just to see if we're # either missing almost all the data or all of it - ATOM_FX_NUM=3D`grep -c I_ATOM_F "$DUMP"` - ASYNC_NUM=3D`grep -c I_ASYNC "$DUMP"` - TRACE_INFO_NUM=3D`grep -c I_TRACE_INFO "$DUMP"` + ATOM_FX_NUM=3D$(grep -c I_ATOM_F "$DUMP") + ASYNC_NUM=3D$(grep -c I_ASYNC "$DUMP") + TRACE_INFO_NUM=3D$(grep -c I_TRACE_INFO "$DUMP") rm -f "$DUMP" =20 # Arguments provide minimums for a pass @@ -96,18 +96,18 @@ perf_dump_aux_tid_verify() { =20 # The TID test tools will print a TID per stdout line that are being # tested - TIDS=3D`cat "$2"` + TIDS=3D$(cat "$2") # Scan the perf report to find the TIDs that are actually CID in hex # and build a list of the ones found - FOUND_TIDS=3D`perf report --stdio --dump -i "$1" | \ + FOUND_TIDS=3D$(perf report --stdio --dump -i "$1" | \ grep -o "CID=3D0x[0-9a-z]\+" | sed 's/CID=3D//g' | \ - uniq | sort | uniq` + uniq | sort | uniq) # No CID=3Dxxx found - maybe your kernel is reporting these as # VMID=3Dxxx so look there if test -z "$FOUND_TIDS"; then - FOUND_TIDS=3D`perf report --stdio --dump -i "$1" | \ + FOUND_TIDS=3D$(perf report --stdio --dump -i "$1" | \ grep -o "VMID=3D0x[0-9a-z]\+" | sed 's/VMID=3D//g' | \ - uniq | sort | uniq` + uniq | sort | uniq) fi =20 # Iterate over the list of TIDs that the test says it has and find @@ -116,7 +116,7 @@ perf_dump_aux_tid_verify() { for TID2 in $TIDS; do FOUND=3D"" for TIDHEX in $FOUND_TIDS; do - TID=3D`printf "%i" $TIDHEX` + TID=3D$(printf "%i" $TIDHEX) if test "$TID" -eq "$TID2"; then FOUND=3D"y" break --=20 2.39.1