From nobody Sat Sep 13 18:27:39 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EF03C636CC for ; Tue, 31 Jan 2023 15:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232979AbjAaPMD (ORCPT ); Tue, 31 Jan 2023 10:12:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232963AbjAaPLm (ORCPT ); Tue, 31 Jan 2023 10:11:42 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58C5153544; Tue, 31 Jan 2023 07:09:41 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1F05361557; Tue, 31 Jan 2023 15:08:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 104BEC433EF; Tue, 31 Jan 2023 15:08:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675177727; bh=Wo5hiX0qGQOtoQFDNuk/pDBVwD2wnAOpM1so7q5LdTQ=; h=From:To:Cc:Subject:Date:From; b=fj374gCgukYg91MO0bhAA47Jz/S++bkN6RO9QnCXgL0itCGcqHZ8iPTnAa3VS+pKG 71TsmJBnO/BsteP4I1EYZfbYoVr8iyYUrTAzWhimrL0PW2DYMG6h904NjQIydFPMe8 W0yiiIUvX75dGUUR2OSNkhVkVpPGb2fDsYDy2v5agRp31Sdly/n2M5eIrT5Jq+1o0l SbvGb1iUoZxXqRc++vn3smbdXAwssN1RMh8f+2QPfoQ/W6Y4bmAS895HlaN5/mEvXD oCswUFnvxKRVrwiA7A7mmzMINW5Pv3NLB5gaskJcHfsmQYG7tuknZXalySM3S8PLuS DIh2PatG8KLWA== From: Chao Yu To: akpm@linux-foundation.org, adobriyan@gmail.com Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Chao Yu Subject: [PATCH v2] proc: remove mark_inode_dirty() in .setattr() Date: Tue, 31 Jan 2023 23:08:40 +0800 Message-Id: <20230131150840.34726-1-chao@kernel.org> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" procfs' .setattr() has updated i_uid, i_gid and i_mode into proc dirent, we don't need to call mark_inode_dirty() for delayed update, remove it. Signed-off-by: Chao Yu Reviewed-by: Alexey Dobriyan --- v2: - remove mark_inode_dirty() from proc_setattr() and proc_sys_setattr() as well. fs/proc/base.c | 1 - fs/proc/generic.c | 1 - fs/proc/proc_sysctl.c | 1 - 3 files changed, 3 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 9e479d7d202b..16236fe9b9fe 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -699,7 +699,6 @@ int proc_setattr(struct user_namespace *mnt_userns, str= uct dentry *dentry, return error; =20 setattr_copy(&init_user_ns, inode, attr); - mark_inode_dirty(inode); return 0; } =20 diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 5f52f20d5ed1..f547e9593a77 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -127,7 +127,6 @@ static int proc_notify_change(struct user_namespace *mn= t_userns, return error; =20 setattr_copy(&init_user_ns, inode, iattr); - mark_inode_dirty(inode); =20 proc_set_user(de, inode->i_uid, inode->i_gid); de->mode =3D inode->i_mode; diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 48f2d60bd78a..4e71d18e610e 100644 --- a/fs/proc/proc_sysctl.c +++ b/fs/proc/proc_sysctl.c @@ -841,7 +841,6 @@ static int proc_sys_setattr(struct user_namespace *mnt_= userns, return error; =20 setattr_copy(&init_user_ns, inode, attr); - mark_inode_dirty(inode); return 0; } =20 --=20 2.36.1