From nobody Sat Sep 13 22:27:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E54C54EAA for ; Mon, 30 Jan 2023 16:17:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236218AbjA3QR3 (ORCPT ); Mon, 30 Jan 2023 11:17:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235264AbjA3QRT (ORCPT ); Mon, 30 Jan 2023 11:17:19 -0500 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D16732137 for ; Mon, 30 Jan 2023 08:17:18 -0800 (PST) Received: from zn.tnic (p5de8e9fe.dip0.t-ipconnect.de [93.232.233.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 836021EC066E; Mon, 30 Jan 2023 17:17:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1675095437; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d83KcD8OBTU0320YA3XbPbLjBYW6teajmhjAa074RMo=; b=iI0mWQpjGGsIaO6s913P6m725ex127gGkwG0rhWVn0i4NN94QLBfTLtxlfFIG3M4T+eYUa unForHvyJmRf/yUM9bwIUxp9avfPIO67eYSUnzvvcdbtFYAwdm6jaububuVmcfhcGRJr1b MrL2M8Bu6C3lfV13XdcOljUq+MO5e4g= From: Borislav Petkov To: X86 ML Cc: LKML Subject: [PATCH 4/4] x86/microcode/core: Return an error only when necessary Date: Mon, 30 Jan 2023 17:17:09 +0100 Message-Id: <20230130161709.11615-5-bp@alien8.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20230130161709.11615-1-bp@alien8.de> References: <20230130161709.11615-1-bp@alien8.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: "Borislav Petkov (AMD)" Return an error from the late loading function which is run on each CPU only when an error has actually been encountered during the update. Signed-off-by: Borislav Petkov (AMD) --- arch/x86/kernel/cpu/microcode/core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index 931d3c3262ec..d52042d5faae 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -409,10 +409,10 @@ static int __reload_late(void *info) goto wait_for_siblings; =20 if (err >=3D UCODE_NFOUND) { - if (err =3D=3D UCODE_ERROR) + if (err =3D=3D UCODE_ERROR) { pr_warn("Error reloading microcode on CPU %d\n", cpu); - - ret =3D -1; + ret =3D -1; + } } =20 wait_for_siblings: --=20 2.35.1