From nobody Sat Sep 13 22:05:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB479C636D0 for ; Mon, 30 Jan 2023 09:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235476AbjA3Jeh (ORCPT ); Mon, 30 Jan 2023 04:34:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236394AbjA3JeO (ORCPT ); Mon, 30 Jan 2023 04:34:14 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC5B830F5 for ; Mon, 30 Jan 2023 01:32:51 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id jm10so10935083plb.13 for ; Mon, 30 Jan 2023 01:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nxtYcVhJhYnmw9Kyf/CwQWgviswE64iGZP+l2Z32zUU=; b=WfpSpboUezsAyUDDVV9MgUHTxwU1B6vz4v5+gIu7omiVgcRS+MZhIWZsnhesnBobkJ FuricfmatL/tBgUO2Ox5jovBrabUbuVFkruA6tDgzTFQg8NdpfM1PA/DXKnbJhaaakHI UetQVLgUSxAPkniq7vGNYBLuRL/k9EnltcV5QBnMJgmh+6y3YuHI2HDK2tO2cQFuJKu1 cy34U3MGwmpRhajU5owIL9mqSuUSM6w1F3wRuOzqU7r+M/Nf66ZWml5iRBZ7ttNvwCBl HqdqkfNfe4oBmhzr0Q895sfoVszPUVnwcg2WRU1LSP9N1QpyFifC6WgQ5fm4pizh9PJA QCpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nxtYcVhJhYnmw9Kyf/CwQWgviswE64iGZP+l2Z32zUU=; b=hyUF6/mf6Jbn5IdCr2ckuQxWo/YCQ2W1A2n4b6nVApr3EF+hPB/rwDTcVU7afAR/2+ +Qj2tl5jrVPo7kTtaAA7ZAxdQ2chdxw/5K5fDrcud9YbCEhWYFzHbF329jTG+9uHyvCF KdI0E4G1bS/YuU9Fe5M6pw/nV12387+5mS6Lq4J8MeJib/ywUOEtyPEO+AAnuA22pmjo l6/SBWQXFzV5btMLmzp32LmyNwlKXLukPKq+mpanA5HsCNlL4bLptvsFUtvnSq8Lf3sa wcqyDVRk7LN0UJbYYYZnIKQDQDPUoDA48du2U8IbSB4RYDxakz1CUlwx0bnNxVIe9bCM x/IA== X-Gm-Message-State: AO0yUKVoO3sbQUb2AJvTvJiYi9vuJ9eDuvPuTD46iZCJNo7z1sLcm59Y WZA2yYSDGe1jiq5ZMeZvtOFfwA== X-Google-Smtp-Source: AK7set+sqas1TmEZGyot0yhlXSSwa3Kkzex+Yml58yVBreADNUkvzMVeVh4R0UHw2PdTkO1Dvv9mIA== X-Received: by 2002:a05:6a20:1592:b0:be:9249:236c with SMTP id h18-20020a056a20159200b000be9249236cmr1679774pzj.35.1675071160436; Mon, 30 Jan 2023 01:32:40 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id t13-20020a6564cd000000b004db2b310f95sm6245704pgv.16.2023.01.30.01.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 01:32:40 -0800 (PST) From: Nylon Chen To: aou@eecs.berkeley.edu, conor@kernel.org, emil.renner.berthing@canonical.com, geert+renesas@glider.be, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robh+dt@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: nylon.chen@sifive.com, nylon7717@gmail.com, zong.li@sifive.com, greentime.hu@sifive.com, vincent.chen@sifive.com Subject: [PATCH v2 1/2] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties Date: Mon, 30 Jan 2023 17:32:28 +0800 Message-Id: <20230130093229.27489-2-nylon.chen@sifive.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20230130093229.27489-1-nylon.chen@sifive.com> References: <20230130093229.27489-1-nylon.chen@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" This removes the active-low properties of the PWM-controlled LEDs in the HiFive Unmatched device tree. The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schematic= s-v3.pdf[1]. [0]: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf8453f8= 698_hifive-unleashed-a00-schematics-1.pdf [1]: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce76f4= 192_hifive-unmatched-schematics-v3.pdf Signed-off-by: Nylon Chen Acked-by: Conor Dooley Reviewed-by: Conor Dooley --- arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 4 ---- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ---- 2 files changed, 8 deletions(-) diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unleashed-a00.dts index 900a50526d77..7a9f336a391c 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts @@ -50,7 +50,6 @@ led-controller { =20 led-d1 { pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; max-brightness =3D <255>; label =3D "d1"; @@ -58,7 +57,6 @@ led-d1 { =20 led-d2 { pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; max-brightness =3D <255>; label =3D "d2"; @@ -66,7 +64,6 @@ led-d2 { =20 led-d3 { pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; max-brightness =3D <255>; label =3D "d3"; @@ -74,7 +71,6 @@ led-d3 { =20 led-d4 { pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; max-brightness =3D <255>; label =3D "d4"; diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/ris= cv/boot/dts/sifive/hifive-unmatched-a00.dts index 07387f9c135c..11f08a545ee6 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -52,7 +52,6 @@ led-controller-1 { =20 led-d12 { pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; max-brightness =3D <255>; label =3D "d12"; @@ -69,19 +68,16 @@ multi-led { =20 led-red { pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; }; =20 led-green { pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; }; =20 led-blue { pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; - active-low; color =3D ; }; }; --=20 2.36.1 From nobody Sat Sep 13 22:05:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CF31C61DA4 for ; Mon, 30 Jan 2023 09:35:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236251AbjA3Jes (ORCPT ); Mon, 30 Jan 2023 04:34:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235949AbjA3JeP (ORCPT ); Mon, 30 Jan 2023 04:34:15 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEE05976E for ; Mon, 30 Jan 2023 01:32:55 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id rm7-20020a17090b3ec700b0022c05558d22so10467149pjb.5 for ; Mon, 30 Jan 2023 01:32:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w06XLuTGv42ExA7kvsEzi3HmqNn0e+XIKH+7gH1xWFk=; b=PPfshnuneZVuaGMsWsf0abmeP49jp4AxSkkBj/mh1QI/DzHKXdaR6hl+H+ItCxqyBK 8EvW4xXW6VegaasREhK2bUhShb9wvty8UOLr3wp/rbISnmKVHRVvA0rpCOSUt0MCj0ZR oPhRoLukyOzJLiU4C/lp/aLdGjZGUoPkShPRj19HLGlGJVneY/5JrOxKgYSDAs+kHckA ZbAar3Gjnh03WMx7A3k5Ncx3kq8vJdKp0fzptQZusU7UMj0/chZLjSo/ClNBAAPUYkSd 8bm/XpTxdY/MmYvytxFvGcJV04KPmAG08wqBrYkaeFcuRA8URaK7P1WcmVaJR2IZIpdw jMhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w06XLuTGv42ExA7kvsEzi3HmqNn0e+XIKH+7gH1xWFk=; b=YfFZfKKUvIPcHiSYYWNTwp//vEHixxZ161ii8aDnHEdsGW+qoACooiJPd7edgh1XYT 09q0ODlqcAtCPs++lcqg2KXHJ3328BPTRdzHer0sejwWVJBDFePcjKD0GgWjV56PPzIM QCo5cJxp54BXHzV9r7RzWfCVqfF/5EMW5VbtLbkW8lroTM1WFsIpNdUvCNK6gvGFXyCK tYLeNp5fkiuIcv/cT3BWyU5xGI6ivH3Hyt6SsKtyCqueucPCgW7qQl9TUk1qgdc9UCin 9WfL8SaY7jwqL1PM0qO2Kh+ubjbXudjShmp5eJ6iiLIs3rtfgGNZiUPpV+DIjXCbkfa5 ug0g== X-Gm-Message-State: AFqh2kol0n6srg/Ib2UH1kTZbsl+iIuBxQBNYT1Gjc8WJ3ls5Ok0xKdJ Ims2+V30UMskhQmPXcn/3wR1rA== X-Google-Smtp-Source: AMrXdXtS3CCualmkzbk7XdCqctKx3U6p6dFg1oHURin04Tlb0OJZb8OfiFW6kp53r9/H5XL1owCXrw== X-Received: by 2002:a05:6a20:1596:b0:b8:7905:b6c4 with SMTP id h22-20020a056a20159600b000b87905b6c4mr62293777pzj.61.1675071165340; Mon, 30 Jan 2023 01:32:45 -0800 (PST) Received: from hsinchu15.internal.sifive.com (59-124-168-89.hinet-ip.hinet.net. [59.124.168.89]) by smtp.gmail.com with ESMTPSA id t13-20020a6564cd000000b004db2b310f95sm6245704pgv.16.2023.01.30.01.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 01:32:44 -0800 (PST) From: Nylon Chen To: aou@eecs.berkeley.edu, conor@kernel.org, emil.renner.berthing@canonical.com, geert+renesas@glider.be, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robh+dt@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Cc: nylon.chen@sifive.com, nylon7717@gmail.com, zong.li@sifive.com, greentime.hu@sifive.com, vincent.chen@sifive.com Subject: [PATCH v2 2/2] pwm: sifive: change the PWM controlled LED algorithm Date: Mon, 30 Jan 2023 17:32:29 +0800 Message-Id: <20230130093229.27489-3-nylon.chen@sifive.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20230130093229.27489-1-nylon.chen@sifive.com> References: <20230130093229.27489-1-nylon.chen@sifive.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The `frac` variable represents the pulse inactive time, and the result of this algorithm is the pulse active time. Therefore, we must reverse the result. The reference is SiFive FU740-C000 Manual[0]. [0]: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16a= cba_fu740-c000-manual-v1p6.pdf Signed-off-by: Nylon Chen --- drivers/pwm/pwm-sifive.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c index 62b6acc6373d..a5eda165d071 100644 --- a/drivers/pwm/pwm-sifive.c +++ b/drivers/pwm/pwm-sifive.c @@ -158,6 +158,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, stru= ct pwm_device *pwm, frac =3D DIV64_U64_ROUND_CLOSEST(num, state->period); /* The hardware cannot generate a 100% duty cycle */ frac =3D min(frac, (1U << PWM_SIFIVE_CMPWIDTH) - 1); + frac =3D (1U << PWM_SIFIVE_CMPWIDTH) - 1 - frac; =20 mutex_lock(&ddata->lock); if (state->period !=3D ddata->approx_period) { --=20 2.36.1