From nobody Sat Sep 13 22:03:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B06C54EED for ; Mon, 30 Jan 2023 04:25:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235268AbjA3EZr (ORCPT ); Sun, 29 Jan 2023 23:25:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbjA3EZn (ORCPT ); Sun, 29 Jan 2023 23:25:43 -0500 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4383C4EEF for ; Sun, 29 Jan 2023 20:25:42 -0800 (PST) Received: by mail-pg1-x531.google.com with SMTP id 78so6772074pgb.8 for ; Sun, 29 Jan 2023 20:25:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ddl5ubdJXdhY37QXaqSPFuWOXoIoME8XjzTIYCn2FfM=; b=TrsrcayBW/ufr6B0b7ySUMgYrDdrlI1lmymJVug4Ai+xm9Efhi9PJpmJAq0XdcYAEi nQT+yasgYhwPxylv5Ay2NG7qWqlQEidG/nPOxhClNZYhEh1uCdBq6Cz66BopIlWiSax7 ZyAW40TGTUCdLLapAVdvy0LIAAidA2fB8uXqJ2+s1diIMYaNAA50slhM1O5gSS1CO2/D BM0Q6Af/Vk/ESFCz1P/NZBOr74dhaWS7ufOGHTwk9VFYGKrE8iV/LHBDBXLClRsiB4ai VYKlqSwQ8MYwtAExxiSyESGSy1lnp8BlLj+/HPJSFN+MhPhMRElH7chEMLvlGGW9hRtm eRKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ddl5ubdJXdhY37QXaqSPFuWOXoIoME8XjzTIYCn2FfM=; b=cbLlrM5GL8AxPhKK9gBCJHhuGtxq4sUOishqXV65QwdylXr2PemUbuGWxejzn5LZOV LHdmBubhzoypyoPqkdTGH8RlCNFzPCoNBlrTh1sLQ19bm6Zz7yd6OZ8h+YqcDuMq/Con n1NZqhmofaTeAq/1rl1lryL+zddnK5/cPLdOuUHeU1kln3VRGdbevUdZZWRgv7pxn+uP 0SIkoIEsCfeZgYH5kuYSvdvtnQJ4W0/zwVQvf1wjfQU4tDJBUb0Ws0ks07NnAfBnYJIU xwoQvn31ZUoha9hLkAGcc4SWMJ/MdANYHoqjt09fLOctG+n7/mTrKLB9h8s+ZwlF4PJ/ FOcA== X-Gm-Message-State: AO0yUKVaYILb4cW5CZFS3nK7mJKMrysqPDLhVzYTlaW4bcjEaILkuc+5 mPPLaoNDYEpUnxr7bYgb+zU1JcuibNys/g== X-Google-Smtp-Source: AK7set/g64z3OvggFkD0Z2RB8lO0nvGTzCuFS0OJ7oPDugPEV5kn1VJtceRXiEDz6GS84tqVRQdhbg== X-Received: by 2002:a62:1742:0:b0:590:772c:b990 with SMTP id 63-20020a621742000000b00590772cb990mr16502661pfx.15.1675052741760; Sun, 29 Jan 2023 20:25:41 -0800 (PST) Received: from localhost.localdomain ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id 138-20020a621790000000b0059312530b54sm4275969pfx.180.2023.01.29.20.25.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 20:25:40 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Andrew Morton Cc: Joe Perches , Petr Mladek , Andy Shevchenko , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH mm-unstable v4 1/3] mmflags.h: use less error prone method to define pageflag_names Date: Mon, 30 Jan 2023 13:25:12 +0900 Message-Id: <20230130042514.2418-2-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230130042514.2418-1-42.hyeyoo@gmail.com> References: <20230130042514.2418-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" As suggested by Andy Shevchenko, use helper macro to decrease chances of typo when defining pageflag_names. Link: https://lore.kernel.org/lkml/Y6AycLbpjVzXM5I9@smile.fi.intel.com Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Andy Shevchenko Suggested-by: ? :-) --- include/trace/events/mmflags.h | 85 ++++++++++++++++++---------------- 1 file changed, 44 insertions(+), 41 deletions(-) diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h index 9db52bc4ce19..f453babe29b3 100644 --- a/include/trace/events/mmflags.h +++ b/include/trace/events/mmflags.h @@ -67,71 +67,74 @@ ) : "none" =20 #ifdef CONFIG_MMU -#define IF_HAVE_PG_MLOCK(flag,string) ,{1UL << flag, string} +#define IF_HAVE_PG_MLOCK(_name) ,{1UL << PG_##_name, __stringify(_name)} #else -#define IF_HAVE_PG_MLOCK(flag,string) +#define IF_HAVE_PG_MLOCK(_name) #endif =20 #ifdef CONFIG_ARCH_USES_PG_UNCACHED -#define IF_HAVE_PG_UNCACHED(flag,string) ,{1UL << flag, string} +#define IF_HAVE_PG_UNCACHED(_name) ,{1UL << PG_##_name, __stringify(_name)} #else -#define IF_HAVE_PG_UNCACHED(flag,string) +#define IF_HAVE_PG_UNCACHED(_name) #endif =20 #ifdef CONFIG_MEMORY_FAILURE -#define IF_HAVE_PG_HWPOISON(flag,string) ,{1UL << flag, string} +#define IF_HAVE_PG_HWPOISON(_name) ,{1UL << PG_##_name, __stringify(_name)} #else -#define IF_HAVE_PG_HWPOISON(flag,string) +#define IF_HAVE_PG_HWPOISON(_name) #endif =20 #if defined(CONFIG_PAGE_IDLE_FLAG) && defined(CONFIG_64BIT) -#define IF_HAVE_PG_IDLE(flag,string) ,{1UL << flag, string} +#define IF_HAVE_PG_IDLE(_name) ,{1UL << PG_##_name, __stringify(_name)} #else -#define IF_HAVE_PG_IDLE(flag,string) +#define IF_HAVE_PG_IDLE(_name) #endif =20 #ifdef CONFIG_ARCH_USES_PG_ARCH_X -#define IF_HAVE_PG_ARCH_X(flag,string) ,{1UL << flag, string} +#define IF_HAVE_PG_ARCH_X(_name) ,{1UL << PG_##_name, __stringify(_name)} #else -#define IF_HAVE_PG_ARCH_X(flag,string) +#define IF_HAVE_PG_ARCH_X(_name) #endif =20 #ifdef CONFIG_KASAN_HW_TAGS -#define IF_HAVE_PG_SKIP_KASAN_POISON(flag,string) ,{1UL << flag, string} +#define IF_HAVE_PG_SKIP_KASAN_POISON(_name) \ + ,{1UL << PG_##_name, __stringify(_name)} #else -#define IF_HAVE_PG_SKIP_KASAN_POISON(flag,string) +#define IF_HAVE_PG_SKIP_KASAN_POISON(_name) #endif =20 +#define DEF_PAGEFLAG_NAME(_name) { 1UL << PG_##_name, __stringify(_name) } + #define __def_pageflag_names \ - {1UL << PG_locked, "locked" }, \ - {1UL << PG_waiters, "waiters" }, \ - {1UL << PG_error, "error" }, \ - {1UL << PG_referenced, "referenced" }, \ - {1UL << PG_uptodate, "uptodate" }, \ - {1UL << PG_dirty, "dirty" }, \ - {1UL << PG_lru, "lru" }, \ - {1UL << PG_active, "active" }, \ - {1UL << PG_workingset, "workingset" }, \ - {1UL << PG_slab, "slab" }, \ - {1UL << PG_owner_priv_1, "owner_priv_1" }, \ - {1UL << PG_arch_1, "arch_1" }, \ - {1UL << PG_reserved, "reserved" }, \ - {1UL << PG_private, "private" }, \ - {1UL << PG_private_2, "private_2" }, \ - {1UL << PG_writeback, "writeback" }, \ - {1UL << PG_head, "head" }, \ - {1UL << PG_mappedtodisk, "mappedtodisk" }, \ - {1UL << PG_reclaim, "reclaim" }, \ - {1UL << PG_swapbacked, "swapbacked" }, \ - {1UL << PG_unevictable, "unevictable" } \ -IF_HAVE_PG_MLOCK(PG_mlocked, "mlocked" ) \ -IF_HAVE_PG_UNCACHED(PG_uncached, "uncached" ) \ -IF_HAVE_PG_HWPOISON(PG_hwpoison, "hwpoison" ) \ -IF_HAVE_PG_IDLE(PG_young, "young" ) \ -IF_HAVE_PG_IDLE(PG_idle, "idle" ) \ -IF_HAVE_PG_ARCH_X(PG_arch_2, "arch_2" ) \ -IF_HAVE_PG_ARCH_X(PG_arch_3, "arch_3" ) \ -IF_HAVE_PG_SKIP_KASAN_POISON(PG_skip_kasan_poison, "skip_kasan_poison") + DEF_PAGEFLAG_NAME(locked), \ + DEF_PAGEFLAG_NAME(waiters), \ + DEF_PAGEFLAG_NAME(error), \ + DEF_PAGEFLAG_NAME(referenced), \ + DEF_PAGEFLAG_NAME(uptodate), \ + DEF_PAGEFLAG_NAME(dirty), \ + DEF_PAGEFLAG_NAME(lru), \ + DEF_PAGEFLAG_NAME(active), \ + DEF_PAGEFLAG_NAME(workingset), \ + DEF_PAGEFLAG_NAME(slab), \ + DEF_PAGEFLAG_NAME(owner_priv_1), \ + DEF_PAGEFLAG_NAME(arch_1), \ + DEF_PAGEFLAG_NAME(reserved), \ + DEF_PAGEFLAG_NAME(private), \ + DEF_PAGEFLAG_NAME(private_2), \ + DEF_PAGEFLAG_NAME(writeback), \ + DEF_PAGEFLAG_NAME(head), \ + DEF_PAGEFLAG_NAME(mappedtodisk), \ + DEF_PAGEFLAG_NAME(reclaim), \ + DEF_PAGEFLAG_NAME(swapbacked), \ + DEF_PAGEFLAG_NAME(unevictable) \ +IF_HAVE_PG_MLOCK(mlocked) \ +IF_HAVE_PG_UNCACHED(uncached) \ +IF_HAVE_PG_HWPOISON(hwpoison) \ +IF_HAVE_PG_IDLE(idle) \ +IF_HAVE_PG_IDLE(young) \ +IF_HAVE_PG_ARCH_X(arch_2) \ +IF_HAVE_PG_ARCH_X(arch_3) \ +IF_HAVE_PG_SKIP_KASAN_POISON(skip_kasan_poison) =20 #define show_page_flags(flags) \ (flags) ? __print_flags(flags, "|", \ --=20 2.39.1 From nobody Sat Sep 13 22:03:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E1A2C54EED for ; Mon, 30 Jan 2023 04:26:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235585AbjA3E0A (ORCPT ); Sun, 29 Jan 2023 23:26:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36456 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235277AbjA3EZr (ORCPT ); Sun, 29 Jan 2023 23:25:47 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 389A81C59F for ; Sun, 29 Jan 2023 20:25:46 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso14190579pjj.1 for ; Sun, 29 Jan 2023 20:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LwwzdAzQtrDpCWVBIKiBhOmPzUd7VlYgWQiD6C21IJ0=; b=RfLhOWGiR1DflwvehJodiK8eZGsp/vBq6+Phyd26hga+7Av2OBhSct+0XSH2B9FRzM p1m4/SQPUKR7nuT6kdKVjud9HnaisdGTqP1VRrO/3BwlrFVhBImkRKsi4K4VVNzjcjdn RAqpjAGeRVnTJPYjcazViD5yOdR3PZhnv4z0CbFzR6dqDpSAxiypyotLgJEFeCyZce89 UyYEt7oiwQTWtM1yzJ0MzCOp3gSP1mICANOrnWpW0e2bnbSjr6gncWosiiu1EbAiAlHa 2AcRJ8BLB3xryqSf4gogQqDj0vhzoMOIBasWKNCWxcwFhQCtBWdHd/KLlRPfEhnd3xb7 dQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LwwzdAzQtrDpCWVBIKiBhOmPzUd7VlYgWQiD6C21IJ0=; b=T41CDeAIMexsEFOm5aRNjD3tHOa/en6Wd7lwbreMPF2SXSojMTnOyTTHupBt9OJscP 80yLCk/1XkjKJe1WLKYNtr3tac8jNT91/6sl/T88myDr1918GXy0W4sly/KY2jBRVJ5p ZZPlVygt0+jV+o+3xrg0ExuNtjapi6NMINKOzP0IsdHEDvYgA5L5BVe7Uh2ZXZbyeDau 2jluUSbIzZBPr84fbKJrU3vTcOBG1cMVoet54PPtW+d8UqgV0oumxpGcrBsGZt0KyffR SWSzVtrBEDpR9ZXFGHggnGenoFkpz/VnfCjVfCZuj4/w3L/GZrXDhggEKNWQC9LzVDyv FnSQ== X-Gm-Message-State: AFqh2krO9WxAMVMdUHKnThDfvF8Lucd02KhVWMcC1ocU1NlmnwJtv/SL 7tIRYRqg4mePBRH8QgfTaM4= X-Google-Smtp-Source: AMrXdXv0rqldkq324IZrmBFFJnO7fSD5oeWo9f+jtU8Ml/KRwPeLY0lgIYkFlO23Jcdrd2YCCrAdqA== X-Received: by 2002:a05:6a20:3d86:b0:b8:d032:6486 with SMTP id s6-20020a056a203d8600b000b8d0326486mr67733142pzi.16.1675052745607; Sun, 29 Jan 2023 20:25:45 -0800 (PST) Received: from localhost.localdomain ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id 138-20020a621790000000b0059312530b54sm4275969pfx.180.2023.01.29.20.25.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 20:25:44 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Andrew Morton Cc: Joe Perches , Petr Mladek , Andy Shevchenko , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH mm-unstable v4 2/3] mm, printk: introduce new format %pGt for page_type Date: Mon, 30 Jan 2023 13:25:13 +0900 Message-Id: <20230130042514.2418-3-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230130042514.2418-1-42.hyeyoo@gmail.com> References: <20230130042514.2418-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" %pGp format is used to display 'flags' field of a struct page. However, some page flags (i.e. PG_buddy, see page-flags.h for more details) are stored in page_type field. To display human-readable output of page_type, introduce %pGt format. It is important to note the meaning of bits are different in page_type. if page_type is 0xffffffff, no flags are set. Setting PG_buddy (0x00000080) flag results in a page_type of 0xffffff7f. Clearing a bit actually means setting a flag. Bits in page_type are inverted when displaying type names. Only values for which page_type_has_type() returns true are considered as page_type, to avoid confusion with mapcount values. if it returns false, only raw values are displayed and not page type names. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Reviewed-by: Petr Mladek # for vsprintf part --- Documentation/core-api/printk-formats.rst | 16 +++++++++----- include/linux/page-flags.h | 7 +++++- include/trace/events/mmflags.h | 8 +++++++ lib/test_printf.c | 26 +++++++++++++++++++++++ lib/vsprintf.c | 21 ++++++++++++++++++ mm/debug.c | 5 +++++ mm/internal.h | 1 + 7 files changed, 78 insertions(+), 6 deletions(-) diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core= -api/printk-formats.rst index dbe1aacc79d0..dfe7e75a71de 100644 --- a/Documentation/core-api/printk-formats.rst +++ b/Documentation/core-api/printk-formats.rst @@ -575,20 +575,26 @@ The field width is passed by value, the bitmap is pas= sed by reference. Helper macros cpumask_pr_args() and nodemask_pr_args() are available to ea= se printing cpumask and nodemask. =20 -Flags bitfields such as page flags, gfp_flags ---------------------------------------------- +Flags bitfields such as page flags, page_type, gfp_flags +-------------------------------------------------------- =20 :: =20 %pGp 0x17ffffc0002036(referenced|uptodate|lru|active|private|node=3D0|zon= e=3D2|lastcpupid=3D0x1fffff) + %pGt 0xffffff7f(buddy) %pGg GFP_USER|GFP_DMA32|GFP_NOWARN %pGv read|exec|mayread|maywrite|mayexec|denywrite =20 For printing flags bitfields as a collection of symbolic constants that would construct the value. The type of flags is given by the third -character. Currently supported are [p]age flags, [v]ma_flags (both -expect ``unsigned long *``) and [g]fp_flags (expects ``gfp_t *``). The flag -names and print order depends on the particular type. +character. Currently supported are: + + - p - [p]age flags, expects value of type (``unsigned long *``) + - t - page [t]ype, expects value of type (``unsigned int *``) + - v - [v]ma_flags, expects value of type (``unsigned long *``) + - g - [g]fp_flags, expects value of type (``gfp_t *``) + +The flag names and print order depends on the particular type. =20 Note that this format should not be used directly in the :c:func:`TP_printk()` part of a tracepoint. Instead, use the show_*_flags() diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index a7e3a3405520..57287102c5bd 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -926,9 +926,14 @@ static inline bool is_page_hwpoison(struct page *page) #define PageType(page, flag) \ ((page->page_type & (PAGE_TYPE_BASE | flag)) =3D=3D PAGE_TYPE_BASE) =20 +static inline int page_type_has_type(unsigned int page_type) +{ + return (int)page_type < PAGE_MAPCOUNT_RESERVE; +} + static inline int page_has_type(struct page *page) { - return (int)page->page_type < PAGE_MAPCOUNT_RESERVE; + return page_type_has_type(page->page_type); } =20 #define PAGE_TYPE_OPS(uname, lname) \ diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h index f453babe29b3..b28218b7998e 100644 --- a/include/trace/events/mmflags.h +++ b/include/trace/events/mmflags.h @@ -141,6 +141,14 @@ IF_HAVE_PG_SKIP_KASAN_POISON(skip_kasan_poison) __def_pageflag_names \ ) : "none" =20 +#define DEF_PAGETYPE_NAME(_name) { PG_##_name, __stringify(_name) } + +#define __def_pagetype_names \ + DEF_PAGETYPE_NAME(offline), \ + DEF_PAGETYPE_NAME(guard), \ + DEF_PAGETYPE_NAME(table), \ + DEF_PAGETYPE_NAME(buddy) + #if defined(CONFIG_X86) #define __VM_ARCH_SPECIFIC_1 {VM_PAT, "pat" } #elif defined(CONFIG_PPC) diff --git a/lib/test_printf.c b/lib/test_printf.c index 46b4e6c414a3..7677ebccf3c3 100644 --- a/lib/test_printf.c +++ b/lib/test_printf.c @@ -642,12 +642,26 @@ page_flags_test(int section, int node, int zone, int = last_cpupid, test(cmp_buf, "%pGp", &flags); } =20 +static void __init page_type_test(unsigned int page_type, const char *name, + char *cmp_buf) +{ + unsigned long size; + + size =3D scnprintf(cmp_buf, BUF_SIZE, "%#x(", page_type); + if (page_type_has_type(page_type)) + size +=3D scnprintf(cmp_buf + size, BUF_SIZE - size, "%s", name); + + snprintf(cmp_buf + size, BUF_SIZE - size, ")"); + test(cmp_buf, "%pGt", &page_type); +} + static void __init flags(void) { unsigned long flags; char *cmp_buffer; gfp_t gfp; + unsigned int page_type; =20 cmp_buffer =3D kmalloc(BUF_SIZE, GFP_KERNEL); if (!cmp_buffer) @@ -687,6 +701,18 @@ flags(void) gfp |=3D __GFP_HIGH; test(cmp_buffer, "%pGg", &gfp); =20 + page_type =3D ~0; + page_type_test(page_type, "", cmp_buffer); + + page_type =3D 10; + page_type_test(page_type, "", cmp_buffer); + + page_type =3D ~PG_buddy; + page_type_test(page_type, "buddy", cmp_buffer); + + page_type =3D ~(PG_table | PG_buddy); + page_type_test(page_type, "table|buddy", cmp_buffer); + kfree(cmp_buffer); } =20 diff --git a/lib/vsprintf.c b/lib/vsprintf.c index be71a03c936a..fbe320b5e89f 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -2052,6 +2052,25 @@ char *format_page_flags(char *buf, char *end, unsign= ed long flags) return buf; } =20 +static +char *format_page_type(char *buf, char *end, unsigned int page_type) +{ + buf =3D number(buf, end, page_type, default_flag_spec); + + if (buf < end) + *buf =3D '('; + buf++; + + if (page_type_has_type(page_type)) + buf =3D format_flags(buf, end, ~page_type, pagetype_names); + + if (buf < end) + *buf =3D ')'; + buf++; + + return buf; +} + static noinline_for_stack char *flags_string(char *buf, char *end, void *flags_ptr, struct printf_spec spec, const char *fmt) @@ -2065,6 +2084,8 @@ char *flags_string(char *buf, char *end, void *flags_= ptr, switch (fmt[1]) { case 'p': return format_page_flags(buf, end, *(unsigned long *)flags_ptr); + case 't': + return format_page_type(buf, end, *(unsigned int *)flags_ptr); case 'v': flags =3D *(unsigned long *)flags_ptr; names =3D vmaflag_names; diff --git a/mm/debug.c b/mm/debug.c index 96d594e16292..01cf0435723b 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -36,6 +36,11 @@ const struct trace_print_flags pageflag_names[] =3D { {0, NULL} }; =20 +const struct trace_print_flags pagetype_names[] =3D { + __def_pagetype_names, + {0, NULL} +}; + const struct trace_print_flags gfpflag_names[] =3D { __def_gfpflag_names, {0, NULL} diff --git a/mm/internal.h b/mm/internal.h index 90bb2078444c..11c3258809a9 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -802,6 +802,7 @@ static inline void flush_tlb_batched_pending(struct mm_= struct *mm) #endif /* CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH */ =20 extern const struct trace_print_flags pageflag_names[]; +extern const struct trace_print_flags pagetype_names[]; extern const struct trace_print_flags vmaflag_names[]; extern const struct trace_print_flags gfpflag_names[]; =20 --=20 2.39.1 From nobody Sat Sep 13 22:03:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4060FC636CB for ; Mon, 30 Jan 2023 04:26:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235602AbjA3E0D (ORCPT ); Sun, 29 Jan 2023 23:26:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235449AbjA3EZ5 (ORCPT ); Sun, 29 Jan 2023 23:25:57 -0500 Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B98234F9 for ; Sun, 29 Jan 2023 20:25:50 -0800 (PST) Received: by mail-pf1-x435.google.com with SMTP id z1so3842581pfg.12 for ; Sun, 29 Jan 2023 20:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7+2uSEts9I7Ewx+xS7afTWjlA6S/QLMMkQDB6ml0kj0=; b=hKdHkX186An3SlPIdCV6Z762EQ3Mp+tUKDZoyrcHW4XH0L3AXgSWzAsinGVxCJr3iL o7ET8OmEff0FDqiWcyWz2HksAKY0eqrS2JhdnHs4xoHvbxotnBAsJDlH4cFwn9sZ5uPJ Mx6zVjix4c6pHAUF30Zhvibm1eolctdmqCeeqMYN/dqDEtywpaIczX7OifZ3R+jRG6hd CFeZohdbVbwh5Ahc31iEbp95nM8NbxoCnAIVR6icduxEirkVOZLncYjoVM7XKzfO6oEr b9KjhqYvZnMA66sE9SRqYxYTOhNRiff2Vh/hylLUBahbTvtYNv9HOoVtpVuwM8uNWJT2 rbcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7+2uSEts9I7Ewx+xS7afTWjlA6S/QLMMkQDB6ml0kj0=; b=TPmWPt7n+YQ7P0P+PdTLAW1/pdoLe3LvGocSe/dD9mVWj9xIdyTPpLHeXG9Bb9GPAV 8gScJGbRIHM4GwN1rYyNkG5STXqctDrB6Oa+rwBZJIudeitjkh3vBIgTOQMqudICMY1g ibfRFzkBt3vfYDuTCXTVwArTC4Cx1fxDBkElIUZ5FGU1Im4uO9ROw0TXeeLpCtka2X/D PxSdDXN5dTf3+GnnCMY2XI31s1xv1383VUKjl0VvKLQG5IYfpJPhpiivjpChZFFQsd/F Q17flcnThgE1AafhfMIz9ENm5PUe+itxZXZmUg9mxdThyUyW/daJPcC81x7rJ5cGRCQg qwHQ== X-Gm-Message-State: AFqh2koXsOCAE78Y5Wn0WiTOVoIFcvqstjyHj+U0uMLgHcs6z1qJ8rTY zqkYoonqSTAdmu/U24/0Ka8= X-Google-Smtp-Source: AMrXdXt/vTOJEaTIid9fdett6eIQmY9527OXjpDlZK3RUh7rX89GJQs62AZMfIi62ZnaGn5d/ZYSpQ== X-Received: by 2002:a05:6a00:3315:b0:582:294d:f465 with SMTP id cq21-20020a056a00331500b00582294df465mr49045478pfb.13.1675052749382; Sun, 29 Jan 2023 20:25:49 -0800 (PST) Received: from localhost.localdomain ([114.29.91.56]) by smtp.gmail.com with ESMTPSA id 138-20020a621790000000b0059312530b54sm4275969pfx.180.2023.01.29.20.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 20:25:48 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Andrew Morton Cc: Joe Perches , Petr Mladek , Andy Shevchenko , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH mm-unstable v4 3/3] mm/debug: use %pGt to display page_type in dump_page() Date: Mon, 30 Jan 2023 13:25:14 +0900 Message-Id: <20230130042514.2418-4-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230130042514.2418-1-42.hyeyoo@gmail.com> References: <20230130042514.2418-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Some page flags are stored in page_type rather than ->flags field. Use newly introduced page type %pGt in dump_page(). Below are some examples: page:00000000da7184dd refcount:1 mapcount:0 mapping:0000000000000000 index:= 0x0 pfn:0x101cb3 flags: 0x2ffff0000000000(node=3D0|zone=3D2|lastcpupid=3D0xffff) page_type: 0xffffffff() raw: 02ffff0000000000 0000000000000000 dead000000000122 0000000000000000 raw: 0000000000000000 0000000000000000 00000001ffffffff 0000000000000000 page dumped because: newly allocated page page:00000000da7184dd refcount:0 mapcount:-128 mapping:0000000000000000 ind= ex:0x0 pfn:0x101cb3 flags: 0x2ffff0000000000(node=3D0|zone=3D2|lastcpupid=3D0xffff) page_type: 0xffffff7f(buddy) raw: 02ffff0000000000 ffff88813fff8e80 ffff88813fff8e80 0000000000000000 raw: 0000000000000000 0000000000000000 00000000ffffff7f 0000000000000000 page dumped because: freed page page:0000000042202316 refcount:3 mapcount:2 mapping:0000000000000000 index:= 0x7f634722a pfn:0x11994e memcg:ffff888100135000 anon flags: 0x2ffff0000080024(uptodate|active|swapbacked|node=3D0|zone=3D2|= lastcpupid=3D0xffff) page_type: 0x1() raw: 02ffff0000080024 0000000000000000 dead000000000122 ffff8881193398f1 raw: 00000007f634722a 0000000000000000 0000000300000001 ffff888100135000 page dumped because: user-mapped page Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/debug.c b/mm/debug.c index 01cf0435723b..c7b228097bd9 100644 --- a/mm/debug.c +++ b/mm/debug.c @@ -120,6 +120,8 @@ static void __dump_page(struct page *page) =20 pr_warn("%sflags: %pGp%s\n", type, &head->flags, page_cma ? " CMA" : ""); + pr_warn("page_type: %pGt\n", &head->page_type); + print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32, sizeof(unsigned long), page, sizeof(struct page), false); --=20 2.39.1