From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68AC3C54EAA for ; Thu, 26 Jan 2023 23:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233313AbjAZXDf (ORCPT ); Thu, 26 Jan 2023 18:03:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233263AbjAZXDc (ORCPT ); Thu, 26 Jan 2023 18:03:32 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF7E94F84D for ; Thu, 26 Jan 2023 15:03:30 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id c66so1186273iof.12 for ; Thu, 26 Jan 2023 15:03:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BQXELW2Do44btByeSJJTILU+sMVZVBVp+PBgWqh0iPQ=; b=nJw+DUTuQVLOvRz1HyscPLmtu2IerGNqddKZ1FOVXITdFDXtG4bbvVyjK343q2XMAh WdJ+QzKGM53Wepv6E3ojcLezJQuvDDeXF+XurvAjhINj8MUU6Gbw1AD3sPBZxK6QCk55 GoANUAOcWSQY6AwT2VZZ3RUynOJyLTe5cTXA4oPrA6UetAByhIFJXBwfL6NYMMkBT1vT Q18mN13y4idZlUrMhKJNSRRQoh/bpRGJyZ9XfDV3IBQF77KMKD1XT+S2nHAMGE2SWAhJ ti9RpzbOxyCmNAYwV8fca4SZHUQtCFCPCAeBplogm1hS6zCEUIUdKD/v3fZSRiiHyvgi 5Q/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BQXELW2Do44btByeSJJTILU+sMVZVBVp+PBgWqh0iPQ=; b=y7thw3/kECpTlxzkpNcN+T/QgqI5Wui/cQ/hqLZ53nnFGorb/8994UrY6hZsMwbsvv xbueu2rveb9b61NaOhWTsm6Rsu6Ta2OX7szn7T3WQnMLQZu94SABNREg4OafM7+ub6eS HWxIBODel+I6KMGROX42+M4ftb0Ux4L/MfqoJCx4bRTMDAnXx8SlzZAXXk0nR0qOV0DQ 25CsT8I71n/rbyKkOaNlRENjRvQf77bUNeuFwRwrcUVRddjn6XvRUk/r58wkPEBpVq5o HhScZ2BKUf4+dYV2yRqZbskHOI9iO9NRcn9CO1itPXPiFshiWq2ywuPvhPBF8nI3T40k TbyQ== X-Gm-Message-State: AFqh2kqEzG2lTcxNR9rXXbs7M1SeFwf62BGr9/7pRlw13pilT21VjiNZ 386LGN8LUlJMMCm9t6mYTayKzQ== X-Google-Smtp-Source: AMrXdXvphCStfkzdhH5mxfm28KLN/HVvq8n/TNZxgZ6w6uE1XwDEsrJLYnwCwxvmH3W0q6nw92XU6Q== X-Received: by 2002:a6b:7210:0:b0:704:d931:45ec with SMTP id n16-20020a6b7210000000b00704d93145ecmr25938852ioc.20.1674774210025; Thu, 26 Jan 2023 15:03:30 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:29 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH v5 1/7] dt-bindings: mailbox: qcom: add SDX55 compatible Date: Fri, 27 Jan 2023 01:03:13 +0200 Message-Id: <20230126230319.3977109-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The commit 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") added SDX55 compatible string to one of clock-selection conditions, but failed to add one to the main schema's compatible list. Fix this omission. Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index 943f9472ae10..36deddca1524 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -39,6 +39,7 @@ properties: - qcom,msm8953-apcs-kpss-global - qcom,msm8994-apcs-kpss-global - qcom,qcs404-apcs-apps-global + - qcom,sdx55-apcs-gcc - const: syscon reg: maxItems: 1 --=20 2.39.0 From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E000AC61DA7 for ; Thu, 26 Jan 2023 23:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233320AbjAZXDn (ORCPT ); Thu, 26 Jan 2023 18:03:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233263AbjAZXDk (ORCPT ); Thu, 26 Jan 2023 18:03:40 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACA85552BB for ; Thu, 26 Jan 2023 15:03:34 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id n85so1198072iod.7 for ; Thu, 26 Jan 2023 15:03:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=60xbViVesinnCs8Gq9usNvmq6jftqqElQdF+JDe/eCU=; b=tWTI6bI6hZY8GKUxqEourUhIoJzGkInywP019Kc+1c/UouuWQXNB5z/ULI4PqMaJmq QJbV9rYsSN51haZU0EXpb237eM4Tpyzj+lpAebR5TGJwAL+TkeqbIryYZGWew5gaQiFt F2icF3dF0C/N/fkcjmypIcFmPjSny/jOGw/o54TQXiKWMXufecNZ4MttUOt2IyYNFaSW L3YNK38rCA/5P4Ci3fIaBOraV26ATBvTJr18GYNmYHoYS28J6NQPmzxP4sdx3bdrwgNO 4rV/oYxfXjQfgs0tJyGoMcD0qtvFrtAihxJGVgVkDWIGrxVMoY/JyCljLuPU4ULHQ7fF ngcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=60xbViVesinnCs8Gq9usNvmq6jftqqElQdF+JDe/eCU=; b=VVQSWiKz5N1xpi3U2vnmORNfIEC1wI9PAz9sovNCKNLFx7T2Ben3FcOzn1V2oKPdwK udFPDs85SxJdTF+yM/pHbvlT1G8KIgZwYvdpZVHofI7CT+MAqdfz5fWStrnxHmO2286k 2QFdAzyhCTEpWO0CGxGBwULVqFc/0eWYmQF41y+0Iyt0M2cdGqhnQ9yZfd2FtmWGw9EL kAnucD2VYuyNDbNAlEwK8mlvPlWvftUrXGYxCkUiCxDkwLvjLgXHOyCMfVG+9XCehe4v fXSNd6IPQhP5njqFoSkJLr+sZOaY851hAYWwcYTtQQ6L6qZ37q8KW/HcidmtHcjx0IoZ r1tg== X-Gm-Message-State: AO0yUKX9GyljtaBvQSKcUKnICbNpZXcTKXQWeDldu9a5XDARHZ97qKqI dCTiww6MzgH/8fUJNxjBgrmm2w== X-Google-Smtp-Source: AK7set9QmGuL4g3+bJHs80N+f87Y8dv1O2X1wGPkwhEF+Iy0Oe+D2el+Fwqjt5SHhGQrYi8E5Ep4dw== X-Received: by 2002:a05:6602:341d:b0:707:f268:989e with SMTP id n29-20020a056602341d00b00707f268989emr8918107ioz.16.1674774213988; Thu, 26 Jan 2023 15:03:33 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:33 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH v5 2/7] dt-bindings: mailbox: qcom: enable syscon compatible for msm8976 Date: Fri, 27 Jan 2023 01:03:14 +0200 Message-Id: <20230126230319.3977109-3-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On msm8976 platform APCS also uses syscon compatible, so move it to the block of compatibles using SoC-compat together with syscon. Fixes: 60545466180e ("dt-bindings: mailbox: qcom,apcs-kpss-global: Add sysc= on const for relevant entries") Acked-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index 36deddca1524..ecc286ab49ef 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -20,7 +20,6 @@ properties: - enum: - qcom,ipq6018-apcs-apps-global - qcom,ipq8074-apcs-apps-global - - qcom,msm8976-apcs-kpss-global - qcom,msm8996-apcs-hmss-global - qcom,msm8998-apcs-hmss-global - qcom,qcm2290-apcs-hmss-global @@ -37,6 +36,7 @@ properties: - qcom,msm8916-apcs-kpss-global - qcom,msm8939-apcs-kpss-global - qcom,msm8953-apcs-kpss-global + - qcom,msm8976-apcs-kpss-global - qcom,msm8994-apcs-kpss-global - qcom,qcs404-apcs-apps-global - qcom,sdx55-apcs-gcc --=20 2.39.0 From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72E6FC61D97 for ; Thu, 26 Jan 2023 23:03:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233346AbjAZXDq (ORCPT ); Thu, 26 Jan 2023 18:03:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233336AbjAZXDl (ORCPT ); Thu, 26 Jan 2023 18:03:41 -0500 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 039575A34F for ; Thu, 26 Jan 2023 15:03:38 -0800 (PST) Received: by mail-io1-xd32.google.com with SMTP id s26so1188915ioa.11 for ; Thu, 26 Jan 2023 15:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tFnQgKzi9ppV9VJGiOBnjcyAOZNDcLdMdaXWIYNXwKk=; b=qP3mU1xo+I9XVJ0stpRWLHeDB2WmZpVioBz59JrMezSkVQtQvFmt8iFGczec50RPpU sOkNcZBmrJTe/57CDT1J3YsJ3FwzeuxM0bOMikRL/s2aXLQBYF/3sG9qN2TSu8zYjBkU ZI394Ghw7zhV8brdQqTpJfCawXIdZ9yk3qJqRFuF85ic04O/0oLl3JNEZhkxJe6OZdFT whuvxyQtsczusxbxXRXxl0KlAaWugV6rJMHxC4LJBfGHpTedbNCn5iH8Bb39+qeDVV3U G9agmnEdmWbWc/1xoeGC54DuCuR0Hw7Lqa9hbL4tm/ck7D6hiYTpfu46A2Z326wYsVBC /cMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tFnQgKzi9ppV9VJGiOBnjcyAOZNDcLdMdaXWIYNXwKk=; b=VQlN/Qv8gY8l9KPJqDXhy/kzOb6UL1Hm3FBBWYuufcFTijDyRP5Bc2WbRZXY/dQswU yDLwtmaVTyb6QVLy8v81C64fHYjiczip7WH07WnndfBTkF16378T0MDXgznYxjeyPJCL RlY4PNsYp15WnqXg40jnXdbljREk5CrlFw0+7i5HjmgSr91gT7Hsxq7nur5nkYg7kKq3 U2qi24WuHpq5otPM5CXSvSrO+C2DwIlBqIfJjt6SW0tnkYnlClanQLPj6AK0Kjp88/Nj KlFx8nqx3Itwcc+5Wpohf8QlJAiGBc6sP/xIoSHVVJEc6xbhFbZQeTOHKRV+9GmWEKLz a2/w== X-Gm-Message-State: AFqh2kq8RLnZdsVOZjELKJSkR9FUJKI/JFnt8I62d7biEh/X6/rhobbC dimdxV/lhCgkcJf6zBrTl4RvwQ== X-Google-Smtp-Source: AMrXdXuldKyzHGiATIRaGkEyt82ilHxZbn9uVkWvXwoP6vEP97st0wkVuQbXmP2WBKd+5U1bZ1klGA== X-Received: by 2002:a5d:8190:0:b0:707:6e91:e866 with SMTP id u16-20020a5d8190000000b007076e91e866mr20134681ion.15.1674774217714; Thu, 26 Jan 2023 15:03:37 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:37 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH v5 3/7] dt-bindings: mailbox: qcom: correct the list of platforms using clocks Date: Fri, 27 Jan 2023 01:03:15 +0200 Message-Id: <20230126230319.3977109-4-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The schema incorrectly lists some of the platforms in the statement requiring clocks/clock-names. Correct this by moving platforms not requiring additional clocks to the separate clause. Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../mailbox/qcom,apcs-kpss-global.yaml | 26 +++++++++++++------ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index ecc286ab49ef..5f7770036fed 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -72,15 +72,7 @@ allOf: compatible: enum: - qcom,msm8916-apcs-kpss-global - - qcom,msm8994-apcs-kpss-global - - qcom,msm8996-apcs-hmss-global - - qcom,msm8998-apcs-hmss-global - qcom,qcs404-apcs-apps-global - - qcom,sc7180-apss-shared - - qcom,sdm660-apcs-hmss-global - - qcom,sdm845-apss-shared - - qcom,sm6125-apcs-hmss-global - - qcom,sm8150-apss-shared then: properties: clocks: @@ -124,6 +116,24 @@ allOf: items: - const: pll - const: xo + + - if: + properties: + compatible: + enum: + - qcom,msm8994-apcs-kpss-global + - qcom,msm8996-apcs-hmss-global + - qcom,msm8998-apcs-hmss-global + - qcom,sc7180-apss-shared + - qcom,sdm660-apcs-hmss-global + - qcom,sdm845-apss-shared + - qcom,sm6125-apcs-hmss-global + - qcom,sm8150-apss-shared + then: + properties: + clocks: false + clock-names: false + - if: properties: compatible: --=20 2.39.0 From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD93C54EAA for ; Thu, 26 Jan 2023 23:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233351AbjAZXDu (ORCPT ); Thu, 26 Jan 2023 18:03:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233335AbjAZXDp (ORCPT ); Thu, 26 Jan 2023 18:03:45 -0500 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7E55552BB for ; Thu, 26 Jan 2023 15:03:41 -0800 (PST) Received: by mail-io1-xd30.google.com with SMTP id c66so1186475iof.12 for ; Thu, 26 Jan 2023 15:03:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c0817b8QuSi7hdYOROCPDeMWfXlDnjhdy6HTg+NWqT4=; b=mubW0yFBRNRRB/VvHHPAlaCWIMZKyNdR5xOeTOY8/ni1uYMXxzi7pzNV9t3cFgSW5Y FotiU4Btx110lE1+UCIYAUOF264i/LxOaU1iw2Obz6ZwBft2mxffoSdDJviHdGboHHL+ 5GgpbyoSHRws5IUhpudUPx2+THUuMODad/IAgdn3TW+EzQBsQe/inCevGHTbe5vduefT tGubaTNwUn9q2iSaOT6gDoIyfvPQbovlpb4EXSxJ6AyBNsN7cUnccXnBiiH6wbVw9muj Ltj/36xxHnkxK64B6dH0EocpbRN+0KFUMqTb4y7+NMZ8WJvjYSUskLoytUXSS3R7moQ6 Onhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c0817b8QuSi7hdYOROCPDeMWfXlDnjhdy6HTg+NWqT4=; b=MmbWSD94o2+ai5vnQ+Ck3Fa2SComtZfkD0RnLRFY1Q4WylHEXcAXEYjAH8taUk8Tac EDcxhow2PvKPKyOMUDe4VuSTofkpugu3xjNYspohjXmDwFyxzj1P1BqMYlgDSVEDBBkl 7+rLCaGnxX6JXbSo8U2210Oz7DjBrJCl46p02bCfy+rXDZT5a/mm1PLrryFk9xfd2av0 tUEtx4YvAQMQraIitPkQP1dhA97pIc8mnE7AjT27iWFxzyTV8JyqvzzuCYg7j+eEFgL4 OSwIkI10gI+3ZLSCqhSQHUqYVwyqB63ektD0xVpt3YHjHZgGVv90ZMu+Bczq45pqakSd sk6w== X-Gm-Message-State: AFqh2kq7Rjkaz3qiS/HaqCW3IxPzkvNpangwet/Ky0xupdAL915+/k8h d5J1Mwq3pGx2K4aoogbod3pkqA== X-Google-Smtp-Source: AMrXdXtKAXX3oS9Pnk9NtCBhAAYZsbkGo0kVhxqgs6+MnSb6gGZedzmqEAIRil9QHRGoUCWCOyyeCA== X-Received: by 2002:a05:6602:1253:b0:6e3:19f:b3c3 with SMTP id o19-20020a056602125300b006e3019fb3c3mr27906809iou.0.1674774221562; Thu, 26 Jan 2023 15:03:41 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:41 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH v5 4/7] dt-bindings: mailbox: qcom: add missing platforms to conditional clauses Date: Fri, 27 Jan 2023 01:03:16 +0200 Message-Id: <20230126230319.3977109-5-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add missing platforms to the conditional clauses selecting whether the clocks/clock-names properties are required or whether they must be omitted. Acked-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index 5f7770036fed..7d8de7a16984 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -72,6 +72,7 @@ allOf: compatible: enum: - qcom,msm8916-apcs-kpss-global + - qcom,msm8939-apcs-kpss-global - qcom,qcs404-apcs-apps-global then: properties: @@ -121,12 +122,18 @@ allOf: properties: compatible: enum: + - qcom,msm8953-apcs-kpss-global + - qcom,msm8976-apcs-kpss-global - qcom,msm8994-apcs-kpss-global - qcom,msm8996-apcs-hmss-global - qcom,msm8998-apcs-hmss-global + - qcom,qcm2290-apcs-hmss-global - qcom,sc7180-apss-shared + - qcom,sc8180x-apss-shared - qcom,sdm660-apcs-hmss-global - qcom,sdm845-apss-shared + - qcom,sm4250-apcs-hmss-global + - qcom,sm6115-apcs-hmss-global - qcom,sm6125-apcs-hmss-global - qcom,sm8150-apss-shared then: --=20 2.39.0 From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FC15C54EAA for ; Thu, 26 Jan 2023 23:04:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233335AbjAZXEB (ORCPT ); Thu, 26 Jan 2023 18:04:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233301AbjAZXDx (ORCPT ); Thu, 26 Jan 2023 18:03:53 -0500 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B12A5A830 for ; Thu, 26 Jan 2023 15:03:45 -0800 (PST) Received: by mail-io1-xd2b.google.com with SMTP id b127so1190060iof.8 for ; Thu, 26 Jan 2023 15:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QXnOHOh5QfaalI7LSXB28OMKjzgZCCU/t1AphNsWkmU=; b=dvEKsQU/LwU8I5TvPnNA4/w/fSwdXqRmIHCf1lIY5usyAnONTT58PMQCB3ifzkmP3R fi8sQn/nQ5Y5OP7RyluH+vC+uCESbnVsg50lvkuSRPPAzCqOXcGtPjjyyTIP2hOXpbpj sQj1r3jV7owKnyHcVw69WbldPQbGdOjlbv0LjAHC1UG0JfAs4b3EiL7Y4W1Q35OCRUQH sJU4w4A1jeXBV81lNSgxCSxkrZ0NetYvR4Zzv7ut/CbFXOR0hxHrXm4tzfviSv63gaLW 9fNu3jnI9aOB7J7uIWkoAp06UmTuScvpB4L3h45QPJS70zm0aVCCugzl/COjEDmPahi8 pCtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QXnOHOh5QfaalI7LSXB28OMKjzgZCCU/t1AphNsWkmU=; b=7NGiWDjfLoYW8vLYfZ+XYXot7/5frFobHl7N29g0u0T1KhmRY8sZatpF2muiyXWFIe eHrTIKp2jBGrhUyXctpq0lsjMn7GYWVEudfw9gSxbLcibyMOQB/ZxnCH1u/OWfF17cCU rogDo9koQZSZ6XQdLU6yl8ZDC0pOwmmK9GSdWp2FezIOYx1tdz1LawU6qmAfd2dSsmwH o0VJ7zz3pzN/DyrrAvA2na29e/aEQZaCOIwmczrI0n7kZu9rJDqqt1c78kbVPjzIuMs2 C/GULmv0udAkcLfS2ppfigCRb4e37aL6c4lpF13uA6Sl/vVAVhx9VAWnkQQneC+pKHnO AoKA== X-Gm-Message-State: AO0yUKWU9k8urB+BH643Z/Ic7II009/3/obeoVN8Jps4hwflak0RNDGX BgF7bEyEgeb0Y3zH5jGWX+5TrA== X-Google-Smtp-Source: AK7set+MzHTZGoUtc4NYmN9ISFzRwN+Fg/fAOc8m3YcGzKZszaAHAj3SgihizV4/BI5an4rIk3JZoQ== X-Received: by 2002:a05:6602:2aca:b0:704:9e64:971 with SMTP id m10-20020a0566022aca00b007049e640971mr2846658iov.20.1674774225225; Thu, 26 Jan 2023 15:03:45 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:44 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski Subject: [PATCH v5 5/7] dt-bindings: mailbox: qcom: add #clock-cells to msm8996 example Date: Fri, 27 Jan 2023 01:03:17 +0200 Message-Id: <20230126230319.3977109-6-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the #clock-cells property to the MSM8996 example, as the APCS block is going to provide the `sys_apcs_aux' clock to the consumers. Acked-by: Krzysztof Kozlowski Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index 7d8de7a16984..1633aa82fc84 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -166,6 +166,7 @@ examples: reg =3D <0x9820000 0x1000>; =20 #mbox-cells =3D <1>; + #clock-cells =3D <0>; }; =20 rpm-glink { --=20 2.39.0 From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80E6AC05027 for ; Thu, 26 Jan 2023 23:04:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233363AbjAZXEG (ORCPT ); Thu, 26 Jan 2023 18:04:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233328AbjAZXD6 (ORCPT ); Thu, 26 Jan 2023 18:03:58 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7B665367 for ; Thu, 26 Jan 2023 15:03:49 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id r71so1205288iod.2 for ; Thu, 26 Jan 2023 15:03:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=60yxEW22hoAOOhOWGOTH5M2hZiABdMD97947KesUJto=; b=poqn1L3NeJ8Bshdxo0CekTCXbHJ2lRle49Zm7WY/4/v/A7MHCjEZ6WqbXd+6t3AS5S 902/CCuzt+mjQoVQp5LdS19P/+RolWfy+KLlJCHv3pdk3bPDZu1/4hJmVYFqTE5cXLk9 qk+37IWGdPc2PkyqNRd2ByMdns5+8IPtMlejGHaCL1MKhaW9yd7ZwKXo0P0qXf/m2Gb5 3E+//uMPwO836UORt6QuNGLicUszWv0N6RUKnJfoCeh2kyz4niuVqrPzMUhpLnDhBFzd w3hrht37nPOEM9XR7dsT7+TThR6ZodoUNaS2oU04AWpLtvdVR0WAx/fUQpbqJvG7e4v1 HlmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=60yxEW22hoAOOhOWGOTH5M2hZiABdMD97947KesUJto=; b=K1CB9Zxva+CJj9pXbsGy4gTBTs9v0UrgHFIjGOYm/NgZ4LHBJDshNKhGb2a2vZgvQR OrQwctznSyx7RakInUMCmVplJoRlGvAnsFS0OCLgSBmIP7L5HPgaPvotnDvHUXrbr/yB AJwanNfXIe0rjCGpntOCQzD6RRBO9eTpy4tjQtrPRytvO9Mt9aARcYIWz47vbf5VsA1R uolNeDkqDC7FLaWqePJ542HNnC/9LnDQS93tqeQbyHpfIAueBEVorxHtViHWvuqK3GYB 6iEfopzYPhGz8JGmS1KAYZyN3UbfIR79MhyZusfdAJSRCoIgfwbDg9op6khAUOxKNO9I YNpA== X-Gm-Message-State: AFqh2konBfSgcqhFrlJvJRWnZI1Bdi56EAxMc+4DIEwCbx1gU3AgTN5f DHLsp3X2x3WDXX/tB7UyfGgIyQ== X-Google-Smtp-Source: AMrXdXuAuaDVbBJKaExmyvsT8vI+dU4w26RIO0s+cAnOk/hzXXDGbqW1tGqBiFkvX9ufmtw6RTWfKw== X-Received: by 2002:a5e:cb42:0:b0:6df:e4f7:8c20 with SMTP id h2-20020a5ecb42000000b006dfe4f78c20mr28877020iok.14.1674774228807; Thu, 26 Jan 2023 15:03:48 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:48 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 6/7] mailbox: qcom-apcs-ipc: enable APCS clock device for MSM8996 Date: Fri, 27 Jan 2023 01:03:18 +0200 Message-Id: <20230126230319.3977109-7-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" MSM8996 also has the clock-related part of the APCS mailbox device. Follow the usual pattern and create a child device to handle these clocks. Signed-off-by: Dmitry Baryshkov --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom= -apcs-ipc-mailbox.c index 0e9f9cba8668..bd61dacb44ba 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -42,7 +42,7 @@ static const struct qcom_apcs_ipc_data msm8994_apcs_data = =3D { }; =20 static const struct qcom_apcs_ipc_data msm8996_apcs_data =3D { - .offset =3D 16, .clk_name =3D NULL + .offset =3D 16, .clk_name =3D "qcom-apcs-msm8996-clk" }; =20 static const struct qcom_apcs_ipc_data apps_shared_apcs_data =3D { --=20 2.39.0 From nobody Sun Sep 14 03:28:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A64DC05027 for ; Thu, 26 Jan 2023 23:04:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233342AbjAZXEO (ORCPT ); Thu, 26 Jan 2023 18:04:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233375AbjAZXEE (ORCPT ); Thu, 26 Jan 2023 18:04:04 -0500 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F1CE6A706 for ; Thu, 26 Jan 2023 15:03:53 -0800 (PST) Received: by mail-io1-xd34.google.com with SMTP id j1so1197415iob.6 for ; Thu, 26 Jan 2023 15:03:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N26PEPApLYbpGz0qyKTlI8x1Z7NNwGnlm+O7zvpxGcs=; b=jV3sjLex1kbpEc3GWpAMPWdMaIdlA7yEzjz4a9asfMWv3NL6RKXXBEo8SN5LWeZsEM l+EGsnMNpnsEr5cSbQP+9OF/fca+U1XIRgOzcbCOgJ5X4KjGcYhDqN/0Kt3jy1MrhyrL QjPtf/Th8PXUZYciux58kxjxfeQSwRbC9U7qlEDB74v2vzn8/dBoCf0TyNIdOdLZlsju 9SrpKufFhkPMMLIgEV6z8UuzuqFWdcdiLxIigki7UJuDgC2YcpGcvWNjx5EEQVIyVeXl HAfYSGb6APRJ85OgAxoEFdjjVRuPrQnQk8uU+5CU5cFUiv/EeLQgsgUqZeprRQYsUC1j Hj1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N26PEPApLYbpGz0qyKTlI8x1Z7NNwGnlm+O7zvpxGcs=; b=XBn5BztdJHS6vHUKv26F6o5SB06MC11e8zVewoTKasFWRXlKelUy3/zlokKWbd5TI0 CcQE0S4v1emOavmBQQ/mWA6+dg41MQF4myIxqBZYHW4Ii66hslRylkDc1JRBEJ9WVPin w/6Fq0vSo0Kn8t0Ftf6DIbe8K1h3mfcs6/QhPO6IeYfQP6UNKjuSlHhYUHWkZnCQYJGP s8iafSv6C3HZ063yWL0/yF5CpJ6szy1kSNK3exCFzBMuAGHDHP1hkilMPLN2RZsWw2mR xsshR8D8HdbQzFkcqF6zvrSG2fv5Hv7E64l859o600xEVo08SDijxsZ3IL7Op9x0gyvy q1HA== X-Gm-Message-State: AFqh2kpPZVm91oQnu7x9j5Oxu9hvhH8ePlpUIlylJBqaNXzE3gR+ks3E BjzNQGSx+oEzUVjW1UMFS5pzgA== X-Google-Smtp-Source: AMrXdXtIdkarRoDNgD4GrQZClYf/mKVXlQGJSrx6jyDSeVaoioXe8qOIGzVme9t4KANLslPXpjHEFw== X-Received: by 2002:a6b:dd11:0:b0:704:67aa:57b0 with SMTP id f17-20020a6bdd11000000b0070467aa57b0mr26056011ioc.2.1674774232392; Thu, 26 Jan 2023 15:03:52 -0800 (PST) Received: from eriador.lumag.spb.ru ([194.204.33.9]) by smtp.gmail.com with ESMTPSA id l4-20020a6bd104000000b006f8b7d869a0sm670924iob.1.2023.01.26.15.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 15:03:52 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 7/7] clk: qcom: add the driver for the MSM8996 APCS clocks Date: Fri, 27 Jan 2023 01:03:19 +0200 Message-Id: <20230126230319.3977109-8-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> References: <20230126230319.3977109-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a simple driver handling the APCS clocks on MSM8996. For now it supports just a single aux clock, linking GPLL0 to CPU and CBF clocks. Note, there is little sense in registering sys_apcs_aux as a child of gpll0. The PLL is always-on. And listing the gpll0 as a property of the apcs would delay its probing until the GCC has been probed (while we would like for the apcs to be probed as early as possible). Signed-off-by: Dmitry Baryshkov Reviewed-by: Konrad Dybcio --- drivers/clk/qcom/Makefile | 2 +- drivers/clk/qcom/apcs-msm8996.c | 88 +++++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+), 1 deletion(-) create mode 100644 drivers/clk/qcom/apcs-msm8996.c diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile index 3194465dd02c..a8ed1f38b2f7 100644 --- a/drivers/clk/qcom/Makefile +++ b/drivers/clk/qcom/Makefile @@ -52,7 +52,7 @@ obj-$(CONFIG_MSM_MMCC_8998) +=3D mmcc-msm8998.o obj-$(CONFIG_QCOM_A53PLL) +=3D a53-pll.o obj-$(CONFIG_QCOM_A7PLL) +=3D a7-pll.o obj-$(CONFIG_QCOM_CLK_APCS_MSM8916) +=3D apcs-msm8916.o -obj-$(CONFIG_QCOM_CLK_APCC_MSM8996) +=3D clk-cpu-8996.o +obj-$(CONFIG_QCOM_CLK_APCC_MSM8996) +=3D apcs-msm8996.o clk-cpu-8996.o obj-$(CONFIG_QCOM_CLK_APCS_SDX55) +=3D apcs-sdx55.o obj-$(CONFIG_QCOM_CLK_RPM) +=3D clk-rpm.o obj-$(CONFIG_QCOM_CLK_RPMH) +=3D clk-rpmh.o diff --git a/drivers/clk/qcom/apcs-msm8996.c b/drivers/clk/qcom/apcs-msm899= 6.c new file mode 100644 index 000000000000..48d22572b6ae --- /dev/null +++ b/drivers/clk/qcom/apcs-msm8996.c @@ -0,0 +1,88 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Qualcomm APCS clock controller driver + * + * Copyright (c) 2022, Linaro Limited + * Author: Dmitry Baryshkov + */ + +#include +#include +#include +#include +#include +#include + +#define APCS_AUX_OFFSET 0x50 + +#define APCS_AUX_DIV_MASK GENMASK(17, 16) +#define APCS_AUX_DIV_2 0x1 + +static int qcom_apcs_msm8996_clk_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct device *parent =3D dev->parent; + struct regmap *regmap; + struct clk_hw *hw; + unsigned int val; + int ret =3D -ENODEV; + + regmap =3D dev_get_regmap(parent, NULL); + if (!regmap) { + dev_err(dev, "failed to get regmap: %d\n", ret); + return ret; + } + + regmap_read(regmap, APCS_AUX_OFFSET, &val); + regmap_update_bits(regmap, APCS_AUX_OFFSET, APCS_AUX_DIV_MASK, + FIELD_PREP(APCS_AUX_DIV_MASK, APCS_AUX_DIV_2)); + + /* + * This clock is used during CPU cluster setup while setting up CPU PLLs. + * Add hardware mandated delay to make sure that the sys_apcs_aux clock + * is stable (after setting the divider) before continuing + * bootstrapping to keep CPUs from ending up in a weird state. + */ + udelay(5); + + /* + * As this clocks is a parent of the CPU cluster clocks and is actually + * used as a parent during CPU clocks setup, we want for it to gegister + * as early as possible, without letting fw_devlink to delay probing of + * either of the drivers. + * + * The sys_apcs_aux is a child (divider) of gpll0, but we register it + * as a fixed rate clock instead to ease bootstrapping procedure. By + * doing this we make sure that CPU cluster clocks are able to be setup + * early during the boot process (as it is recommended by Qualcomm). + */ + hw =3D devm_clk_hw_register_fixed_rate(dev, "sys_apcs_aux", NULL, 0, 3000= 00000); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); +} + +static struct platform_driver qcom_apcs_msm8996_clk_driver =3D { + .probe =3D qcom_apcs_msm8996_clk_probe, + .driver =3D { + .name =3D "qcom-apcs-msm8996-clk", + }, +}; + +/* Register early enough to fix the clock to be used for other cores */ +static int __init qcom_apcs_msm8996_clk_init(void) +{ + return platform_driver_register(&qcom_apcs_msm8996_clk_driver); +} +postcore_initcall(qcom_apcs_msm8996_clk_init); + +static void __exit qcom_apcs_msm8996_clk_exit(void) +{ + platform_driver_unregister(&qcom_apcs_msm8996_clk_driver); +} +module_exit(qcom_apcs_msm8996_clk_exit); + +MODULE_AUTHOR("Dmitry Baryshkov "); +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Qualcomm MSM8996 APCS clock driver"); --=20 2.39.0