From nobody Sun Sep 14 14:31:14 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC453C05027 for ; Fri, 20 Jan 2023 19:49:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229997AbjATTtM (ORCPT ); Fri, 20 Jan 2023 14:49:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbjATTtK (ORCPT ); Fri, 20 Jan 2023 14:49:10 -0500 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B897A6779E for ; Fri, 20 Jan 2023 11:49:04 -0800 (PST) Received: by mail-wr1-x435.google.com with SMTP id q5so1121955wrv.0 for ; Fri, 20 Jan 2023 11:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U1fLfhP+Gt35sMsNmrxRVX9NnAlPOzN2tCmzAKeG25c=; b=fKL1gUuQQfN6lRf5NSg53u6eZGlPjqy4XoEJ5j3qxOPk/2Hu6yEAVzixdXJRaTDZHl sz5xMdaT8RP5E85DS1uxDdK46TTWtLtnZ/x4Xs92L+JUCAI+PZUV5kkrFflkbEX7H5oE xuCXDPnhzCKaEB2yXbzOmKW8xXB/KiD0OSHJ3h8CmSMpFUtMubbkDXZVrb7dEdDAI+uy 0qOPjtjNkVtu+ry4neyo6eB/N6RdaP32R9YnfWq3p1kn/tZtx2r2WpeQBuAugU1vn2YH Em765RcL91Qhe6XjlgouI94lBmYTsv15xUwAwpqV0q32yxOFM0TivIHU0+9efciVircU QuQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U1fLfhP+Gt35sMsNmrxRVX9NnAlPOzN2tCmzAKeG25c=; b=OLaF9iun+4bKQl0RSRiINJwq5/yAg4blle1lmH7qCYL10HZne2L99eMReuzm+DzaUV pRYnhYr85q0EuqCfrV+6V54SnaTE3F0d0qU6hSUmbhMMiDEMHoMVNVjF0zZKdTqRuUF5 DSav/fNx7BxFKZhXFq6HFiFuOi+Z8lGCHhx+bwBmfaBzcCSZ0MOGhRiLe5T9WsY9fsd4 jcYN2GB/yyrHso5MoL63EhmkrR0NrbArinBr1fMPM7UgUZWbcT6++3n0yMDiJXjjpb78 DaHUKDf4Vbu/uTaqDkYQgby/+/8zE1lc8VnHNZzis/Ff2qDn+QuDzKv8/QHxXcnjMV/B elcg== X-Gm-Message-State: AFqh2kps6WlcaswgmY1gAl38lR45NNznXvZObOYPZUgkM2IBMXf1DOCp 95pGHbtbJMuPrHpe3MyP8gp7Cg== X-Google-Smtp-Source: AMrXdXsVJMYNom7SLj5vM30I7jS3ShXNULJqDkSHssTAjPTH021Au/32dCYHSiwtt6csRhcWs5mYGw== X-Received: by 2002:a5d:6282:0:b0:2bf:9516:d295 with SMTP id k2-20020a5d6282000000b002bf9516d295mr1510192wru.22.1674244143346; Fri, 20 Jan 2023 11:49:03 -0800 (PST) Received: from localhost.localdomain (host86-130-134-87.range86-130.btcentralplus.com. [86.130.134.87]) by smtp.gmail.com with ESMTPSA id l29-20020adfa39d000000b002bf95500254sm878921wrb.64.2023.01.20.11.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 11:49:02 -0800 (PST) From: Qais Yousef To: Peter Zijlstra , Ingo Molnar , Juri Lelli , Waiman Long Cc: Steven Rostedt , tj@kernel.org, linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, Dietmar Eggemann , cgroups@vger.kernel.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Qais Yousef Subject: [PATCH v2] sched: cpuset: Don't rebuild sched domains on suspend-resume Date: Fri, 20 Jan 2023 19:48:22 +0000 Message-Id: <20230120194822.962958-1-qyousef@layalina.io> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Commit f9a25f776d78 ("cpusets: Rebuild root domain deadline accounting info= rmation") enabled rebuilding sched domain on cpuset and hotplug operations to correct deadline accounting. Rebuilding sched domain is a slow operation and we see 10+ ms delay on suspend-resume because of that. Since nothing is expected to change on suspend-resume operation; skip rebuilding the sched domains to regain the time lost. Debugged-by: Rick Yiu Signed-off-by: Qais Yousef (Google) --- Changes in v2: =20 * Remove redundant check in update_tasks_root_domain() (Thanks Waiman) =20 v1 link: =20 https://lore.kernel.org/lkml/20221216233501.gh6m75e7s66dmjgo@airbuntu/ kernel/cgroup/cpuset.c | 3 +++ kernel/sched/deadline.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index a29c0b13706b..9a45f083459c 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1088,6 +1088,9 @@ static void rebuild_root_domains(void) lockdep_assert_cpus_held(); lockdep_assert_held(&sched_domains_mutex); =20 + if (cpuhp_tasks_frozen) + return; + rcu_read_lock(); =20 /* diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c index 0d97d54276cc..42c1143a3956 100644 --- a/kernel/sched/deadline.c +++ b/kernel/sched/deadline.c @@ -2575,6 +2575,9 @@ void dl_clear_root_domain(struct root_domain *rd) { unsigned long flags; =20 + if (cpuhp_tasks_frozen) + return; + raw_spin_lock_irqsave(&rd->dl_bw.lock, flags); rd->dl_bw.total_bw =3D 0; raw_spin_unlock_irqrestore(&rd->dl_bw.lock, flags); --=20 2.25.1