From nobody Sun Sep 14 16:08:44 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E72EC25B4E for ; Fri, 20 Jan 2023 16:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjATQTy (ORCPT ); Fri, 20 Jan 2023 11:19:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229769AbjATQTn (ORCPT ); Fri, 20 Jan 2023 11:19:43 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B5C226843 for ; Fri, 20 Jan 2023 08:19:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674231582; x=1705767582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9CCNdlSDny/3dQlb/K05NLxYiooqDXz3qOp5IJDFRMY=; b=aeKAwwdT4HMTcimJKJjbnqtESFzVp/UFjphlRf0jPJB+c9N6yqEichJ4 N9SdT+vrnLsv1MfzxZO6rYPgMAET+gVAmJVdLetlXs9GJ+WSgsSuMgwil wAKrFg53JMBu4dErAw0Fo5Wlix0EGGYydp0o59GRFEKoJPxk+KPejRjAv vVHZ1+RD3fZNfz7+3TJ0+kCfYV6/h4e7ylfVzDP2MVBFsunFDginkD7FR 5vJU2lL6OBIIaNsg6Gy7zU+YpAONvq+XPOdIXGxIlWgXBjCLHqHGt0l+4 LkPTCU+jSwVAilHzjUa3IdF1+UlPEAgGrPCmDad14Pw/72vEe5Zuhdi22 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="411846577" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="411846577" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 08:19:38 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10596"; a="653836372" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="653836372" Received: from araj-ucode.jf.intel.com ([10.23.0.19]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 08:19:37 -0800 From: Ashok Raj To: Boris Petkov , Thomas Gleixner Cc: Ashok Raj , Tony Luck , LKML , x86 , Ingo Molnar , Dave Hansen , Alison Schofield , Reinette Chatre , Tom Lendacky , Stefan Talpalaru , David Woodhouse , Benjamin Herrenschmidt , Jonathan Corbet , "Rafael J . Wysocki" , Peter Zilstra , Andy Lutomirski , Andrew Cooper , Boris Ostrovsky Subject: [Patch v5 3/5] x86/microcode: Display revisions only when update is successful Date: Fri, 20 Jan 2023 08:19:21 -0800 Message-Id: <20230120161923.118882-4-ashok.raj@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230120161923.118882-1-ashok.raj@intel.com> References: <20230120161923.118882-1-ashok.raj@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Right now, microcode loading failures and successes print the same message "Reloading completed". This is misleading to users. Display the updated revision number only if an update was successful. Display "Reload completed" only if the update was successful, otherwise report the update failed. Signed-off-by: Ashok Raj Fixes: 9bd681251b7c ("x86/microcode: Announce reload operation's completion= ") Suggested-by: Thomas Gleixner Reviewed-by: Tony Luck Link: https://lore.kernel.org/lkml/874judpqqd.ffs@tglx/ Cc: LKML Cc: x86 Cc: Ingo Molnar Cc: Tony Luck Cc: Dave Hansen Cc: Alison Schofield Cc: Reinette Chatre Cc: Thomas Gleixner (Intel) Cc: Tom Lendacky Cc: Stefan Talpalaru Cc: David Woodhouse Cc: Benjamin Herrenschmidt Cc: Jonathan Corbet Cc: Rafael J. Wysocki Cc: Peter Zilstra (Intel) Cc: Andy Lutomirski Cc: Andrew Cooper Cc: Boris Ostrovsky --- Changes since V3: Tony, Ingo - Print clear message if the update was successful or not. --- arch/x86/kernel/cpu/microcode/core.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/mic= rocode/core.c index bb943a91a364..d7cbc83df9b6 100644 --- a/arch/x86/kernel/cpu/microcode/core.c +++ b/arch/x86/kernel/cpu/microcode/core.c @@ -455,11 +455,15 @@ static int microcode_reload_late(void) store_cpu_caps(&prev_info); =20 ret =3D stop_machine_cpuslocked(__reload_late, NULL, cpu_online_mask); - if (ret =3D=3D 0) - microcode_check(&prev_info); =20 - pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n", - old, boot_cpu_data.microcode); + if (ret =3D=3D 0) { + pr_info("Reload completed, microcode revision: 0x%x -> 0x%x\n", + old, boot_cpu_data.microcode); + microcode_check(&prev_info); + } else { + pr_info("Reload failed, current microcode revision: 0x%x\n", + boot_cpu_data.microcode); + } =20 return ret; } --=20 2.34.1