From nobody Sun Sep 14 16:32:21 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22058C25B4E for ; Fri, 20 Jan 2023 14:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230165AbjATOkV (ORCPT ); Fri, 20 Jan 2023 09:40:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230166AbjATOkN (ORCPT ); Fri, 20 Jan 2023 09:40:13 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCA26D05CF for ; Fri, 20 Jan 2023 06:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1674225582; x=1705761582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1o9L/4gS6hFw7QhrPiNy1BOlai1A8GCWCQbQw2g35go=; b=N8KoVEws+IE8jm989gzVYiwvDTSE+7fVDlhRMvEbRgGPxRJBAZ0N988A 0Qj5vOtAQpC39UJjXcCdJcZJUMrOp2VuNHSNNmcxUNX98QLKH7gCNhCcT e92nA+p2d/l4TmTbYTfvaI5bDB7brPi2SCYauZZtFpD9W0ZNN5qqt6VmT +8VbyqMdYfjV6CcJs+OsckZ+m+7VBzt/M+uoGqIdzVm3cW4gmOCreQHcC jB4MFdQZsVwnSicEOM1oF/Lq362WH5clBzuV4+nOYZ7uZ+vObbc0f0ngM 2KKFfsi2tK2ouMMuh3aZmyGFfJKdTyNe+s4MEGiGMuW0XBI1ETRWTw+s8 g==; X-IronPort-AV: E=Sophos;i="5.97,232,1669100400"; d="scan'208";a="208646900" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 20 Jan 2023 07:38:13 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 20 Jan 2023 07:38:13 -0700 Received: from wendy.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Fri, 20 Jan 2023 07:38:12 -0700 From: Conor Dooley To: Jassi Brar CC: Conor Dooley , Daire McNamara , , Subject: [PATCH v2 2/7] mailbox: mpfs: switch to txdone_poll Date: Fri, 20 Jan 2023 14:37:30 +0000 Message-ID: <20230120143734.3438755-3-conor.dooley@microchip.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230120143734.3438755-1-conor.dooley@microchip.com> References: <20230120143734.3438755-1-conor.dooley@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The system controller on PolarFire SoC has no interrupt to signify that the TX has been completed. The interrupt instead signals that a service requested by the mailbox client has succeeded. If a service fails, there will be no interrupt delivered. Switch to polling the busy register to determine whether transmission has completed. Fixes: 83d7b1560810 ("mbox: add polarfire soc system controller mailbox") Signed-off-by: Conor Dooley --- drivers/mailbox/mailbox-mpfs.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/mailbox-mpfs.c b/drivers/mailbox/mailbox-mpfs.c index d37560e91116..e0e825bdbad9 100644 --- a/drivers/mailbox/mailbox-mpfs.c +++ b/drivers/mailbox/mailbox-mpfs.c @@ -79,6 +79,13 @@ static bool mpfs_mbox_busy(struct mpfs_mbox *mbox) return status & SCB_STATUS_BUSY_MASK; } =20 +static bool mpfs_mbox_last_tx_done(struct mbox_chan *chan) +{ + struct mpfs_mbox *mbox =3D (struct mpfs_mbox *)chan->con_priv; + + return !mpfs_mbox_busy(mbox); +} + static int mpfs_mbox_send_data(struct mbox_chan *chan, void *data) { struct mpfs_mbox *mbox =3D (struct mpfs_mbox *)chan->con_priv; @@ -183,7 +190,6 @@ static irqreturn_t mpfs_mbox_inbox_isr(int irq, void *d= ata) =20 mpfs_mbox_rx_data(chan); =20 - mbox_chan_txdone(chan, 0); return IRQ_HANDLED; } =20 @@ -213,6 +219,7 @@ static const struct mbox_chan_ops mpfs_mbox_ops =3D { .send_data =3D mpfs_mbox_send_data, .startup =3D mpfs_mbox_startup, .shutdown =3D mpfs_mbox_shutdown, + .last_tx_done =3D mpfs_mbox_last_tx_done, }; =20 static int mpfs_mbox_probe(struct platform_device *pdev) @@ -248,7 +255,8 @@ static int mpfs_mbox_probe(struct platform_device *pdev) mbox->controller.num_chans =3D 1; mbox->controller.chans =3D mbox->chans; mbox->controller.ops =3D &mpfs_mbox_ops; - mbox->controller.txdone_irq =3D true; + mbox->controller.txdone_poll =3D true; + mbox->controller.txpoll_period =3D 10u; =20 ret =3D devm_mbox_controller_register(&pdev->dev, &mbox->controller); if (ret) { --=20 2.39.0