From nobody Sun Sep 14 16:23:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0469DC05027 for ; Fri, 20 Jan 2023 12:35:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230162AbjATMf5 (ORCPT ); Fri, 20 Jan 2023 07:35:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230192AbjATMfv (ORCPT ); Fri, 20 Jan 2023 07:35:51 -0500 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCF6CBF5EB; Fri, 20 Jan 2023 04:35:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1674218129; x=1705754129; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JH3uowZm2/EOmx74lVqvydtWQ0K9xGM+P+gA7PXly5g=; b=HYSip1CFyvJ3Ob6Md91EkTc8u2dj9IfnC7PUrHcByJUwA6dd5vOAax32 1DYVFicwa/S808ZrHAIbXlNA8p9mJF0dsEdNDbQPEyJAfGcD8rF415VcK xVGmJas1ly1P4MHBaOEUQXhIe/KXxBjKQGB+1fEGxa0qaR5ywbIvbeJpt pSFLEm+tpjsykvS2hR+vLsXD41oA72LsRqnPnlbx+m4aIA11Oi8o1lYEH 9k6V+5HzaGJf+0FW3zoUluJK3CXgvURkYlc0RxKwSdR3AIWBj4oXrtHXH ZwH4Pdg60b6mf49awK8YbBZ1wizAKq7bHsaM31UsXfFqjx2RPYd2EM+rL A==; X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="387935241" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="387935241" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 04:35:28 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10595"; a="692847442" X-IronPort-AV: E=Sophos;i="5.97,232,1669104000"; d="scan'208";a="692847442" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO ahunter-VirtualBox.home\044ger.corp.intel.com) ([10.251.223.163]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2023 04:35:26 -0800 From: Adrian Hunter To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: [PATCH 06/10] perf symbols: Do not check ss->dynsym twice Date: Fri, 20 Jan 2023 14:34:52 +0200 Message-Id: <20230120123456.12449-7-adrian.hunter@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230120123456.12449-1-adrian.hunter@intel.com> References: <20230120123456.12449-1-adrian.hunter@intel.com> MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" ss->dynsym is checked to be not NULL twice. Remove the first check because, in fact, there can be a plt with no dynsym, which is something that will be dealt with later. Signed-off-by: Adrian Hunter --- tools/perf/util/symbol-elf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c index 990a2c6037bb..87b82507c205 100644 --- a/tools/perf/util/symbol-elf.c +++ b/tools/perf/util/symbol-elf.c @@ -386,9 +386,6 @@ int dso__synthesize_plt_symbols(struct dso *dso, struct= symsrc *ss) Elf *elf; int nr =3D 0, symidx, err =3D -1; =20 - if (!ss->dynsym) - return 0; - elf =3D ss->elf; ehdr =3D ss->ehdr; =20 --=20 2.34.1