From nobody Sat Sep 21 05:54:52 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A9FC677F1 for ; Tue, 17 Jan 2023 17:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233601AbjAQRd0 (ORCPT ); Tue, 17 Jan 2023 12:33:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235304AbjAQR11 (ORCPT ); Tue, 17 Jan 2023 12:27:27 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30A794995E; Tue, 17 Jan 2023 09:26:50 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AC940614EA; Tue, 17 Jan 2023 17:26:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24485C433D2; Tue, 17 Jan 2023 17:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673976409; bh=EXkWvmS2L/OCsuWKSVec76+Ewe99CqDEoweaQMO5UgY=; h=From:To:Cc:Subject:Date:From; b=XfuwvSBN/Ec/MGZH+bwy8rk40+MfcdkaBuBmCIerqEwcfsMCw/8ceAp8tYUaJ88za uxGDbHfaE94z6a5DtAxN2aUGK0JYa/oUXEerODPJF+ljv8NbcqR4XRQZLROgerpOKN KMei4jmesJ/Vde1NipQU81cUacWsg6q2bPhZf0CBhpBtNHfKmZoO04D0qVnFIvm4HK 7JH/rhANh9egfwJ4A1Rw/UoIcEZY1GrdaX2XLXSEQfJgK/kegd61gMR9YQpF8Kwcj9 kDbCbzZ1GpL7EcDBMpsTvtTO9VBzXDHizLxUAof5jYRq5amzxNbnpsZQtz7QYYVzYI 26ckpwQCVJRfg== From: Arnd Bergmann To: Bin Liu , Mauro Carvalho Chehab Cc: Arnd Bergmann , Matthias Brugger , Hans Verkuil , kyrie wu , irui wang , Dan Carpenter , Sakari Ailus , Colin Ian King , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: mtk_jpeg_core: avoid unused-variable warning Date: Tue, 17 Jan 2023 18:26:33 +0100 Message-Id: <20230117172644.3044265-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann The only reference to mtk8195_jpegenc_drvdata is inside of an #ifdef: drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c:1879:32: error: 'mtk81= 95_jpegenc_drvdata' defined but not used [-Werror=3Dunused-variable] 1879 | static struct mtk_jpeg_variant mtk8195_jpegenc_drvdata =3D { | ^~~~~~~~~~~~~~~~~~~~~~~ Fix this by just removing the #ifdef and the corresponding of_match_ptr(). They don't actually serve any purpose here since the driver is only usable when CONFIG_OF is enabled, and build testing without that is not a problem. Fixes: 934e8bccac95 ("mtk-jpegenc: support jpegenc multi-hardware") Signed-off-by: Arnd Bergmann Reviewed-by: Chen-Yu Tsai --- drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c b/drivers= /media/platform/mediatek/jpeg/mtk_jpeg_core.c index 969516a940ba..bd12e73492e5 100644 --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c @@ -1898,7 +1898,6 @@ static const struct mtk_jpeg_variant mtk8195_jpegdec_= drvdata =3D { .cap_q_default_fourcc =3D V4L2_PIX_FMT_YUV420M, }; =20 -#if defined(CONFIG_OF) static const struct of_device_id mtk_jpeg_match[] =3D { { .compatible =3D "mediatek,mt8173-jpgdec", @@ -1924,14 +1923,13 @@ static const struct of_device_id mtk_jpeg_match[] = =3D { }; =20 MODULE_DEVICE_TABLE(of, mtk_jpeg_match); -#endif =20 static struct platform_driver mtk_jpeg_driver =3D { .probe =3D mtk_jpeg_probe, .remove =3D mtk_jpeg_remove, .driver =3D { .name =3D MTK_JPEG_NAME, - .of_match_table =3D of_match_ptr(mtk_jpeg_match), + .of_match_table =3D mtk_jpeg_match, .pm =3D &mtk_jpeg_pm_ops, }, }; --=20 2.39.0