From nobody Mon Sep 15 00:26:07 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 532CEC6379F for ; Tue, 17 Jan 2023 06:03:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235385AbjAQGDO (ORCPT ); Tue, 17 Jan 2023 01:03:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235598AbjAQGCg (ORCPT ); Tue, 17 Jan 2023 01:02:36 -0500 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF11683C1; Mon, 16 Jan 2023 22:02:33 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VZltwnw_1673935344; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VZltwnw_1673935344) by smtp.aliyun-inc.com; Tue, 17 Jan 2023 14:02:31 +0800 From: Jiapeng Chong To: agordeev@linux.ibm.com Cc: gerald.schaefer@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] s390/vmem: Use swap() instead of open coding it Date: Tue, 17 Jan 2023 14:02:23 +0800 Message-Id: <20230117060223.58583-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Swap is a function interface that provides exchange function. To avoid code duplication, we can use swap function. ./arch/s390/mm/vmem.c:680:10-11: WARNING opportunity for swap(). Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D3786 Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- arch/s390/mm/vmem.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/arch/s390/mm/vmem.c b/arch/s390/mm/vmem.c index 78d7768f93d7..774a71b94f5c 100644 --- a/arch/s390/mm/vmem.c +++ b/arch/s390/mm/vmem.c @@ -674,11 +674,8 @@ static void __init memblock_region_swap(void *a, void = *b, int size) { struct memblock_region *r1 =3D a; struct memblock_region *r2 =3D b; - struct memblock_region swap; =20 - swap =3D *r1; - *r1 =3D *r2; - *r2 =3D swap; + swap(*r1, *r2); } =20 /* --=20 2.20.1.7.g153144c