From nobody Mon Sep 15 05:47:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01ABFC3DA78 for ; Sat, 14 Jan 2023 13:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229803AbjANNFy (ORCPT ); Sat, 14 Jan 2023 08:05:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229726AbjANNFv (ORCPT ); Sat, 14 Jan 2023 08:05:51 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32B168A57; Sat, 14 Jan 2023 05:05:50 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id bf43so36753860lfb.6; Sat, 14 Jan 2023 05:05:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vgp8s8P2WnixEBsyqVgrtqVW0mzwiU+P0sRoxo3EKgg=; b=DqIzIVQqNhd6n7jA2tIB+KM6TbxMggUX/MlouaizxXqzrSigNfPdtP1GiYuJWHsI68 EoH0d+GVqWnM6IiIeHH7AloVnZ3iibSVeKZVoTNAIont4n1/b+X+9yUVQWYvzuX9QiaJ vCqQzxTvoImWC1b0q1xYmob9w+mlDSzMxHNTeOHau3P76deLvuhCmNApmI0a+jgxtcqy JJ7jiCjdqGOQaxS/ZymoSQZZrM6KafLZs2eqWDk4hDUdg1jsEaq/GX0EmZ6bYJXQD8Oq AnEx1bq6T1aigkFKmeRmkr+22xKvgToa/jVmz/CHha43Dt5EZdIl0wlvKwj0w41WP35n hlZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vgp8s8P2WnixEBsyqVgrtqVW0mzwiU+P0sRoxo3EKgg=; b=NpuhKJQwOGW7XymcBuUtF+U+Giqy5toc4Xo51pHkbefyy+eSRaggmn5VovX6sLPy4o tGVxQsmyZxm2sG3rW6aPSdrjHWK0eRivdsdyQzVHTFCxCuNc+IWrHyUCplGSk+yvZcVq elGIxWiZjqJVFUm8H5KxyPXVFKgsAoEBRbMBNxZun+GJwegYOpp3NuKXXSFZgtJ3Dvdb BZCAQlN+igR6hynAvzSfbpT1UHml5faD1eJ8EJErs1GfISFMT13CFPsKrqxzPAZlFZ6d j4xwnc0hY+CdH6Pkj4quwqA3LZMJ2yTOzB7k5Kvt4pxgZGrUo8sVma2fhteTCytD5why ukQw== X-Gm-Message-State: AFqh2kqnkcOJXXw3hOdgIIhB42/pAXZLXNhrTCwlfDwHpWTDad1NYgFj QVAjp/zWUdbKZgGLwem50Mw= X-Google-Smtp-Source: AMrXdXseQtXtrBTBAIuP23lB4heGwwraewT2WBFbPz/oRUxG5dwQHtlgc4vN+sjWfXMJyMGsxnoD9Q== X-Received: by 2002:a05:6512:3415:b0:4b5:947e:68f3 with SMTP id i21-20020a056512341500b004b5947e68f3mr18870984lfr.1.1673701548196; Sat, 14 Jan 2023 05:05:48 -0800 (PST) Received: from localhost.localdomain ([46.147.136.10]) by smtp.gmail.com with ESMTPSA id b17-20020a056512071100b0049c29389b98sm4288987lfs.151.2023.01.14.05.05.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Jan 2023 05:05:47 -0800 (PST) From: Alexander Pantyukhin To: adrian.hunter@intel.com Cc: mingo@redhat.com, namhyung@kernel.org, jolsa@kernel.org, acme@kernel.org, akpm@linux-foundation.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Pantyukhin Subject: [PATCH v2] tools:perf:scripts:python:intel-pt-events del unusedvar Date: Sat, 14 Jan 2023 18:05:33 +0500 Message-Id: <20230114130533.2877-1-apantykhin@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The event_attr is never used later, the var is ok be deleted. Additional code simplification is to substitute string slice comparison with "substring" function. This case no need to know the length specific words. Signed-off-by: Alexander Pantyukhin Acked-by: Adrian Hunter --- tools/perf/scripts/python/intel-pt-events.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/scripts/python/intel-pt-events.py b/tools/perf/scri= pts/python/intel-pt-events.py index 08862a2582f4..dfd566369ca4 100644 --- a/tools/perf/scripts/python/intel-pt-events.py +++ b/tools/perf/scripts/python/intel-pt-events.py @@ -340,7 +340,6 @@ def print_srccode(comm, param_dict, sample, symbol, dso= , with_insn): print(start_str, src_str) =20 def do_process_event(param_dict): - event_attr =3D param_dict["attr"] sample =3D param_dict["sample"] raw_buf =3D param_dict["raw_buf"] comm =3D param_dict["comm"] @@ -349,6 +348,7 @@ def do_process_event(param_dict): # callchain =3D param_dict["callchain"] # brstack =3D param_dict["brstack"] # brstacksym =3D param_dict["brstacksym"] + # event_attr =3D param_dict["attr"] =20 # Symbol and dso info are not always resolved dso =3D get_optional(param_dict, "dso") @@ -359,13 +359,13 @@ def do_process_event(param_dict): print(glb_switch_str[cpu]) del glb_switch_str[cpu] =20 - if name[0:12] =3D=3D "instructions": + if name.startswith("instructions"): if glb_src: print_srccode(comm, param_dict, sample, symbol, dso, True) else: print_instructions_start(comm, sample) print_common_ip(param_dict, sample, symbol, dso) - elif name[0:8] =3D=3D "branches": + elif name.startswith("branches"): if glb_src: print_srccode(comm, param_dict, sample, symbol, dso, False) else: --=20 2.25.1