From nobody Mon Sep 15 10:02:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3368C54EBD for ; Thu, 12 Jan 2023 16:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238554AbjALQaj (ORCPT ); Thu, 12 Jan 2023 11:30:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232596AbjALQaA (ORCPT ); Thu, 12 Jan 2023 11:30:00 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C54DFE; Thu, 12 Jan 2023 08:28:52 -0800 (PST) Received: from beast.luon.net (unknown [IPv6:2a10:3781:2531:0:26cc:6c0f:ebfb:d967]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sjoerd) by madras.collabora.co.uk (Postfix) with ESMTPSA id 0AF026602DC6; Thu, 12 Jan 2023 16:28:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673540931; bh=UorPj7AzCH/CfWIQed3UyluZ1vgNc+4RXPdFlhZ1+6I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mHc6RrPNp9x7DvSkTkA7stiIrvhASsZfWkZS0tVoG3zB/ELfcCrIQvOO7GAEzai75 BRrSFJo0pwpFFnBnJh5OJ8xjhpC2pL+9D3xpGMszGtzNflbRpRITZd23KS9kYEEtTp FdODAMlceUMcXqdEkXZgpUScYMz4DBY852/5v70VRezGyP4xAYCePtj6h8a/vZpRNe xTfpbL3ZP0RdpZN40bUIEsQMFaxenEq/TSx4Eh7djfN6G7n42hwtdHwurbsnOY2hPC UW5mVuJ98XFy0kt2RcAOtaR+wO7RF8z4dRUHl0xLCpnmc3aO/kLBVIbJm43/3ibMlW PyJTom4EIhUsg== Received: by beast.luon.net (Postfix, from userid 1000) id 80D9760E4F1E; Thu, 12 Jan 2023 17:28:48 +0100 (CET) From: Sjoerd Simons To: Nishanth Menon Cc: kernel@collabora.com, Nitin Yadav , martyn.welch@collabora.com, Krzysztof Kozlowski , Rob Herring , Tero Kristo , Vignesh Raghavendra , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/3] arm64: dts: ti: k3-am62-main: Update OTAP and ITAP delay select Date: Thu, 12 Jan 2023 17:28:44 +0100 Message-Id: <20230112162847.973869-2-sjoerd@collabora.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112162847.973869-1-sjoerd@collabora.com> References: <20230112162847.973869-1-sjoerd@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Nitin Yadav UHS Class U1 sd-card are not getting detected due to incorrect OTAP/ITAP delay select values in linux. Update OTAP and ITAP delay select values for various speed modes. For sdhci0, update OTAP delay values for ddr52 & HS200 and add ITAP delay for legacy & mmc-hs. For sdhci1 & sdhci2, update OTAP & ITAP delay select recommended as in RIOT for various speed modes. Signed-off-by: Nitin Yadav [cherry-pick from vendor BSP] Signed-off-by: Sjoerd Simons Tested-by: Martyn Welch --- (no changes since v3) Changes in v3: - Rebased against current ti-next aka 6.2-rc1 - Add Martyn's tested-by Changes in v2: - Rebase against linux-next 20221220 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 46 ++++++++++++------------ 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts= /ti/k3-am62-main.dtsi index 072903649d6e..466b94d1cee9 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -501,8 +501,10 @@ sdhci0: mmc@fa10000 { ti,clkbuf-sel =3D <0x7>; ti,otap-del-sel-legacy =3D <0x0>; ti,otap-del-sel-mmc-hs =3D <0x0>; - ti,otap-del-sel-ddr52 =3D <0x9>; - ti,otap-del-sel-hs200 =3D <0x6>; + ti,otap-del-sel-ddr52 =3D <0x5>; + ti,otap-del-sel-hs200 =3D <0x5>; + ti,itap-del-sel-legacy =3D <0xa>; + ti,itap-del-sel-mmc-hs =3D <0x1>; status =3D "disabled"; }; =20 @@ -514,17 +516,17 @@ sdhci1: mmc@fa00000 { clocks =3D <&k3_clks 58 5>, <&k3_clks 58 6>; clock-names =3D "clk_ahb", "clk_xin"; ti,trm-icp =3D <0x2>; - ti,otap-del-sel-legacy =3D <0x0>; + ti,otap-del-sel-legacy =3D <0x8>; ti,otap-del-sel-sd-hs =3D <0x0>; - ti,otap-del-sel-sdr12 =3D <0xf>; - ti,otap-del-sel-sdr25 =3D <0xf>; - ti,otap-del-sel-sdr50 =3D <0xc>; - ti,otap-del-sel-sdr104 =3D <0x6>; - ti,otap-del-sel-ddr50 =3D <0x9>; - ti,itap-del-sel-legacy =3D <0x0>; - ti,itap-del-sel-sd-hs =3D <0x0>; - ti,itap-del-sel-sdr12 =3D <0x0>; - ti,itap-del-sel-sdr25 =3D <0x0>; + ti,otap-del-sel-sdr12 =3D <0x0>; + ti,otap-del-sel-sdr25 =3D <0x0>; + ti,otap-del-sel-sdr50 =3D <0x8>; + ti,otap-del-sel-sdr104 =3D <0x7>; + ti,otap-del-sel-ddr50 =3D <0x4>; + ti,itap-del-sel-legacy =3D <0xa>; + ti,itap-del-sel-sd-hs =3D <0x1>; + ti,itap-del-sel-sdr12 =3D <0xa>; + ti,itap-del-sel-sdr25 =3D <0x1>; ti,clkbuf-sel =3D <0x7>; bus-width =3D <4>; status =3D "disabled"; @@ -538,17 +540,17 @@ sdhci2: mmc@fa20000 { clocks =3D <&k3_clks 184 5>, <&k3_clks 184 6>; clock-names =3D "clk_ahb", "clk_xin"; ti,trm-icp =3D <0x2>; - ti,otap-del-sel-legacy =3D <0x0>; + ti,otap-del-sel-legacy =3D <0x8>; ti,otap-del-sel-sd-hs =3D <0x0>; - ti,otap-del-sel-sdr12 =3D <0xf>; - ti,otap-del-sel-sdr25 =3D <0xf>; - ti,otap-del-sel-sdr50 =3D <0xc>; - ti,otap-del-sel-sdr104 =3D <0x6>; - ti,otap-del-sel-ddr50 =3D <0x9>; - ti,itap-del-sel-legacy =3D <0x0>; - ti,itap-del-sel-sd-hs =3D <0x0>; - ti,itap-del-sel-sdr12 =3D <0x0>; - ti,itap-del-sel-sdr25 =3D <0x0>; + ti,otap-del-sel-sdr12 =3D <0x0>; + ti,otap-del-sel-sdr25 =3D <0x0>; + ti,otap-del-sel-sdr50 =3D <0x8>; + ti,otap-del-sel-sdr104 =3D <0x7>; + ti,otap-del-sel-ddr50 =3D <0x8>; + ti,itap-del-sel-legacy =3D <0xa>; + ti,itap-del-sel-sd-hs =3D <0xa>; + ti,itap-del-sel-sdr12 =3D <0xa>; + ti,itap-del-sel-sdr25 =3D <0x1>; ti,clkbuf-sel =3D <0x7>; status =3D "disabled"; }; --=20 2.39.0 From nobody Mon Sep 15 10:02:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 007F4C54EBC for ; Thu, 12 Jan 2023 16:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233963AbjALQav (ORCPT ); Thu, 12 Jan 2023 11:30:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232994AbjALQaA (ORCPT ); Thu, 12 Jan 2023 11:30:00 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D2D1D60; Thu, 12 Jan 2023 08:28:53 -0800 (PST) Received: from beast.luon.net (unknown [IPv6:2a10:3781:2531:0:26cc:6c0f:ebfb:d967]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: sjoerd) by madras.collabora.co.uk (Postfix) with ESMTPSA id BF6BD6602DBB; Thu, 12 Jan 2023 16:28:51 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673540931; bh=/MUXja0lZkywFQKNAJ/ZYCX/AfVpxbPZT9qjorcgbTs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ST32RcIJHyNRh+zZKkZrBx/I2Mxzi7yj/z+UC7xfTtN9tOvhS+h1SOuVcfaEP2DQy rq6Q8UfOU/Q1MqBGm9RWQl010dyVoJFJK0aMrWX/ICVxT4GTs1PDCe5Vd7G3x+1Ae4 crSm3XCYJVleUkO6MkHXzW2Fb8gj31EUmrDXugiigYy0rH3WYkRJ3o5Iug0XlSRnRB c5iFfkX+OjfOHpCus/pHjGSqpaZBNg/fHiP7KrkOIubHuwxZ8jBkMJhKIZHWYC2WVg +qKmKTIne2ZI+HsPOWvV5s/djJJyADwJQa0AUEervCOzRu9PlkI3lVx/zzHkmdQGD7 sX8GGrDdkU76Q== Received: by beast.luon.net (Postfix, from userid 1000) id 7199460E4F20; Thu, 12 Jan 2023 17:28:49 +0100 (CET) From: Sjoerd Simons To: Nishanth Menon Cc: kernel@collabora.com, Nitin Yadav , martyn.welch@collabora.com, Aswath Govindraju , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , Tero Kristo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/3] arm64: dts: ti: k3-am62-main: Add support for USB Date: Thu, 12 Jan 2023 17:28:45 +0100 Message-Id: <20230112162847.973869-3-sjoerd@collabora.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112162847.973869-1-sjoerd@collabora.com> References: <20230112162847.973869-1-sjoerd@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Aswath Govindraju AM62 SoC has two instances of USB on it. Therefore, add support for the same. Signed-off-by: Aswath Govindraju Signed-off-by: Vignesh Raghavendra [cherry-pick from vendor BSP, disable nodes by default] Signed-off-by: Sjoerd Simons Tested-by: Martyn Welch --- Changes in v4: - Default to status=3D"disabled" for usbss nodes Changes in v3: - Rebased against current ti-next aka 6.2-rc1 - Add Martyn's tested-by Changes in v2: - Rebase against linux-next 20221220 arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 46 ++++++++++++++++++++++++ 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts= /ti/k3-am62-main.dtsi index 466b94d1cee9..2d437d3b94ed 100644 --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi @@ -555,6 +555,52 @@ sdhci2: mmc@fa20000 { status =3D "disabled"; }; =20 + usbss0: dwc3-usb@f900000 { + compatible =3D "ti,am62-usb"; + reg =3D <0x00 0x0f900000 0x00 0x800>; + clocks =3D <&k3_clks 161 3>; + clock-names =3D "ref"; + ti,syscon-phy-pll-refclk =3D <&wkup_conf 0x4008>; + #address-cells =3D <2>; + #size-cells =3D <2>; + power-domains =3D <&k3_pds 178 TI_SCI_PD_EXCLUSIVE>; + ranges; + status =3D "disabled"; + + usb0: usb@31000000 { + compatible =3D "snps,dwc3"; + reg =3D<0x00 0x31000000 0x00 0x50000>; + interrupts =3D , /* irq.0 */ + ; /* irq.0 */ + interrupt-names =3D "host", "peripheral"; + maximum-speed =3D "high-speed"; + dr_mode =3D "otg"; + }; + }; + + usbss1: dwc3-usb@f910000 { + compatible =3D "ti,am62-usb"; + reg =3D <0x00 0x0f910000 0x00 0x800>; + clocks =3D <&k3_clks 162 3>; + clock-names =3D "ref"; + ti,syscon-phy-pll-refclk =3D <&wkup_conf 0x4018>; + #address-cells =3D <2>; + #size-cells =3D <2>; + power-domains =3D <&k3_pds 179 TI_SCI_PD_EXCLUSIVE>; + ranges; + status =3D "disabled"; + + usb1: usb@31100000 { + compatible =3D "snps,dwc3"; + reg =3D<0x00 0x31100000 0x00 0x50000>; + interrupts =3D , /* irq.0 */ + ; /* irq.0 */ + interrupt-names =3D "host", "peripheral"; + maximum-speed =3D "high-speed"; + dr_mode =3D "otg"; + }; + }; + fss: bus@fc00000 { compatible =3D "simple-bus"; reg =3D <0x00 0x0fc00000 0x00 0x70000>; --=20 2.39.0 From nobody Mon Sep 15 10:02:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08854C54EBC for ; Thu, 12 Jan 2023 16:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235932AbjALQa5 (ORCPT ); Thu, 12 Jan 2023 11:30:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35708 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233136AbjALQaA (ORCPT ); Thu, 12 Jan 2023 11:30:00 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 156F4C6D; Thu, 12 Jan 2023 08:28:54 -0800 (PST) Received: from beast.luon.net (simons.connected.by.freedominter.net [45.83.240.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sjoerd) by madras.collabora.co.uk (Postfix) with ESMTPSA id CC3896602DCD; Thu, 12 Jan 2023 16:28:52 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673540932; bh=mb1FOmjwtW1XJfBII8bu1T9OEKm0ryg8UdzWb6jiwz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GDj+66P6Jq6nxjfTsAUXbid+fH+RXws6EFwipMscRCCT65IRouCT8Pee58MZxwBS2 oQpOjfq1b1ajNuiZhcspvuJ346KCt3/USKbcmya6JjllrlWSI4t+DKEK735UEdf7qz yJzgfSY6usRCaGrmg11sLObv+LdLPgw4OGA8ykZKjZ3WGtyHnd6mSkN4SaJqdPkO7K x2oEgTXf/oZtJ0GySo9KUsRzDIlXtviFYGaX2UDPKAYgdB92UvxpBwJcMMdAh9p/ZJ gEMkGZ3QdzBXlNnm/zdWvS1BVJANBumIZ0u4uIVMT2VZoyb+KfOEJpPJvDp+qg6d4s VWNgCbYzeIY/Q== Received: by beast.luon.net (Postfix, from userid 1000) id 656A360E4F23; Thu, 12 Jan 2023 17:28:50 +0100 (CET) From: Sjoerd Simons To: Nishanth Menon Cc: kernel@collabora.com, Nitin Yadav , martyn.welch@collabora.com, Aswath Govindraju , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , Tero Kristo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/3] arm64: dts: ti: k3-am625-sk: Add support for USB Date: Thu, 12 Jan 2023 17:28:46 +0100 Message-Id: <20230112162847.973869-4-sjoerd@collabora.com> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230112162847.973869-1-sjoerd@collabora.com> References: <20230112162847.973869-1-sjoerd@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Aswath Govindraju AM62 SoC has two instances of USB and they are brought on to the board in the following way, -> USB0 instance - This is brought out to a USB TypeC connector on board through TPS6598 PD controller. The PD controller should decide the role based on CC pin in the connector. Unfortunately the irq line for the TPS isn't hooked up which is a mode not yet support by the driver (some patches were submitted earlier this year[0]). So for now the PD controller is left out and peripheral mode chosen. -> USB1 instance - This is brought out to a USB TypeA connector on board. Therefore, add the required device tree support for the above in the board dts file. 0: https://lore.kernel.org/lkml/f714ee55-ef47-317d-81b9-57020dda064b@ti.com= /T/ Signed-off-by: Aswath Govindraju Signed-off-by: Vignesh Raghavendra [merge from vendor bsp, drop TPS6598 support, drop unneeded nodes, reword c= ommit message] Signed-off-by: Sjoerd Simons Tested-by: Martyn Welch --- Changes in v4: - Disable new usbss nodes by default in the dtsi and enable in the dts - Drop unneeded disabled nodes in board dts - Drop unneeded nodes - Enable usbss nodes - Small typo fix Changes in v3: - Rebased against current ti-next aka 6.2-rc1 - Add Martyn's tested-by Changes in v2: - Rebase against linux-next 20221220 arch/arm64/boot/dts/ti/k3-am625-sk.dts | 27 ++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am625-sk.dts b/arch/arm64/boot/dts/t= i/k3-am625-sk.dts index 4f179b146cab..6bc7d63cf52f 100644 --- a/arch/arm64/boot/dts/ti/k3-am625-sk.dts +++ b/arch/arm64/boot/dts/ti/k3-am625-sk.dts @@ -24,6 +24,8 @@ aliases { spi0 =3D &ospi0; ethernet0 =3D &cpsw_port1; ethernet1 =3D &cpsw_port2; + usb0 =3D &usb0; + usb1 =3D &usb1; }; =20 chosen { @@ -284,6 +286,12 @@ main_gpio1_ioexp_intr_pins_default: main-gpio1-ioexp-i= ntr-pins-default { AM62X_IOPAD(0x01d4, PIN_INPUT, 7) /* (B15) UART0_RTSn.GPIO1_23 */ >; }; + + main_usb1_pins_default: main-usb1-pins-default { + pinctrl-single,pins =3D < + AM62X_IOPAD(0x0258, PIN_OUTPUT, 0) /* (F18) USB1_DRVVBUS */ + >; + }; }; =20 &wkup_uart0 { @@ -464,3 +472,22 @@ partition@3fc0000 { }; }; }; + +&usbss0 { + status =3D "okay"; + ti,vbus-divider; +}; + +&usbss1 { + status =3D "okay"; +}; + +&usb0 { + dr_mode =3D "peripheral"; +}; + +&usb1 { + dr_mode =3D "host"; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&main_usb1_pins_default>; +}; --=20 2.39.0