From nobody Mon Sep 15 14:35:15 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55FE9C46467 for ; Thu, 12 Jan 2023 00:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236225AbjALAl2 (ORCPT ); Wed, 11 Jan 2023 19:41:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232920AbjALAkp (ORCPT ); Wed, 11 Jan 2023 19:40:45 -0500 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71045AE47 for ; Wed, 11 Jan 2023 16:40:44 -0800 (PST) Received: by mail-yb1-xb4a.google.com with SMTP id k204-20020a256fd5000000b007b8b040bc50so16193770ybc.1 for ; Wed, 11 Jan 2023 16:40:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:from:subject:mime-version:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=h5P/G8QEaO3HyqhOGu82/HAf0R+66PdkPKsQpUDiMlc=; b=eGF1F/lrqMAN39cq8nEU49coorNRUqIbHnBryr2InQnzMzIJqVkcu5LPJEwm9N98WX XfQXM1GX3/oQQD7WLmDXjPWDDCmAGtUKDrKG+13dIczddfM9NyrDPOxdTaJ2OiHTy7Ua VS9swDDP9KM29DD1GKHiBd7AONB27uTqkb5q82XGMSidBRLysjYg3uXSbYpvy2juUbUN sW7A3W4icerCbpWSVO1oWTlwIMOejaGAdCDE9GHEg5DWjLyQY0nxgB3zaJCByzx0uRzR jg9mAkaclTKJ4T4oUsjzayw971NIw0wGEB9BJkz+K2Ru3FAJQvWRAygLhr+2LU0pZjef 1gOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=h5P/G8QEaO3HyqhOGu82/HAf0R+66PdkPKsQpUDiMlc=; b=P2zRloM23CkBjbA5m0CnBP+gvRzIKUfvMemfHg+AqFS2v2FYIyVdkjXkMlgD9TVQv5 zTGEqLDz9GK0PzcuadNXW7hF479J7XWWQVWfLBY23Gi26gRBtjyL9gQbyLOilE/aByAa JYUpXNWGhmZG2tgv4l9RQBL6yPletimkPOahmEeOSq5uo4huis4b7pM3l5yOjv0ecHwQ P6uAj/vLBeXWVgyfIAfP+AAgJrjyH7p6wz02eF48u9pz5blNYDHDW2DOP4wkPom+pkZ2 c6xDTvesNQj4mOx//7+N8HYlZzTkPEsfU0ZMR+uAdErl/pCIZxe+Zm8MAlkB9Vb60ZFM k7Tg== X-Gm-Message-State: AFqh2koZCG5si6jix6/IlHEqReYLASglGihqLMmnNA+GJdkbOjJQx6Hl 7+AefHJ7wW6mQMf0xe86BT83vwJKJnqU X-Google-Smtp-Source: AMrXdXundbCb7228SbcR6pwey2fibfqlj3mfadwLRyLe+3nDs49ZYHwTOvs+jqWJ9NNUcMgbYkf+ezMwkHJt X-Received: from irogers.svl.corp.google.com ([2620:15c:2d4:203:16b7:1d88:e27f:db49]) (user=irogers job=sendgmr) by 2002:a81:6f42:0:b0:36f:f251:213b with SMTP id k63-20020a816f42000000b0036ff251213bmr1500569ywc.228.1673484043746; Wed, 11 Jan 2023 16:40:43 -0800 (PST) Date: Wed, 11 Jan 2023 16:40:24 -0800 Message-Id: <20230112004024.1934601-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.39.0.314.g84b9a713c41-goog Subject: [PATCH v1] tools/resolve_btfids: Install subcmd headers From: Ian Rogers To: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Connor OBrien , Nathan Chancellor , Ian Rogers , Kumar Kartikeya Dwivedi , bpf@vger.kernel.org, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Previously tools/lib/subcmd was added to the include path, switch to installing the headers and then including from that directory. This avoids dependencies on headers internal to tools/lib/subcmd. Add the missing subcmd directory to the affected #include. Signed-off-by: Ian Rogers --- tools/bpf/resolve_btfids/Makefile | 19 ++++++++++++++----- tools/bpf/resolve_btfids/main.c | 2 +- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/tools/bpf/resolve_btfids/Makefile b/tools/bpf/resolve_btfids/M= akefile index 19a3112e271a..de7d29cf43d6 100644 --- a/tools/bpf/resolve_btfids/Makefile +++ b/tools/bpf/resolve_btfids/Makefile @@ -35,21 +35,29 @@ SUBCMD_SRC :=3D $(srctree)/tools/lib/subcmd/ BPFOBJ :=3D $(OUTPUT)/libbpf/libbpf.a LIBBPF_OUT :=3D $(abspath $(dir $(BPFOBJ)))/ SUBCMDOBJ :=3D $(OUTPUT)/libsubcmd/libsubcmd.a +SUBCMD_OUT :=3D $(abspath $(dir $(SUBCMDOBJ)))/ =20 LIBBPF_DESTDIR :=3D $(LIBBPF_OUT) LIBBPF_INCLUDE :=3D $(LIBBPF_DESTDIR)include =20 +SUBCMD_DESTDIR :=3D $(SUBCMD_OUT) +SUBCMD_INCLUDE :=3D $(SUBCMD_DESTDIR)include + BINARY :=3D $(OUTPUT)/resolve_btfids BINARY_IN :=3D $(BINARY)-in.o =20 all: $(BINARY) =20 +prepare: $(SUBCMDOBJ) + $(OUTPUT) $(OUTPUT)/libsubcmd $(LIBBPF_OUT): $(call msg,MKDIR,,$@) $(Q)mkdir -p $(@) =20 $(SUBCMDOBJ): fixdep FORCE | $(OUTPUT)/libsubcmd - $(Q)$(MAKE) -C $(SUBCMD_SRC) OUTPUT=3D$(abspath $(dir $@))/ $(abspath $@) + $(Q)$(MAKE) -C $(SUBCMD_SRC) OUTPUT=3D$(SUBCMD_OUT) \ + DESTDIR=3D$(SUBCMD_DESTDIR) prefix=3D \ + $(abspath $@) install_headers =20 $(BPFOBJ): $(wildcard $(LIBBPF_SRC)/*.[ch] $(LIBBPF_SRC)/Makefile) | $(LIB= BPF_OUT) $(Q)$(MAKE) $(submake_extras) -C $(LIBBPF_SRC) OUTPUT=3D$(LIBBPF_OUT) \ @@ -60,14 +68,14 @@ CFLAGS +=3D -g \ -I$(srctree)/tools/include \ -I$(srctree)/tools/include/uapi \ -I$(LIBBPF_INCLUDE) \ - -I$(SUBCMD_SRC) + -I$(SUBCMD_INCLUDE) =20 LIBS =3D -lelf -lz =20 export srctree OUTPUT CFLAGS Q include $(srctree)/tools/build/Makefile.include =20 -$(BINARY_IN): $(BPFOBJ) fixdep FORCE | $(OUTPUT) +$(BINARY_IN): $(BPFOBJ) fixdep FORCE prepare | $(OUTPUT) $(Q)$(MAKE) $(build)=3Dresolve_btfids =20 $(BINARY): $(BPFOBJ) $(SUBCMDOBJ) $(BINARY_IN) @@ -79,7 +87,8 @@ clean_objects :=3D $(wildcard $(OUTPUT)/*.o = \ $(OUTPUT)/.*.o.d \ $(LIBBPF_OUT) \ $(LIBBPF_DESTDIR) \ - $(OUTPUT)/libsubcmd \ + $(SUBCMD_OUT) \ + $(SUBCMD_DESTDIR) \ $(OUTPUT)/resolve_btfids) =20 ifneq ($(clean_objects),) @@ -96,4 +105,4 @@ tags: =20 FORCE: =20 -.PHONY: all FORCE clean tags +.PHONY: all FORCE clean tags prepare diff --git a/tools/bpf/resolve_btfids/main.c b/tools/bpf/resolve_btfids/mai= n.c index 80cd7843c677..77058174082d 100644 --- a/tools/bpf/resolve_btfids/main.c +++ b/tools/bpf/resolve_btfids/main.c @@ -75,7 +75,7 @@ #include #include #include -#include +#include =20 #define BTF_IDS_SECTION ".BTF_ids" #define BTF_ID "__BTF_ID__" --=20 2.39.0.314.g84b9a713c41-goog