From nobody Mon Sep 15 15:57:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85EEDC5479D for ; Wed, 11 Jan 2023 19:15:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238493AbjAKTPP (ORCPT ); Wed, 11 Jan 2023 14:15:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234951AbjAKTO6 (ORCPT ); Wed, 11 Jan 2023 14:14:58 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BC463DBE2 for ; Wed, 11 Jan 2023 11:14:57 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id g14so17014345ljh.10 for ; Wed, 11 Jan 2023 11:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tvetCGKgjl4TOcgsE3HW1CpjBzYScqI9QN0WXqkeGn4=; b=UqhKEmCNju2kbHfZHKTxtm3c5czCKHVZOHbWKFfA+y3BQABbnOEAaQAEtZu8Hw6ODL g9Ela4PeWz2KlODeCwSpZJBLxWlZIPCzzQEbanxbIN4Z4IG4eQmhLIxp+g7YecT2ic6H +7RNb+lfTiQKcHE7PWJTmBaDXxPcrBDkfy0l58IsOlKnH76wTZFBDZuC6DlozB0dIr94 T1IuhM40k4s0FtYwrzxXSwJtz2y/SenTuLSY+yT6vBmELKmgZQ8qKYJxQriZbm9h4+x2 uEEqrNDKI2ujs8QPx4GkmXo8zb5Dinv8G9XgN/xBYxDLuovutltK4GiGZIz7dZYL693w g5/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tvetCGKgjl4TOcgsE3HW1CpjBzYScqI9QN0WXqkeGn4=; b=MBWh8xarE41KPv3zf9tIIjyZaKXrL6FXYBBDAWtPhGgu5cEPOOsHp/OyxnksnQbFtT EVvJHckNKprjg2f9ACw6DrZxfbjSa4FQwjjEoxC5eUEg/6kfTFioHxhlpbjX4kD9sVV3 4LWEGC9SDPLdiWBcjrbkdNJunnKp7vXDhSIHt0YqzXxYWQ8iwWQxUKkfQGovvI6qO7ul iXLdROi1224i2/D3u+T6ansrIHKLUIgxNKHTXKpZ3/LoKyGd04yccB1a2Ws5IogU+PgJ CFy2EPZng8l75pGr5E7X3NIR/qDbW/s5y0AvfWGgcxNpU7T0Od8v/YgV5yfFQSCo9UuD PCIw== X-Gm-Message-State: AFqh2kor8uNGZNXypVaQxtIgNEd02GAmXF1QmFEvnzpIF3ByMOAtJCXk OvZNHniKVveO98LMbc9gJtxeag== X-Google-Smtp-Source: AMrXdXtRgrWhdT6cEv/zJaSMKYCkCBZoQwGdm6GxhA/zjl8LuIh8iSWnzd6HzUuMcQR0F2lo0Jyjig== X-Received: by 2002:a2e:8e67:0:b0:281:17f6:eeb9 with SMTP id t7-20020a2e8e67000000b0028117f6eeb9mr5621561ljk.8.1673464495502; Wed, 11 Jan 2023 11:14:55 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r7-20020a2e8e27000000b00289873cce0bsm76343ljk.14.2023.01.11.11.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:14:55 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] dt-bindings: mailbox: qcom: correct the list of platforms using clocks Date: Wed, 11 Jan 2023 22:14:50 +0300 Message-Id: <20230111191453.2509468-2-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> References: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Only three platforms require `pll' and `aux' clocks: msm8916, msm8939 and qcs404. Correct the list of platforms in the corresponding clause. Fixes: 0d17014e9189 ("dt-bindings: mailbox: Add binding for SDX55 APCS") Signed-off-by: Dmitry Baryshkov --- .../bindings/mailbox/qcom,apcs-kpss-global.yaml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index 943f9472ae10..b8a44ef0540f 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -71,15 +71,8 @@ allOf: compatible: enum: - qcom,msm8916-apcs-kpss-global - - qcom,msm8994-apcs-kpss-global - - qcom,msm8996-apcs-hmss-global - - qcom,msm8998-apcs-hmss-global + - qcom,msm8939-apcs-kpss-global - qcom,qcs404-apcs-apps-global - - qcom,sc7180-apss-shared - - qcom,sdm660-apcs-hmss-global - - qcom,sdm845-apss-shared - - qcom,sm6125-apcs-hmss-global - - qcom,sm8150-apss-shared then: properties: clocks: --=20 2.30.2 From nobody Mon Sep 15 15:57:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F8FFC5479D for ; Wed, 11 Jan 2023 19:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239376AbjAKTPY (ORCPT ); Wed, 11 Jan 2023 14:15:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232656AbjAKTO7 (ORCPT ); Wed, 11 Jan 2023 14:14:59 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0139F3DBE4 for ; Wed, 11 Jan 2023 11:14:58 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id y18so13503044ljk.11 for ; Wed, 11 Jan 2023 11:14:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qnO47DUEwN//XThycfEdpAbdWEvh77T3LIosKiAxmXQ=; b=rIShkYakHyEndgpFPEx8c/mV1M7z06AugUVKSo7J4Pya1+TGDnRWXk4vX66XQAWLtE lx6DIi+y8VGUZIVjL522QS2T/Lw28zY0rS5qZ8DheJvCMUNMhHFEN61nGjAWRCkMWjBk kbvpj2lBiu/jPIbHxT+6y+9jwG8laWIrRwPGFFi4E78+O9VQ8B4ywgzgtfDwfzRqbzAa R/Q3ZElOtA3cB3NCMtN98FuB4PpDIPu6HDvBozNlCnE8RtLY9kKv9UIy/VicQv1leLAL /2IEs6GHjxj1uzVrXUeolvnpC/N3pLxpzeN4QImDiXzMR1dHlB5ekDYrNIyA6n0jhJTn PBEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qnO47DUEwN//XThycfEdpAbdWEvh77T3LIosKiAxmXQ=; b=hoG8vP9nP3o12O/1fN1XVwhagF3ppVNtAnM8vqyY5gLCKBYO7HUsiDkx/7/Rbxdq7I C/px60ATOX0VBvo3uk93D4YTtiSvadAoe1ZOwD+Gpow8S/rA/1Mt2/kHF8p9EPzvzx9F luN1brqqPtJlAbpyfzI+TI2Rv3bqwJoRAifuF1NeuW7nKhM4LHFX3htNfAcGP8aWUzIX nDZyk5GKnmLjhYxczaxX9Pe6WG9aaqR9b9UOYV38FE2JjEox7F86zf/QLsVeDSCyV8kP dJCiFGjEHiQXAbN9ZGlAp9RtHzWsCNogHlFqix9O80h9EHdB0MAwxoH0RA+b9LZkrGEo l9nw== X-Gm-Message-State: AFqh2kqTSlnxhyNbx8OL3jCXZ0zDRbnkk41HeDLTGRwD3Ej6pi4+gBov 6CKxTWchNVSGZLkRiBzg/7yl+g== X-Google-Smtp-Source: AMrXdXvx0DRu2+CA6xRA5IFr/WBd1wZwaDOy+Wzlq5t+NYgswAsi1LDZw6/CIT0a55v8qx0dbbcnbQ== X-Received: by 2002:a05:651c:220b:b0:279:f1df:97a6 with SMTP id y11-20020a05651c220b00b00279f1df97a6mr24826788ljq.7.1673464496242; Wed, 11 Jan 2023 11:14:56 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r7-20020a2e8e27000000b00289873cce0bsm76343ljk.14.2023.01.11.11.14.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:14:55 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] dt-bindings: mailbox: qcom: add #clock-cells to msm8996 example Date: Wed, 11 Jan 2023 22:14:51 +0300 Message-Id: <20230111191453.2509468-3-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> References: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add the #clock-cells property to the MSM8996 example, as the APCS block is going to provide the `sys_apcs_aux' clock to the consumers. Signed-off-by: Dmitry Baryshkov --- .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-globa= l.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.ya= ml index b8a44ef0540f..5e7c83345774 100644 --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml @@ -141,6 +141,7 @@ examples: reg =3D <0x9820000 0x1000>; =20 #mbox-cells =3D <1>; + #clock-cells =3D <0>; }; =20 rpm-glink { --=20 2.30.2 From nobody Mon Sep 15 15:57:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD79C5479D for ; Wed, 11 Jan 2023 19:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239475AbjAKTPd (ORCPT ); Wed, 11 Jan 2023 14:15:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235742AbjAKTO7 (ORCPT ); Wed, 11 Jan 2023 14:14:59 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CFFB3DBF4 for ; Wed, 11 Jan 2023 11:14:58 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id bn6so17026647ljb.13 for ; Wed, 11 Jan 2023 11:14:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dPcZBzHD7ae6hkELFAHD+D8x2hKPutj+3M3d+IlT3KQ=; b=UMv7/eMyntz4XC/n0FQobQsKOnZQOAAYdZD9dw3Q3LzNgH71k0ft+Iqir/z2+HF71I zOnDFjw0DTI+biMwLY/eQLXThEOF2Xzv2OoufOF1WV0kPt/+imGpxihOFw4THOplbGPT 0Ts7mtKSZReDkPU2MUcOEmwPAvX99rtX754/l89mElokerv1nguqcGty0yzfos9RHjiu cwQhGRlSZVNusrCB/tJJYE1WsQ4xAAxD0vmHEpPb+RRN0Hruw7xSNqKaRv+/AMIpX+lG Usiw2D4N4Vx+2n7BcT1tReSttWk0BGwrqFBz9URDKSZbMfzzfhh7XufNQJFrLRKiRzi1 nNVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dPcZBzHD7ae6hkELFAHD+D8x2hKPutj+3M3d+IlT3KQ=; b=lcsZCbFVnvkw22Gl36STFs4voLrTz+Vk0jY5rt214X/CqVTjvDETjsLg0gfSC3plhg bgeFQhWeEj5H7FsNUx3fZ3TCyAvOsAff4cmprW9VHc9zMLg2JC6oDX+zz+rT+Q03/44k cxQ/TdMG69vFuwrMWUvVfRwfU3BVgBJTqSFy9g1oZsPSQB+du6FqdzEzhuO+B8WlLOD4 XoXJGea0dkJbvLoT52I4TFUejDZtwFEOPwbCvw1vobBImuhLiCI3MDWJKs38ErpqD8VV 0racba/tVnJ/fJr0fDsAt4uRDZnxaa6FCpZrJZNHye15g9AFkuq1IJyyQuHetKUEWL0r Wlpg== X-Gm-Message-State: AFqh2krQSSoMgpnKurINumH60Ghvbc1Gft1oOIif/PBZaeCuT/zBZsYa AcFOiOh6uhB63ziZ1O4WSdCggg== X-Google-Smtp-Source: AMrXdXuapSySspddRmgkrBvUeYqYXvuI/qlqdHQcrDRWca5y/BcX5TCLFKVsmrpgEhlHLopnJUHIwQ== X-Received: by 2002:a2e:b52a:0:b0:27f:fff4:a6c8 with SMTP id z10-20020a2eb52a000000b0027ffff4a6c8mr7328861ljm.48.1673464496896; Wed, 11 Jan 2023 11:14:56 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r7-20020a2e8e27000000b00289873cce0bsm76343ljk.14.2023.01.11.11.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:14:56 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/4] mailbox: qcom-apcs-ipc: enable APCS clock device for MSM8996 Date: Wed, 11 Jan 2023 22:14:52 +0300 Message-Id: <20230111191453.2509468-4-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> References: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" MSM8996 also has the clock-related part of the APCS mailbox device. Follow the usual pattern and create a child device to handle these clocks. Signed-off-by: Dmitry Baryshkov --- drivers/mailbox/qcom-apcs-ipc-mailbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c b/drivers/mailbox/qcom= -apcs-ipc-mailbox.c index 0e9f9cba8668..bd61dacb44ba 100644 --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c @@ -42,7 +42,7 @@ static const struct qcom_apcs_ipc_data msm8994_apcs_data = =3D { }; =20 static const struct qcom_apcs_ipc_data msm8996_apcs_data =3D { - .offset =3D 16, .clk_name =3D NULL + .offset =3D 16, .clk_name =3D "qcom-apcs-msm8996-clk" }; =20 static const struct qcom_apcs_ipc_data apps_shared_apcs_data =3D { --=20 2.30.2 From nobody Mon Sep 15 15:57:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DADC5479D for ; Wed, 11 Jan 2023 19:15:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239350AbjAKTP2 (ORCPT ); Wed, 11 Jan 2023 14:15:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238603AbjAKTPH (ORCPT ); Wed, 11 Jan 2023 14:15:07 -0500 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B01F3E0CE for ; Wed, 11 Jan 2023 11:14:59 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id y18so13503113ljk.11 for ; Wed, 11 Jan 2023 11:14:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/UXtctDmgy3FdaxNyTJINCTK6qOQw5kYpO166rCggWQ=; b=qym5ytsZN3GQaBori/kOTx2Aep16/qNYc2VJvNqD8DFQ9VjVpng6JnQxWBpQm7DSh/ v0iXSSbNM5PMxGMoWAFJVILD/V+E8mOSrHeBW/SXXV9ztayAlnlvlq+DHqogQbhmBjef 16wTpZOxKLnCegLhMEWh2L7Wb77NUteeeeDYcMSVPvlrrAeW4SE9SKDcMPmabe+Gy9XB k91n7kOT8N38u4/6vSfPE+xCIPeW+t3Jj9DDYDfGE0hgvvoZsov0ZaJ8lr/yx5m1ZiAd iJiYRmmbYECRPJXMHN09rSYdaL4XyqYZsCUq8aMzuT1xh5ukpJ3N1eSTT5J7S62xYY97 Df4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/UXtctDmgy3FdaxNyTJINCTK6qOQw5kYpO166rCggWQ=; b=KGAfmyGMoFXhJKGF48YrLtUlHPy1K0JwvjvebQfNP1nfstJ4didFIIMBZWUrhFSDGJ zrg8S2/BfWbhn9XoZeg8Lr2ZS4TqPeTQrBXAPpb9C/EqtfZXEJm9iRKeynCTDJU7VVpc AuBuUQHbYkiIbLhYPCc1vbLkSUXq+EfBcNAXTTmbz/TFZMYIr5375DfMTCjTRr1FDH4r cIYxQFHylMBbQByDKdTKTYCZK1q91bGkp9LTfTK7Mu2w9TPvjgYchNf2Z7gqIMDUDw6H 9uw4dSJCdBnKz2Mk2cJuW7wcxe14JPhIN2KWh5+ruUXM89RnQeECGqy6eQWze+/cTBAa D+8Q== X-Gm-Message-State: AFqh2kr8TgPHwe4PSNDPnOF9u/24lJVkhM1VqwTShTQzE1zMKRCdBwgS X1CGaYD0nQ8qOuiOgO+CUAx9ug== X-Google-Smtp-Source: AMrXdXu1EYK0JDO4UII/7zB1knsDVnmMAe5zoz1LVmjb+jur+ozkviixsD6HgC14w38fwIUFCL8InQ== X-Received: by 2002:a2e:a5ca:0:b0:27f:d652:f38c with SMTP id n10-20020a2ea5ca000000b0027fd652f38cmr13729215ljp.19.1673464497640; Wed, 11 Jan 2023 11:14:57 -0800 (PST) Received: from umbar.unikie.fi ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id r7-20020a2e8e27000000b00289873cce0bsm76343ljk.14.2023.01.11.11.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 11:14:57 -0800 (PST) From: Dmitry Baryshkov To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Stephen Boyd , Michael Turquette , Rob Herring , Krzysztof Kozlowski , Taniya Das , Jassi Brar Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 4/4] clk: qcom: add the driver for the MSM8996 APCS clocks Date: Wed, 11 Jan 2023 22:14:53 +0300 Message-Id: <20230111191453.2509468-5-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> References: <20230111191453.2509468-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add a simple driver handling the APCS clocks on MSM8996. For now it supports just a single aux clock, linking GPLL0 to CPU and CBF clocks. Note, there is little sense in registering sys_apcs_aux as a child of gpll0. The PLL is always-on. And listing the gpll0 as a property of the apcs would delay its probing until the GCC has been probed (while we would like for the apcs to be probed as early as possible). Signed-off-by: Dmitry Baryshkov --- drivers/clk/qcom/Makefile | 2 +- drivers/clk/qcom/apcs-msm8996.c | 77 +++++++++++++++++++++++++++++++++ 2 files changed, 78 insertions(+), 1 deletion(-) create mode 100644 drivers/clk/qcom/apcs-msm8996.c diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile index f18c446a97ea..ca2f586edb3e 100644 --- a/drivers/clk/qcom/Makefile +++ b/drivers/clk/qcom/Makefile @@ -52,7 +52,7 @@ obj-$(CONFIG_MSM_MMCC_8998) +=3D mmcc-msm8998.o obj-$(CONFIG_QCOM_A53PLL) +=3D a53-pll.o obj-$(CONFIG_QCOM_A7PLL) +=3D a7-pll.o obj-$(CONFIG_QCOM_CLK_APCS_MSM8916) +=3D apcs-msm8916.o -obj-$(CONFIG_QCOM_CLK_APCC_MSM8996) +=3D clk-cpu-8996.o +obj-$(CONFIG_QCOM_CLK_APCC_MSM8996) +=3D apcs-msm8996.o clk-cpu-8996.o obj-$(CONFIG_QCOM_CLK_APCS_SDX55) +=3D apcs-sdx55.o obj-$(CONFIG_QCOM_CLK_RPM) +=3D clk-rpm.o obj-$(CONFIG_QCOM_CLK_RPMH) +=3D clk-rpmh.o diff --git a/drivers/clk/qcom/apcs-msm8996.c b/drivers/clk/qcom/apcs-msm899= 6.c new file mode 100644 index 000000000000..2e9959974ed9 --- /dev/null +++ b/drivers/clk/qcom/apcs-msm8996.c @@ -0,0 +1,77 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Qualcomm APCS clock controller driver + * + * Copyright (c) 2022, Linaro Limited + * Author: Dmitry Baryshkov + */ + +#include +#include +#include +#include +#include +#include +#include + +#define APCS_AUX_OFFSET 0x50 + +#define APCS_AUX_DIV_MASK GENMASK(17, 16) +#define APCS_AUX_DIV_2 0x1 + +static int qcom_apcs_msm8996_clk_probe(struct platform_device *pdev) +{ + struct device *dev =3D &pdev->dev; + struct device *parent =3D dev->parent; + struct regmap *regmap; + struct clk_hw *hw; + unsigned int val; + int ret =3D -ENODEV; + + regmap =3D dev_get_regmap(parent, NULL); + if (!regmap) { + dev_err(dev, "failed to get regmap: %d\n", ret); + return ret; + } + + regmap_read(regmap, APCS_AUX_OFFSET, &val); + regmap_update_bits(regmap, APCS_AUX_OFFSET, APCS_AUX_DIV_MASK, + FIELD_PREP(APCS_AUX_DIV_MASK, APCS_AUX_DIV_2)); + + /* Hardware mandated delay */ + udelay(5); + + /* + * Register the clock as fixed rate instead of being a child of gpll0 + * to let the driver register probe as early as possible. + */ + hw =3D devm_clk_hw_register_fixed_rate(dev, "sys_apcs_aux", NULL, 0, 3000= 00000); + if (IS_ERR(hw)) + return PTR_ERR(hw); + + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, hw); +} + +static struct platform_driver qcom_apcs_msm8996_clk_driver =3D { + .probe =3D qcom_apcs_msm8996_clk_probe, + .driver =3D { + .name =3D "qcom-apcs-msm8996-clk", + }, +}; + +/* Register early enough to fix the clock to be used for other cores */ +static int __init qcom_apcs_msm8996_clk_init(void) +{ + return platform_driver_register(&qcom_apcs_msm8996_clk_driver); +} +postcore_initcall(qcom_apcs_msm8996_clk_init); + +static void __exit qcom_apcs_msm8996_clk_exit(void) +{ + platform_driver_unregister(&qcom_apcs_msm8996_clk_driver); +} +module_exit(qcom_apcs_msm8996_clk_exit); + +MODULE_AUTHOR("Dmitry Baryshkov "); +MODULE_LICENSE("GPL v2"); +MODULE_DESCRIPTION("Qualcomm MSM8996 APCS clock driver"); --=20 2.30.2