From nobody Mon Sep 15 17:45:16 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5BC5C678D7 for ; Wed, 11 Jan 2023 09:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238383AbjAKJJS (ORCPT ); Wed, 11 Jan 2023 04:09:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238292AbjAKJH7 (ORCPT ); Wed, 11 Jan 2023 04:07:59 -0500 Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4AF512A8F; Wed, 11 Jan 2023 01:05:17 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 94B95186451B; Wed, 11 Jan 2023 12:05:14 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id emQUQq88maMc; Wed, 11 Jan 2023 12:05:14 +0300 (MSK) Received: from localhost (localhost [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 2965518644E6; Wed, 11 Jan 2023 12:05:14 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KeCrFPPN08Nw; Wed, 11 Jan 2023 12:05:14 +0300 (MSK) Received: from ekaterina-MACHD-WXX9.. (unknown [10.177.226.118]) by mail.astralinux.ru (Postfix) with ESMTPSA id DBA60186401F; Wed, 11 Jan 2023 12:05:12 +0300 (MSK) From: Esina Ekaterina To: Zhao Qiang Cc: Esina Ekaterina , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH v3] net: wan: Add checks for NULL for utdm in undo_uhdlc_init and unmap_si_regs Date: Wed, 11 Jan 2023 12:05:03 +0300 Message-Id: <20230111090504.66434-1-eesina@astralinux.ru> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230110204418.79f43f45@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If uhdlc_priv_tsa !=3D 1 then utdm is not initialized. And if ret !=3D NULL then goto undo_uhdlc_init, where utdm is dereferenced. Same if dev =3D=3D NULL. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Esina Ekaterina --- v3: Remove braces v2: Add check for NULL for unmap_si_regs --- drivers/net/wan/fsl_ucc_hdlc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 22edea6ca4b8..8166708c7190 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b/drivers/net/wan/fsl_ucc_hdlc.c @@ -1243,9 +1243,11 @@ static int ucc_hdlc_probe(struct platform_device *pd= ev) free_dev: free_netdev(dev); undo_uhdlc_init: - iounmap(utdm->siram); + if (utdm !=3D NULL) + iounmap(utdm->siram); unmap_si_regs: - iounmap(utdm->si_regs); + if (utdm !=3D NULL) + iounmap(utdm->si_regs); free_utdm: if (uhdlc_priv->tsa) kfree(utdm); --=20 2.39.0