From nobody Tue Nov 5 09:32:41 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B583C6379F for ; Wed, 11 Jan 2023 08:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236201AbjAKIcv (ORCPT ); Wed, 11 Jan 2023 03:32:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236015AbjAKIcP (ORCPT ); Wed, 11 Jan 2023 03:32:15 -0500 Received: from out30-7.freemail.mail.aliyun.com (out30-7.freemail.mail.aliyun.com [115.124.30.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33C353897; Wed, 11 Jan 2023 00:32:08 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R811e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046056;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0VZMek7P_1673425923; Received: from localhost(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VZMek7P_1673425923) by smtp.aliyun-inc.com; Wed, 11 Jan 2023 16:32:04 +0800 From: Jingbo Xu To: xiang@kernel.org, chao@kernel.org, linux-erofs@lists.ozlabs.org Cc: huyue2@coolpad.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v2 5/7] erofs: implement .mmap for page cache sharing Date: Wed, 11 Jan 2023 16:31:56 +0800 Message-Id: <20230111083158.23462-6-jefflexu@linux.alibaba.com> X-Mailer: git-send-email 2.19.1.6.gb485710b In-Reply-To: <20230111083158.23462-1-jefflexu@linux.alibaba.com> References: <20230111083158.23462-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In mmap(2), replace vma->vm_file with the anonymous file associated with the blob, so that the vma will be linked to the address_space of the blob. One thing worth noting is that, we return error early in mmap(2) if users attempt to map beyond the file size. Normally filesystems won't restrict this in mmap(2). The checking is done in the fault handler, and SIGBUS will be signaled to users if they actually attempt to access the area beyond the end of the file. However since vma->vm_file has been changed to the anonymous file in mmap(2), we can no way derive the file size of the original file. As file size is immutable in ro filesystem, let's fail early in mmap(2) in this case. Signed-off-by: Jingbo Xu --- fs/erofs/fscache.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/fs/erofs/fscache.c b/fs/erofs/fscache.c index 4075d9519a7d..e3a65041c9b8 100644 --- a/fs/erofs/fscache.c +++ b/fs/erofs/fscache.c @@ -431,9 +431,40 @@ static ssize_t erofs_fscache_share_file_read_iter(stru= ct kiocb *iocb, return already_read ? already_read : ret; } =20 +vm_fault_t erofs_fscache_share_fault(struct vm_fault *vmf) +{ + struct file *realfile =3D vmf->vma->vm_file; + struct erofs_fscache_share_file_info *finfo =3D realfile->private_data; + pgoff_t index =3D vmf->pgoff; + + if (unlikely(index >=3D finfo->max_idx)) + return VM_FAULT_SIGBUS; + + return filemap_fault(vmf); +} + +static const struct vm_operations_struct erofs_fscache_share_file_vm_ops = =3D { + .fault =3D erofs_fscache_share_fault, +}; + +static int erofs_fscache_share_file_mmap(struct file *file, + struct vm_area_struct *vma) +{ + struct file *realfile =3D file->private_data; + struct erofs_fscache_share_file_info *finfo =3D realfile->private_data; + + vma_set_file(vma, realfile); + vma->vm_pgoff =3D (finfo->pa >> PAGE_SHIFT) + vma->vm_pgoff; + vma->vm_ops =3D &erofs_fscache_share_file_vm_ops; + + file_accessed(file); + return 0; +} + const struct file_operations erofs_fscache_share_file_fops =3D { .llseek =3D generic_file_llseek, .read_iter =3D erofs_fscache_share_file_read_iter, + .mmap =3D erofs_fscache_share_file_mmap, .open =3D erofs_fscache_share_file_open, .release =3D erofs_fscache_share_file_release, }; --=20 2.19.1.6.gb485710b